Commit Graph

47 Commits

Author SHA1 Message Date
nweiz@google.com bcdb64e20e Refactor pkg/path.
This CL does several things:

* Splits lib/path.dart into multiple libraries.

* Renames "Builder" to "Context".

* Makes the Context API match the top-level functions ("root" was
  renamed to "current" and "resolve" was renamed to "absolute").

* The top-level "absolute" function now takes multiple parts, to match
  [Context.absolute].

R=rnystrom@google.com
BUG=14981

Review URL: https://codereview.chromium.org//62753005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30423 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-19 20:48:45 +00:00
nweiz@google.com baee87f63d Work around issue 11901 in stack_trace.
For some reason, timer_impl.dart in dart:async has the incorrect URL
in VM stack traces. This adds manual handling for that in the
stack_trace package.

R=rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//63393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30318 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-15 22:16:10 +00:00
nweiz@google.com 31ac89f049 Properly parse jsshell and d8 stack frames.
It turns out jsshell and d8 can use native paths where Firefox and
Chrome usually use URLs. This CL accommodates that.

R=rnystrom@google.com
BUG=14897

Review URL: https://codereview.chromium.org//63603005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30079 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 22:41:42 +00:00
dgrove@google.com 18ca7d0036 Re-land r29957 (add versions and constraints for packages and samples), with
SDK constraints bumped from 1.0.0 to 0.8.10+6 .

R=ricow@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//62473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29986 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 18:28:22 +00:00
ajohnsen@google.com 61f6c51990 Revert "add versions and constraints for packages and samples"
This is currently blocking us from testing samples.

BUG=
R=kasperl@google.com

Review URL: https://codereview.chromium.org//59513007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29960 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 09:09:18 +00:00
jmesserly@google.com 02638c5760 add versions and constraints for packages and samples
- all packages at 0.9.0, except "analyzer" which had a version already
- dependencies at ">=0.9.0 <0.10.0" except analyzer is ">=0.10.0 <0.11.0"
- sdk constraint ">=1.0.0 <2.0.0"

R=sigmund@google.com

Review URL: https://codereview.chromium.org//59763006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29957 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 03:27:58 +00:00
nweiz@google.com 9cb7129067 Support Safari 6.1's new stack trace format in pkg/stack_trace.
R=rnystrom@google.com
BUG=14534

Review URL: https://codereview.chromium.org//48273005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29399 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 21:50:23 +00:00
nweiz@google.com 3c132b1e28 Properly parse friendly stack traces without columns.
Review URL: https://codereview.chromium.org//28783006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28892 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 22:57:06 +00:00
nweiz@google.com 54d951a769 Make stack frames without columns print correctly.
This works around issue 14233.

R=alanknight@google.com

Review URL: https://codereview.chromium.org//29323004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28884 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 21:55:41 +00:00
nweiz@google.com 66e568e6ce Work around issue 14125 in stack_trace by adding a dummy setter.
R=rnystrom@google.com
BUG=13945

Review URL: https://codereview.chromium.org//27416002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28811 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 18:09:58 +00:00
iposva@google.com c4be237e68 - Fix build.
Review URL: https://codereview.chromium.org//24249010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27854 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 21:15:04 +00:00
iposva@google.com f18e12b5db Address codereview comments:
- Update variable names.
- Add test case for column-free stack frame.

Review URL: https://codereview.chromium.org//24395014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27852 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 20:54:26 +00:00
iposva@google.com 8a9adf5656 - Use simplified token location call where appropriate.
R=asiva@google.com, hausner@google.com, mlippautz@google.com

Review URL: https://codereview.chromium.org//23850014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27833 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 17:32:40 +00:00
nweiz@google.com 28790a8eba Support "[as ...]" in V8 stack traces in pkg/stack_trace.
BUG=13431
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23533074

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27720 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 19:38:58 +00:00
kathyw@google.com 2ff7bb2447 One-liners for unittest and matcher.
Also had to give a one-liner to stack_trace, to work around a doc generation issue (dartbug.com/13246).

R=gram@google.com

Review URL: https://codereview.chromium.org//23828006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27398 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 19:28:17 +00:00
blois@google.com 43b08221c4 Fixing stack traces on IE10.
BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//23445005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26735 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 18:35:08 +00:00
nweiz@google.com 56f9452f65 Fix a bad merge in pkg/stack_trace.
TBR
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//22880030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26467 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 20:15:01 +00:00
nweiz@google.com 202a7a3e00 Support IE and Safari stack traces.
R=rnystrom@google.com
BUG=12380

Review URL: https://codereview.chromium.org//23068019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26464 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 19:58:07 +00:00
nweiz@google.com 53275e8ec5 Properly parse V8 stack traces that contain the exception description.
R=rnystrom@google.com
BUG=12151

Review URL: https://codereview.chromium.org//23159007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26395 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 21:41:33 +00:00
nweiz@google.com a24a587bb0 Support "..." VM frames in pkg/stack_trace.
Also include the original stack trace when a parse error occurs.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//23133004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26132 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 18:10:23 +00:00
rnystrom@google.com a9d24edd0f Rename "pathos" package to "path".
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//18356011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24964 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-12 17:54:48 +00:00
nweiz@google.com a1dfaf542d Make the Firefox trace RegExp not go exponential on V8.
BUG=11645
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//18339005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24829 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 22:25:07 +00:00
nweiz@google.com 031c343cae Add a couple functions to package:stack_trace.
This adds a function to convert a Trace to a VM-style StackTrace
object, and to parse a Trace-style string into a Trace.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//18029023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24611 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 22:24:01 +00:00
nweiz@google.com 83d0bc07d2 Properly handle empty stack traces in package:stack_trace.
R=sigmund@google.com

Review URL: https://codereview.chromium.org//18170002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24571 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 01:50:01 +00:00
nweiz@google.com e91e9182c5 Add support for V8 and Firefox stack traces in pkg/stack_trace.
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//18167002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24569 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 01:22:36 +00:00
amouravski@google.com 5089f391d2 Revert "Add support for V8 and Firefox stack traces in pkg/stack_trace."
This reverts commit r24502.

Review URL: https://codereview.chromium.org//17998002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24506 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 02:16:12 +00:00
nweiz@google.com a92a52a4ff Add support for V8 and Firefox stack traces in pkg/stack_trace.
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//17765004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24502 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 00:28:28 +00:00
nweiz@google.com 25ec4666f0 Fix the pkg/stack_trace tests.
On Windows they're now (correctly) using relative URIs as opposed to
relative paths.

Review URL: https://codereview.chromium.org//17157009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24205 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-19 22:15:07 +00:00
nweiz@google.com 66404438fc Add toUri and fromUri functions to pathos.
This also replaces the ubiqutous pathToFileUri/fileUriToPath functions.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//16848002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24196 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-19 19:06:19 +00:00
nweiz@google.com 25d42f64e6 Make the StackTrace library better handle core library frames.
Core library stack frames now have libraries and meaningful line numbers, so in
general we should preserve those. However, terse stack traces don't care about
the internal workings of the core libraries, so they now explicitly remove the
library and line number information.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//16097012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23621 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 23:36:31 +00:00
sgjesse@google.com 9d6a64e81b Merge the dart:uri library into dart:core and update the Uri class
This merges the dart:uri library into dart:core removing the dart:uri library. Besides moving the library the Url class has been changed.

* Removed existing Uri constructor as it was equivalent with Uri.parse
* Remamed constructor Uri.fromComponents to Uri
* Moved toplevel function encodeUriComponent to static method Uri.encodeComponent
* Moved toplevel function decodeUriComponent to static method Uri.decodeComponent
* Moved toplevel function encodeUri to static method Uri.encodeFull
* Moved toplevel function decodeUri to static method Uri.decodeFull
* Rename domain to host
* Added static methods Uri.encodeQueryComponent and Uri.decodeQueryComponent
* Added support for path generation and splitting
* Added support for query generation and splitting
* Added some level of normalization

R=floitsch@google.com, lrn@google.com, nweiz@google.com, scheglov@google.com
BUG=

Review URL: https://codereview.chromium.org//16019002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23266 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 13:35:01 +00:00
ajohnsen@google.com d548955117 Enable parsing of IPv6 form addresse (see rfc2373 and rfc2732).
This also wraps the 'domain' component in toString with [...], if it
contains any ':' characters.

BUG=
R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//14753005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22228 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-01 09:27:50 +00:00
nweiz@google.com 7523a1df0d Be lazier when capturing stack traces.
It turns out that capturing stack traces is cheap; converting them to strings is
what's so expensive.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//14647003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22205 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-30 21:34:08 +00:00
nweiz@google.com 0ff9830d88 Fix a bug in pathToFileUri.
TBR

Review URL: https://codereview.chromium.org//14287003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21916 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 01:00:03 +00:00
nweiz@google.com 18ef5b5d80 Clean up various ways we find paths in pub.
This makes it so that it's never necessary to pass in DART_SDK.

Review URL: https://codereview.chromium.org//14449004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21914 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 23:55:46 +00:00
nweiz@google.com cdb1f717a3 Use UnmodifiableListView to expose read-only lists.
Review URL: https://codereview.chromium.org//14394003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21855 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-22 23:05:30 +00:00
sethladd@google.com 8fd2c2e5ea add installation instructions to pkg packages
BUG=

Review URL: https://codereview.chromium.org//14188048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21770 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-19 20:51:10 +00:00
lrn@google.com 0f607e459c Remove methods on StackTrace class.
The API is not ready for finalization, so we remove it for further
development after M4.

Makes dart2js's StackTrace object implement dart:core's StackTrace.
Marks dart2js stack-trace tests as Fail instead of Skip.

Review URL: https://codereview.chromium.org//14009004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21437 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 11:44:30 +00:00
floitsch@google.com 94fd64a5e2 Import math library with a prefix.
Review URL: https://codereview.chromium.org//14111004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21406 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-13 13:17:13 +00:00
lrn@google.com f41508d33b Added new version of reduce.
Removed min/max and uses of min/max.

Review URL: https://codereview.chromium.org//14071002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21258 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-11 08:32:31 +00:00
nweiz@google.com 49113955eb Normalize packages' library names.
This makes the library names play nicer with dartdoc.

Review URL: https://codereview.chromium.org//13674024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21106 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-08 19:39:30 +00:00
nweiz@google.com 23bf53be66 Use the stack_trace library in scheduled_test.
This also adds a couple features to stack_trace.

Review URL: https://codereview.chromium.org//13157004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20752 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-01 20:46:15 +00:00
nweiz@google.com 0d0cdb58b2 Check in pkg/stack_trace/lib/src/utils.dart.
Review URL: https://codereview.chromium.org//13371002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20710 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-30 00:47:33 +00:00
nweiz@google.com 250224ed32 Be more careful about converting between file URIs and paths.
This happened to work on Windows because it interprets forward slashes as
directory separators.

Review URL: https://codereview.chromium.org//13191011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20708 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-30 00:36:38 +00:00
nweiz@google.com 829edfcfa6 Fix the stack_trace frame test on Windows as well.
Review URL: https://codereview.chromium.org//12681036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20588 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-27 21:57:31 +00:00
nweiz@google.com e3fcad44c3 Fix Frame.location on Windows in pkg/stack_trace.
Review URL: https://codereview.chromium.org//12545080

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20586 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-27 21:37:20 +00:00
nweiz@google.com 3697a04750 Add a library for manipulating stack traces.
Review URL: https://codereview.chromium.org//13102003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20582 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-27 21:15:55 +00:00