Commit Graph

1321 Commits

Author SHA1 Message Date
nweiz@google.com 09afa8f485 Validate that a package doesn't depend on itself.
BUG=7045

Review URL: https://codereview.chromium.org//11737013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16614 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-03 22:18:46 +00:00
efortuna@google.com 9cbe127651 Fix new path of html lib docs in apidoc.
BUG=

Review URL: https://codereview.chromium.org//11706002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16559 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-28 22:54:57 +00:00
sgjesse@google.com 7e293aa077 Reapply "Fix URI encoding/decoding of + and space""
Updated test expectations for some tests for pkg/http, pkg/oauth2 and
pub to match the change.

TBR=lrn@google.com

Review URL: https://codereview.chromium.org//11659009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16426 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 09:50:05 +00:00
floitsch@google.com f020a7d270 Add 'timeout' for io_test.
This reintroduces the change from https://codereview.chromium.org/11648033/
which was reverted in https://codereview.chromium.org/11570065/.

Review URL: https://codereview.chromium.org//11660003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16425 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 09:48:33 +00:00
floitsch@google.com 5271b558c2 Close receivePort when tests are failing.
Review URL: https://codereview.chromium.org//11570065

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16422 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 09:37:48 +00:00
nweiz@google.com 5168d9bafd Add a validator for dependency version constraints.
BUG=7045

Review URL: https://codereview.chromium.org//11635060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16415 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 01:59:58 +00:00
nweiz@google.com 88af0578b6 Add a timeout to scheduled pub tests.
This ensures that at least we'll know which test is timing out.

Review URL: https://codereview.chromium.org//11649047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16410 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 00:24:44 +00:00
nweiz@google.com 2ae5ab640e Add a small note to a TODO.
Review URL: https://codereview.chromium.org//11644058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16409 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-20 23:51:44 +00:00
floitsch@google.com bef5bcf8b4 Update status file.
Review URL: https://codereview.chromium.org//11648033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16395 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-20 20:09:26 +00:00
rnystrom@google.com 12b11b4cc0 Convert /** comments to /// in pub.
Previously, it was a mix of both styles. Now it's consistent. :)

Review URL: https://codereview.chromium.org//11638010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16354 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-20 02:04:28 +00:00
ager@google.com 87a38c4546 Fix pub suppression
R=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//11648008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16310 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 10:24:14 +00:00
ricow@google.com e652efe397 Suppress flake for pub/io_test on windows
Review URL: https://codereview.chromium.org//11637013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16307 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 08:49:10 +00:00
nweiz@google.com 71e2fc2bf4 Fix analyzer errors/warnings for Pub.
Review URL: https://codereview.chromium.org//11609005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16299 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 01:08:42 +00:00
rnystrom@google.com 747a3f83f5 Move path ("pathos") to pkg/.
Review URL: https://codereview.chromium.org//11647003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16297 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 00:04:37 +00:00
rnystrom@google.com c302b07858 Fix interpolation in warning message. :(
Review URL: https://codereview.chromium.org//11616019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16279 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 19:24:42 +00:00
nweiz@google.com 14c52ba5f1 Make listDir always emit paths within the given directory.
BUG=7346

Review URL: https://codereview.chromium.org//11553043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16275 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 19:00:12 +00:00
nweiz@google.com bc356f6840 Add the http library to pub.
TBR

Review URL: https://codereview.chromium.org//11593016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16231 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 22:00:05 +00:00
nweiz@google.com e2036dea9c Add a pub command for managing uploaders for packages.
BUG=7363

Review URL: https://codereview.chromium.org//11569046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16230 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 21:47:37 +00:00
amouravski@google.com 849f34cdbd Fixed package: imports breaking apidoc.
Review URL: https://codereview.chromium.org//11598012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16218 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 18:33:27 +00:00
nweiz@google.com 59fcc7a8cf Don't log a user's credentials.
Review URL: https://codereview.chromium.org//11565046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16184 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 22:30:09 +00:00
nweiz@google.com 3ea1942248 Validate that a single library has the same name as the package.
BUG=7045

Review URL: https://codereview.chromium.org//11519049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16139 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 20:57:30 +00:00
rnystrom@google.com 4edb7f8630 Exclude .gitignored files from published package.
Review URL: https://codereview.chromium.org//11567015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16134 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 18:39:16 +00:00
nweiz@google.com 899b1a7d1f A few small changes to the "pub lish" confirmation UI.
* Don't collapse the root directory of a directory tree, since this is usually
  going to be a very heterogeneous set of files and directories.

* Indent "(N more...)" two fewer spaces. This makes it clearer at what level
  things are collapsed when it comes immediately after a directory. E.g.

      |-- dir
      |   '-- file
      | (6 more...)
      |-- other-dir

  vs

      |-- dir
      |   '-- file
      |   (6 more...)
      |-- other-dir

Review URL: https://codereview.chromium.org//11442068

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16085 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 01:11:47 +00:00
rnystrom@google.com 617d0970cd Don't try to put symlinked files in archive.
Review URL: https://codereview.chromium.org//11558036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16079 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 23:55:20 +00:00
rnystrom@google.com 0f9bed70a5 Make pub publish more user friendly:
- Show the contents of their package.
- Let the confirm the upload even if there are no warnings.
- Make the error/warning text less scary.
- Validate that the pubspec has a version client-side.

Addresses #7175 and #7219.

Review URL: https://codereview.chromium.org//11557008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16068 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 22:22:38 +00:00
nweiz@google.com 7a2155fd65 Move path-manipulation code from io.dart into path.dart.
Review URL: https://codereview.chromium.org//11553005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16063 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 21:24:09 +00:00
rnystrom@google.com f0154d3b5a Fix #7330.
Review URL: https://codereview.chromium.org//11558022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16056 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 19:49:26 +00:00
nweiz@google.com 8c3148b8b8 Mark the Pub validator test as failing on mac.
Review URL: https://codereview.chromium.org//11552004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16013 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 01:47:38 +00:00
nweiz@google.com 6e4bb05e59 Add a validator that checks that the lib directory is not empty.
BUG=7045

Review URL: https://codereview.chromium.org//11543006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16010 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 00:54:17 +00:00
nweiz@google.com 4f782ecd56 Fix issue 7215 by relativising a path before checking its components.
This includes a couple more miscellaneous fixes.

BUG=7215

Review URL: https://codereview.chromium.org//11528020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16002 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 21:18:11 +00:00
rnystrom@google.com ff428417ed Workaround #6986.
This avoids trying to read a non-existent lockfile. On some
non-English locales, this fails when trying to parse the error
message coming from Windows.
BUG=6986

Review URL: https://codereview.chromium.org//11477012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15992 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 19:01:47 +00:00
sgjesse@google.com 93514a3b28 Reapply "Stop working around issue 6984."
Originally committted in r15804 and reverted in r15825.

Issue 6984 should be fixed by r15951.

R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//11528005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15961 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 10:03:21 +00:00
rnystrom@google.com 67367bf7df Handle relative paths where the trailing directory has an extension.
Review URL: https://codereview.chromium.org//11512011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15946 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 03:22:15 +00:00
rnystrom@google.com 9125bd4591 Clean up command help.
It was missing a newline before which made it look busted:

some command helpUsage: pub foo

Review URL: https://codereview.chromium.org//11485012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15944 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 02:15:05 +00:00
rnystrom@google.com e025df43ea Revise path library.
BUG=

Review URL: https://codereview.chromium.org//11471048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15937 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-10 23:56:19 +00:00
rnystrom@google.com 10f914c414 Get pub_lish tests running on Windows.
There were two issues:

1. We were printing 7zip's stderr to pub's stderr which confuses the tests that look for certain errors.
2. Sometimes deleting the sandbox fails because the spawned pub process hasn't shut down yet. To handle that, we just retry the delete a few times. <sigh>

Review URL: https://codereview.chromium.org//11522006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15935 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-10 23:11:21 +00:00
rnystrom@google.com c9bacbbdb4 Fix path tests on windows.
BUG=

Review URL: https://codereview.chromium.org//11472045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15883 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 05:11:32 +00:00
nweiz@google.com a050d4147d Make pipeInputToInput yet more resilient to stream closure.
Review URL: https://codereview.chromium.org//11468039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15882 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:59:37 +00:00
nweiz@google.com f813520a0a Add Bob's path library to pub.
BUG=7215

Review URL: https://codereview.chromium.org//11475046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15881 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:47:03 +00:00
nweiz@google.com 4b0a76bc2d pipeInputToInput should be resilient to stream closure.
Review URL: https://codereview.chromium.org//11474048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15880 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:39:19 +00:00
nweiz@google.com 3b8e03576e Validate that an uploaded package has a LICENSE file.
BUG=7045

Review URL: https://codereview.chromium.org//11474047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15879 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:24:44 +00:00
nweiz@google.com 55ad513b3b Work around issue 7218 in Pub.
Review URL: https://codereview.chromium.org//11470030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15878 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:21:15 +00:00
rnystrom@google.com 88bb817a82 Finish integrating logging.
BUG=

Review URL: https://codereview.chromium.org//11470031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15877 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:13:13 +00:00
rnystrom@google.com e5567d556b Add some relatively innocuous logging.
Review URL: https://codereview.chromium.org//11464032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15876 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 02:57:00 +00:00
rnystrom@google.com 30d0a0356d Fix type annotation and comment.
Review URL: https://codereview.chromium.org//11464040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15875 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 02:46:07 +00:00
rnystrom@google.com 015bb89346 Make sure to drain stderr in tests so that spawned process doesn't hang.
Review URL: https://codereview.chromium.org//11474046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15874 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 02:18:06 +00:00
rnystrom@google.com 2b9281fe14 Add in basic logging system.
Review URL: https://codereview.chromium.org//11470023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15870 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 22:13:47 +00:00
nweiz@google.com af15a10d6a Fix "src" detection in the pub lish validator on Windows.
Review URL: https://codereview.chromium.org//11472033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15866 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 21:33:35 +00:00
nweiz@google.com 89dca42b83 Properly parse library names on Windows in pub.
Review URL: https://codereview.chromium.org//11476030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15859 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 19:46:10 +00:00
nweiz@google.com 97f425b7de Add a validator that checks package names.
BUG=7045

Review URL: https://codereview.chromium.org//11444018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15857 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 19:30:51 +00:00