rnystrom@google.com
c5fb8014cb
Try setting the working directory explicitly.
...
This shouldn't be necessary but I want to see if this makes the
Windows buildbots happy.
BUG=
Review URL: https://codereview.chromium.org//11377036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14650 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 20:49:40 +00:00
ager@google.com
b61bebe636
Allow Directory.create to create all missing path components.
...
Unified Directory.create/list/delete to take a named 'recursive'
argument.
Fixed bug in Path implementation on Windows.
R=sgjesse@google.com
BUG=dartbug.com/6024
Review URL: https://codereview.chromium.org//11364097
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14572 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-06 15:00:54 +00:00
rnystrom@google.com
5704507534
Show better error messages in network failures.
...
We had decent messages for a couple of failure modes. This tries
to catch some more.
Review URL: https://codereview.chromium.org//11369066
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14543 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-05 20:42:39 +00:00
rnystrom@google.com
c561c7f4c8
Configure git explicitly when committing.
...
Review URL: https://codereview.chromium.org//11343059
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14314 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 23:31:16 +00:00
rnystrom@google.com
30f4763934
Revert "Explicitly configure git committer."
...
This reverts commit de38db47e7f5eca54ad1e338fec317cf67701448.
Review URL: https://codereview.chromium.org//11339058
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14313 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 22:19:21 +00:00
rnystrom@google.com
36ced3963a
Explicitly configure git committer.
...
Review URL: https://codereview.chromium.org//11276042
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14312 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 22:09:41 +00:00
floitsch@google.com
9cc9214b58
Rename regexp methods to getters.
...
Review URL: https://codereview.chromium.org//11266050
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14094 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 19:31:56 +00:00
floitsch@google.com
2e778387b3
Make getKeys, getValues getters (keys, values).
...
Review URL: https://codereview.chromium.org//11267018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14093 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 19:22:11 +00:00
floitsch@google.com
3300f91153
Make first and last getters.
...
Review URL: https://codereview.chromium.org//11273041
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14082 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 15:19:31 +00:00
floitsch@google.com
e7c5e69beb
Make String.charCodes a getter.
...
Review URL: https://codereview.chromium.org//11263040
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14078 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 14:25:43 +00:00
floitsch@google.com
09f6d09d88
Make isEmpty a getter.
...
Review URL: https://codereview.chromium.org//11238035
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14022 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 15:04:32 +00:00
floitsch@google.com
0e47b363ae
Make hasNext a getter instead of a method.
...
Review URL: https://codereview.chromium.org//11230011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14015 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 13:05:11 +00:00
lrn@google.com
a083c1a108
Removed IllegalAccessException and UnsupportedOperationException.
...
Both were converted to StateError.
Review URL: https://codereview.chromium.org//11235054
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14012 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 12:36:10 +00:00
rnystrom@google.com
4c04a099d5
Apply patch from other client.
...
BUG=
Review URL: https://codereview.chromium.org//11235067
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13984 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 20:25:58 +00:00
floitsch@google.com
27cadf2b66
isEven, isOdd, isNegative, isMaxValue, isMinValue, isInfinite, isPositive, isSingleValue.
...
Review URL: https://codereview.chromium.org//11227042
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13974 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 16:15:36 +00:00
ager@google.com
57d5cd2278
Remove second sleep in pub and enable pub tests on Windows.
...
After the inherit fix I cannot reproduce the other 7zip
problem either so I'm removing the sleep call. All tests
pass on my machine.
Bob, could you test this with all of your migthty pub
power and see if you can make it break?
R=sgjesse@google.com ,rnystrom@google.com
BUG=dartbug.com/5910
Review URL: https://codereview.chromium.org//11225056
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13964 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 13:56:54 +00:00
ager@google.com
e18e79217d
Do *not* make file handles inheritable on Windows.
...
This is the cause of the pub failures to unpack a file that has
just been created. The problem is that another 7-zip process has
inherited the file handle for a file that we are still writing.
When we are done writing the file, we cannot use it because the
other process still keeps the handle.
R=sgjesse@google.com ,rnystrom@google.com
BUG=dartbug.com/5910
Review URL: https://codereview.chromium.org//11230051
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13960 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 13:04:02 +00:00
floitsch@google.com
9074fd0178
Make hashCode a getter and not a method.
...
Review URL: https://codereview.chromium.org//11191078
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13866 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 12:41:04 +00:00
regis@google.com
8c3cfbb381
Second round of cleanups for new optional parameter semantics.
...
Review URL: https://codereview.chromium.org//11194025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13759 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 20:58:19 +00:00
ager@google.com
ff9e0f75fb
Change Process.start to return a future that completes with a
...
Process object only when the process has been successfully started.
This is less error prone since you can use all the methods on a
Process object as soon as you can get your hands on it. Unfortunately,
this change leads to quite a few changes in test.dart. Some of those
changes will fix bugs as well. We used to have a problem with a
timeout that could fire just in between two steps in a chain of
commands that constitute one test run. This change should address
that issue as well.
BUG=dartbug.com/5305
Review URL: https://codereview.chromium.org//11091070
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13729 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 10:57:45 +00:00
regis@google.com
adb534674c
Change core lib, dart2js, and more for new optional parameters syntax and semantics (new semantics is not enforced yet).
...
Review URL: https://codereview.chromium.org//11090016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13684 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 16:03:47 +00:00
ajohnsen@google.com
1cbee26da4
Use correct newline-token on windows, in pub.
...
BUG=
Review URL: https://codereview.chromium.org//11174003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13678 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 09:09:49 +00:00
ajohnsen@google.com
5a104d7f2b
Extract a list of lines from a process' stdout and stderr, in pub.
...
BUG=
Review URL: https://codereview.chromium.org//11169003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13677 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 08:34:20 +00:00
johnniwinther@google.com
19d27b1fe0
Pub fix for Windows
...
BUG=5859
Review URL: https://codereview.chromium.org//11170003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13676 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 08:09:51 +00:00
ricow@google.com
f7b22d4cbb
Download packages to temp dir inside system cache.
...
This fixes an issue where the rename will fail if your system temp directory is
on a different volume from your user directory (and thus your pub cache).
Review URL: https://codereview.chromium.org//11151035
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13674 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 06:18:49 +00:00
rnystrom@google.com
e6fbcf3426
Add prefix.
...
Review URL: https://codereview.chromium.org//11142028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13671 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-15 22:52:38 +00:00
rnystrom@google.com
ba0802348c
Sleep before moving directory on Windows.
...
Gives 7zip more time to finish extracting before we access the
directory.
BUG=
Review URL: https://codereview.chromium.org//11151030
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13670 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-15 22:43:15 +00:00
rnystrom@google.com
4091f4ed21
Put a nasty sleep() on Windows.
...
We get "file in use" errors between downloading and extracting archives, so sleep for a bit.
BUG=
Review URL: https://codereview.chromium.org//11146022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13668 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-15 21:27:59 +00:00
rnystrom@google.com
1bb574612e
Download to a temp dir and rename on success.
...
This prevents ghost packages ending up in your pub cache if a
download fails. Also added some more output during installation so
you can see what's happening.
BUG=
Review URL: https://codereview.chromium.org//11151026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13666 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-15 20:59:56 +00:00
rnystrom@google.com
fc169ee8b2
"Reverting 13451"
...
Review URL: https://codereview.chromium.org//11066091
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13452 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 23:32:21 +00:00
rnystrom@google.com
87f5622b44
Print out the working directory when git fails.
...
Also (sigh) re-enabling Windows again.
Review URL: https://codereview.chromium.org//11087039
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13451 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 23:26:43 +00:00
rnystrom@google.com
20788ffcba
Show git command that failed.
...
Review URL: https://codereview.chromium.org//11066088
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13439 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 20:54:05 +00:00
rnystrom@google.com
182ae3e26c
Update pub to use new import syntax.
...
Review URL: https://codereview.chromium.org//11093012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13391 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 01:25:43 +00:00
rnystrom@google.com
eb33df709b
Include stderr on git failure.
...
Also moves the git stuff out of io into its own library.
Review URL: https://codereview.chromium.org//11066066
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13388 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 00:56:57 +00:00
rnystrom@google.com
6a2cac8d2a
Create destination directory before git cloning into it.
...
BUG=
Review URL: https://codereview.chromium.org//11076004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13334 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 23:13:14 +00:00
rnystrom@google.com
f9b1655f8b
Pass in DART_SDK from batch file on Windows.
...
Review URL: https://codereview.chromium.org//11027049
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13269 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 23:29:59 +00:00
rnystrom@google.com
3baa35cb36
Don't warn on the absence of "lib" in the root package.
...
Review URL: https://codereview.chromium.org//11043026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13193 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-03 20:04:19 +00:00
rnystrom@google.com
1b52caacc5
Extract archives by writing .tar.gz to temp file on Windows.
...
Review URL: https://codereview.chromium.org//11031015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13096 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-02 01:34:30 +00:00
dgrove@google.com
9f1afef68c
Update the way that pub determines DART_SDK on macos/linux.
...
Review URL: https://codereview.chromium.org//10977083
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13037 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-28 18:21:28 +00:00
dgrove@google.com
5418ac38e6
Pass DART_SDK into pub for Linux/MacOS.
...
Review URL: https://codereview.chromium.org//10977063
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12985 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 22:28:52 +00:00
lrn@google.com
37197c2553
Stop using the Hashable interface.
...
All objects have a hashCode method, so there is no need for a Hashable
interface.
The interface itself is retained for at least two weeks, to give time for
code to remove uses of it.
Review URL: https://codereview.chromium.org//10993059
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12955 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 13:07:54 +00:00
rnystrom@google.com
def86f3256
Convert raw strings in pub (and apidoc) to new syntax.
...
Review URL: https://codereview.chromium.org//10981031
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12890 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-26 01:23:18 +00:00
lrn@google.com
a1faa6f135
Change IllegalArgumentException to ArgumentError.
...
Review URL: https://codereview.chromium.org//10989013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12841 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-25 12:27:52 +00:00
nweiz@google.com
85b348a987
Allow circular dependencies on the root source in Pub.
...
BUG=5300
Review URL: https://codereview.chromium.org//10949026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12817 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-24 22:55:42 +00:00
rnystrom@google.com
88e331a795
Support dependencies in SDK packages.
...
Review URL: https://codereview.chromium.org//10947050
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12816 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-24 22:49:05 +00:00
rnystrom@google.com
e8fe8a636c
Beat on hosted repo support on Windows a bit more.
...
The hosted tests are passing locally, and I've done pub install
from pub.dartlang.org successfully, but there are still some
intermittent errors, so I'm not enabling the hosted tests on the
bots just yet.
Review URL: https://codereview.chromium.org//10970025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12677 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 01:14:49 +00:00
ager@google.com
e86e1cec03
Fix API misuse bug I introduced when fixing another API misuse bug. :-)
...
R=nweiz@google.com
BUG=
Review URL: https://codereview.chromium.org//10966004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12615 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 06:20:45 +00:00
rnystrom@google.com
395cbc5de5
Create a sensible package cache directory on Windows.
...
BUG=5236
Review URL: https://codereview.chromium.org//10948046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12612 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 00:34:07 +00:00
rnystrom@google.com
4610c4d6ed
Remove "pub list" command.
...
Review URL: https://codereview.chromium.org//10941049
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12607 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 21:35:55 +00:00
nweiz@google.com
5096506fe0
Add packages/ directories for dart files in web/.
...
BUG=5196
Review URL: https://codereview.chromium.org//10951021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12587 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 18:54:01 +00:00