Commit Graph

5874 Commits

Author SHA1 Message Date
Martin Kustermann 60087afcf8 Add third_party/android_tools/sdk/platform-tools to PATH if available
R=whesse@google.com

Review URL: https://codereview.chromium.org/1938973002 .
2016-05-02 14:01:44 +02:00
Martin Kustermann abfea75f1e Add support for timeouts when using AdbPrecompilationCommand
R=whesse@google.com

Review URL: https://codereview.chromium.org/1940853002 .
2016-05-02 14:00:18 +02:00
Martin Kustermann 620b896e2f Initial support to test.dart for running precompiler tests on android devices
Steps to make this work:

a) Make sure you have an android sdk checkout:

  => See https://github.com/dart-lang/sdk/wiki/Building-Dart-SDK-for-Android

b) Building using android-toolchain crosscompiler:

  $ ./tools/build.py -mrelease -aarm --os=android dart_precompiled_runtime

  => Notice --os=android

c) Testing using attached android phones:

  $ export PATH=$PATH:$PWD/third_party/android_tools/sdk/platform-tools
  $ ./tools/test.py -mrelease -aarm --system=android -cprecompiler -rdart_precompiled --use-blobs

  => Notice --system=android

Failing tests on android can be marked in status files via:

[ $compiler == precompiler && $runtime == dart_precompiled && $system == android ]

R=whesse@google.com

Review URL: https://codereview.chromium.org/1922163002 .
2016-05-02 12:41:22 +02:00
Alan Knight c5acca2ff0 Check for the case where previousNode fails in sanitization. Can happen with object tags
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1825373004 .
2016-04-28 12:51:40 -07:00
Jacob Richman 6ef4eae35f Remove as checks bloating sample dart apps by 4K
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1923143002 .
2016-04-27 08:53:48 -07:00
Terry Lucas 425d3f5947 Updated DEPS to latest WebKit change
TBR=jacobr@google.com

Review URL: https://codereview.chromium.org/1924783002 .
2016-04-27 07:00:51 -07:00
Terry Lucas a96e920508 Update to latest chromium change fixes Mac compile
TBR=rmacnak@google.com

Review URL: https://codereview.chromium.org/1931473002 .
2016-04-27 05:27:21 -07:00
William Hesse a47eb0f59e Start working on version 1.17 of the Dart SDK
BUG=
R=kevmoo@google.com

Review URL: https://codereview.chromium.org/1923623002 .
2016-04-26 21:30:16 +02:00
William Hesse 7c9219a48e Revert "Delay Firefox browser startup in test scripts, to flatten load."
This reverts commit 40b69fd615.

BUG=https://github.com/dart-lang/sdk/issues/26060
R=kevmoo@google.com

Review URL: https://codereview.chromium.org/1921553005 .
2016-04-26 21:29:45 +02:00
William Hesse 40b69fd615 Delay Firefox browser startup in test scripts, to flatten load.
BUG=https://github.com/dart-lang/sdk/issues/26060
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/1882813002 .
2016-04-26 15:33:52 +02:00
Ryan Macnak f262fad639 Option to output precompiled instructions as a blob for use with mmap instead of assembly for use in a shared library.
BUG=http://dartbug.com/26199
R=fschneider@google.com

Review URL: https://codereview.chromium.org/1915853004 .
2016-04-25 16:19:34 -07:00
Alan Knight dad1a74d2e Oops, movementX/Y are private. Fix template
BUG=

Review URL: https://codereview.chromium.org/1916203002 .
2016-04-25 13:26:14 -07:00
Zachary Anderson 3d7202bad3 DBC: Adds simdbc64 target, adds arm64 arithmetic overflow logic
There were differences between linux gcc, android gcc,
MacOS clang, and 32 vs. 64-bit w.r.t the __builtin
functions for detecting arithmetic overflow. I couldn't get
them all working at the same time. Instead, I removed them,
and changed to always use the inline assembly. This works
in all the configurations above.

This change also adds a simdbc64 target for building simdbc
for 64-bit, and sets up the android targets. simdbc targets
arm, and simdbc64 targets arm64. You can build them with:

$ ./tools/build.py -m release -a simdbc{64} --os=android runtime

R=iposva@google.com

Review URL: https://codereview.chromium.org/1904153003 .
2016-04-25 12:48:34 -07:00
Alan Knight 5542568adc Fix MouseEvent.movement to not use old webkit prefix
BUG=

Review URL: https://codereview.chromium.org/1921823002 .
2016-04-25 12:35:03 -07:00
Terry Lucas cf59fdfabd Updated test expectations
TBR=jacobr@google.com

Review URL: https://codereview.chromium.org/1913573002 .
2016-04-22 14:02:01 -07:00
Terry Lucas 8f7b8a9d87 Update to new Webkit additions for custom elements
TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1914643002 .
2016-04-22 12:53:36 -07:00
Jacob Richman 7fdce7a2f0 Use _downcast and _cast instead of "as" to reduce dart2js output size.
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1914583002 .
2016-04-22 11:09:01 -07:00
John McCutchan 14d8653ed8 Go back to using dart_bootstrap for precompilation bots
BUG=

Review URL: https://codereview.chromium.org/1913193002 .
2016-04-22 11:07:01 -07:00
John McCutchan 0cfd4f5cd5 GN Build fixes for Flutter + gen_snapshot fix
1. Add "dart_runtime_mode" GN argument. This is an enum with three valid values: "release", "profile", and "develop".
   *) "release" builds product precompiled-runtime.
   *) "profile" builds non-product precompiled-runtime.
   *) "develop" builds non-product non-precompiled-runtime.

2. Remove the redundant "dart_product" GN argument.

3. Kill all *precompiled_runtime static library variants and the related config.

4. Always include the precompiler in gen_snapshot.

5. Support multiple --embedder_entry_points_manifest arguments to gen_snapshot.

6. Update our test harness to use gen_snapshot and pass the same kinds of command line arguments the Flutter folks are using.

7. ASSERT that both DART_PRECOMPILED_RUNTIME and DART_PRECOMPILER are not set at the same time.

R=fschneider@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/1903583002 .
2016-04-22 07:00:03 -07:00
Jacob Richman 819ed4bb60 Fix strong mode errors in SVG
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1903893003 .
2016-04-21 12:45:08 -07:00
Jacob Richman 25b88eabe5 Fix indexed_db strong mode warnings.
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1903973002 .
2016-04-21 10:03:53 -07:00
Jacob Richman 9ffe1c2450 Make querySelectorAll a generic method so that checked mode behavior is consistent with existing behavior and strong mode behavior is strong for the case of List<InputElement> elems = document.querySelector("input");
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1904903003 .
2016-04-21 09:54:18 -07:00
Jacob Richman 777e1a386e Revert "Remove the generics from _FrozenElementList: causes checked mode failures"
This reverts commit 7824ac771b.

BUG=

Review URL: https://codereview.chromium.org/1909613003 .
2016-04-20 18:50:11 -07:00
Jacob Richman b546d05362 TBR. Add back fix to the misleading types for onError. Otherwise, html/worker_test/functional fails due to the browser itself throwing an event of type Error that is not an ErrorEvent.
BUG=

Review URL: https://codereview.chromium.org/1908603002 .
2016-04-20 10:41:56 -07:00
Florian Schneider e905d64058 VM: Remove redundant build target dart_product.
It has been replaced by out/Product<arch>/dart

Building and testing product mode works via the -mproduct flag
with build.py/test.py.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1902073003 .
2016-04-20 12:29:21 +02:00
Jacob Richman 068252e721 Revert changes to event signatures as they broke one co19 test and this change isn't required due to relaxation in types in EventStreamProvider.dart
BUG=

Review URL: https://codereview.chromium.org/1903033002 .
2016-04-19 16:42:16 -07:00
Jacob Richman 864b64fd5e Strong html
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1894713002 .
2016-04-19 15:08:45 -07:00
Terry Lucas b500f3c008 Update to latest Chromium CL displays Dart version.
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1902233002 .
2016-04-19 12:55:24 -07:00
Terry Lucas e8fd9f5c1f The patch file cached_patches.dart generated from C++ with special dartium switch --enable-blink-features=dartGenCachedPatches
TBR=jacobr@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org/1898163002 .
2016-04-19 08:32:50 -07:00
Vyacheslav Egorov cb63245a4c Fix GYP configurations on Mac and Windows after DBC patch.
R=srdjan@google.com
BUG=

Review URL: https://codereview.chromium.org/1895223003 .
2016-04-19 00:07:04 +02:00
Vyacheslav Egorov ee0f608ce4 Dart Byte Code interpreter.
This version is Clang/GCC only and does not support Windows because it uses computed goto's.

Only unoptimized mode is supported.

Architecture is described in constants_dbc.h and stack_frame_dbc.h.

R=fschneider@google.com, zra@google.com

Review URL: https://codereview.chromium.org/1858283002 .
2016-04-18 23:02:01 +02:00
Alan Knight 810faa31b9 Don't add a non-null check in dart2js for a nullable parameter (seeWebGl.texImage2D)
BUG=

Review URL: https://codereview.chromium.org/1885943002 .
2016-04-16 16:26:14 -07:00
Kevin Moore 5b5312a67c pkg/analyzer: support latest pkg/crypto version
BUG= https://github.com/dart-lang/sdk/issues/26138
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org/1890973003 .
2016-04-15 10:00:24 -07:00
Alan Knight 7824ac771b Remove the generics from _FrozenElementList: causes checked mode failures
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1891543005 .
2016-04-14 15:14:40 -07:00
Terry Lucas 74ddf84ffd Remove MutationEvent bad entries in both removed list and renamed list
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1890983002 .
2016-04-14 13:49:42 -07:00
Alan Knight 48d73a66e0 Fix MutationEvent class name
BUG=

Review URL: https://codereview.chromium.org/1888693004 .
2016-04-14 09:56:07 -07:00
Alan Knight a718c8dac9 Fix a few strong mode errors in dart:html
BUG=
R=jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/65fe0a5383c7d09efb1dd958a7a30ec5c4d1c847

Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 15:13:31 -07:00
Alan Knight 3fd7e32b65 Revert "Fix a few strong mode errors in dart:html"
This reverts commit 65fe0a5383.

BUG=

Review URL: https://codereview.chromium.org/1879253004 .
2016-04-13 14:56:42 -07:00
Alan Knight 65fe0a5383 Fix a few strong mode errors in dart:html
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1876363006 .
2016-04-13 14:41:10 -07:00
William Hesse c0096e6f0c Print name of previous test when a browser test times out.
Remove timeout multiplier for dart2js browser tests.

BUG=https://github.com/dart-lang/sdk/issues/26060
R=kustermann@google.com

Review URL: https://codereview.chromium.org/1867283002 .
2016-04-13 12:35:27 +02:00
Jacob Richman 08c171d3e5 Revert "Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects.""
Fix missing case that was breaking co19 tests.
This reverts commit 688eeb555c.

BUG=

Review URL: https://codereview.chromium.org/1883513004 .
2016-04-12 17:16:06 -07:00
Jacob Richman 688eeb555c Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects."
This reverts commit f382890e1a.
Reverting while tests are fixed.

BUG=

Review URL: https://codereview.chromium.org/1879093002 .
2016-04-12 11:28:05 -07:00
Terry Lucas 7146915ea8 Breaking Change: Support @JS at library level
R=jacobr@google.com
TBR=asiva@google.com, jacobr@google.com

Review URL: https://codereview.chromium.org/1871573002 .
2016-04-12 10:29:49 -07:00
Jacob Richman f382890e1a Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects.
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1873933002 .
2016-04-12 10:23:32 -07:00
Jacob Richman e3bc65d10f Roll dartium deps forward
BUG=

Review URL: https://codereview.chromium.org/1881683003 .
2016-04-11 17:38:00 -07:00
Terry Lucas 5c359477be Update to reverted CL in WebKit
TBR=jacobr@google.com

Review URL: https://codereview.chromium.org/1876063002 .
2016-04-11 07:22:24 -07:00
William Hesse 333959070b Remove timeout multiplier for dart2js browser tests.
This reverts part of
https://github.com/dart-lang/sdk/commit/82e62563924c0bfde5be8dccfddb186980de637f
Review is at
https://codereview.chromium.org/1865913002

BUG=https://github.com/dart-lang/sdk/issues/26060
R=ahe@google.com

Review URL: https://codereview.chromium.org/1874653002 .
2016-04-08 13:06:32 +02:00
William Hesse 579d7c4aea Correct a tree hash to a commit hash in dartium DEPS
BUG=

Review URL: https://codereview.chromium.org/1873723002 .
2016-04-08 11:46:24 +02:00
Jacob Richman 63f33795ef Roll chromium dep forward.
BUG=

Review URL: https://codereview.chromium.org/1867203002 .
2016-04-07 17:23:02 -07:00
Ivan Posva c434931517 - Remove --coverage_dir flag and old-style coverage service requests.
BUG=

Review URL: https://codereview.chromium.org/1846443002 .
2016-04-07 16:24:49 -07:00