dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

5874 Commits

Author SHA1 Message Date
Florian Schneider b7359ace36 test.dart: Cope with errors when locating the VS toolchain on Windows. 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2723263002 .
 2017-03-09 12:35:08 -08:00
Peter von der Ahé 8608d1b436 Use correct types on cloned constructors in mixin applications. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2736103004 .
 2017-03-09 12:52:00 +01:00
John McCutchan bffe527cfe Sanity check that 'localhost' can be resolved before building Observatory 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2738983002 .
 2017-03-08 15:45:57 -08:00
Peter von der Ahé 2934dfaf16 Avoid crashing on function syntax. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2730093002 .
 2017-03-07 16:54:09 +01:00
William Hesse b226f6c3c2 Remove mojo download from dartium DEPS 
This step is causing failures on the buildbots, so if it isn't needed,
we can remove it.  The scripts try and use gsutil in an incorrect location,
and we can no longer manually copy it because the buildbots have started
automatically removing it.

BUG=https://github.com/dart-lang/sdk/issues/28248
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2724303004 .
 2017-03-06 09:32:43 +01:00
Vyacheslav Egorov 021f933f69 VM: Make use_osr an Isolate flag, similar to how we made use_field_guards. 
In Debug mode we have assertions checking that we don't attempt OSR when
FLAG_use_osr is disabled - however app-jit snapshots are compiled with OSR
enabled and still contain countining and OSR attempting code, which causes
assertions to fail.

Refactor how getters for isolate flags are defined, consolidate all flags into
a single list.

Update test expectations and switch -c dartk configuration to use app-jit snapshot.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2728163002 .
 2017-03-03 19:02:23 +01:00
Vyacheslav Egorov 4f06bae505 patch_sdk.dart: Fix Windows build. 
BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2730913002 .
 2017-03-03 15:19:28 +01:00
Vyacheslav Egorov c0c87b0afd GN: change the way we specify dependencies for the patched_sdk target. 
Instead of listing all files as inputs in GN script using Python helper we make
patch_sdk.dart generate a depfile that Ninja can use:

            https://ninja-build.org/manual.html#_depfile

This prevents breakages when some dependencies are deleted and GN is not rerun.

R=ahe@google.com, kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2729503006 .
 2017-03-03 14:52:51 +01:00
Martin Kustermann c00f2f0d00 Correct help message for --write-test-outcome-log 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2729153002 .
 2017-03-03 11:28:16 +01:00
Peter von der Ahé 88a92f805a Move all main methods to tool/. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2722223006 .
 2017-03-02 14:41:06 +01:00
John McCutchan 6c0a2af761 Have observatory_tool always invoke pub with no HTTP_PROXY environment variable set 
Fixes #28865

R=zra@google.com

Review-Url: https://codereview.chromium.org/2724483003 .
 2017-02-28 07:59:55 -08:00
Zach Anderson 7af47d5ea9 [test.dart]: Fix output encoding in case of non-utf8 test output 
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2721683002 .
 2017-02-28 07:50:28 -08:00
Florian Schneider 74d2f37a86 Improve ctrl-C handling in ninja.py. 
This enables interrupting by pressing ctrl-C.

BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2725493002 .
 2017-02-27 15:38:45 -08:00
Zachary Anderson 6c08487f47 [Fuchsia] Adds an option to create_sdk.py to skip binary stripping 
create_sdk.py tries to use the host 'strip' instead of the
'strip' from the build's toolchain.

fixes #28900

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2720613004 .
 2017-02-27 15:35:11 -08:00
Zachary Anderson 1f0168b95c Adds tools/ninja.py that runs goma builds in parallel 
This CL adds a script tools/ninja.py that runs Goma enabled builds
in parallel. Non-goma builds are run serially, as before.

Conflating this feature with gyp support in tools/build.py
got to be a bit of a mess, which is why this is split off as a
separate script. This script can replace build.py after gyp support
is removed.

With a warm goma:
$ time ./tools/build.py -m debug,release -a x64,ia32 runtime runtime_precompiled
...
real	4m25.627s
user	3m30.740s
sys	1m3.873s

$ ./tools/ninja.py -m debug,release -a x64,ia32 runtime runtime_precompiled
...
The build took 108.900 seconds

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2712743009 .
 2017-02-27 10:55:01 -08:00
Vyacheslav Egorov b026aed3cf Remove dartk and DFE workers support from testing scripts and kernel-service. 
We only support running -c dark and -c dartkp configuration through Kernel isolate and fasta in non-batch mode.

R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2721543003 .
 2017-02-27 13:31:03 +01:00
Vyacheslav Egorov de56824429 Switch -c dartk/dartkp configuration to use fasta. 
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2721443002 .
 2017-02-26 20:39:02 +01:00
Stephen Adams 14c7c3c556 Redo "Refined types for most HtmlElement factory constructors" 
Fix: ShadowElement is not always present.

Original:
Committed: https://github.com/dart-lang/sdk/commit/b7b12b564a3e1811ccfca3e28fe30dde685f6633
Reverted:  https://github.com/dart-lang/sdk/commit/963df1e3e1a3bac0013d191d2b02898bbebefa9d

BUG=

Review-Url: https://codereview.chromium.org/2718713003 .
 2017-02-24 14:28:58 -08:00
Stephen Adams 963df1e3e1 Revert "Refined types for most HtmlElement factory constructors" 
Need to fix ShadowElement

TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2710323004 .
 2017-02-24 14:15:37 -08:00
Stephen Adams b7b12b564a Refined types for most HtmlElement factory constructors 
The body of new DivElement() is marked as returning a DivElement, instead of inferred to return Element.
The more precise receiver type allows svg polyfills to be excluded, allowsing the HtmlElement methods to be identified as the single target and inlined.

This tends to improve the code generated for idioms like

    new DivElement()..classes.add('foo')

    var e1 = new DivElement();
    e1.children.add(e2);

BUG=
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2705213003 .
 2017-02-24 11:23:06 -08:00
Martin Kustermann eb903b955e Add more debugging support to coredump archiving code 
It seems sometimes we cannot find the coredumps but we are unable to
reproduce it (even on the bots). So let's add some more debugging
information.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2713193002 .
 2017-02-24 17:06:28 +01:00
Martin Kustermann cc45d27027 Disable usage of site_config boto file 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2710333004 .
 2017-02-24 17:04:40 +01:00
Martin Kustermann f3bef9983b Convert arguments to ''.join() to strings in tools/utils.py 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2710333003 .
 2017-02-24 12:23:26 +01:00
Vyacheslav Egorov cb530221cf Pass patched_sdk path down to fasta as an Uri. 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2719453002 .
 2017-02-24 11:08:03 +01:00
Vyacheslav Egorov 0e11683bd8 Fix the placement of the platform.dill file generated by patch_sdk. 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2716793003 .
 2017-02-24 10:45:54 +01:00
Ben Konyi 2b81624bb2 Revert "Revert "[test.dart] Complain if there is non-utf8 formatted data in test output"" 
This reverts commit 7af8f320a7.

TBR=zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2710603009 .
 2017-02-23 17:08:15 -08:00
Ben Konyi 7af8f320a7 Revert "[test.dart] Complain if there is non-utf8 formatted data in test output" 
This reverts commit c294dec5e6.

TBR=zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2705213006 .
 2017-02-23 16:57:31 -08:00
Zach Anderson c294dec5e6 [test.dart] Complain if there is non-utf8 formatted data in test output 
related #28872

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2710003005 .
 2017-02-23 14:15:26 -08:00
Martin Kustermann 8b7f7b242c Temporarily suppress fasta compiler hints/warnings/errors during compilation of platform.dill for the patched_sdk target 
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2711963002 .
 2017-02-23 20:01:15 +01:00
Vyacheslav Egorov 1f00947ea8 In patch_sdk when passing --packages down to fasta turn it into an URI. 
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2709033005 .
 2017-02-23 17:38:23 +01:00
Vyacheslav Egorov 80c3247f99 Make patch_sdk step invoke fasta's compile_platform to generate patched_sdk/platform.dill. 
This is where Kernel isolate expects to find it currently.

This is a preparation for flipping DFE_USE_FASTA to true.

R=ahe@google.com, kustermann@google.com

Review-Url: https://codereview.chromium.org/2710943006 .
 2017-02-23 17:12:45 +01:00
Devon Carew 1da570c215 Remove and hide analyzer cli flags. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2713723003 .
 2017-02-22 14:09:41 -08:00
Peter von der Ahé b13b8d872a Add YAML file with VM patch file information. 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2698003003 .
 2017-02-21 13:56:28 +01:00
Devon Carew 6e9adf2624 Remove older deprecated flags; more cleanup to the cli help args. 
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2692203010 .
 2017-02-17 13:30:37 -08:00
Vyacheslav Egorov 364b8575de VM: Restore old implementation of ClassID.cid* fields. 
When we were implementing bootstraping from Kernel in https://github.com/dart-lang/sdk/commit/23fd1a184b393825f29444243780f3593ce0b3c1 we switched ClassID.cid* fields to become 'static final' lazily initialized fields instead of constants as they were before. This was mainly done to allow dartk compile patched_sdk - because these fields were previously injected in runtime and never existed in the text form.

However this regressed code quality for app-jit and app-aot snapshots because 'static final' fields are reset by snapshotting so resulting code contains InitStaticField and LoadStaticField instructions.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2693863006 .
 2017-02-16 17:43:42 +01:00
Martin Kustermann fa36b34887 Add dart_bootstrap/gen_snapshot/dart_precompiled_runtime to task_kill.py (by default) 
On Windows we had hanging dart_bootstrap.exe which prevented builds. So
with this change will we ensure to kill these leaked processes if they
occur.

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2698943002 .
 2017-02-16 12:48:59 +01:00
William Hesse 389fa95320 Remove two flags from dartanalyzer running in test.dart 
BUG=
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2691393004 .
 2017-02-16 01:55:59 +01:00
Ryan Macnak 1ed4c27c01 Roll Dartium blink to "Update invocation of create_snapshot_bin.py." 
Review-Url: https://codereview.chromium.org/2694413004 .
 2017-02-15 14:42:44 -08:00
Jens Johansen 7b11ede8c2 [Kernel] Replace --use-dfe with --no-dfe 
Replace --use-dfe (defaulting to true) with --no-dfe (defaulting to false)
so that it is still used by default, but it is actually possible to
_not_ run with the kernel isolate and instead use dartk.

BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2689213006 .
 2017-02-15 11:08:31 +01:00
Sigmund Cherem 91796be231 Add mode to test.dart to run dart2js with kernel, and include initial set of 
failures in status files

BUG=
R=efortuna@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2688413004 .
 2017-02-14 14:37:23 -08:00
Martin Kustermann affb786582 Enable support for coredump archiving on windows 
BUG=https://github.com/dart-lang/sdk/issues/28648
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2692883002 .
 2017-02-14 16:34:31 +01:00
Martin Kustermann d93928a6ce Make dartk-{release,debug} builders work properly again 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2696613003 .
 2017-02-14 14:01:58 +01:00
Peter von der Ahé cb10fc984b Add a new kind of suite to ease test.dart integration. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2693893002 .
 2017-02-14 10:45:44 +01:00
Kevin Moore cbdf0aec6f DEPS: Updated to latest dart2js_info 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2682083006 .
 2017-02-10 14:34:41 -08:00
Zach Anderson 8a9a98073f [dart:io] flush() stdin before close()ing 
Calls to close() on an IOSink do not imply that writes buffered by the
underlying StreamConsumer have been flushed. This CL adds a note
indicating this to the IOSink docs, and adds calls to flush() before
calls to close() for some calls to stdin.close() for spawned
processes in our tests.

related #28737

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2687963003 .
 2017-02-10 09:55:16 -08:00
Martin Kustermann a00684d6c0 Run pub get with --verbose to debug flaky timeouts on pkg tests 
BUG=https://github.com/dart-lang/sdk/issues/28734
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2683353003 .
 2017-02-10 13:41:51 +01:00
Martin Kustermann be2942a279 Significantly reduce the timeout app_jit is given on the buildbot 
Currently tests in the app_jit-debug configuration are given 16 minutes
timeout. This caused us to run into a global timeout of test.dart (it's
"debug timer" which is set to 10 minutes of inactivity).

Even the slowest tests run in the app_jit-debug configuration within around 1:30 m on the buildbot.

This CL changes the timeout from 16 minutes to 4 minutes.

R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2685303002 .
 2017-02-10 12:56:44 +01:00
Florian Schneider eccfcdf787 Remove left-over from bad merge. 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2687943003 .
 2017-02-09 16:17:28 -08:00
Florian Schneider 20e736e6ca test.dart: Dump stack traces for child processes on timeout. 
This should help flaky timeout debugging for tests that spawn child processes.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2682373004 .
 2017-02-09 15:34:24 -08:00
William Hesse eb0502e62d Add "Chrome Helper" to taskkill script on macos 
BUG=
R=terry@google.com

Review-Url: https://codereview.chromium.org/2684993007 .
 2017-02-09 20:09:19 +01:00