dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

5874 Commits

Author SHA1 Message Date
Bob Nystrom 8d90363dce Start getting the DDC bot to run tests using test.dart. 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2960343002 .
 2017-06-28 16:50:27 -07:00
Stephen Adams fc7d880c60 Implement _ChildNodeListLazy.removeRange as throwing UnsupportedError 
_ChildNodeListLazy.removeRange used to throw UnsupportedError because ListMixin.removeRange calls setRange.
Make throwing UnsupportedError explicit to avoid relying on the implementation of ListMixin.removeRange
This will unblock the '_closeGap' change.

BUG=
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2955103003 .
 2017-06-28 09:42:55 -07:00
Florian Loitsch 978213d427 Revert "Make Zone API strong mode clean." 
This reverts commit 0b35711d48.

BUG=

Review-Url: https://codereview.chromium.org/2963743002 .
 2017-06-28 13:31:32 +02:00
Florian Loitsch 0b35711d48 Make Zone API strong mode clean. 
Review-Url: https://codereview.chromium.org/2959163002 .
 2017-06-28 13:16:39 +02:00
Zachary Anderson a8252812b6 [Fuchsia] Script for downloading the latest prebuilt dev SDK 
This will be called from a jiri hook after it lands.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2959973002 .
 2017-06-27 13:12:22 -07:00
Bob Nystrom 82df163eca Refactor dependency_graph.dart. 
It multiplexed a bunch of different events onto a single stream. But
every single listener on that stream immediately demuxed them and only
cared about a subset of the events.

So I made separate streams for each event. Other minor clean-ups too.

R=sigmund@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2957703002 .
 2017-06-26 17:07:37 -07:00
Erik Corry 029b1cb948 Spelling fixes e to i. 
R=kevmoo@google.com
BUG=

Review-Url: https://codereview.chromium.org/2957593002 .
 2017-06-24 13:41:39 +02:00
Bob Nystrom dfb4f52b43 Simplify enqueueBrowserTest(). 
It's still big and monolithic, but it's not as big as it was before.

- Remove old unused Polymer stuff.
- Move some of the logic out into a helper function.
- Other small tweaks.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2949823003 .
 2017-06-23 15:02:36 -07:00
Bob Nystrom 3144296c4f Remove unused PubCommand stuff. 
The rest of the pub functionality was removed already, so I think this
is just a straggler.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2944163002 .
 2017-06-23 12:55:46 -07:00
Bob Nystrom 556c0550bf Simplify CommandOutput and friends. 
- Merge CommandOutputImpl and CommandOutput. There were no classes that
  implemented CommandOutput that didn't extend the Impl.
- Remove "Impl" from the other class names.
- Make stuff private when possible. Likewise final.
- Other tiny style changes.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2946783002 .
 2017-06-23 12:13:31 -07:00
William Hesse 6482690781 Rebased simplify CompilerConfiguration 
BUG=

Review-Url: https://codereview.chromium.org/2954113002 .
 2017-06-23 14:10:03 +02:00
Alexander Aprelev 8cd713bed3 Introduce dart_host_toolchain argument for generate_patch_sdk.gni. This allows for Flutter build to make sure that host_toolchain used for patched_sdk generation word size matches target platform. 
Flutter Dart in product configuration doesn't allow --checked option. So remove '--checked' from invocation.

R=rmacnak@google.com

BUG:https://github.com/flutter/flutter/issues/10841
Review-Url: https://codereview.chromium.org/2944103003 .
 2017-06-22 12:41:31 -07:00
Zachary Anderson ac16656161 Remove MIPS support 
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2858623002 .
 2017-06-22 08:49:22 -07:00
William Hesse 232684aac0 Update co19 to revision dec2b67aaab3bb7339b9764049707e71e601da3d 
BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2954443002 .
 2017-06-22 11:46:13 +02:00
William Hesse d8ec6450d0 Fix compiler==none case in browser testing (Dartium case) 
Error was introduced in https://codereview.chromium.org/2947473002/

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2950173004 .
 2017-06-22 11:30:23 +02:00
Bob Nystrom b452b39962 Basic support for dev_compiler in test.dart. 
It can compile and run tests on Chrome. There are a lot of failing tests
that I (or the team) will need to triage, but I think at least basic
tests are working as expected.

There is code that could be cleaned up to more neatly factor how dart2js
and dartdevc are handled now that there are two separate compilers to
JS. There's also some redundant code between the path for testing
compile errors (enqueueStandardTest()) and the path for running a test
in the browser.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2947473002 .
 2017-06-21 13:19:28 -07:00
William Hesse 823e7c6b03 Revert "Merge branch 'co19roll'" 
This reverts commit 42cc7d570c.

BUG=
TBR=sortie@google.com

Review-Url: https://codereview.chromium.org/2952573003 .
 2017-06-21 07:15:25 +02:00
William Hesse 42cc7d570c Merge branch 'co19roll' 
Update co19 status files with results from buildbot.

Update co19 to revision dec2b67aaab3bb7339b9764049707e71e601da3d

BUG=
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2948763003 .
 2017-06-21 06:34:55 +02:00
Terry Lucas 97d188418a Update to latest WebKit changes: 
- Fix DevConsole crash with JS see Issue https://github.com/dart-lang/sdk/issues/29873
     CL https://codereview.chromium.org/2941143002
- Fix debugging in WebStorm, NULL returned for JS objects see Issue https://github.com/dart-lang/sdk/issues/29854
     CL https://codereview.chromium.org/2945063002

TBR=jacobr@google.com

Review-Url: https://codereview.chromium.org/2952643002 .
 2017-06-20 09:08:00 -07:00
William Hesse ea2167bbac Make debian package builder more robust in uninstall step 
BUG=
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2950783002 .
 2017-06-20 13:34:54 +02:00
William Hesse 2b6fbc7069 Revert co19 roll attempt 
Revert "Status files updated according to buildbot log (#29929)"

This reverts commit 5b7a7958b2.

Revert "Fix Dartium DEPS typo in co19 roll"

This reverts commit 4996568879.

BUG=

Review-Url: https://codereview.chromium.org/2949543002 .
 2017-06-19 13:17:55 +02:00
William Hesse 4996568879 Fix Dartium DEPS typo in co19 roll 
BUG=
TBR=sortie@google.com

Review-Url: https://codereview.chromium.org/2951443002 .
 2017-06-19 13:06:40 +02:00
Sergey G. Grekhov 5b7a7958b2 Status files updated according to buildbot log (#29929) 
* DEPS ans status files updated to the last co19 commit

* Commented lines deleted from .status file

* DEPS ans status files updated to the last co19 commit

* DEPS ans status files updated to the fix of https://github.com/dart-lang/co19/issues/110

* Fix for https://github.com/dart-lang/co19/issues/87 added

* Fix for https://github.com/dart-lang/co19/issues/88 added

* Status files updated according to buildbot log
 2017-06-19 12:55:32 +02:00
Florian Loitsch dbfaa36728 Add summary command to bot. 
Looks at the latest build results and gives information. For now
just prints, if a bot has an error.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2944653002 .
 2017-06-19 10:22:50 +02:00
Terry Lucas 8ab1a87aba Typedefs and IDL file order between platforms could generated different files. 
TBR=alanknight@google.com,vsm@google.com

Review-Url: https://codereview.chromium.org/2948493002 .
 2017-06-18 11:54:29 -07:00
Siva Chandra bac83e0973 Replace the --platform vm_option with --kernel-binaries option. 
This new flag value specifies the directory in which the VM should look
up the platform.dill file. A future change will require the VM to load
another kernel binary from disk. This binary will also live in the same
directory that --kernel-binaries specifies. This way, we avoid adding a
different flag for each of the different binaries.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2933203004 .
 2017-06-16 12:22:31 -07:00
William Hesse f99509ad42 Fix bad merge in refactoring 
The land of https://codereview.chromium.org/2933973002 merged badly
with https://codereview.chromium.org/2934243002/

BUG=https://github.com/dart-lang/sdk/issues/28955
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2938383002 .
 2017-06-16 10:10:54 +02:00
Terry Lucas 1e1bab0bff Updated to latest WebKit changes 
TBR=asiva@google.com

Review-Url: https://codereview.chromium.org/2939193002 .
 2017-06-15 14:31:48 -07:00
Bob Nystrom a6ca718e98 Simplify Command classes. 
- Get rid of separate CommandBuilder class and singleton pattern. It
  was being passed around explicitly even though half of the places
  that received a CommandBuilder as a parameter still directly called
  CommandBuilder.instance instead of using it.
- Get rid of Command caching. As far as I can tell, it makes no
  measurable difference in runtime performance or memory usage. Even
  with a large invocation of a lot of configurations and tests, the
  Command classes don't seem to be a significant use of memory.
- Shorten the factory names. "get" adds no value, and we know it
  returns a "Command" since it's on Command.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2933973002 .
 2017-06-15 14:19:03 -07:00
Siva Chandra 65a5707189 Add a vmservice_sdk directory in runtime/bin. 
This directory has a libraries.json file pointing to vmservice_io and
_vmservice in the source tree. The script tools/patch_sdk.dart has been
updated to use this new directory as the sdk directory when compiling
dart:vmservice_io. This way, to build vmservice_io.dill, we
do not need to copy the dart files pertaining to vmservice_io and
_vmservice.

Fixes #29859

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2938903003 .
 2017-06-15 13:08:10 -07:00
Sigmund Cherem 5a63b0e339 Add flutter mode to patched_sdk 
This is needed to create a platform.dill for flutter.

R=aam@google.com

Review-Url: https://codereview.chromium.org/2931773003 .
 2017-06-14 17:29:36 -07:00
Bob Nystrom 979026abef Don't allow "none" as a runtime for dartk. 
Also, add a little sanity checking in TestCase.

Fix #29842.

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2941603002 .
 2017-06-14 10:31:09 -07:00
William Hesse e64ee95959 Move ie11 timeout handling code to BrowserControllerTestOutcome 
Only content_shell testing uses the BrowserCommandOutputImpl class.
Rename the class to ContentShellCommandOutputImpl.

BUG=https://github.com/dart-lang/sdk/issues/28955
BUG=https://github.com/dart-lang/sdk/issues/29869
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2934243002 .
 2017-06-14 15:50:41 +02:00
William Hesse d98d32b63c Report ie11 timeouts in debug log, not as errors (attempt 2) 
BUG=https://github.com/dart-lang/sdk/issues/28955
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2938813002 .
 2017-06-14 14:17:27 +02:00
Siva Chandra 1fe6097cc8 Generate vmservice_io.dill along with platform.dill. 
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2940473002 .
 2017-06-13 15:40:17 -07:00
Siva Chandra a879f91420 Remove dart:_vmservice and dart:vmservice_io from platform.dill. 
A mirrors test which now passes has been removed from the blacklist.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2931193002 .
 2017-06-13 13:49:38 -07:00
William Hesse dc08a02cbc Revert co19 roll attempt. 
After status files are updated with failures from this run, we will try again.

R=brian.wilkerson@google.com

Revert "DEPS ans status files updated to the last co19 commit (#29604)"

This reverts commit 70b2b3f6b1.

Revert "Fix typos introduced in DEPS by 70b2b3f6b1bb2def061f80b7693cd89e23fa9134"

This reverts commit 9e9f7210d0.

BUG=

Review-Url: https://codereview.chromium.org/2933403002 .
 2017-06-13 20:31:19 +02:00
William Hesse 9e9f7210d0 Fix typos introduced in DEPS by 70b2b3f6b1 
BUG=
TBR=brian.wilkerson@google.com

Review-Url: https://codereview.chromium.org/2939553004 .
 2017-06-13 19:59:53 +02:00
Sergey G. Grekhov 70b2b3f6b1 DEPS ans status files updated to the last co19 commit (#29604) 
* DEPS ans status files updated to the last co19 commit

* Commented lines deleted from .status file

* DEPS ans status files updated to the last co19 commit

* DEPS ans status files updated to the fix of https://github.com/dart-lang/co19/issues/110

* Fix for https://github.com/dart-lang/co19/issues/87 added

* Fix for https://github.com/dart-lang/co19/issues/88 added
 2017-06-13 19:49:18 +02:00
Alan Knight 6042ae4bd8 Get the name and message from DOMException correctly 
BUG=
R=jacobr@google.com, terry@google.com

Review-Url: https://codereview.chromium.org/2931903003 .
 2017-06-13 08:59:33 -07:00
Terry Lucas b3a90540f1 Fix sound not playing in Dartium checked mode. 
Checked mode failure with optional args and Promise missing convertNativePromiseToDartFuture calls.
Easiest solution is to emit proper code instead of re-plumbing the Dartium emitter for operations
with optional arguments that are Promises.

https://github.com/dart-lang/sdk/issues/29810

TBR=alanknight@google.com,kevmoo@google.com

Review-Url: https://codereview.chromium.org/2940543002 .
 2017-06-12 22:50:12 -07:00
Bob Nystrom 571839ed90 Remove negated variables now that we support "!". 
R=lrn@google.com

Review-Url: https://codereview.chromium.org/2924183002 .
 2017-06-12 15:50:59 -07:00
Bob Nystrom 19cb0cafb7 Simplify test_suite.dart. 
- Get rid of baseCommand, which is only ever an empty list.
- Move some utility classes out of the giant test_suite.dart.

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2915843003 .
 2017-06-09 16:46:49 -07:00
Terry Lucas 3cbacefbe3 Fix HTMLCanvasElement.getContext it can return RenderingContext2 now which will be tree shaken without this annotation. 
R=alanknight@google.com,sigmund@google.com

Review-Url: https://codereview.chromium.org/2932793002 .
 2017-06-08 20:44:30 -07:00
Bob Nystrom 8bc4e89219 Remove unused record and replay functionality. 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2920633002 .
 2017-06-08 09:18:03 -07:00
Sigmund Cherem 9c32854d44 Use the correct sources for dartium in patched_sdk for vm 
BUG=
R=ahe@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2923043004 .
 2017-06-06 12:03:16 -07:00
William Hesse 33fe148c51 Update checked-in SDK to 1.24.0-dev.6.8 
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2922273003 .
 2017-06-06 17:05:09 +02:00
Martin Kustermann 2c41c608f1 Roll dartium to pull in changes art_SaveCompilationTrace/_Dart_LoadCompilationTrace 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2927553002 .
 2017-06-06 13:36:46 +02:00
Terry Lucas ffa45b00fe Updated to latest WebKit change. Support --dump-render-tree switch. 
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2923673002 .
 2017-06-05 13:45:15 -07:00
Ryan Macnak b69b3e58f0 Update test.py's --arch=all to match that of build.py. 
R=zra@google.com

Review-Url: https://codereview.chromium.org/2918403002 .
 2017-06-05 13:07:30 -07:00