dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

5874 Commits

Author SHA1 Message Date
Morten Krogh-Jespersen c6af2dbc49 Adding debug info to assertion resultcode check 
Bug:
Change-Id: I02c4eae12c557157e1d61a5cfc8ffad752be8f30
Reviewed-on: https://dart-review.googlesource.com/8441
Reviewed-by: Jonas Termansen <sortie@google.com>
 2017-09-26 11:57:57 +00:00
Morten Krogh-Jespersen fb0b2c5a73 Adding info about negative tests to result log 
Bug:
Change-Id: Ic868ca637477bce4a7857304ce6b23aa4ea30817
Reviewed-on: https://dart-review.googlesource.com/8420
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
 2017-09-26 10:19:31 +00:00
Morten Krogh-Jespersen 83f0b3a12a Fixing up result tool with test-matrix. 
Bug:
Change-Id: I753da0d540910a5309f0ba73a13d0d4093621330
Reviewed-on: https://dart-review.googlesource.com/8042
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-26 07:43:42 +00:00
Morten Krogh-Jespersen befa486d21 Changing naming of luci classes. 
Bug:
Change-Id: Ie453bdc93661f9269ce20dc060e726a115b0a1b0
Reviewed-on: https://dart-review.googlesource.com/8043
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-26 07:13:18 +00:00
Bob Nystrom 1f3d67ddbc Don't migrate status entries from "_parser.status" files. 
Change-Id: Ic5e3cbe8d6f95e1f3e9b2e0f4313d54e240d6f7d
Reviewed-on: https://dart-review.googlesource.com/7850
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-22 22:39:14 +00:00
Terry Lucas 65a2303696 Updated to support migrating *.html files too 
R=rnystrom@google.com

Change-Id: Icca5b36c87cb7c3af566b66cec537c53552deeab
Reviewed-on: https://dart-review.googlesource.com/7635
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-09-22 17:50:57 +00:00
Bob Nystrom edee53f93d Bring back the deleted 1.0 corelib tests. 
What is dead may never die.

Change-Id: I80ef766b8ce2b6e1416df8e1f9b91fb74169dc79
Reviewed-on: https://dart-review.googlesource.com/7483
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-21 18:29:40 +00:00
Morten Krogh-Jespersen c02d9c821f Adding baseclass for output + fix. 
Change-Id: I99000a97055db94b54ded7a8c15d417de4588674
Reviewed-on: https://dart-review.googlesource.com/7542
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-21 10:48:08 +00:00
Alexander Thomas 9124b9efd3 Revert "Remove mac-vm-kernel builder from the CQ until we have >4 machines to run it." 
This reverts commit f598b4766c.
Root cause fixed in https://chromium-review.googlesource.com/c/chromium/tools/build/+/676844.

Bug:
Change-Id: I73da850638cf677b5fe4c8f8549b3174c34dd828
Reviewed-on: https://dart-review.googlesource.com/7547
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2017-09-21 10:11:18 +00:00
Erik Ernst c49cbae7f0 Rietveld 2688903004 (spec_parser) migrated to Gerrit. 
Change-Id: Iddd1e8a795bfaed0092a30bb9d83070fe62d4a60
Reviewed-on: https://dart-review.googlesource.com/7261
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-21 09:36:10 +00:00
William Hesse f598b4766c Remove mac-vm-kernel builder from the CQ until we have >4 machines to run it. 
Bug:
Change-Id: Ibb07ce966bdedb20551f079ce5899d83b7ebb8a6
Reviewed-on: https://dart-review.googlesource.com/7403
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-20 22:57:46 +00:00
Florian Loitsch 38bf70d7ac Use generic functions in zones. 
Migrated from https://chromiumcodereview.appspot.com/2893893002/

Change-Id: I0bd6dc1438eb1e6762e7760a08b5a760b07d4b10
Reviewed-on: https://dart-review.googlesource.com/4942
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
 2017-09-20 15:46:06 +00:00
Morten Krogh-Jespersen a535f656c2 Adding table outputs to consoles. 
Bug:
Change-Id: Idea8360620f2f8370114ff231e6ffb38bfca9ab3
Reviewed-on: https://dart-review.googlesource.com/7262
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-20 13:02:06 +00:00
Johnni Winther 08c0d36b6d Address comments 
in https://dart-review.googlesource.com/c/sdk/+/6860

Change-Id: I466e9123d152537005898f97998b62200d81ee45
Reviewed-on: https://dart-review.googlesource.com/6961
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-19 12:28:40 +00:00
Johnni Winther e61f8461f3 Support --commit in compare_failures 
Change-Id: Ie54419ab14b6fef9401404da1063e556e9dc2131
Reviewed-on: https://dart-review.googlesource.com/6860
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
 2017-09-19 12:09:44 +00:00
Alexander Thomas 203c339583 Use separate unittest builder for dart2js 
Bug:
Change-Id: Ic5835777ec9e32a1558728c31b1fa1b8787fb386
Reviewed-on: https://dart-review.googlesource.com/6467
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-19 08:12:37 +00:00
Morten Krogh-Jespersen 51f78ee83c Building result tool to interpret result.log and status files. 
Change-Id: If74fad44ac9253cd0046c52bf070d507964bcab8
Reviewed-on: https://dart-review.googlesource.com/3542
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-19 07:41:09 +00:00
Morten Krogh-Jespersen 47d60740b2 Adding descriptions about current tools in gardening. 
Change-Id: I7337fb938e1ff91be0304c7884ee38732253195e
Reviewed-on: https://dart-review.googlesource.com/6580
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-18 14:49:46 +00:00
William Hesse adb0e8864f Update Dart version to 2.0.0 
Bug:
Change-Id: I13a8daea5f7adae670cea73d429d552c1e96c8e6
Reviewed-on: https://dart-review.googlesource.com/6461
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-09-18 09:31:05 +00:00
William Hesse 12b9849c80 Set requirejs timeout in DDC testing to 30 seconds 
Bug:
Change-Id: I4b2148b4f526e583025d78c9b47bfac357fa45bb
Reviewed-on: https://dart-review.googlesource.com/5761
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2017-09-15 01:38:17 +00:00
Alexander Markov fe2e114e8e [Test tool] Support testing of Dart VM experimental strong mode 
This CL extends '--compiler dartkp' configuration of the testing
tool (tools/test.py) to take '--strong' option into account.

'tools/test.py -c dartkp --strong' runs tests through kernel
front-end (pkg/front_end/tool/_fasta/compile.dart) and Dart VM
precompiler, and in addition:

* Enables strong mode in the kernel front-end.
* Enables experimental optimizations in the kernel front-end
  with '--target=vm_precompiler'.
* Enables experimental optimizations in Dart VM with
  '--experimental-strong-mode'.

Issue: https://github.com/dart-lang/sdk/issues/30480
Change-Id: I565a4a7f79f880a872a28fe6b91372af1e77f978
Reviewed-on: https://dart-review.googlesource.com/5295
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-09-14 16:32:37 +00:00
Morten Krogh-Jespersen d695a17edd Adding selectors to summary map. 
Change-Id: Id5bfc3282b85415ccca6bf0b81595b67dcba9111
Reviewed-on: https://dart-review.googlesource.com/5663
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
 2017-09-14 13:15:58 +00:00
Alexander Thomas d80ff48a4c Enable sdk and vm-kernel-mac builders in commit queue 
Bug:
Change-Id: Ib33c6b40b9c609068ea317eba4c8927f964ef061
Reviewed-on: https://dart-review.googlesource.com/4420
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2017-09-14 07:52:30 +00:00
Morten Krogh-Jespersen a90bb3a104 Revert "Revert "Adding option to print out status files for a configuration."" 
This reverts commit f50c2c2b6a.

Bug:
Change-Id: I895c1e498b58999127ebb6d7656c12fba1cb338b
Reviewed-on: https://dart-review.googlesource.com/5422
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
 2017-09-13 12:52:18 +00:00
William Hesse f50c2c2b6a Revert "Adding option to print out status files for a configuration." 
This reverts commit 0fcffaaeb5.

Bug:
Change-Id: I8852ce88c190e420615314b7fe95bf9d69a5f8d1
TBR=mkroghj@google.com
Reviewed-on: https://dart-review.googlesource.com/5361
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-13 09:11:32 +00:00
Morten Krogh-Jespersen b3788bc610 Adding extra information to toSummaryMap(). 
This will allow external clients to rebuild an environment to
correctly identify tests in status files.

Change-Id: Id359224df758600161cc7e32472638559eee0719
Reviewed-on: https://dart-review.googlesource.com/3881
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-13 08:36:58 +00:00
Morten Krogh-Jespersen 0fcffaaeb5 Adding option to print out status files for a configuration. 
This will help other tools to use the same status files at test.py
uses.

Bug:
Change-Id: Ib01d0c8368089a35682d0d79e257b8df01e54de6
Reviewed-on: https://dart-review.googlesource.com/3941
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-13 08:30:38 +00:00
Ben Konyi 0b7d8e9688 Fixed status file migration issues for html and isolate directories. 
Bug:
Change-Id: Ie4853d109b95731018f63487fd658b76841c8742
Reviewed-on: https://dart-review.googlesource.com/4603
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-12 17:57:20 +00:00
Alexander Thomas 7bca1569e5 Correct case of vctip executable 
Bug:
Change-Id: I89fa5a8ccdff94d2034ee6366b6c0261d9a2e99e
Reviewed-on: https://dart-review.googlesource.com/5260
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2017-09-12 17:20:31 +00:00
Morten Krogh-Jespersen 5862a92160 Adding write-result-log output to bots.py. 
Change-Id: I57bbfa48fc204af63f12632f8b0a42a90a5b751c
Reviewed-on: https://dart-review.googlesource.com/5200
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-12 14:00:11 +00:00
Alexander Thomas 08d4ebc11e Kill VCTIP and mspdbsrv on windows 
Don't rely on "non-empty strings are true" semantics.
Stop killing svn, it's already dead.

Bug:
Change-Id: Iab228963535f1a4cf3b778c0353fb7cfd5b04695
Reviewed-on: https://dart-review.googlesource.com/4740
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-11 16:04:25 +00:00
William Hesse 233a4d0d65 Add buildbot status to CQ config 
Bug:
Change-Id: I1ba66c9d321008ba5dbfb3715de67ba67c6485eb
Reviewed-on: https://dart-review.googlesource.com/4840
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-09-11 15:57:46 +00:00
Alexander Thomas 6c81e20c83 Add support for try bots to bot_utils 
Bug:
Change-Id: Ic7cab15974e1786f26b744b28068b8971a2d746e
Reviewed-on: https://dart-review.googlesource.com/4421
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-11 07:13:22 +00:00
Zach Anderson ef5c553333 [windows] Disable clang-format download for bot failures 
Change-Id: I137675fc73e4b068baf1100b684ae0d694d12977
Reviewed-on: https://dart-review.googlesource.com/4607
Reviewed-by: Zach Anderson <zra@google.com>
 2017-09-08 22:43:37 +00:00
Zach Anderson 0be7e8076a [windows] Roll clang-format forward 
Change-Id: I47f4539ccf6e4a54bcdfb7381c1091d63ef94951
Reviewed-on: https://dart-review.googlesource.com/4606
Reviewed-by: Zach Anderson <zra@google.com>
 2017-09-08 22:25:38 +00:00
Alexander Thomas d44ab6e4ad Make Windows SDK builder experimental 
Bug:
Change-Id: Id4591240611fff601cb83e6bf9b6df89aadddfea
Reviewed-on: https://dart-review.googlesource.com/4460
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-09-08 12:33:31 +00:00
Alexander Thomas a787e53198 Add Windows SDK builder to CQ 
Add experimental Linux SDK builder to CQ
Support building API docs on try builders

Bug:
Change-Id: I163d2a4a9e5f8a062ea005e9b50d9351d867ba02
Reviewed-on: https://dart-review.googlesource.com/4000
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-08 11:36:23 +00:00
Sigmund Cherem 436ed70100 Add preview-dart-2 flag to analyzer cli and plumb it through test.py. 
This allows us to collect stats about language-style tests as follows:

 ./tools/test.py -m release -c dart2analyzer -r none --preview-dart-2 --report \
      language language_2 corelib corelib_2

As of this morning, the command above has 87% of the tests passing.

Change-Id: I0f84211d5f33659d5923601267367be90c578107
Reviewed-on: https://dart-review.googlesource.com/3381
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-09-07 20:13:40 +00:00
Zachary Anderson e94ff71e64 [infra] Roll back toolchain due to crasher on mac. 
related #30642

Change-Id: Id1777132d4447da45eec07513406b25e9c1795b0
Reviewed-on: https://dart-review.googlesource.com/4061
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-07 16:14:40 +00:00
William Hesse c638d2edfc Remove the vm-kernel-mac builder from the CQ due to overloading 
Bug:
Change-Id: Ice37e8722f50ddefc42a46b0faec180dfe715f99
Reviewed-on: https://dart-review.googlesource.com/4040
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-07 14:59:12 +00:00
Bob Nystrom 090efb342c Don't delete 1.0 tests and status entries when migrating. 
We do still remove the "_strong" ones since there's no reason to keep
those -- "_2" strictly supersedes them.

Change-Id: If6b9a8a5d22d8995a5fd0ac5538449c646b053ef
Reviewed-on: https://dart-review.googlesource.com/3403
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-06 17:40:19 +00:00
William Hesse 809a6b6fb3 Turn off retries in the CQ (commit queue) configuration 
Bug:
Change-Id: I089c0377c65eace61d994602a2baf352a0f2c7f2
Reviewed-on: https://dart-review.googlesource.com/3622
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-06 15:12:36 +00:00
Morten Krogh-Jespersen 955ce3e05b Removing compilationSkipped from result json log. 
Change-Id: Ifc4a0d64a15f2de3f65808a40fb8cf8275937982
Reviewed-on: https://dart-review.googlesource.com/3600
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-06 13:27:22 +00:00
Jens Johansen d854c77e58 [kernel] Only serialize non-external libaries and sources from those. 
Previously the VM couldn't handle external libraries, but that was
fixed in 2f49198520.

Part of the CL was reverted though because the compilatin was changed
to using an outline instead of the platform which doesn't work.
What does work though, is not including the external libraries in the
output.

This CL makes the following changes:

* Don't include external libraries in the output (by not setting all
  libraries to be non-external).

* Only writes the sources actually used to the binary (i.e. whatever
  libraries left out because they were external will not contribute
  source code either).

* Cleanup of now unused code.


Timings (only run once though):


Without this CL (but with the CL it's based on):

$ time python tools/test.py -m release -cdartk language -j6
Test configuration: dartk_vm_release_x64
[05:43 | 100% | + 3504 | -    0]

real    5m43.597s
user    33m48.152s
sys     9m34.140s


Only the "utils/kernel-service/kernel-service.dart" part of this CL:

$ time python tools/test.py -m release -cdartk language -j6
Test configuration: dartk_vm_release_x64
[04:55 | 100% | + 3504 | -    0]

real    4m55.684s
user    29m54.360s
sys     8m7.408s


Entire CL:

$ time python tools/test.py -m release -cdartk language -j6
Test configuration: dartk_vm_release_x64
[04:20 | 100% | + 3504 | -    0]

real    4m20.416s
user    27m17.320s
sys     6m53.472s

Change-Id: Ie9c5bfa958e558a5007784e821a0b58d417bae55
Reviewed-on: https://dart-review.googlesource.com/3161
Reviewed-by: Samir Jindel <sjindel@google.com>
 2017-09-06 11:56:24 +00:00
Alexander Thomas 9278d252e7 Re-enable Mac try builders 
Skip tests failing on CQ but not on buildbot
Replace some timeouts with skips to speed up the tests

Bug:
Change-Id: I101e922bd18e522d0efd69cdf8329e2ca8f9829e
Reviewed-on: https://dart-review.googlesource.com/2920
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2017-09-06 09:46:14 +00:00
Terry Lucas 352f9fd859 Fixed bad indent not flushing emitted files. 
Removed Dartium code emission.

TBR: alanknight@google.com,vsm@google.com
Change-Id: Ib027f542b238c90311f6838e67b4b8d27815374c
Reviewed-on: https://dart-review.googlesource.com/3280
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-09-05 14:43:08 +00:00
Alexander Thomas c3fdf433a2 Remove flaky mac try bots 
Bug:
Change-Id: I12c222ec85dcc1f6ba2f4b61acfcf7bdb04533d2
Reviewed-on: https://dart-review.googlesource.com/3003
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-09-04 16:57:12 +00:00
Alexander Thomas e01f51e100 Remove slow precomp builder from CQ 
Bug:
Change-Id: I4da113c739dd511514319af498206b5b5690a9b1
Reviewed-on: https://dart-review.googlesource.com/2980
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-04 15:33:31 +00:00
Alexander Thomas 9670b42c7f Remove failing dart2js Windows builder from CQ 
Bug:
Change-Id: I162122e3d2c42fb7dee713ce63db1f375a6bc783
Reviewed-on: https://dart-review.googlesource.com/2961
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-04 14:46:27 +00:00
Alexander Thomas c2143ad258 Remove failing windows builder from commit queue 
BUG=
R=whesse@google.com

Review-Url: https://codereview.chromium.org/3008093002 .
 2017-09-04 14:17:37 +02:00