Commit Graph

1865 Commits

Author SHA1 Message Date
ajohnsen@google.com 970cc5ba68 Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl.
After this cleanup, RegExp no longer have a const constructor. Use 'new
RegExp(...)' from now on.

BUG=

Review URL: https://codereview.chromium.org//11365196

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14838 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 10:41:37 +00:00
ajohnsen@google.com ab69873a42 Make RegExp constructor non-const.
Another take of https://codereview.chromium.org/11410033/ with status changes applied for co19 tests.

BUG=

Review URL: https://codereview.chromium.org//11369210

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14837 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 10:18:06 +00:00
ajohnsen@google.com ec9fee9858 "Reverting 14829-14832"
BUG=

Review URL: https://codereview.chromium.org//11312203

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14833 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 07:28:13 +00:00
ajohnsen@google.com 8dc3edd7ce Make RegExp's constructor non-const.
BUG=

Review URL: https://codereview.chromium.org//11410033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14829 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 06:48:43 +00:00
floitsch@google.com 8e6f238f86 a === b -> identical(a, b)
Replace === null with == null.

BUG=http://dartbug.com/6380

Review URL: https://codereview.chromium.org//11361190

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14794 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 17:19:58 +00:00
antonm@google.com 1ba6e54811 Do not generate multiple tests for vm options.
R=ahe@google.com,ager@google.com
BUG=6436

Review URL: https://codereview.chromium.org//11358175

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14786 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 13:26:30 +00:00
rnystrom@google.com f30fb024ce The goal here is to rearrange StandardTestSuite so that it's possible override some of its behavior for running package tests while still keeping the rest of the behavior.
This patch is just the refactoring. I'll do the actual pub stuff in a separate patch.

Review URL: https://codereview.chromium.org//11275217

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14757 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-09 20:56:59 +00:00
kustermann@google.com e78ad924f6 Added support for logging the output of failed flaky tests.
Failed flaky tests will be logged to 'failed_flaky_tests.log'.
The default behavior is that the old log file gets deleted before
any tests are run. To prevent this, the '--append_flaky_log' option
can be set.

Review URL: https://codereview.chromium.org//11364129

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14735 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-09 12:08:00 +00:00
efortuna@google.com 4a23980c8a Take 2 of splitting html tests into subtests. Had to make two changes to drt to
fully work.
Review URL: https://codereview.chromium.org//11368128

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14703 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 18:54:14 +00:00
efortuna@google.com 868b439bc4 Revert run large html tests individually.
Review URL: https://codereview.chromium.org//11406002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14667 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 00:11:09 +00:00
efortuna@google.com bf9cd05e79 Move html_individual_config to correct location after tree rearranging.
Review URL: https://codereview.chromium.org//11362147

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14664 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 23:53:11 +00:00
efortuna@google.com 3476d1c528 Run large html tests individually.
Review URL: https://codereview.chromium.org//11293019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14663 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 23:42:50 +00:00
kustermann@google.com 3462f1ecaa Don't run compile-time error tests on browsers.
Also added a new category to the report stating the number of tests
we skipped because of this.

Review URL: https://codereview.chromium.org//11368101

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14571 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-06 14:46:10 +00:00
ahe@google.com 9b49d61cfb Fix syntax errors.
Review URL: https://codereview.chromium.org//11362079

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14512 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-05 06:22:15 +00:00
ahe@google.com a57b4fbf71 Prevent hanging if selenium cannot close browser.
Review URL: https://codereview.chromium.org//11275125

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14511 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-05 06:17:33 +00:00
ahe@google.com dd897e755e Disable wrapping of Firefox/Windows dart2js tests.
Review URL: https://codereview.chromium.org//11312059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14451 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-02 07:13:26 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
gram@google.com 353f4c4c8a Update test utils to generate wrappers with new library syntax and handle
tests with new library syntax.
Review URL: https://codereview.chromium.org//11358045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14437 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 21:31:27 +00:00
ahe@google.com fbe2e51663 Disable Firefox console logging as it appears to hang the browser.
See this selenium bug: http://code.google.com/p/selenium/issues/detail?id=4375

Review URL: https://codereview.chromium.org//11362036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14419 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 17:46:30 +00:00
ager@google.com 0fed52bd2d Only start http server for browser tests.
This reduces the annoyance of the fixed port number used and allows
non-browser test configurations to be run in parallel (or one browser
configuration in parallel with a bunch of non-browser configurations).

R=ahe@google.com,ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//11360028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14403 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 12:58:44 +00:00
ager@google.com 83f2cfa4c1 Get rid of 'close' on process. It is very easy to use incorrectly and cut off data from your streams.
When using an interactive process started with Process.start you have
to drain the stdout and stderr streams to make sure that all resources
are freed. If you do that the dart:io library will make sure to free
all system resources for you.

R=sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//11343009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14187 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 11:59:09 +00:00
ager@google.com 7f04c40b2d Land update to tools directory with new binaries.
BUG=

Review URL: https://codereview.chromium.org//11343008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14176 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 09:21:14 +00:00
floitsch@google.com 7041a6bbf1 Make methods in Stopwatch getters and rename to be more consistent.
Includes:
- Stopwatch.frequency.
- Stopwatch.elapsedInMs() -> Stopwatch.elapsedMilliseconds
- Stopwatch.elapsedInUs() -> Stopwatch.elapsedMicroseconds
- Stopwatch.elapsed() -> Stopwatch.elapsedTicks

Review URL: https://codereview.chromium.org//11265024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14140 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 14:25:23 +00:00
efortuna@google.com 7df114a8f1 Revert 14110 "Fix usesWebDriver check"
Review URL: https://codereview.chromium.org//11275052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14111 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 23:26:23 +00:00
efortuna@google.com d1aff197ae Fix usesWebDriver check, and the usage of config['browser'] vs config['runtime']
Review URL: https://codereview.chromium.org//11275025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14110 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 23:14:55 +00:00
ricow@google.com 252f09bc40 Testing support for running tests minified in dart2js.
Review URL: https://codereview.chromium.org//11262028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14071 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 12:18:30 +00:00
ager@google.com 01e373bef0 Fix CCTestSuite in test.dart.
R=sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//11270032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14064 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 09:38:51 +00:00
efortuna@google.com e304efa6d6 Update status file for ie10 html tests.
Review URL: https://codereview.chromium.org//11262017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14044 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 22:03:48 +00:00
ager@google.com 61e7010693 Fix issue that cases the usesWebDriver getter in TestCase to always return false.
Remove newly added code for timeout handling.

Make sure that timeout handling actually works so that dart2js
timing out will actually cause a timeout even when retrying
browser tests.

R=ahe@google.com,efortuna@google.com,ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//11267008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14014 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 12:58:40 +00:00
efortuna@google.com 6100654dcf Don't replicate timeout calculation for browser tests. They do their own timing
from the time that the browser is actually opened.
Review URL: https://codereview.chromium.org//11189150

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13989 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 23:12:54 +00:00
efortuna@google.com 1407ec08f3 Increase timeout to see if "timeout" errors on Windows bot goes away. Otherwise,
the test framework  is incorrectly calculating "timeouts"
Review URL: https://codereview.chromium.org//11229067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13986 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 21:41:00 +00:00
efortuna@google.com 48a9e653c8 Mark ie10 + Windows as an acceptable browser + OS combo.
Review URL: https://codereview.chromium.org//11175043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13979 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 17:24:24 +00:00
efortuna@google.com ce3543f212 Reapply ie to ie9 rename.
Review URL: https://codereview.chromium.org//11231081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13978 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 17:17:30 +00:00
efortuna@google.com 920589055f Revert rename ie to ie9.
Review URL: https://codereview.chromium.org//11249003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13976 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 16:28:33 +00:00
ahe@google.com 7f0ec1cf6e Update dart2js co19 status after bad merge.
Review URL: https://codereview.chromium.org//11231071

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13944 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 10:42:21 +00:00
ahe@google.com 8fafabe175 Update co19 to r397.
Review URL: https://codereview.chromium.org//11233058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13935 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 09:28:31 +00:00
efortuna@google.com 31fb4a0c74 Complete renaming of ie bots to ie9, to add ie10.
Review URL: https://codereview.chromium.org//11189101

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13908 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 20:59:01 +00:00
efortuna@google.com 4a3571e368 Add Opera to the "webdriver_test_setup" script.
Review URL: https://codereview.chromium.org//11232026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13905 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 20:01:55 +00:00
ricow@google.com fe7ace35e5 Fix DiffProgressIndicator to use the correct parameter name
Review URL: https://codereview.chromium.org//11187049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13770 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 11:17:12 +00:00
efortuna@google.com 89d7cdaae5 One more ie -> ie9 rename.
Review URL: https://codereview.chromium.org//11191031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13750 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 18:06:15 +00:00
efortuna@google.com 4839206863 Rename ie to ie9.
Review URL: https://codereview.chromium.org//11184015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13748 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 17:44:38 +00:00
blois@google.com d41409e427 Making unit test HTML files contain relative paths.
BUG=

Review URL: https://codereview.chromium.org//11186009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13746 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 15:59:47 +00:00
ager@google.com ff9e0f75fb Change Process.start to return a future that completes with a
Process object only when the process has been successfully started.

This is less error prone since you can use all the methods on a
Process object as soon as you can get your hands on it. Unfortunately,
this change leads to quite a few changes in test.dart. Some of those
changes will fix bugs as well. We used to have a problem with a
timeout that could fire just in between two steps in a chain of
commands that constitute one test run. This change should address
that issue as well.

BUG=dartbug.com/5305

Review URL: https://codereview.chromium.org//11091070

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13729 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-17 10:57:45 +00:00
regis@google.com adb534674c Change core lib, dart2js, and more for new optional parameters syntax and semantics (new semantics is not enforced yet).
Review URL: https://codereview.chromium.org//11090016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13684 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 16:03:47 +00:00
ahe@google.com 6cac76e938 Group co19 results by runtime.
Review URL: https://codereview.chromium.org//11181004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13680 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 14:23:35 +00:00
efortuna@google.com 00d5784bf5 Revert r13569 "Automagically start up selenium server for Safari." Seems to be
causing widespread browser failure. Will investigate.
Review URL: https://codereview.chromium.org//11088084

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13578 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-11 19:59:12 +00:00
efortuna@google.com a09c2bb4d1 Automagically start up selenium server for Safari.
Review URL: https://codereview.chromium.org//11098075

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13569 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-11 18:24:42 +00:00
ricow@google.com a4009dfcbf Move tools/testing/dart/version.dart into tools/release
Review URL: https://codereview.chromium.org//11028137

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13526 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-11 09:36:46 +00:00
ricow@google.com 239e10a5d0 Fix path handling in tools/version.dart so that it does not matter where we call this from.
Review URL: https://codereview.chromium.org//11098066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13525 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-11 09:30:48 +00:00
johnniwinther@google.com 5989130b34 Version fixed for Windows.
Review URL: https://codereview.chromium.org//11090067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13523 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-11 08:50:35 +00:00