03f7b209b2
test.py: Report timings by adding up the time of all commands
...
BUT=http://dartbug.com/11847
R=ahe@google.com
Review URL: https://codereview.chromium.org//19388002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25096 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 13:15:22 +00:00
41d8e6ee39
Test running changes.
...
1. Change in the test runner to consider any warning as warning.
After this following was required:
2. Triage language tests.
3. Triage co19 tests.
R=brianwilkerson@google.com , kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//18174010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25069 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-16 20:35:51 +00:00
e7de55b945
Revert "When using content_shell to run tests, run them with '--single-process'"
...
This reverts r24840.
r24840 revealed quite a few issues. Unfortunatly it seems like we cannot run all
tests in single-process mode. In particular indexeddb tests are timing out. The
issue seems to be this chromium bug:
https://code.google.com/p/chromium/issues/detail?id=229684
Review URL: https://codereview.chromium.org//18104008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24846 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 15:34:59 +00:00
1a0def6a46
When using content_shell to run tests, run them with '--single-process'
...
It seems that the exit code of the renderer process is not correctly propagated
to content_shell (at least on windows). By passing the '--single-process' flag
to content_shell, we ensure that we can detect renderer crashes.
R=whesse@google.com
Review URL: https://codereview.chromium.org//18826010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24840 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-09 12:33:03 +00:00
58c6fd4e23
Allow re-running of failing tests on drt-windows
...
Our windows dartium builders are currently flaky. The reasons seems to be that
content_shell.exe is sometimes not able to fetch resources from the HttpServer.
This CL makes sure we try to re-run failing tests on drt-windows. This will
hopefully make the builder less flaky and will buy us some time to figure out
what the exact issue is.
The default number of retries before we give up is 2.
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//18144012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24785 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-05 13:05:19 +00:00
658ea93cec
Allow selectors for test.py to match against a subtest of a multitest
...
Previously we were not able to select a subtest of a multitest
(i.e. "tools/test.py suite/path-to-test/01").
R=johnniwinther@google.com , karlklose@google.com
Review URL: https://codereview.chromium.org//18121013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24782 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-05 08:50:26 +00:00
af21d74d2d
Fix safari browser to use Future.value
...
Also correct type errors found by the analyzer.
R=kustermann@google.com
Review URL: https://codereview.chromium.org//18089005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24532 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 17:07:17 +00:00
545f6e1341
Update checked in binary to version 0.5.19.0
...
This is a reland of r24086 with a fix catching errors in the websocket server in tools/testing/dart/http_server.dart.
R=kustermann@google.com
Review URL: https://codereview.chromium.org//18065003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24520 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 16:10:59 +00:00
48527d06cd
Revert "Do not compile tests for different browsers separately"
...
We have to use subdirectories instead of special names in the javascript files.
R=ahe@google.com
Review URL: https://codereview.chromium.org//17601013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24408 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 14:37:53 +00:00
3b23ea198f
Bugfix: make the new compilation artifact layout also work with dart2dart
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//17619013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24407 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 13:59:49 +00:00
30511a9190
Bugfix in test_suite.dart
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//17644011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24404 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 13:38:56 +00:00
f6e9601c01
Do not compile tests for different browsers separately
...
Currently we recompile tests with dart2js for all browsers. There is no
need to do these compilations for all browsers, since the output should be
exactly the same.
R=ricow@google.com
Review URL: https://codereview.chromium.org//17570018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24402 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 13:25:11 +00:00
ee35be8712
Simplify close functionality in the browser controller.
...
Add a done future that can be used by users to determine if a browser crashes.
This future is the same we return from the close call.
R=kustermann@google.com
Review URL: https://codereview.chromium.org//17633008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24395 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-25 11:35:24 +00:00
302fbd5174
Add two additional directories to safari cache clearing.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//17592003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24317 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 09:47:37 +00:00
568e86f4a1
Also remove Library/Safari from users home dir if --clear_safari_cache is set
...
Additionally, actually handle errors on deletion correctly by checking for existense first and actually failing if we fail to delete the directory.
R=kustermann@google.com
Review URL: https://codereview.chromium.org//17450017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24238 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 16:01:41 +00:00
8984694c97
Print out experimental test.py reproduction command
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//17361003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24231 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 14:19:11 +00:00
ecb4dea649
Add safari cache clearing browser functionality to the safari browser.
...
Also, add flag to test.dart to enable this feature.
R=kustermann@google.com
Review URL: https://codereview.chromium.org//17489002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24215 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 10:30:04 +00:00
12682d3bc7
Add timing information for the individual steps of a failing test.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//17302007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24213 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-20 09:03:23 +00:00
4c5b2ac2ab
Revert 24086 Update checked in binary to version 0.5.19.0
...
This is causing crashes in http server.
R=kustermann@google.com
Review URL: https://codereview.chromium.org//17274002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24096 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-17 13:22:15 +00:00
1523157e2e
Fix missing underscore for maxBrowserProcesses
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//17270002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24095 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-17 13:04:20 +00:00
b814373e75
Change number of started browser processes to the max number of browser processes.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//17037003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24094 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-17 12:45:12 +00:00
1970fc7afb
Update checked in binary to version 0.5.19.0
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//17078007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24086 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-17 10:47:02 +00:00
62f8da0bdf
More debug info on the browser controller.
...
Add timing info on actual requests to the http server.
Review URL: https://codereview.chromium.org//16848019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24017 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-14 06:22:07 +00:00
a3902a74f4
Add debug info for how long it takes to handle the output from the browser.
...
Review URL: https://codereview.chromium.org//16881006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23998 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 17:15:54 +00:00
4eff75f62d
Write browser timings on the debug log
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//16848011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23984 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 14:30:35 +00:00
5c08a32f86
Use request.response.done instead of getting future from close()
...
The checked in binary does not return a future on close()
R=kustermann@google.com
Review URL: https://codereview.chromium.org//16844010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23980 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 14:01:37 +00:00
786b0b7f1c
Fix error handling on errorReportingServer
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//16946005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23978 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 13:53:25 +00:00
e97215e045
Add error reporting server to the browser controller
...
This is used to send back errors from the browsers if we see any issues with getting resources.
R=kustermann@google.com
Review URL: https://codereview.chromium.org//16900003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23973 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 12:40:37 +00:00
4efd9609a5
Moving timing info to utils.dart:DebugLogger
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//16958003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23967 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 11:20:21 +00:00
c0c48e23ef
Add correct timing collection for new browser controller
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//16948002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23957 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 09:14:39 +00:00
0e1472b570
Fix id in browser testing status map
...
This was wrongly set to the old id.
R=kustermann@google.com
Review URL: https://codereview.chromium.org//16922003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23952 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 08:20:55 +00:00
73b8c4adc6
Fixed bug in browser_controller.dart
...
If a browser crashed on it's own, then the driving page running in it will not
post a result. So the test will eventually time out. The testing server will
then call 'browser.close()' and after the browser was closed, it will start a
new one.
Previously the 'browser.close()' future did not complete in this scenario, since
the '_browserClosed' callback was not set.
Note that with the new browser controller, browser crashes will currently be
reported as timeouts.
R=ricow@google.com
Review URL: https://codereview.chromium.org//16836009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23951 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 08:08:34 +00:00
96272613d5
Add timing information to browser controller logging.
...
Review URL: https://codereview.chromium.org//16843009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23950 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-13 06:59:58 +00:00
b0f2c1f54e
Increase timeout for simarm
...
TBR=zra
Review URL: https://codereview.chromium.org//16415013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23919 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 16:56:10 +00:00
8ea94854e3
Second round of status file updates for simarm/arm
...
TBR=zra
Review URL: https://codereview.chromium.org//16802005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23915 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 16:04:39 +00:00
659b81f7bb
Fixed sdk/bin/dart2analyzer to use package-root
...
R=ahe@google.com , ricow@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//16667023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23905 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 13:37:46 +00:00
ee8ddfd2d4
Add debugging info to browser controller.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//16365017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23903 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 12:54:39 +00:00
57838491b2
Remove leftover static varibles for old kill functionality in the browser controller.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//16280010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23898 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-12 09:10:04 +00:00
609c1239d5
Move interop js code out of dart.js
...
BUG=7973
Note: this is a breaking change and would be advertised as such.
Anyone using js-interop would need to explicitly include:
<script type="text/javascript" "pkg/browser/lib/interop.js"></script>
along with dart.js in their HTML. Those who don't need js-interop can
save on this code.
Alexandre: I'm imagining interop.js would be the landing spot for
dart:js bootstrap code as well.
R=alexandre.ardhuin@gmail.com , dgrove@google.com
Review URL: https://codereview.chromium.org//16592002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23855 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-11 15:33:18 +00:00
80fea8fd8e
More fixes for java2dart and status files.
...
Now DDA passes/fails the same tests as Java version.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//15675016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23705 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 18:13:44 +00:00
096eb7ada9
Simplified the killing mechanism in browser_controller.dart
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//15649021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23674 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 11:12:59 +00:00
b06ba1b3e6
Run 'analyzer' tests with '--show-package-warnings' flag.
...
This does not make any new tests to pass or fail though.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//16278009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23633 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 15:26:56 +00:00
0d3e47da2c
Basic dart^2 analyzer tests running.
...
Status file only for co19 now, more status files in next CL.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//16357010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23602 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 16:09:13 +00:00
662c2a8262
Rename RuntimeError to CyclicIntializationError, as per spec.
...
The RuntimeError has been used to report cyclic initialization errors in
dart2js.
It has also been used for other, unrelated, uses, where it makes
little to no sense.
The RuntimeError type has been removed, but added in js_helper.dart,
where dart2js uses it.
Uses of new RuntimeError("some message") have been converted to
other errors (Argument/State/Unsupported). In some cases, just
throwing a String might have been just as good.
BUG=http://dartbug.com/11040
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//16154017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23584 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 10:33:11 +00:00
e4a9a2eab4
Give developers a correct command line to reproduce test failures without the use of selenium.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//16116007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23576 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 06:13:01 +00:00
077b9e2d29
Bugfix in test_runner.dart
...
On MacOS the content shell executable name included "-characters. Since we're not running the command in a shell, these characters are part of the filename and the exec syscall will fail.
R=ahe@google.com
Review URL: https://codereview.chromium.org//15643008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23463 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 12:19:31 +00:00
803113f8ad
Add quotes to make it easier to copy paste around.
...
R=efortuna@google.com
Review URL: https://codereview.chromium.org//16194005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23411 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 13:34:47 +00:00
3707cd889b
Print output of all commands if a testcase failed
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//15740034
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23408 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 13:15:26 +00:00
eda01014b4
Support for running tests in an iframe
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//16050006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23400 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 12:16:22 +00:00
29d11f90ad
Use run_vm_tests.host to list VM tests if possible
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//15963011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23348 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 12:36:34 +00:00
kustermann@google.com