dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

56 Commits

Author SHA1 Message Date
Alexander Aprelev 436c8d8a79 [gardening] Remove flutter patch as the original cl was indeed identified as a culprit and will be reverted. 
Change-Id: I79788eb6e42ea14e7ed0d26acd9e70d07485fd80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104181
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-05-29 23:44:01 +00:00
Alexander Aprelev ebe6146781 [gardening] Fix patch name so it matches dart sdk hash. 
Change-Id: I51852a003b43b127c0754d5a730c8deac8663514
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104163
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-05-29 22:16:34 +00:00
Alexander Aprelev 19a8886a8a [gardening] Attempt to troubleshoot failing hhh buildbot. 
Create a patch that reverts https://github.com/flutter/engine/pull/9085 from which redness started.

Change-Id: Id975eb3023cf6c2634a81e4e81eab30e21851581
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104120
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-05-29 20:37:40 +00:00
Vyacheslav Egorov 00ed6b21fb [gardening] Update 3xHEAD apply script. 
It is currently failing because it is trying to cd in non-existent directory.

Change-Id: I29f3947db6aa0e34d747309b310da565dc0c010d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103137
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
 2019-05-21 14:35:32 +00:00
Vyacheslav Egorov b08397c658 [gardening] Fix Flutter 3xHEAD build 
Change-Id: Ie8fb3abe542db6432bd4e862010c714cd7126c8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103135
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
 2019-05-21 12:23:22 +00:00
Vyacheslav Egorov f4bc1c12e7 [gardening] Update 3xHEAD patch after DEPS update 
Change-Id: Ic1ca7d3fa208b7ed7b2ea423a38affa339608694
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98853
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2019-04-09 12:44:18 +00:00
Alexander Aprelev 2ebdb0890f [gardening] Update flutter engine patch as DART_CHECK_VALID change is no longer needed. 
Change-Id: If1c8f42d8c27c9fa38cb2863d1a411b9c519838b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98605
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-04-03 17:49:20 +00:00
Alexander Aprelev 1dd72d4309 Revert "[vm/build] Expose is_release/is_profile so they are available in third_party gn scripts." and different fix. 
Patchset 1 reverts commit f3aaf8a770 as it will
present problems in other embedders which will have to deal with is_profile argument.

Patchset 2 fixes the build by switching from is_product to dart_runtime_mode

Change-Id: I167e6f531af3b0fb0f3e006b074ebdf1b69f3fe5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98601
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2019-04-03 17:06:47 +00:00
Alexander Aprelev efa9b9da99 [gardening] Patch flutter engine to fix flutter hhh build. 
Change-Id: I38500c3f234e7fb9ccbb7fc0ddefa6fcdfbf676b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98526
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-04-03 04:57:55 +00:00
Alexander Aprelev 3782887c37 [gardening] Update flutter glfw-disabling patch 
Change-Id: Id6b242751fe8ef8fec3fe3d1de89363da4550b6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98452
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-04-02 20:01:21 +00:00
Alexander Aprelev bb0dc80550 [gardening] Rename flutter engine patch to catch up with roll 
Change-Id: I6d23e907cc611ff05e2512e65fc8b27be7a018fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98423
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-04-01 20:46:05 +00:00
Alexander Aprelev 010f3e91fa [gardening] Follow-up to temp disable flutter engine gl build 
Change-Id: I985b3887291582e1a1fa09e10b82e0d452b8c84d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98441
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-04-01 20:17:59 +00:00
Alexander Aprelev 0d0857ca98 [gardening] Temporarily disable flutter engine gl build to unbreak hhh buildbot 
Change-Id: I370a2fd94f0eec2806cdcf519da89ad5e084bc7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98440
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-04-01 19:54:18 +00:00
Alexander Aprelev cd34ec901c [gardening] Flutter patch is no longer needed. 
Change-Id: I4db199a733df5e9d616079e8ed3a0cd5548ec3de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98364
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-29 21:58:10 +00:00
Alexander Aprelev 1e82544b07 [gardening] Attempt to paper over failing flutter test affected by https://dart-review.googlesource.com/c/sdk/+/97311. 
Change-Id: I1224df800b8e2cdda84309b998fd130aba7c2d47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98363
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-29 21:18:13 +00:00
Alexander Aprelev e8fc260e93 [gardening] Clean up outdated flutter hhh patches 
Change-Id: I82c43ca77e97cf54cc3bf289d7f9662acdc99b5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97940
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2019-03-26 16:38:45 +00:00
Alexander Aprelev 14fcc352cd [gardening] Try troubleshoot flutter hhh buildbot. 
This reverts move to appjit for flutter tools (https://github.com/flutter/flutter/pull/27749) that is in the range of the changes that broke `pub run build_runner test`

Change-Id: Ia1c1e66031fb7976faf75cf4a9bf95bac3a450a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97640
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-22 17:36:14 +00:00
Alexander Aprelev 87108efecb [gardening] Update flutter patch so flutter compile_test passes. 
Change-Id: Ibf6a31308deac5e4ef388930308774b994feb46d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97285
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-19 17:16:24 +00:00
Stevie Strickland 231061c15a [gardening] Moving patch to be based on dart hash. 
Change-Id: I220a3be123d976d8de062deea6c48003d8521f72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97119
Auto-Submit: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
 2019-03-18 16:18:55 +00:00
Daco Harkes e6c3bc4ba9 [gardening] update Flutter engine patch file 
Change-Id: Iba80d75ba342a3e97f35ffea3b394f97e8b86efe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97080
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-03-15 10:34:44 +00:00
Alexander Thomas e2b5559c77 [infra] Use gclient.py to apply patches to bypass update_depot_tools 
apply.sh calls gclient, but the default gclient script always runs
update_depot_tools but that is not available on bots. Calling
gclient.py directly avoids that.

Change-Id: Ief80b4822277aa5a0d075c324eed0ef15a81359d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96682
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-03-12 18:18:14 +00:00
Martin Kustermann d3d077090d [VM/FrontendServer] Add 3head patch to frontend server after breaking API changes 
This CL

  https://dart-review.googlesource.com/c/sdk/+/95683

changed the names of named, optional parameters of methods which are
overridden by code in flutter/engine.

Change-Id: I09d054b33297c0eaaf00928d0c69761abb57082a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96581
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-03-12 09:05:42 +00:00
Stevie Strickland 32eedccdcd [gardening] Fix patches restored in earlier commit. 
Change-Id: I2cc25667fb98982d1bc99bf700d014f6a850fbd5
Reviewed-on: https://dart-review.googlesource.com/c/94262
Reviewed-by: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
 2019-02-25 15:20:20 +00:00
Stevie Strickland b37de47842 [gardening] Restore flutter '--package' and dartjs_info_tag engine patch 
Change-Id: I2637ccf341e138c56ff4df64b7e7294fc9a1d975
Reviewed-on: https://dart-review.googlesource.com/c/94225
Reviewed-by: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Stevie Strickland <sstrickl@google.com>
 2019-02-25 14:12:27 +00:00
Alexander Aprelev 0e99581c35 [gardening] Restore flutter '--package' patch, add dartjs_info_tag engine patch 
Change-Id: I19c4ceeca877f99128a733a23bb1ad5abd99e032
Reviewed-on: https://dart-review.googlesource.com/c/93848
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-02-21 19:06:40 +00:00
Martin Kustermann 75ee523f91 [VM] Remove flutter/flutter patch for 3head, the issue has been fixed upstream 
Namely by https://github.com/flutter/flutter/pull/28101

Change-Id: I686927bebffccbb1b575ba488739c38e7de68c9e
Reviewed-on: https://dart-review.googlesource.com/c/93940
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2019-02-21 09:13:09 +00:00
Alexander Aprelev 4013b0eece [gardening] Add adjusted fix to flutter test patch. 
Follow-up to https://dart-review.googlesource.com/c/sdk/+/93921.

Change-Id: Ic0a38e574964d74e220a544b457a204ab04da2b6
Reviewed-on: https://dart-review.googlesource.com/c/93846
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-02-21 06:30:10 +00:00
Alexander Aprelev 69d46587cf [gardening] Add fix to flutter test patch. 
Follow-up to https://dart-review.googlesource.com/c/sdk/+/93920.

Change-Id: If65340f2d997f6a94b36519fe2d01a16677e9b59
Reviewed-on: https://dart-review.googlesource.com/c/93921
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-02-21 06:15:33 +00:00
Alexander Aprelev e58b7cd59e [gardening] Fix flutter patch. 
Follow-up to https://dart-review.googlesource.com/c/93845

Change-Id: I6d558e63ab41ed0cb09b5a56af2a9b7d397136ae
Reviewed-on: https://dart-review.googlesource.com/c/93920
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-02-21 03:51:56 +00:00
Alexander Aprelev 22e70ed48f [gardening] Patch flutter/flutter to fix hhh buildbot 
Change-Id: Ib3a8e03591dd26c83dc9d27d8cef0aaff0279957
Reviewed-on: https://dart-review.googlesource.com/c/93845
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-02-21 01:32:22 +00:00
Paul Berry 6846a7c486 Fix flutter analyzer bot by disabling lint prefer_collection_literals. 
With set literal support enabled, there are many new cases in Flutter hit by this lint.

Change-Id: Ife1e4f9ac5205bdfb74b89ab18a6c36dd9ebcea1
Reviewed-on: https://dart-review.googlesource.com/c/93460
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2019-02-15 20:40:46 +00:00
Samir Jindel 7fe7e28c46 [vm] Fix location of Flutter 3xH patch file. 
Change-Id: Ib055f110ac189cb553e86d86e6a807cae08c0b6d
Reviewed-on: https://dart-review.googlesource.com/c/93083
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-13 15:49:25 +00:00
Samir Jindel 809d8123d3 [vm] Add FFI library to more targets and Flutter file libraries.json (in patch). 
Change-Id: I65421efbc708b5192f871a0dae5f739352c5c3d9
Reviewed-on: https://dart-review.googlesource.com/c/93080
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-13 15:01:23 +00:00
Martin Kustermann 1bfc3816d8 [infra] Extend 3head patching to apply patches for flutter/flutter depending on pinned engine commit 
This also adds a patch to flutter/flutter to fix head-head-head
configuration (until engine is rolled into framework again).

Change-Id: I6dae0983126a6664337834d3c93f1369139f1ac1
Reviewed-on: https://dart-review.googlesource.com/c/91922
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
 2019-02-04 12:37:10 +00:00
Alexander Aprelev bcbf47d48f [gardening] Patch flutter engine to unbreak hhh build. 
Change-Id: If6fa39703db1bb6307b2eda0f7eafa92cdd18375
Reviewed-on: https://dart-review.googlesource.com/c/88120
Reviewed-by: Alexander Aprelev <aam@google.com>
 2018-12-27 17:00:24 +00:00
Samir Jindel 2219b51b7e [gardening/flutter] Update 3xH patch to remove --sync-async flag from engine build file. 
Change-Id: Ib35ddb9b297a69d3e41fd15ef259d326353ad340
Reviewed-on: https://dart-review.googlesource.com/c/87974
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2018-12-21 15:23:32 +00:00
Daco Harkes fbd014bc8a Revert "[gardening] remove sync-async flag use from flutter" 
This reverts commit 58fd3aaaf2.

Reason for revert: patch invalid hash

Original change's description:
> [gardening] remove sync-async flag use from flutter
> 
> Change-Id: I3bc54d60507f7234d2e4a14ba58f327fd82cc728
> Reviewed-on: https://dart-review.googlesource.com/c/87971
> Reviewed-by: Samir Jindel <sjindel@google.com>

TBR=sjindel@google.com,dacoharkes@google.com

Change-Id: If1d4ef50edf6d4ac95cf906a18eafe4af25338cb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/87973
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2018-12-21 15:15:05 +00:00
Daco Harkes 58fd3aaaf2 [gardening] remove sync-async flag use from flutter 
Change-Id: I3bc54d60507f7234d2e4a14ba58f327fd82cc728
Reviewed-on: https://dart-review.googlesource.com/c/87971
Reviewed-by: Samir Jindel <sjindel@google.com>
 2018-12-21 14:55:45 +00:00
Vyacheslav Egorov 3baab294c1 [gardening] Update 3xHEAD patch 
TBR=paulberry@google.com

Change-Id: I9dffd4709f2817717c42733a608cdcd9bf59e984
Reviewed-on: https://dart-review.googlesource.com/c/86922
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-12-11 13:07:50 +00:00
Samir Jindel 84420e1ae5 [vm] Roll version of pkg/linter forward in 3xH engine patch. 
Change-Id: I7f517b467de203bb22ae29a50fe8758f40869f7c
Reviewed-on: https://dart-review.googlesource.com/c/86210
Reviewed-by: Samir Jindel <sjindel@google.com>
 2018-12-05 17:43:03 +00:00
Alexander Aprelev 4eeebc46cf [hhh] Patch flutter so it is compatible with latest analyzer 
Change-Id: I70b9cdb0609e063fa9b0ce1e4a89dac24f87fad9
Reviewed-on: https://dart-review.googlesource.com/c/85730
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-12-03 17:10:46 +00:00
Vyacheslav Egorov 1891636db0 [gardening] Final attempt to fix apply.sh. 
Use git cache fetch correctly

TBR=kustermann@google.com

Change-Id: I9245ebc2bb36e4f80e815b0f4557a34f77cbbe84
Reviewed-on: https://dart-review.googlesource.com/c/85289
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-23 15:32:40 +00:00
Vyacheslav Egorov 6300b7e0a0 [gardening] Fix apply.sh syntax (no spaces between variable name and =) 
TBR=kustermann@google.com

Change-Id: Ia268f69045d91447f5b84ee9a21926b03ecc2f58
Reviewed-on: https://dart-review.googlesource.com/c/85288
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-23 15:19:21 +00:00
Vyacheslav Egorov 2fbc6b9a2e [gardening] Make apply.sh script force update git cache used by bots 
R=kustermann@google.com

Change-Id: Id03377dbe4a294032d41a612076b933b447fd2f6
Reviewed-on: https://dart-review.googlesource.com/c/85287
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-11-23 15:03:57 +00:00
Vyacheslav Egorov 1ed5f78e9c [gardening] Make apply.sh script fetch before trying to checkout. 
TBR=kustermann@google.com

Change-Id: I195100218b7d83eee4647d5baf254c075e7492df
Reviewed-on: https://dart-review.googlesource.com/c/85286
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-23 13:48:08 +00:00
Vyacheslav Egorov c62af758ee [gardening] Switch apply.sh script to use bash instead of sh 
R=sortie@google.com

Change-Id: I30d39d4edf864d0307d18c8fd095649cfe3ed17c
Reviewed-on: https://dart-review.googlesource.com/c/85284
Reviewed-by: Jonas Termansen <sortie@google.com>
 2018-11-23 13:31:15 +00:00
Vyacheslav Egorov 01380ede49 [gardening] Expand 3xHEAD Flutter patch mechanism to support DEPS file changes. 
We don't rerun gclient sync after applying patches so changes to Dart
dependencies were not picked up.

Change-Id: I4360ddf7f906ab0552bd3ae8abbe9210a785845a
Reviewed-on: https://dart-review.googlesource.com/c/85282
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-11-23 13:10:25 +00:00
Vyacheslav Egorov ba0222df78 [flutter] Update flutter-engine-linux 3xHEAD patch. 
dart2js_info dependency is upgraded to 0.5.15 from 0.5.13

Change-Id: I3077c7953af17c610864d309e9f17e350a560fba
Reviewed-on: https://dart-review.googlesource.com/c/85262
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-23 11:37:36 +00:00
Alexander Aprelev c8372c00dc Patch hhh flutter flutter as follow-up to https://dart-review.googlesource.com/c/sdk/+/84688 
Change-Id: I392ad11684eedee143cab9e90227c6b886e09c12
Reviewed-on: https://dart-review.googlesource.com/c/84960
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-11-20 20:15:51 +00:00
Alexander Aprelev 57a4f11b64 [gardening] Patch flutter engine post 0ca1c57 
Change-Id: I92d9589850fa4b95c4be454a48e9e9782f90b908
Reviewed-on: https://dart-review.googlesource.com/c/84926
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2018-11-20 18:50:06 +00:00