Commit Graph

57 Commits

Author SHA1 Message Date
Sigmund Cherem 1b5f7c1047 Remove unnecessary flags for dart2js from test.dart
Change-Id: I751688fba97d605de69164068fe2377d80087127
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96861
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2019-03-14 22:01:13 +00:00
Alexander Thomas 2c780c4b1d [gardening] Make gardening tools accept more swarming URLs & Dart 2 fixes
Change-Id: I9101020f3a32da130e26c53391477dc5501ef6ff
Reviewed-on: https://dart-review.googlesource.com/59080
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-06-07 14:57:26 +00:00
Alexander Thomas 8baa82413b [infra] Remove --no-preview-dart-2 flag from gardening tools
Fixes a regression caused by https://dart-review.googlesource.com/c/sdk/+/52461

Change-Id: I59ba32c2f31e70620bea58466935ed47ed61c1dc
Reviewed-on: https://dart-review.googlesource.com/53361
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-05-02 08:09:10 +00:00
Alexander Thomas a60d803913 [infra] Add --no-preview-dart-2 support for the analyzer to test.py
https://github.com/dart-lang/sdk/issues/32609

Change-Id: I5a7009a55a26452eae6e6465aeb78cecab91b476
Reviewed-on: https://dart-review.googlesource.com/50725
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-04-11 15:16:36 +00:00
Johnni Winther 23c59bd819 Fix compare_failures
+ and --force flag to always analysis past results (slower)

Change-Id: I9df760b61cfb71ecdf9a4b69d256895812f2eff1
Reviewed-on: https://dart-review.googlesource.com/50500
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-10 13:38:41 +00:00
Sigmund Cherem 21c9372d8d Add dart2js-old-frontend option to test.py
Change-Id: I4e762bd5e50b2ff8a91b29e8067e47351ace94f7
Reviewed-on: https://dart-review.googlesource.com/44380
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-02-28 23:21:24 +00:00
Alexander Thomas 2d84ed2297 [infra] Allow passing status command inputs to the tool directly
Change-Id: I20ee77aa8fe2102ddaed785d085d9e0c1806471d
Reviewed-on: https://dart-review.googlesource.com/37000
Reviewed-by: William Hesse <whesse@google.com>
2018-01-26 20:31:16 +00:00
Alexander Thomas c508eb6f29 [infra] Add support for to status.dart results
Change-Id: I17294da087152d7c9d5bc04c9146d05bfac1e6a9
Reviewed-on: https://dart-review.googlesource.com/36843
Reviewed-by: William Hesse <whesse@google.com>
2018-01-26 00:15:11 +00:00
Alexander Thomas 616d02ef65 Search runtime directory for status summaries
Change-Id: Id1b4010cb07883193ea3ef5726c3cb651c2e061b
Reviewed-on: https://dart-review.googlesource.com/33882
Reviewed-by: William Hesse <whesse@google.com>
2018-01-10 16:13:57 +00:00
Morten Krogh-Jespersen d68cdbf099 Tool for updating status files from result logs.
Queries the user for input and performs updates to status files.

Bug:
Change-Id: Iac90d713fcff952b4f0d27044cbbcdc02456de4e
Reviewed-on: https://dart-review.googlesource.com/27540
Reviewed-by: William Hesse <whesse@google.com>
2017-12-08 14:58:55 +00:00
Morten Krogh-Jespersen 1022bd1ebb Refactor status expectations into a class.
This helps that status expectations are only loaded once. Ensure that we only
load a suite of status files once.

Finally, this also updates the regular expression for finding multitest
expectations without wildcard entries in the path.

Bug:
Change-Id: I9bee07cb0845cfe341fb731aa5772aba8b3060b1
Reviewed-on: https://dart-review.googlesource.com/27520
Reviewed-by: Jonas Termansen <sortie@google.com>
2017-12-08 14:58:55 +00:00
Morten Krogh-Jespersen 8765d5e529 Rewrite tool to find overlapping sections.
The rewrite removes the need to search for configurations from running tests by
using the disjunctive normal form.

Bug:
Change-Id: I66bbbbb9b0eb1e1ae9f8dc02e7ef6a8498850b26
Reviewed-on: https://dart-review.googlesource.com/24106
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-12-08 12:42:16 +00:00
Morten Krogh-Jespersen 6cbb00a889 Refactor results failures tool to allow sharing of code.
Combines the two util.dart files and moves getting result logs from arguments to
a helper file.

Adding spec-parser as compiler to environment.

Bug:
Change-Id: Ifc3b9aacaf98a2976d25ef594bac5c5823bed208
Reviewed-on: https://dart-review.googlesource.com/25260
Reviewed-by: Jonas Termansen <sortie@google.com>
2017-12-08 01:06:28 +00:00
Morten Krogh-Jespersen 3021c0d75f Clean up code to remove add-hoc test matrix.
Bug:
Change-Id: I739880778ded42af1998e34744dbae4ed2d5f128
Reviewed-on: https://dart-review.googlesource.com/24900
Reviewed-by: Alexander Thomas <athom@google.com>
2017-12-04 08:28:13 +00:00
Erik Ernst d7b4d12a1e Bug fix: avoid range error
Change-Id: I4fb2f132df38516c21f76b4589aa4896d7e213bc
Reviewed-on: https://dart-review.googlesource.com/24462
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
2017-11-29 15:45:40 +00:00
Morten Krogh-Jespersen 7f875c6e01 Make compare failures work with logdog instead of build bot data.
Build bot data is no longer maintained and all logs are moving over to logdog.

Bug:
Change-Id: If3526bde1c950b936d9bf1e67bb53d19bffe7177
Reviewed-on: https://dart-review.googlesource.com/17222
Reviewed-by: William Hesse <whesse@google.com>
2017-10-31 07:22:57 +00:00
Morten Krogh-Jespersen 359eddc256 Make logdog rpc the primary way to interact with logdog.
Additionally, combine all stream chunks into a single buffer, separated by new
line.

Bug:
Change-Id: I0c56aa1e99e76ee7ff578c84dc9e3ef534f5e63f
Reviewed-on: https://dart-review.googlesource.com/17221
Reviewed-by: William Hesse <whesse@google.com>
2017-10-31 07:22:57 +00:00
Morten Krogh-Jespersen 6365369a39 Refactoring failures tool
Refactoring of failures tool with:

Reducing the time it takes for looking up status files by dividing entries in
the status file by wildcard and none-wildcard. Speciel attention is needed for
multitests.

Not report an error when Skip or SkipByDesign is added to the status files.

Report which status files expectations are taken from.

Bug:
Change-Id: I56a05a9bd79a5206ef5287a58d341165d98aaefc
Reviewed-on: https://dart-review.googlesource.com/16441
Reviewed-by: William Hesse <whesse@google.com>
2017-10-27 09:12:06 +00:00
Morten Krogh-Jespersen a95fef2a21 Remove dependendy on archive in gardening tools.
Bug:
Change-Id: I259f9446242c425dae62ecb23cdaa669e13f49a4
Reviewed-on: https://dart-review.googlesource.com/16160
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2017-10-25 07:14:23 +00:00
Morten Krogh-Jespersen ccd835ddb1 Wrapper around status files and expectations.
Bug:
Change-Id: I5cb9efcc915d4106f35516702109d35d4c12e604
Reviewed-on: https://dart-review.googlesource.com/13744
Reviewed-by: William Hesse <whesse@google.com>
2017-10-24 07:42:42 +00:00
Morten Krogh-Jespersen b679bf0818 Tool for finding duplicate entries for tests in status files.
Bug:
Change-Id: Ia1c1110b7b5f71465763bd3042ae459008293971
Reviewed-on: https://dart-review.googlesource.com/13745
Reviewed-by: William Hesse <whesse@google.com>
2017-10-20 11:44:09 +00:00
Morten Krogh-Jespersen f458bda37f Get builders and latest builds from CQ.
Change-Id: Ic8a53a688b82cb39061e5f6f4a1dc6beb685bc8c
Reviewed-on: https://dart-review.googlesource.com/12560
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-10-18 06:15:08 +00:00
Morten Krogh-Jespersen bb0687e6f5 Add utility methods to gardening.
Bug:
Change-Id: I4b9365a34b211d2885d32a8683a3128b82832a77
Reviewed-on: https://dart-review.googlesource.com/13742
Reviewed-by: William Hesse <whesse@google.com>
2017-10-16 13:48:25 +00:00
Morten Krogh-Jespersen 4c88f9a453 Order tests by name in result failures output.
Bug:
Change-Id: Ib3f055594d396a1f0f72e5539aa63b93754b4a24
Reviewed-on: https://dart-review.googlesource.com/13461
Reviewed-by: William Hesse <whesse@google.com>
2017-10-12 11:33:46 +00:00
Morten Krogh-Jespersen 19705f0147 Add results tool to gardening tools.
Bug:
Change-Id: I15e08fd44a56aca20cfcec92c893f94cf88d711a
Reviewed-on: https://dart-review.googlesource.com/10900
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-10-09 08:28:20 +00:00
Johnni Winther f9cb6c4137 Remove dart2js_with_kernel_in_ssa test option
Change-Id: I2da692a4d458acc4b36e14beb99e1fb9d2bdec70
Reviewed-on: https://dart-review.googlesource.com/10861
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-10-05 06:53:39 +00:00
Morten Krogh-Jespersen 622d6a771f Add workflow class for working with workflows in console apps.
Bug:
Change-Id: I77f7a213c995f4cb22b4fee43098839febee8f73
Reviewed-on: https://dart-review.googlesource.com/10321
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-10-05 06:43:47 +00:00
Morten Krogh-Jespersen 0a685691ec Updating Luci to not use try.
Bug:
Change-Id: If35ddc90e87174acb5666670697e259b72845579
Reviewed-on: https://dart-review.googlesource.com/9922
Reviewed-by: William Hesse <whesse@google.com>
2017-10-03 10:02:10 +00:00
Morten Krogh-Jespersen 83f0b3a12a Fixing up result tool with test-matrix.
Bug:
Change-Id: I753da0d540910a5309f0ba73a13d0d4093621330
Reviewed-on: https://dart-review.googlesource.com/8042
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-09-26 07:43:42 +00:00
Morten Krogh-Jespersen befa486d21 Changing naming of luci classes.
Bug:
Change-Id: Ie453bdc93661f9269ce20dc060e726a115b0a1b0
Reviewed-on: https://dart-review.googlesource.com/8043
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-09-26 07:13:18 +00:00
Johnni Winther e61f8461f3 Support --commit in compare_failures
Change-Id: Ie54419ab14b6fef9401404da1063e556e9dc2131
Reviewed-on: https://dart-review.googlesource.com/6860
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-09-19 12:09:44 +00:00
Morten Krogh-Jespersen 51f78ee83c Building result tool to interpret result.log and status files.
Change-Id: If74fad44ac9253cd0046c52bf070d507964bcab8
Reviewed-on: https://dart-review.googlesource.com/3542
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-09-19 07:41:09 +00:00
Morten Krogh-Jespersen dfd5038ecb Added ability to find builder-groups
Added calls to CBE, cleaned up the remaining screen-scraping and added ability to find builder-groups and builders in groups

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3005723002 .
2017-08-30 09:26:44 +02:00
Morten Krogh-Jespersen fe94ff5ec0 Additional tools for gardening.
- multitest will generate a specific case of a multitest file
- luci_api is the start of a project, to make an api to ease the life     of the gardener. At this point, it can answer, given a commit, which     builds on bots does that commit belong to.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3005443002 .
2017-08-28 12:37:12 +02:00
Johnni Winther f1b3a59da3 Use package:testing for tools/gardening
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2999043003 .
2017-08-16 15:55:52 +02:00
Johnni Winther d2676d2f16 Use Bot in compare_failures
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/3000953002 .
2017-08-15 14:52:47 +02:00
Johnni Winther aa7f14aed3 Use timeout to read most recent build from http
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2998993002 .
2017-08-15 14:36:27 +02:00
Johnni Winther 798577d188 Add filtering to 'summary'
- and include positive result summary in the output.

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2993913002 .
2017-08-08 16:26:41 +02:00
Johnni Winther 494d2c623e Improve output of current-summary gardening tool.
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/3000493002 .
2017-08-08 16:25:42 +02:00
Florian Loitsch 83fcb7aa94 Small improvements to bot summary.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2996503002 .
2017-08-04 15:13:07 +02:00
Florian Loitsch aaf67e5050 Fix bot summary when URIs couldn't be read.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2999433002 .
2017-08-04 14:46:57 +02:00
Johnni Winther baed658109 Allow multiple inputs to compare-failures
- and ensure that TestFailure is created with the BuildResult.buildUri

R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2987403002 .
2017-08-03 12:24:36 +02:00
Dmitry Stefantsov b5aeeb5b25 [Gardening Tool] Allow filtering groups by names in current_summary.dart
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2989263002 .
2017-08-02 16:49:03 +02:00
Johnni Winther dc83f62199 Add test to compare-failures
+ support build group names as command-line argument

R=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2987253002 .
2017-08-02 09:38:53 +02:00
Erik Ernst e451f16db0 Bug fix: Now handles that "summary" does not require any arguments.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2970963002 .
2017-07-06 13:13:17 +02:00
Erik Ernst c2afa4146b Updated various gardening data, and ignoring gardening/temp.
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2973653002 .
2017-07-05 16:20:40 +02:00
Florian Loitsch dbfaa36728 Add summary command to bot.
Looks at the latest build results and gives information. For now
just prints, if a bot has an error.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2944653002 .
2017-06-19 10:22:50 +02:00
Erik Ernst 80c5b67980 Added find-shard to bot.dart.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2915043002 .
2017-06-01 16:25:29 +02:00
Johnni Winther f1472ed8bb Fix gardening/bot help messages
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2919693003 .
2017-06-01 11:32:58 +02:00
Johnni Winther 0e61716730 Add BuildBotClient to abstract http/logdog access
+ support error handling for logdog

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2912343002 .
2017-06-01 10:02:04 +02:00