The step names of test.py invocations are currently used as directory names
in cloud storage. This unintentionally creates an unexpected subdirectory
where the top third_party/ directory is malformed because it doesn't have
the right contents.
Change-Id: I57e32ed917ba863e9bccf611f496e520b9a97310
Reviewed-on: https://dart-review.googlesource.com/c/80620
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
This includes Fasta, tools and observatory, so the checked-in SDK must
have the lower-case constants.
Change-Id: I8380ad041ad058f7d02ae19caccfecd434d13d75
Reviewed-on: https://dart-review.googlesource.com/50201
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.
Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
test.py ignores RuntimeError, MissingRuntimeError, and Timeout when the
runtime is "none". Previously, the status update tool would attempt to fix
these "unexpected passes".
Change-Id: I73c15fdc7e18aa29d5553e58b6b4e65ec07c1246
Reviewed-on: https://dart-review.googlesource.com/49461
Reviewed-by: William Hesse <whesse@google.com>
* Prevent autofixing tests across suites.
* Handle invalid input when selecting files.
* Only display sections in files that apply to the failing test.
Change-Id: Ia7f22bdf29901af05742e461ca009f2e3a4a3e37
Reviewed-on: https://dart-review.googlesource.com/37400
Reviewed-by: William Hesse <whesse@google.com>
This reverts commit c5306595f4, which updated
the status for linux only, and updates it for all operating systems instead.
It also fixes a minor error in the status update tools.
Change-Id: I556dff775f221b872c5cea27b7ed5a0088d378a5
Reviewed-on: https://dart-review.googlesource.com/37261
Reviewed-by: Alexander Thomas <athom@google.com>
This helps that status expectations are only loaded once. Ensure that we only
load a suite of status files once.
Finally, this also updates the regular expression for finding multitest
expectations without wildcard entries in the path.
Bug:
Change-Id: I9bee07cb0845cfe341fb731aa5772aba8b3060b1
Reviewed-on: https://dart-review.googlesource.com/27520
Reviewed-by: Jonas Termansen <sortie@google.com>
This updates the information in the README.md file regarding overlapping
sections, how it is invoke and the result from running it.
Bug:
Change-Id: I7c8c057ad73d5893c3ff69e4588e0f234f2d5832
Reviewed-on: https://dart-review.googlesource.com/27620
Reviewed-by: Jonas Termansen <sortie@google.com>
The rewrite removes the need to search for configurations from running tests by
using the disjunctive normal form.
Bug:
Change-Id: I66bbbbb9b0eb1e1ae9f8dc02e7ef6a8498850b26
Reviewed-on: https://dart-review.googlesource.com/24106
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Combines the two util.dart files and moves getting result logs from arguments to
a helper file.
Adding spec-parser as compiler to environment.
Bug:
Change-Id: Ifc3b9aacaf98a2976d25ef594bac5c5823bed208
Reviewed-on: https://dart-review.googlesource.com/25260
Reviewed-by: Jonas Termansen <sortie@google.com>
Build bot data is no longer maintained and all logs are moving over to logdog.
Bug:
Change-Id: If3526bde1c950b936d9bf1e67bb53d19bffe7177
Reviewed-on: https://dart-review.googlesource.com/17222
Reviewed-by: William Hesse <whesse@google.com>
Additionally, combine all stream chunks into a single buffer, separated by new
line.
Bug:
Change-Id: I0c56aa1e99e76ee7ff578c84dc9e3ef534f5e63f
Reviewed-on: https://dart-review.googlesource.com/17221
Reviewed-by: William Hesse <whesse@google.com>
Refactoring of failures tool with:
Reducing the time it takes for looking up status files by dividing entries in
the status file by wildcard and none-wildcard. Speciel attention is needed for
multitests.
Not report an error when Skip or SkipByDesign is added to the status files.
Report which status files expectations are taken from.
Bug:
Change-Id: I56a05a9bd79a5206ef5287a58d341165d98aaefc
Reviewed-on: https://dart-review.googlesource.com/16441
Reviewed-by: William Hesse <whesse@google.com>
Updating the readme to better give a quick overview of how to use the results failures tool.
Bug:
Change-Id: Id6d4492e6a55e651886e9ccbbc88965248e1ac88
Reviewed-on: https://dart-review.googlesource.com/16740
Reviewed-by: William Hesse <whesse@google.com>
Sigmund Cherem