2115a4ffa8
Add additional constructor renames
...
Fixed native_DOMImplementation resolver strings
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//291053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36336 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-19 23:07:51 +00:00
23e2bc42a1
Add explicit resolver string map to dart:html generator
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//291983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36328 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-19 21:32:29 +00:00
93eec7ba80
Make custom constructors use uniform resolvers
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//289113003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36273 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-16 20:18:09 +00:00
2adf307b27
Fix custom constructor bindings
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//287163008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36259 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-16 16:52:53 +00:00
33f2e85e12
Bindings fixes
...
TBR=jacobr@google.com
BUG=
Review URL: https://codereview.chromium.org//291503004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36252 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-16 00:32:19 +00:00
27751f8cf1
More native binding match up fixes
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//284233004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36251 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-16 00:02:18 +00:00
a80f7bb4a4
Fix native bindings in _blink
...
TBR=jacobr@google.com
BUG=
Review URL: https://codereview.chromium.org//289993006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36249 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-15 22:19:10 +00:00
0025a295d7
Make resolver strings match up better
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//284263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36244 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-15 21:48:14 +00:00
640ad70e58
Canonicalize dart:_blink resolver names
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//289803004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36196 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-14 23:27:59 +00:00
a0ad457bd8
Set up some of the webgl native functions as leaf calls
...
(Note: We need a better way of doing this, maybe some way of specifying
this in the IDL itself)
The webgl bindings benchmark score goes up from 363 to 473
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//261913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35717 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-02 23:17:26 +00:00
333cd2ad67
MediaStream/Source fix
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//265763006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35667 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 23:02:26 +00:00
d1f0594840
Initial overloading implementation in _blink
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//260893007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35662 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 22:03:06 +00:00
970367e227
Rename blink -> _blink
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//258733009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35499 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-28 21:56:19 +00:00
36a629367e
Generate dart:blink in the SDK
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//259773004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35439 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 18:29:01 +00:00
5e0688e1ec
This CL contains all of the changes for splitting off all of the native
...
calls from dart:html into dart:blink. As currently configured, the
dart:blink library will be empty and unused. The only changes in the
idl generated dart and C++ code in the default configuration should
be cosmetic. The global variable "dart_use_blink" in systemnative.py
currently controls whether or not the real blink library is
generated. Enabling this requires as yet unchecked in changes to
blink. These changes are expected to land as part of the chrome
35 roll.
Support for building with/without blink
DOM changes for checked receivers
Dartium native call generation refactor
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//254463006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35430 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 16:22:08 +00:00
98ba7c124a
Refactor the class id generation code a bit to make it possible to have toActiveDOMObject, ToEventTarget and toNode functions for each webkit type.
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//224993003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34840 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 20:27:57 +00:00
2dd7dcecb9
Remove one version of DartDOMWrapper::createWrapper and have all call sites
...
directly call the class id version
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//215293004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34599 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 15:00:42 +00:00
1ea29a21d7
Fixes for Chrome 34 merge
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//204033002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34069 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 22:08:44 +00:00
6370348c37
Script changes for ChangeXXX -> Change=XXX
...
Move CustomSetter to Custom=Setter in dart.idl
BUG=17248
R=vsm@google.com
Review URL: https://codereview.chromium.org//187693008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33359 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 00:17:12 +00:00
7acd2cc7c7
Revert all html warning changes.
...
For the sake of ease of cherry-picking, I'm going to back this change out to
apply all at once, once I fix this postMessage test failure on Dartium.
BUG=
Review URL: https://codereview.chromium.org//160963004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32630 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 22:12:18 +00:00
9f1b31b001
Fix more warnings for dart:html.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//153823007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32618 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 20:12:09 +00:00
ad353d440b
Fixes for 1750 roll
...
TBR=jacobr@google.com
Review URL: https://codereview.chromium.org//150783005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32477 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-10 01:38:01 +00:00
d3eb344f08
Do not generate code to create a CallStack in the ConsoleBase calls as that
...
variable is not used at all.
R=jacobr@google.com
Review URL: https://codereview.chromium.org//153183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32265 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 22:47:46 +00:00
7ea7adfe16
Add more functions to the list of leaf functions which do not need an
...
auto generated dart scope. Resulting improvements in the Dromaeo benchmarks
getAttribute 1072.0 1529.0
element_property_access 1304.0 1987.0
setAttribute 305.38922155688624 422.1556886227545
element_property_assignment 509.4905094905095 668.0
getElementById 1012.0 1523.0
getElementById (not in document) 2440.0 3279.0
getElementsByTagName(div) 119232.0 155037.0
getElementsByTagName(p) 109280.0 148015.0
getElementsByTagName(a) 119869.0 156460.0
getElementsByTagName(*) 114050.0 146375.0
getElementsByTagName (not in document) 172848.0 238313.0
getElementsByName 1356.0 1724.0
getElementsByName (not in document) 2657.0 2891.0
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//113743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31582 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 21:48:17 +00:00
6994ac20bb
Fix compile warning on mac
...
Chrome 32 flags appear to be stricter.
TBR=asiva@google.com
Review URL: https://codereview.chromium.org//115523003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31493 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 18:01:32 +00:00
5e3937addf
Changes for Chrome 32
...
Once we're ready to switch ... some paths have changed from 31.
R=jacobr@google.com
Review URL: https://codereview.chromium.org//93933014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31486 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-06 17:12:25 +00:00
1f9f8ecf7a
- Setup infrastructure to white list some native methods as not requiring
...
auto setup of Dart API scopes
- List some functions in the list to check out the infrastructure. Performance
gains from listing these:
firstChild 222.33 to 309.6903096903097
lastChild 217.56 to 306.0
nextSibling 363.00 to 514.0
previousSibling 357.64 to 506.0
nextSiblingDynamic 348.01 to 511.0
childNodes 309.38 to 444.5554445554446
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//119543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31342 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-20 19:02:04 +00:00
3b1902e54a
Add auto scope setup parameter to the native resolvers in preparation for
...
https://codereview.chromium.org/117723002/
R=vsm@google.com
Review URL: https://codereview.chromium.org//113913010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31287 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-19 17:48:14 +00:00
b149db19e3
Changes to generated code for templatized DartDOMWrapper::lookupWrapper.
...
R=asiva@google.com
Review URL: https://codereview.chromium.org//100923004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31050 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-11 00:21:46 +00:00
dd18f8d84f
Change generator to pass in domData in calls to createWrapper.
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//110513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31034 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 18:36:10 +00:00
7010c7b798
Don't write generated C++ bindings twice, only once.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//70453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30198 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-12 17:16:17 +00:00
fa8b243f62
Add JsArray
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//41163005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29393 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 20:46:36 +00:00
db97191375
Dartium fixes for latest Blink rolls.
...
TBR=blois@google.com
Review URL: https://codereview.chromium.org//37203003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29085 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 15:00:32 +00:00
c274135947
Revert "Revert breaking CL"
...
This reverts commit 582a7848d7ad11fe981257598124431e36a9c982.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//35513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29014 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 18:15:03 +00:00
e92900f914
Revert breaking CL
...
Revert "Companion to https://codereview.chromium.org/33973002 Generate correct source locations for Dart log messages."
TBR=jacobr@google.com
BUG=
Review URL: https://codereview.chromium.org//32643009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28981 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 04:30:23 +00:00
c74e0cec97
Companion to https://codereview.chromium.org/33973002 Generate correct source locations for Dart log messages.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//33993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28976 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-22 00:46:02 +00:00
5ee178076a
A few API changes:
...
Remove Callback in favor of directly using closures or JsFunction.withThis().
Move jsify() to a named constructor on JsObject.
- Throw on types other than Map and Iterable.
- Handle cycles
Add JsObject.fromDartObject() which force a transferrable native to be proxied.
Still to do: Reach a conclusion on Serializable
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//27514003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28902 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-19 04:36:10 +00:00
e7aef33a2c
Fixing custom element type extensions in Dartium to have correct native type ID
...
This is in support of the recent change to write the native type ID to the Dart wrappers
Dart changes for https://codereview.chromium.org/27769002/
BUG=14190
R=vsm@google.com
Review URL: https://codereview.chromium.org//29033003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28899 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 23:43:45 +00:00
ab61301521
Generate a class table of all the IDL classes in the database. This table is used
...
to access the C++ class hierachy information to do a proper subtype of check.
The new subtype of check improves the following benchmarks
Dromaeo-drt dom-modify appendChild runs-per-second from 889.0 to 1575.0
Dromaeo-drt dom-modify insertBefore runs-per-second from 592.4075924075925 to 1298.0
The generated class table is as follows:
enum {
_HistoryCrossFrameClassId = 0,
_LocationCrossFrameClassId,
_DOMWindowCrossFrameClassId,
_DateTimeClassId,
// New types that are not auto-generated should be added here.
ANGLEInstancedArraysClassId,
AbstractWorkerClassId,
....
....
};
typedef struct {
const char* class_name;
int library_id;
int base_class_id;
bool is_node;
bool is_active;
bool is_event;
} _Classinfo;
typedef _Classinfo _DartWebkitClassInfo[NumWebkitClassIds];
_DartWebkitClassInfo DartWebkitClassInfo = {
{ "_HistoryCrossFrame", DartHtmlLibraryId, -1, false, false, false },
{ "_LocationCrossFrame", DartHtmlLibraryId, -1, false, false, false },
{ "_DOMWindowCrossFrame", DartHtmlLibraryId, -1, false, false, true },
{ "DateTime", DartCoreLibraryId, -1, false, false, false },
// New types that are not auto-generated should be added here.
{ "AngleInstancedArrays", DartWebGlLibraryId, -1, false, false, false, },
{ "AbstractWorker", DartHtmlLibraryId, -1, false, false, false, },
.....
.....
};
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//27358002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28821 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 20:27:30 +00:00
89802cee42
Updating CustomElement lifecycle scope logic
...
More closely following what V8 is doing in:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/scripts/code_generator_v8.pm&l=1725
Primary issue was that this was being emitted in too many places (getters and attributes which didn't need it).
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//25675008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28818 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 20:13:14 +00:00
33b96c8696
Pass in domData as a parameter to unwrapDartWrapper.
...
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//26051003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28353 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 03:25:48 +00:00
19a260904e
Generate a library ID instead of a library name, so that the ID can be used
...
to get the library handles from the cache (avoids having to lookup everytime)
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//25626002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28226 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 16:21:17 +00:00
c801e99a65
Adding custom element lifecycle processing to all attribute modifiers.
...
This is needed for the custom element attributeChanged lifecycle event. It appears to be the same thing that V8 is currently doing.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//25666008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28179 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 19:48:10 +00:00
354c4dd5ad
Revert "Revert "Start of dartium custom element lifecycle event support.""
...
Primary changes are that a fast-path has been added for the single-argument Document.createElement and the systemnative.py changes were split out to CL https://codereview.chromium.org/24661002/ .
This is dependent on https://codereview.chromium.org/24677002/
First patch is the original, second is the updates.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//24491003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27921 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 23:15:09 +00:00
f4734449cd
Emitting CustomElementCallbackDispatcher for all APIs impacting custom element lifecycle
...
This is part of getting custom element lifecycles working in Dart and follows the same model that V8 is using. Basically it ensures that the lifecycle events are processed after any operations which may have custom element side-effects.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//24661002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27910 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 20:34:33 +00:00
3fd115d5e3
Revert "Start of dartium custom element lifecycle event support."
...
This reverts commit 27718 to see if it gets performance back down.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//24479002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27897 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 17:56:53 +00:00
928894a58c
- Added Dart_GetNativeIsolateData so that the bindings code can access the IsolateCurrentData
...
where possible without having to invoke Isolate::Current()
- Modified lookupWrapper to accept DartDOMData as a parameter so that the return to Dart functions
won't invoke Isolate::Current()
Some Dromaeo numbers before this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr getAttribute runs-per-second 1162.2
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr element_property_access runs-per-second 1255.6
after this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr getAttribute runs-per-second 1237.6
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr element_property_access runs-per-second 1385.4
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//24376005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27789 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-23 23:53:39 +00:00
34f58a8209
Start of dartium custom element lifecycle event support.
...
These are the Dart repo changes paired with https://codereview.chromium.org/24294002/
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//23817006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27718 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 18:40:11 +00:00
ca128dea70
- Modify toDart to first do a simple lookup in the appropriate table before going down the templatized
...
morass of switch statements
- Add a returnToDart function so that the WeakPersistent Handle returned from a lookup/create of the wrapper
could be returned as is without the need to call Dart_handleFromWeakPersistentHandle
- Use Dart_SetDoubleReturnValue for doubles
some DromaeoDartium numbers before this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(div) runs-per-second 84240.6
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-traverse nextSibling runs-per-second 207.91683326669332
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(*) runs-per-second 69599.2
some DromaeoDartium numbers after this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(div) runs-per-second 104252.4
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-traverse nextSibling runs-per-second 366.8
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(*) runs-per-second 94922.6
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//23681014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27710 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 16:25:12 +00:00
013e3bb062
Dart binding changes to along with Blink merge 155942-156717
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23829002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26948 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 21:24:02 +00:00
leafp@google.com