Terry Lucas
c5cfdc5279
Expose data member 'port' for MessageEvents and automatically pull in markupsafe for go.sh script.
...
Fixes #35730
R=sigmund@google.com
Change-Id: I91d9622601c99bbbfaad87c24f01db2b26303744
Reviewed-on: https://dart-review.googlesource.com/c/91165
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2019-01-27 20:06:58 +00:00
Stephen Adams
aeaf82577e
dart:html: Add Element.removeAttribute
...
- Improve `element.attributes.remove(name)` to compile to `element.removeAttribute(name)`.
- Improve `element.getNamespacedAttributes(namespace).remove(name)` to compile to
`element.removeAttributeNS(namespace, name)`.
- Add removeAttribute[NS].
- Add hasAttriute[NS].
- Assert attribute names are not null to prevent conversion to "null"/"undefined".
- TODO: Assert values are not null to prevent conversion to "null"/"undefined".
- namespaceURI does not need checking since null and undefined map to 'no namespace'.
Fixes https://github.com/dart-lang/sdk/issues/35655
Change-Id: Ie5bee23c88e8fb92f9d46f29fdf4b7f3175a2aa3
Reviewed-on: https://dart-review.googlesource.com/c/90160
Commit-Queue: Stephen Adams <sra@google.com >
Reviewed-by: Terry Lucas <terry@google.com >
2019-01-18 19:06:24 +00:00
Terry Lucas
edca6169c1
Fixed a number of dart:html P1 issues.
...
- Fixed HTML API's with callback typedef to correctly convert Dart function to JS function.
- Expose HttpStatus from dart:html
- Expose DomName ondblclick and dblclickEvent for Angular analyzer.
- Fixed removeAll should be Iterable<Object> to match Set's removeAll not Iterable<E>.
- Fixed a number of DataTransferItem, Entry, FileEntry and DiretoryEntry returning NativeJavaScriptObject needed type registered in DDC.
- Added ability to allow local file access from Chrome browser added -local in ddb.
R=vsm@google.com
Fixes #30278
Fixes #35484
Fixes #34318
Fixes #35510
Change-Id: Ide8c04716c54045e837781d489562f27b694b109
Reviewed-on: https://dart-review.googlesource.com/c/89340
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
Reviewed-by: Nate Bosch <nbosch@google.com >
2019-01-15 17:21:50 +00:00
Terry Lucas
490421d166
Fixed Service Workers and any Promise/Future API with a Dictionary parameter.
...
APIs in dart:html (that take a Dictionary) will receive a Dart Map parameter. The Map parameter
must be converted to a Dictionary before passing to the browser's API. Before this change,
any Promise/Future API with a Map/Dictionary parameter never called the Promise and didn't
return a Dart Future - now it does.
This caused a number of breaks especially in Service Workers (register, etc.). Here is a
complete list of the fixed APIs:
BackgroundFetchManager
Future<BackgroundFetchRegistration> fetch(String id, Object requests, [Map options])
CacheStorage
Future match(/*RequestInfo*/ request, [Map options])
CanMakePayment
Future<List<Client>> matchAll([Map options])
CookieStore
Future getAll([Map options])
Future set(String name, String value, [Map options])
CredentialsContainer
Future get([Map options])
Future create([Map options])
DirectoryEntry
Future<Entry> _getDirectory(String path, {Map options})
Future<Entry> _getFile(String path, {Map options})
ImageCapture
Future setOptions(Map photoSettings)
MediaCapabilities
Future<MediaCapabilitiesInfo> decodingInfo(Map configuration)
Future<MediaCapabilitiesInfo> encodingInfo(Map configuration)
MediaStreamTrack
Future applyConstraints([Map constraints])
Navigator
Future requestKeyboardLock([List<String> keyCodes])
Future requestMidiAccess([Map options])
Future share([Map data])
OffscreenCanvas
Future<Blob> convertToBlob([Map options])
PaymentInstruments
Future set(String instrumentKey, Map details)
Permissions
Future<PermissionStatus> query(Map permission)
Future<PermissionStatus> request(Map permissions)
Future<PermissionStatus> revoke(Map permission)
PushManager
Future permissionState([Map options])
Future<PushSubscription> subscribe([Map options])
RtcPeerConnection
REMOVED: Future createAnswer([options_OR_successCallback,
RtcPeerConnectionErrorCallback failureCallback,
Map mediaConstraints])
REMOVED: Future createOffer([options_OR_successCallback,
RtcPeerConnectionErrorCallback failureCallback,
Map rtcOfferOptions])
REMOVED: Future setLocalDescription(Map description, VoidCallback successCallback,
[RtcPeerConnectionErrorCallback failureCallback])
REMOVED: Future setLocalDescription(Map description, VoidCallback successCallback,
[RtcPeerConnectionErrorCallback failureCallback])
Future<RtcSessionDescription> createAnswer([Map options])
Future<RtcSessionDescription> createOffer([Map options])
Future setLocalDescription(Map description)
Future setRemoteDescription(Map description)
ServiceWorkerContainer
Future<ServiceWorkerRegistration> register(String url, [Map options])
ServiceWorkerRegistration
Future<List<Notification>> getNotifications([Map filter])
Future showNotification(String title, [Map options])
VRDevice
Future requestSession([Map options])
Future supportsSession([Map options])
VRSession
Future requestFrameOfReference(String type, [Map options])
Window
Future fetch(/*RequestInfo*/ input, [Map init])
WorkerGlobalScope
Future fetch(/*RequestInfo*/ input, [Map init])
In addition, exposed Service Worker "self" as a static getter named "instance". The
instance is exposed on four different Service Worker classes and can throw a InstanceTypeError
if the instance isn't of the class expected (WorkerGlobalScope.instance will always work
and not throw):
* SharedWorkerGlobalScope.instance
* DedicatedWorkerGlobalScope.instance
* ServiceWorkerGlobalScope.instance
* WorkerGlobalScope.instance
R=vsm@google.com
Bug: #34202
Change-Id: I641ccbff7cc771465dd32c73db20eba5d6667939
Reviewed-on: https://dart-review.googlesource.com/c/74482
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
Reviewed-by: Jenny Messerly <jmesserly@google.com >
2018-10-14 22:48:33 +00:00
Terry Lucas
dd8988c9b2
- Moved all WebGL rendering/drawing constants to synthesized class WebGL.
...
- Removed obsolete Dartium/_blink code.
R=kevmoo@google.com
Change-Id: I81a6f0d5bfe33592ff8ae9c85db9266e898c2861
Reviewed-on: https://dart-review.googlesource.com/60380
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2018-06-15 17:08:54 +00:00
Terry Lucas
f479435bca
- Removed custom handling of fill - it was wrong the method is now overloaded.
...
- Associate the JS class SpeechSyntesisVoice with the correct Dart class (DDC).
- Top-level querySelectorAll wasn't generic.
- Handle "static" for attributes in the IDLs.
Fixes #33147
Fixes #33178
Fixes #31886
Fixes #20585
R=vsm@google.com
Change-Id: Ic75a2bfc66670b72342269be259408b610547dab
Reviewed-on: https://dart-review.googlesource.com/59240
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2018-06-15 02:25:13 +00:00
Terry Lucas
cf87b84f7d
Support Promise to Future for both DDC and dart2js.
...
APIs in the newer Chrome IDLs support more JS style promises. The Dart web libraries now hookup those promises and return a Dart Future.
Additionally, a new type maplike is exposed in the IDL this is exposed too.
Change-Id: I44175877eb95f4d910586d42c0139fb182483f82
Reviewed-on: https://dart-review.googlesource.com/49800
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2018-05-23 04:08:14 +00:00
Terry Lucas
3e6b8717fe
Fixed GamePadList not working in DDC and hide MessagePort.start operation.
...
Fixes https://github.com/dart-lang/sdk/issues/31029
R=vsm@google.com
Change-Id: I757538eec1ebcf42204e7de0807a48a4757f3faf
Reviewed-on: https://dart-review.googlesource.com/49740
Reviewed-by: Vijay Menon <vsm@google.com >
Commit-Queue: Terry Lucas <terry@google.com >
2018-04-05 15:13:17 +00:00
Terry Lucas
bc75856e54
Update getClientRects, removed xtab, removed bogus entry in dom.json,
...
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.
Fixed all tests using query and queryAll.
Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675
R=kevmoo@google.com
Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2018-03-27 20:45:33 +00:00
Terry Lucas
581c512345
Fixed DOMRectList not having a prototype field.
...
TBR=vsm@google.com
Change-Id: I6cbc38bbb2123b914d5b5511774425c403e614ed
Reviewed-on: https://dart-review.googlesource.com/47183
Reviewed-by: Terry Lucas <terry@google.com >
Commit-Queue: Terry Lucas <terry@google.com >
2018-03-20 01:08:47 +00:00
Terry Lucas
ef6273cba0
Dart Web Libraries re-generated based on Chrome 63 WebIDLs.
...
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.
Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#
Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Terry Lucas <terry@google.com >
2018-03-18 09:41:04 +00:00
Terry Lucas
d7a8aa155f
Fixed a number of File API methods in DDC.
...
R=vsm@google.com
Change-Id: I77881201f1e89f731476655476eb865e10d581a1
Reviewed-on: https://dart-review.googlesource.com/38164
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2018-02-05 22:29:00 +00:00
Terry Lucas
0a02050867
Fixed DirectoryReader returned from createReader to exist in DDC.
...
R=vsm@google.com
Change-Id: I6761da70b2f51f235534ee10fa0b7cb7a7a98659
Reviewed-on: https://dart-review.googlesource.com/36020
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2018-01-19 18:14:05 +00:00
Terry Lucas
476b1e02a9
Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test.
...
Also, updated status files to correctly fix failures in FF, IE and removed other spurious status entries.
R=alanknight@google.com ,vsm@google.com
Change-Id: Ic965103d892ff4d5d119712e3187e829f57cd022
Reviewed-on: https://dart-review.googlesource.com/31800
Reviewed-by: Terry Lucas <terry@google.com >
2017-12-29 23:51:02 +00:00
Terry Lucas
0af98266ab
Revert "Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test."
...
This reverts commit 0c8294e4a0 .
Bug:
Change-Id: Idb35c64fd5365f2669e8aff45765fed74e0f0766
Reviewed-on: https://dart-review.googlesource.com/31440
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Terry Lucas <terry@google.com >
2017-12-23 01:59:38 +00:00
Terry Lucas
0c8294e4a0
Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test.
...
R=alanknight@google.com ,vsm@google.com
Change-Id: I80e82f5aaa3c9748740031d8da139f79e2c0ab70
Reviewed-on: https://dart-review.googlesource.com/31080
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Alan Knight <alanknight@google.com >
2017-12-22 22:57:34 +00:00
Terry Lucas
529add3834
DDC fix to expose classes which are only created inside of the browser.
...
R=vsm@google.com
Change-Id: I27ede73ac84a72ee9b5e8b3b0a706ade82b2aa59
Reviewed-on: https://dart-review.googlesource.com/25500
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
2017-12-13 03:03:09 +00:00
Terry Lucas
1265b4c674
Fixed readPixels not working in Dartium.
...
BUG=11614
R=alanknight@google.com , jacobr@google.com
Review-Url: https://codereview.chromium.org/2975953002 .
2017-07-11 13:12:51 -07:00
Terry Lucas
b3a90540f1
Fix sound not playing in Dartium checked mode.
...
Checked mode failure with optional args and Promise missing convertNativePromiseToDartFuture calls.
Easiest solution is to emit proper code instead of re-plumbing the Dartium emitter for operations
with optional arguments that are Promises.
https://github.com/dart-lang/sdk/issues/29810
TBR=alanknight@google.com ,kevmoo@google.com
Review-Url: https://codereview.chromium.org/2940543002 .
2017-06-12 22:50:12 -07:00
Stephen Adams
01ba5f8d74
fix KeyEvent and KeyboardEvent
...
Some keyboard specific properties moved in the IDL from UIEvent to
KeyboardEvent. We has done work to hide them on UIEvent; this needed
to be updated.
TBR=terry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2883623004 .
2017-05-12 16:03:01 -07:00
Stephen Adams
0879884d80
web_audio: rename OfflineAudioContext.suspend
...
Rename member to avoid warning due to incompatible signature of base class method of same name.
TBR=terry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2872023006 .
2017-05-11 18:05:09 -07:00
Stephen Adams
f3734a9fc5
dom: Recognize __getter__ indexers
...
BUG=
R=alanknight@google.com
Review-Url: https://codereview.chromium.org/2879663002 .
2017-05-11 13:59:41 -07:00
Terry Lucas
f27144d7b5
Roll 50: Updated for push to origin/master.
...
TBR=jacobr@google.com
Review-Url: https://codereview.chromium.org/2875773003 .
2017-05-10 18:16:51 -07:00
William Hesse
bde8d3efc6
Revert "Don't call _ensureRequestAnimationFrame in Dartium."
...
This reverts commit bf8eeef6a0 .
Revert "Fix animationFrameRequest for dartium."
This reverts commit 3daaf3849f .
BUG=https://github.com/dart-lang/sdk/issues/26906
Review URL: https://codereview.chromium.org/2159183003 .
2016-07-19 13:56:36 +02:00
Alan Knight
30b489578d
Revert "Reapply zone tasks."
...
This reverts commit 6a7c037aa6 .
BUG=
Review URL: https://codereview.chromium.org/2162643002 .
2016-07-18 13:12:36 -07:00
Florian Loitsch
3daaf3849f
Fix animationFrameRequest for dartium.
...
Review URL: https://codereview.chromium.org/2124863002 .
2016-07-05 19:22:27 +02:00
Florian Loitsch
6a7c037aa6
Reapply zone tasks.
...
This reverts commit 34d3c37233 .
Committed: https://github.com/dart-lang/sdk/commit/f746f8f77e93fd93cb4ff3b4ed644c96a432947a
R=lrn@google.com
Review URL: https://codereview.chromium.org/2119243002 .
Reverted: https://github.com/dart-lang/sdk/commit/dae392291595fa394d601d2d0baa77b66d85533f
2016-07-05 17:33:09 +02:00
Florian Loitsch
dae3922915
Revert "Reapply zone tasks."
...
This reverts commit f746f8f77e .
Review URL: https://codereview.chromium.org/2123593002 .
2016-07-04 21:58:15 +02:00
Florian Loitsch
f746f8f77e
Reapply zone tasks.
...
This reverts commit 34d3c37233 .
Review URL: https://codereview.chromium.org/2119243002 .
2016-07-04 19:55:58 +02:00
Florian Loitsch
34d3c37233
Revert zone tasks.
...
Revert "Add tasks to zones."
This reverts commit 85cccde717 .
Revert "Make Dom events run through zone tasks."
This reverts commit 6d1f6b2af6 .
Revert "Add zone task support for request-anim."
This reverts commit 726b9f8dc7 .
Revert "Add zone task support to http-requests."
This reverts commit b40cfcb57f .
Revert "Update status file for jsshell."
This reverts commit 5e05ee9b5f .
Review URL: https://codereview.chromium.org/2120063002 .
2016-07-01 22:36:52 -07:00
Florian Loitsch
b40cfcb57f
Add zone task support to http-requests.
...
R=alanknight@google.com , lrn@google.com
Review URL: https://codereview.chromium.org/2042033002 .
2016-07-01 19:44:19 -07:00
Jacob Richman
f26e522f84
Strip unused functionality from dart:html and fix strong mode errors. Switch from blacklisting pure interfaces to determining pure interfaces from the idl and whitelisting impure interfaces we need for dart2js.
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1987073002 .
2016-05-18 12:49:09 -07:00
Alan Knight
5542568adc
Fix MouseEvent.movement to not use old webkit prefix
...
BUG=
Review URL: https://codereview.chromium.org/1921823002 .
2016-04-25 12:35:03 -07:00
Jacob Richman
864b64fd5e
Strong html
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1894713002 .
2016-04-19 15:08:45 -07:00
Terry Lucas
74ddf84ffd
Remove MutationEvent bad entries in both removed list and renamed list
...
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1890983002 .
2016-04-14 13:49:42 -07:00
Alan Knight
ab55f22334
Fix WebGL tex[Sub]Image2D/buffer[Sub]Data, restored Typed/Untyped aliases
...
BUG=
Review URL: https://codereview.chromium.org/1831033002 .
2016-03-24 10:20:11 -07:00
Terry Lucas
5c3728b067
Fix for KeyEvent,KeyboardEvent and UIEvent changes in roll 45
...
TBR=jacobr@google.com ,alanknight@google.com ,sigmund@google.com
Review URL: https://codereview.chromium.org/1754523006 .
2016-03-07 07:51:50 -08:00
Alan Knight
83e2e2dbb2
Change scripts to avoid generating things that bloat the compiled code
...
BUG=
Review URL: https://codereview.chromium.org/1763213002 .
2016-03-04 15:08:48 -08:00
Kasper Lund
96be0c49fb
Revert "Change scripts to avoid generating things that bloat the compiled code"
...
This reverts commit 4f3abbd5ef .
2016-03-04 10:06:07 +01:00
Alan Knight
4f3abbd5ef
Change scripts to avoid generating things that bloat the compiled code
...
BUG=
Review URL: https://codereview.chromium.org/1759303003 .
2016-03-03 17:39:50 -08:00
Terry Lucas
e1a33e9981
Moved ChromiumSubscribeUniform to web_gl
...
Fixed to return null if dictionary returned form blink is null
Cleanup up logging/error reporting
TBR=alanknight@google.com ,jacobr@google.com
Committed: https://github.com/dart-lang/sdk/commit/01f6e4ed0f8882001e5a308cc8e36dcb62e9b5bc
Review URL: https://codereview.chromium.org/1752983003 .
2016-03-02 08:15:45 -08:00
Terry Lucas
c7c12c7756
Migrated changed for sdk/lib genernation from integration branch to master.
...
- client* not properly exposed.
- Expose createImageDataFromImageData for backward compat
- Chrome now allow typedefs defined in and IDL to be used and other IDL files (even though the IDL has no include).
TBR=alanknight@google.com ,jacobr@google.com
Review URL: https://codereview.chromium.org/1744093002 .
2016-02-28 11:59:20 -08:00
Alan Knight
cc142b92a4
Treat Element.clientTop/Left/etc same as scrollTop/etc., avoid duplicate members
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org/1726173002 .
2016-02-23 16:29:40 -08:00
Terry Lucas
97861e3f22
Fixed a few problems with 45 roll merge
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1720823003 .
2016-02-22 12:02:43 -08:00
Terry Lucas
a3350d9b06
Generation of sdk/lib files from 45 roll
...
TBR=alanknight@google.com ,jacobr@google.com
Review URL: https://codereview.chromium.org/1720743005 .
2016-02-22 10:59:12 -08:00
Jacob Richman
f478562b0a
Dartium 45 roll
...
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1682783002 .
2016-02-09 10:50:43 -08:00
Alan Knight
d2b1388ed1
Switch IDB Database.transaction to use a template to do the right type conversions
...
BUG=
Review URL: https://codereview.chromium.org/1473443003 .
2015-11-23 14:29:44 -08:00
Alan Knight
9ad57e7aa3
Fix Crypto.getRandomValues to modify its argument, fix tests
...
BUG=
Review URL: https://codereview.chromium.org/1387273002 .
2015-10-07 09:11:14 -07:00
Terry L. Lucas
7b322c246c
Dartium JS Enabled take 2
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1348173002 .
2015-09-16 07:13:53 -07:00
Terry L. Lucas
09c804aa78
Revert "Dartium JS Interop enabled."
...
This reverts commit 403bd1698d .
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org//1345083002 .
2015-09-15 19:44:26 -07:00