dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

79 Commits

Author SHA1 Message Date
Sigmund Cherem 5192cd1008 Narrowing improvements in dart2js global inference. 
* no longer narrow by selector use, only narrow by type and non-null
* check for narrow nesting
* add non-null in a couple known places

One large apps, I compared the type-masks in dump-info and all differences were improvements with non-null. We weren't doing any narrowing based on the possible targets of a selector.

Change-Id: I270f360f70fbe3171d09ccd71d10517be9140194
Reviewed-on: https://dart-review.googlesource.com/c/90340
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-02-23 00:10:11 +00:00
Terry Lucas edca6169c1 Fixed a number of dart:html P1 issues. 
- Fixed HTML API's with callback typedef to correctly convert Dart function to JS function.
- Expose HttpStatus from dart:html
- Expose DomName ondblclick and dblclickEvent for Angular analyzer.
- Fixed removeAll should be Iterable<Object> to match Set's removeAll not Iterable<E>.
- Fixed a number of DataTransferItem, Entry, FileEntry and DiretoryEntry returning NativeJavaScriptObject needed type registered in DDC.
- Added ability to allow local file access from Chrome browser added -local in ddb.

R=vsm@google.com

Fixes #30278
Fixes #35484
Fixes #34318
Fixes #35510

Change-Id: Ide8c04716c54045e837781d489562f27b694b109
Reviewed-on: https://dart-review.googlesource.com/c/89340
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2019-01-15 17:21:50 +00:00
Terry Lucas 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 
R=kevmoo@google.com,vsm@google.com

Fixes #32304

Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-06-18 18:48:03 +00:00
Terry Lucas bc75856e54 Update getClientRects, removed xtab, removed bogus entry in dom.json, 
expose ServiceWorker, removed query and queryAll from in dart:html,
added constructor to MessageChannel and removed getCssCanvasContext.

Fixed all tests using query and queryAll.

Fixes https://github.com/dart-lang/sdk/issues/25664
Fixes https://github.com/dart-lang/sdk/issues/26349
Fixes https://github.com/dart-lang/sdk/issues/32323
Fixes https://github.com/dart-lang/sdk/issues/32659
Fixes https://github.com/dart-lang/sdk/issues/32675

R=kevmoo@google.com

Change-Id: I687471e80b8fe9c7040673113f424dbaab7c64d4
Reviewed-on: https://dart-review.googlesource.com/48381
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-03-27 20:45:33 +00:00
Terry Lucas ef6273cba0 Dart Web Libraries re-generated based on Chrome 63 WebIDLs. 
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.

Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#

Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 09:41:04 +00:00
Terry Lucas 3cbacefbe3 Fix HTMLCanvasElement.getContext it can return RenderingContext2 now which will be tree shaken without this annotation. 
R=alanknight@google.com,sigmund@google.com

Review-Url: https://codereview.chromium.org/2932793002 .
 2017-06-08 20:44:30 -07:00
Stephen Adams 9c3d439b1e dart2js + html: getBoundingClientRect() returns a ClientRect 
Gives better code since the general Rectangle requires getInterceptor
dispatch.

BUG= https://github.com/dart-lang/sdk/issues/29602
R=jacobr@google.com, terry@google.com

Review-Url: https://codereview.chromium.org/2879403002 .
 2017-05-16 13:48:04 -07:00
Stephen Adams ca3d90c4cd Prevent ExtendableMessageEvent.data from thwarting DOM tree-shaking 
We can't have the [data] and [source] getters typed as Object.
This causes it to appear that all DOM types are instantiated.

I have modelled the annotations after the same getters from
MessageEvent.

TBR=jacobr@google.com

BUG=

Review-Url: https://codereview.chromium.org/2879763002 .
 2017-05-11 19:31:20 -07:00
Stephen Adams ea2c9cba39 dart2js_html: Fix for issue 29538 - some returned lists may be null 
Annotate querySelectorAll as not-null to recover code quality.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2857143003 .
 2017-05-03 14:26:38 -07:00
Harry Terkelsen 1d749a2fec record that Gamepad.buttons creates GamepadButtons 
This also extends the html generator to be able to generate List implementations with nullable element types

Fixes https://github.com/dart-lang/sdk/issues/27073

R=sra@google.com, terry@google.com

Review URL: https://codereview.chromium.org/2242203002 .
 2016-08-16 13:56:32 -07:00
Harry Terkelsen faaff39aa9 Record that MediaStream creates MediaStreamTracks 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/2168473002 .
 2016-07-19 17:00:04 -07:00
Alan Knight 4fe809c211 Add @creates annotation to VttCue members 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1811213002 .
 2016-03-18 07:35:35 -07:00
Alan Knight 051451d7e6 Trying to fix SQLResultSetRowList's subscript operator to do type conversion 
BUG=

Review URL: https://codereview.chromium.org/1779023002 .
 2016-03-09 14:02:30 -08:00
Alan Knight 83e2e2dbb2 Change scripts to avoid generating things that bloat the compiled code 
BUG=

Review URL: https://codereview.chromium.org/1763213002 .
 2016-03-04 15:08:48 -08:00
Kasper Lund 96be0c49fb Revert "Change scripts to avoid generating things that bloat the compiled code" 
This reverts commit 4f3abbd5ef.
 2016-03-04 10:06:07 +01:00
Alan Knight 4f3abbd5ef Change scripts to avoid generating things that bloat the compiled code 
BUG=

Review URL: https://codereview.chromium.org/1759303003 .
 2016-03-03 17:39:50 -08:00
Alan Knight 78b0f6f353 Replace the now missing ContextAttributes with our previously Firefox-only _TypedContextAttributes 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1727003002 .
 2016-02-23 16:33:31 -08:00
Terry Lucas a3350d9b06 Generation of sdk/lib files from 45 roll 
TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1720743005 .
 2016-02-22 10:59:12 -08:00
Sigmund Cherem c3e61f315c cpsir: triage remainder of html test suite, fix a couple. 
R=asgerf@google.com, het@google.com

Review URL: https://codereview.chromium.org/1679603002 .
 2016-02-08 10:37:52 -08:00
sra@google.com 1b2296c2be getElementsByName returns HtmlCollection on IE 
Review URL: https://codereview.chromium.org//1093243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45299 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-20 22:23:08 +00:00
sra@google.com 55372e4678 t # Enter a description of the change. 
Revert "getElementsByName returns HtmlCollection on IE"

TBR=terry@google.com
BUG=

Review URL: https://codereview.chromium.org//1098953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45298 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-20 21:48:30 +00:00
sra@google.com 44ea26b4fb getElementsByName returns HtmlCollection on IE 
This CL will be committed and reverted to sniff out test status changes (some very small tests will start passing)

TBR=terry@google.com

Review URL: https://codereview.chromium.org//1093243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45295 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-20 20:16:24 +00:00
alanknight@google.com 46a24513a3 Add MediaSource.supported, annotations for supported browsers, and a minimal test 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//990383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44472 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-13 17:31:42 +00:00
alanknight@google.com 5d2f7f8ae8 Fix notification 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1002953005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44471 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-13 17:21:31 +00:00
sra@google.com 8c7e1a75d1 Revert "Element.style is not null" 
Need to investigate:
FAILED: dart2js-chrome release_ia32 co19/LayoutTests/fast/xsl/default-html_t01
Expected: RuntimeError
Actual: Pass

Review URL: https://codereview.chromium.org//971033004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44222 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-04 05:24:57 +00:00
sra@google.com c363abff4a Element.style is not null 
BUG=

Review URL: https://codereview.chromium.org//960503006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44220 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-04 03:54:22 +00:00
terry@google.com e0fff4e457 Changes to support roll 39 IDLs 
Reviewers=vsm@google.com,asiva@google.com

Review URL: https://codereview.chromium.org//952133004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44099 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-27 18:10:08 +00:00
vsm@google.com 94095d64a2 Merge 38 changes to bleeding edge 
TBR=terry@google.com,leafp@google.com
BUG=

Review URL: https://codereview.chromium.org//605083004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40774 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-29 15:56:25 +00:00
terry@google.com 5e96fad938 Fixing treeshaking problem with 37 roll 
Reviewers=vsm@google.com, sra@google.com

R=sra@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//597363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40665 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-25 02:40:36 +00:00
vsm@google.com 1c4bb5f363 Revert "Chrome 38 script changes from integration branch" 
This reverts commit r40567.

TBR=leafp@google.com

Review URL: https://codereview.chromium.org//589253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40570 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-22 21:11:34 +00:00
vsm@google.com 9e25106514 Chrome 38 script changes from integration branch 
TBR=leafp@google.com

Review URL: https://codereview.chromium.org//593853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40567 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-22 20:45:57 +00:00
terry@google.com ecceb75d35 Begin hookup of Blink IDL parser for dart:* libraries. 
BUG=
R=vsm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39948

Review URL: https://codereview.chromium.org//444743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40026 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-09 13:18:24 +00:00
terry@google.com ac72bce2f1 "Reverting 39948" 
BUG=

Review URL: https://codereview.chromium.org//554853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39999 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-08 20:58:19 +00:00
terry@google.com cf0c6a3565 Begin hookup of Blink IDL parser for dart:* libraries. 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//444743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39948 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-08 02:33:50 +00:00
efortuna@google.com 7cbe70fb2c Deprecate MouseEvent.elementTo and elementFrom since they have the same 
functionality as relatedTarget.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//454043004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39050 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-08 21:07:24 +00:00
efortuna@google.com 8e07c04649 Update supported browser annotations for Firefox Web Audio. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//335453006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38244 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-15 18:06:35 +00:00
efortuna@google.com e0672a319d Add ClipboardEvent for Firefox. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//380383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38138 260f80e4-7a28-3924-810f-c04153c831b5
 2014-07-10 22:34:07 +00:00
efortuna@google.com bce070e7cc Change HtmlCollection to appear as List<Node> and getElementsByX return ListNode|HtmlCollection (depending on browser). 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//227153010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34799 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-07 22:22:55 +00:00
sra@google.com 246f07b5c8 Fix for FileReader.readAsArrayBuffer http://dartbug.com/17058 
R=blois@google.com

Review URL: https://codereview.chromium.org//180583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33048 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-26 00:31:05 +00:00
sra@google.com 9f09fcbaac Redo "Make dart2js typed_data implementation classes private" 
This time with analyzer suppression for new library/

BUG=

Review URL: https://codereview.chromium.org//141653003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31935 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-17 23:01:26 +00:00
sra@google.com 9ceaef9d73 Revert "Redo "Make dart2js typed_data implementation classes private"" 
Revert while I figure out the correct analyzer suppression.

BUG=

Review URL: https://codereview.chromium.org//141523008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31933 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-17 21:54:18 +00:00
sra@google.com 42b1721927 Redo "Make dart2js typed_data implementation classes private" 
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//138543005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31930 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-17 21:08:40 +00:00
sra@google.com 8ffab76c82 Revert "Redo "Make dart2js typed_data implementation classes private"" 
Review URL: https://codereview.chromium.org//140543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31866 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 05:03:02 +00:00
sra@google.com 83ae5cfabf Redo "Make dart2js typed_data implementation classes private" 
The main library is now private, with the user visible library as small re-export library.

R=blois@google.com, floitsch@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org//130563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31865 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-16 04:27:50 +00:00
sra@google.com f41f6f6722 ImageData.data is a Uint8ClampedList 
Review URL: https://codereview.chromium.org//41583005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29228 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-25 00:46:48 +00:00
amouravski@google.com c1eb44e3d0 Fix for getContextAttributes which wraps bare dictionary into a Dart type. 
R=sra@google.com

Review URL: https://codereview.chromium.org//35863006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29221 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-24 22:32:46 +00:00
blois@google.com 15e086338d Revert "Revert "Removing some deprecated members"" 
Take-two of https://code.google.com/p/dart/source/detail?r=29022

The issue with the original was that addEventListener was changed to private, but this caused the IDB classes which override it to not override it any longer. This was breaking C++ multiple inheritance type casts. Fix is to make addEventListener public.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//35013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29051 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-23 00:44:10 +00:00
blois@google.com 3aef09e008 Revert "Removing some deprecated members" 
For some reason this broke indexed_db on Dartium, I debugged in some but need more time to understand. The completed event is not firing.

TBR
BUG=

Review URL: https://codereview.chromium.org//32523007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29033 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 20:20:32 +00:00
blois@google.com e2c4716609 Removing some deprecated members 
These are all DOM APIs that we had annotated as deprecated but not actually removed. They've all been deprecated for quite a while.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//30353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29022 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 18:42:01 +00:00
blois@google.com 0c4f4dce36 Fixing dart2js size regression from CustomElement.detail 
The annotation for CustomEvent.detail was being dropped.
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//26115003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28807 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-17 17:36:58 +00:00