Remove accidental legacy test section from front_end bots.
Remove no-op --strong arg from test matrix.
Change-Id: Icafc7eeb3c25f5816596affeaf8f75a7328fb907
Reviewed-on: https://dart-review.googlesource.com/64520
Reviewed-by: Jonas Termansen <sortie@google.com>
Cq-Include-Trybots:luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Change-Id: I37f3b78180133c31f6267b76c3eeb16f8c00325a
Reviewed-on: https://dart-review.googlesource.com/63623
Reviewed-by: Erik Ernst <eernst@google.com>
* uses 6 shards for try bots like the recipes used to do
* add a strong-hostasserts configuration. Currently the test.py flag is called
--host-checked, but all it does is enable assertions (no more checked mode in
Dart2)
Change-Id: I50c565bb210fbb98334b7d84556c3ab98c38b22a
Reviewed-on: https://dart-review.googlesource.com/63682
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
After reviewing all recipes, we needed a few changes to bring the test matrix to parity:
- we needed to add strong-mode coverage (mostly in d8 at this time)
- we needed to add fast-startup coverage on all browsers
This however includes a bit more coverage than the existing recipes:
- strong-mode coverage in d8 now includes all suites, not just language_2 and corelib_2
- legacy coverage in ie11 includes all suites, not just html and co19
Next steps:
- move the remaining dart2js bots to the test matrix using the existing and new builders
- fix .status files on builders that include more suites (d8-strong + ie11)
- fix .status files on new Dart 2.0 builders
- add new Dart 2.0 builders to the waterfall
- eventually remove Dart1 builders.
Change-Id: Iec0a7fef7176cc81d3ced5e34c8dd63d33b7079e
Reviewed-on: https://dart-review.googlesource.com/61086
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
The builder configurations have been moved to the "builder_configurations" key,
and the "configurations" key will be used for test configurations.
Change-Id: Ic61f1646378a13526dc59b713f272cea51d9781b
Reviewed-on: https://dart-review.googlesource.com/63580
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
The key "configurations" will be used for named configurations, after
the recipes are updated to use the new "builder_configurations" key.
Change-Id: Ifec6803f3aaee83cbc48c591ac306af3ef951933
Reviewed-on: https://dart-review.googlesource.com/62147
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
- make Dart2 the default option for the command line VM
- add option --no-preview-dart-2 as a fallback option to run dart1
- change test scripts to use the executable dart for testing dart2 mode instead of
pkg/vm/tool/dart2
- adjust numerous build and test configurations
Change-Id: Id813fa5b71a89c7ec9335d3f6e83cfc9f35f86e7
Reviewed-on: https://dart-review.googlesource.com/58240
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
This uses optional new/const and `=` in named argument defaults.
All changes are automated, except for:
- utils/dartdevc/BUILD.gn: run DDC build scripts with --preview-dart-2
- pkg/dev_compiler/tool/patch_sdk.dart: add a TODO that Analyzer doesn't
supporting implicit const in libraries.dart
- pkg/dev_compiler/tool/input_sdk/libraries.dart: was not formatted due
to the aforementioned Analyzer bug
- tools/bots/test_matrix.json: run DDC sourcemap suite in Dart 2 mode
- pkg/pkg.status: skip pkg/dev_compiler if running in Dart 1 mode
Change-Id: I9b80ccba0c2cc7b66efc662a0b16562e3660aee3
Reviewed-on: https://dart-review.googlesource.com/60402
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
The --preview-dart-2 flag flip makes it unecessary to:
* Test Dart 2 configs in host-checked mode.
* Test --checked and --strong together.
* Test --preview-dart-2 and --strong separately.
Change-Id: I1738d351c866fb95fd9e1249f5f4ffb88169e106
Reviewed-on: https://dart-review.googlesource.com/59900
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
* Remove co19_2 from file sets for now.
* Skip extremely slow test.
* Remove redundant build target from test matrix.
#33150
Change-Id: Ib17d2e7438dc2ab473e751f1d79c617cbc26275d
Reviewed-on: https://dart-review.googlesource.com/55661
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
The http_server in the test.py scripts uses package_resolver, which
uses 10 packages from third_party/pkg and third_party/pkg_tested.
Change-Id: I1e9ca660b9bd0a6270bcc8e4121da6a3bf9713bd
Reviewed-on: https://dart-review.googlesource.com/47781
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Danny Tuppeny