Commit Graph

12 Commits

Author SHA1 Message Date
Kevin Moore 8719fb3a7b Generate homebrew script compatible with latest changes
Fixes https://github.com/dart-lang/homebrew-dart/issues/58

Change-Id: I23e38db5448c5d8ceb55d57689eda0eecf80c630
Reviewed-on: https://dart-review.googlesource.com/c/88883
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2019-01-10 16:43:34 +00:00
Kevin Moore d908743de1 update_homebrew: initial cleanup
Before fixing https://github.com/dart-lang/homebrew-dart/issues/58

Change-Id: Id09065c9a732d0eb4268f2667ff1bfea635d0922
Reviewed-on: https://dart-review.googlesource.com/c/88900
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
2019-01-10 13:05:58 +00:00
William Hesse 8e2f28e264 Update homebrew to drop the @2 tab and fix for 2.0
Change-Id: I1ece391c9c7cdcec9fd0662841bdbdaee7a7a373
Reviewed-on: https://dart-review.googlesource.com/69101
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-09 11:49:32 +00:00
Alexander Thomas a16ad6d9de [infra] Make update_homebrew script work on Dart2
Change-Id: Ieb4d5131273dfe85f29b7f9916a5d3be3c7fe461
Reviewed-on: https://dart-review.googlesource.com/62146
Reviewed-by: William Hesse <whesse@google.com>
2018-06-26 10:04:58 +00:00
Alexander Thomas b6cea45ee8 [infra] Escape $ in new homebrew script string
Change-Id: I9f4f675372589929c117e73cfc445e7b13c30f0f
Reviewed-on: https://dart-review.googlesource.com/59740
Reviewed-by: William Hesse <whesse@google.com>
2018-06-11 16:58:00 +00:00
Andrew Janke 61e57e2012 update_homebrew🎯 also make a dart@2, for Dart 2 migration
This PR modifies update_homebrew to also generate a dart@2 versioned formula. The new file is dropped out right next to the old `dart.rb` file.

The dart@2 formula is a temporary measure to aid application developers
migrating from Dart 1 to Dart 2.

Supersedes https://github.com/dart-lang/homebrew-dart/pull/52.

This looks right by inspection, but I haven't been able to test it yet: my local `dart` environment is all messed up, and I am a Dart newbie. Still, I'm putting this out here as a PR so the discussion from https://github.com/dart-lang/homebrew-dart/pull/52 can proceed.

Closes #33318
https://github.com/dart-lang/sdk/pull/33318

GitOrigin-RevId: 5230782aabf4f45199cff9b1fb9c5304e5dcb21c
Change-Id: I78cf5b066d85ac8b0ef51ed44e6eb1a15192b23c
Reviewed-on: https://dart-review.googlesource.com/58120
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-06-07 10:17:22 +00:00
Kevin Moore ed4733e6fc homebrow: Remove notes on Dartium – looking towards the future
Change-Id: I8f37818ee530e6c0fb3f40d7b382a7329bc82543
Reviewed-on: https://dart-review.googlesource.com/52423
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-24 18:27:33 +00:00
Lasse R.H. Nielsen 973a1a0219 Remove uses of upper-case constants in remaining SDK code.
This includes Fasta, tools and observatory, so the checked-in SDK must
have the lower-case constants.

Change-Id: I8380ad041ad058f7d02ae19caccfecd434d13d75
Reviewed-on: https://dart-review.googlesource.com/50201
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-04-16 16:11:57 +00:00
Kevin Moore 970b03986d Update homebrew formula to fail with dartium on dev releases
Closes https://github.com/dart-lang/sdk/issues/32642

Change-Id: I221ec3cca7c6965a0feef1dd380160221e1b5fb2
Reviewed-on: https://dart-review.googlesource.com/48000
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
2018-03-23 01:45:34 +00:00
Tom Sullivan ded230959d Fix Homebrew undent warning
Update the generated `dart.rb` formula file to fix:

```
Warning: Calling <<-EOS.undent is deprecated!
Use <<~EOS instead.
/usr/local/Homebrew/Library/Taps/dart-lang/homebrew-dart/dart.rb:72:in `caveats'
Please report this to the dart-lang/dart tap!
```

being reported by `brew`.

Fixes https://github.com/dart-lang/homebrew-dart/issues/48

Credit for original patch to @fsouza:

https://github.com/fsouza/homebrew-dart/commit/06b76e0935a0c74e8f10d32b81e1b72358a661b4

Closes #32346
https://github.com/dart-lang/sdk/pull/32346

GitOrigin-RevId: 938a696caea21eda193375ad4cce5aab0e7b5e71
Change-Id: I757647a7ef0a373cb0258f0fcf03f89849aeba5e
Reviewed-on: https://dart-review.googlesource.com/44100
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-03-01 13:50:38 +00:00
William Hesse 7643dc86fc Update the homebrew recipe to not have Dartium dev versions.
BUG=
R=kevmoo@google.com

Review-Url: https://codereview.chromium.org/2977223002 .
2017-07-17 18:31:09 +02:00
Kevin Moore 4b0384c899 Homebrew cleanup (#28899)
* basic cleanup to home-brew script
* avoid global variables
* Up a more typical package layout
* add generate binary – make it easy to test the output without dealing with git
* Update output to pass brew audit `brew audit --strict --online dart.rb`
2017-03-09 12:35:36 -08:00