Commit Graph

18 Commits

Author SHA1 Message Date
Kevin Moore d908743de1 update_homebrew: initial cleanup
Before fixing https://github.com/dart-lang/homebrew-dart/issues/58

Change-Id: Id09065c9a732d0eb4268f2667ff1bfea635d0922
Reviewed-on: https://dart-review.googlesource.com/c/88900
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
2019-01-10 13:05:58 +00:00
Kevin Moore 4b0384c899 Homebrew cleanup (#28899)
* basic cleanup to home-brew script
* avoid global variables
* Up a more typical package layout
* add generate binary – make it easy to test the output without dealing with git
* Update output to pass brew audit `brew audit --strict --online dart.rb`
2017-03-09 12:35:36 -08:00
William Hesse 9aec21c3cc Update homebrew updater script to use 64-bit dartium
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org/2321393002 .
2016-09-09 13:45:33 +02:00
William Hesse 634e5a1d02 Refs #25328 Use a portable shebang
BSD systems don't place bash in /bin and a lot of the dart tools
hardcode a #!/bin/bash shebang that fails the 'all' target build
(not able to execute dart2js since the interpreter is not found).

Solve the issue by using #!/usr/bin/env as the shebang. For scripts
that need to pass arguments to bash modify the script to use the set
command as the first executed line of shell.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/1552313002 .
2016-01-05 16:26:28 +01:00
keertip 18b68f7290 remove docgen remnants from repo, update CHANGELOG
BUG=
R=alanknight@google.com, whesse@google.com

Review URL: https://codereview.chromium.org//1361163002 .
2015-09-23 10:27:15 -07:00
William Hesse c4f359fd9f Remove dartium formula from homebrew updater.
The dart formula has options --with-dartium and --with-content-shell, and
the dartium formula has been showing the deprecation message for months.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1284633002 .
2015-08-10 15:39:17 +02:00
William Hesse feade0551f Flag --with-dartium should install dartium
Although the --with-dartium flag was documented, the flag
--with-content-shell was used for installing dartium instead.

Chromium path in caveats should be version agnostic
Fixes https://github.com/dart-lang/homebrew-dart/issues/32

R=whesse@google.com

Review URL: https://codereview.chromium.org//1211743002.
2015-07-01 10:25:03 +02:00
Kevin Moore 90b656946b homebrew: Include version information in resources
Ensures cached files are unique

R=whesse@google.com

Review URL: https://codereview.chromium.org//1179033002.
2015-06-12 09:24:05 +01:00
Kevin Moore 09e8210c47 update_homebrew: add optional resources content-shell and dartium to dart formula
deprecate dartium formula
make -k optional
remove extra version sets

R=whesse@google.com

Review URL: https://codereview.chromium.org//1170953004.
2015-06-09 13:43:29 +02:00
Kevin Moore 2e6d2a6224 update_homebrew: more fixes
normalize top-level constants
simplify file writing
pop out variables to top-level constants

R=whesse@google.com

Review URL: https://codereview.chromium.org//1170973002.
2015-06-09 11:17:18 +02:00
Kevin Moore 856248f135 update_homebrew: support version-formatted revisions
fix for running in checked mode

R=whesse@google.com

Review URL: https://codereview.chromium.org//1160383002
2015-06-02 10:02:10 -07:00
Kevin Moore ebb0d0100d update_homebrew: use async/await
R=whesse@google.com

Review URL: https://codereview.chromium.org//1156473004
2015-06-01 09:51:51 -07:00
kevmoo@google.com 3c9dbbb49a homebrew: use exec to run shimmed command
R=whesse@google.com

Review URL: https://codereview.chromium.org//1133383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45764 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-13 14:38:04 +00:00
whesse@google.com 7ba45adfab Add MacOS content_shell download to homebrew formula update app.
BUG=dartbug.com/21717
R=ricow@google.com

Review URL: https://codereview.chromium.org//788043004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42251 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 17:04:32 +00:00
whesse@google.com 3430239194 Add additional check to vmservice/websocket_client test.
Fix type errors in update_homebrew script.

BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org//652833005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41166 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-17 12:11:27 +00:00
whesse@google.com b98c02e1b8 Change update_homebrew script to work with single-file homebrew formulas.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//654653007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41125 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-15 12:45:57 +00:00
whesse@google.com 7514534b79 Fix update_homebrew script for releasing Dart on Mac using homebrew.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//621743004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40837 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-01 14:23:37 +00:00
whesse@google.com 84679c0055 Add tools script to update homebrew, the MacOS SDK updating solution.
BUG=dartbug.com/20210
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//608693004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40801 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-30 09:14:43 +00:00