dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

19280 Commits

Author SHA1 Message Date
Lasse R.H. Nielsen f56fea3e63 Fix typo. 
Change-Id: I8f884eec6ea7fe20eac49f015157b54bfb21158f
Reviewed-on: https://dart-review.googlesource.com/c/84637
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-11-19 12:48:02 +00:00
Lasse R.H. Nielsen 0561ff2619 Add tests for trailing commas in set literals. 
Change-Id: I42e361e7c8fef21c30e5bfcc514be44a2f0ed801
Reviewed-on: https://dart-review.googlesource.com/c/84632
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-11-19 10:26:50 +00:00
Paul Berry 32a6032f03 Merge commit 'ddbe22190c41b1993a3c93b67f1bfa57287348f8' into analyzer 2018-11-16 12:01:38 -08:00
Paul Berry dba295527b Merge commit '2535b1e0219779d9befe65d6c09275044b233bc2' into analyzer 2018-11-16 09:19:45 -08:00
Johnni Winther 2776108a8f Remove LocalsHandler._capturedAndBoxed 
Change-Id: I1f91a59d1e64dedad61dec77dd74aa6cd8e360dd
Reviewed-on: https://dart-review.googlesource.com/c/84524
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-11-16 07:58:56 +00:00
Paul Berry b14b19e13c Merge commit '9e3d3cf765ba3f761b2507950039bcdd2dd3ece8' into analyzer 2018-11-15 09:17:48 -08:00
Samir Jindel 733b53d971 [vm] Mark enum_private_test/01 as flaky. 
Change-Id: I1d5b597f051808f4ef5dfbe5cc5a8e4bf77016b5
Reviewed-on: https://dart-review.googlesource.com/c/84533
Reviewed-by: Samir Jindel <sjindel@google.com>
 2018-11-15 16:20:50 +00:00
Samir Jindel 6914a86177 [vm] Update status file for enum_private_test/01. 
Change-Id: I9c666c22a4f6e5eae9f98fa20f37480e9c6e940b
Reviewed-on: https://dart-review.googlesource.com/c/84530
Auto-Submit: Samir Jindel <sjindel@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2018-11-15 15:16:49 +00:00
Samir Jindel 6b8aeb8898 [vm] Update status file for inference_enum_list_test. 
Change-Id: I9d8988d072ac953cdba6eae9cc7aca8c6b918fc7
Reviewed-on: https://dart-review.googlesource.com/c/84527
Auto-Submit: Samir Jindel <sjindel@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2018-11-15 14:05:22 +00:00
Alexander Markov ed48cfeb47 [vm/bytecode] Support source positions when executing bytecode 
This includes both interpreted and compiled bytecode.

Change-Id: I6309ec4f0687f68caf6260cc57dacf94f027177d
Reviewed-on: https://dart-review.googlesource.com/c/84481
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2018-11-15 00:48:04 +00:00
Sigmund Cherem 5a14f9e619 Remove unnecessary setupPackages step. 
Since we switched to the CFE we no longer use this, the CFE recomputes the package-configuration internally.

Change-Id: Icdc2a3eeff1aa75e560157ecf0d5320208096d21
Reviewed-on: https://dart-review.googlesource.com/c/84362
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-11-14 19:28:40 +00:00
Sigmund Cherem 5214afdb25 remove platform_configuration parser 
This was a .ini-like format that we used for our old *.platform files. Those
files are now replaced by libraries.json.

Change-Id: Ica00fcdafcecf676195a07873c41622adafdf1e3
Reviewed-on: https://dart-review.googlesource.com/c/84340
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-11-14 19:28:31 +00:00
Paul Berry fc2888982c Merge commit 'c92f9dce2357d0da7909c0c5f630ad59882ccf29' into analyzer 2018-11-13 12:35:13 -08:00
Alexander Markov f4a80a8466 [vm/bytecode] Fix entry point when optimized code is cleared but bytecode remains 
If interpreter is enabled and a function has bytecode, then its entry
point should be set to 'interpreter call' instead of 'lazy compile'
when clearing code.

Fixes https://github.com/dart-lang/sdk/issues/35128

Change-Id: Ie714ac9c4d1ffef181512c5785c374e9de22ab95
Reviewed-on: https://dart-review.googlesource.com/c/84180
Commit-Queue: Régis Crelier <regis@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2018-11-13 01:04:05 +00:00
Konstantin Shcheglov 9cf51348d4 Issue 33553. For get/set. Don't report ABSTRACT_SUPER_MEMBER_REFERENCE if the nominal superclass has noSuchMethod(). 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/33553
Change-Id: Ic0e142519a839607560ae0d0e551424a9b32c954
Reviewed-on: https://dart-review.googlesource.com/c/84045
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-12 17:31:25 +00:00
Daco Harkes 76e0d94616 [gardening] fix retries in socket_source_address_test 
Change-Id: I05bd349a039092d0a7839f04f40b4c4561611bbb
Reviewed-on: https://dart-review.googlesource.com/c/84036
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-11-12 17:04:34 +00:00
Daco Harkes 83a05147ae [gardening] fix retries in socket_ipv6_test 
Change-Id: Iaf7c7127896b99f69eec7b0f68328874490356cd
Reviewed-on: https://dart-review.googlesource.com/c/84035
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
 2018-11-12 14:43:40 +00:00
Paul Berry 3ae0dcaa18 Merge commit '5ef1465c55be601f601e1f565c9b9d2f94d76aff' into analyzer 
Conflicts:
	pkg/analysis_server/lib/src/analysis_server.dart
	pkg/analysis_server/lib/src/server/driver.dart
 2018-11-12 06:39:27 -08:00
Alexander Markov e33dee2a38 [gardening] Update status for issue #35128 
Issue: https://github.com/dart-lang/sdk/issues/35128
Change-Id: I453cdba4bafda460af9afa94239c3b5ad0da2b5d
Reviewed-on: https://dart-review.googlesource.com/c/84051
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
 2018-11-10 00:36:58 +00:00
Ben Konyi 39297646bf [ Corelib / Tests ] Removed tests for Maps helper class, which no longer exists 
Change-Id: I2adff8cc7f49bcb9710dca2b692fb40761fae175
Reviewed-on: https://dart-review.googlesource.com/c/84082
Commit-Queue: Ben Konyi <bkonyi@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
 2018-11-09 23:33:58 +00:00
Johnni Winther d062a41404 Make resolution/codegen_world_builder into libraries 
Change-Id: Ic8c00b2b3cf13a21e165486c1c825df75edd7d7b
Reviewed-on: https://dart-review.googlesource.com/c/84021
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Auto-Submit: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-11-09 23:05:58 +00:00
Sigmund Cherem b484aada21 Remove library-root option - replace it with a libraries-spec option instead 
Change-Id: Ie1df52cdaa7ab4381a4c1b94c61a1210f0f31b5f
Reviewed-on: https://dart-review.googlesource.com/c/83641
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-11-09 22:40:28 +00:00
Vyacheslav Egorov 5db3314a86 [gardening] Update status for language_2/type_constants_test/none 
Hot reload does not support deferred libraries.

TBR=lrn@google.com

Change-Id: Ie33966404d1274b8cbec7a54c284fd9c0022b5af
Reviewed-on: https://dart-review.googlesource.com/c/83981
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-11-09 11:28:02 +00:00
Lasse R.H. Nielsen 4f5bc1ea22 Add test for constant type literals being valid in switch cases and constant maps. 
Implementations already allow type constants, some just do not have the correct semantics.

See: https://dart-review.googlesource.com/c/sdk/+/81274/2..4
Change-Id: I2f535e4609b9d3b002ba33f579f3b840d70e0fdb
Reviewed-on: https://dart-review.googlesource.com/c/82981
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-11-09 10:22:00 +00:00
Alexander Aprelev 0bf9635a62 [gardening] Fix dart2 errors in socket_upgrade_to_secure_test. 
This is follow-up to d528e1651f (https://dart-review.googlesource.com/c/sdk/+/30389/)

Should help with https://github.com/dart-lang/sdk/issues/35104

Change-Id: I13070961e95ee53339d41e369863cd91aeb21e30
Reviewed-on: https://dart-review.googlesource.com/c/83780
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-11-08 23:26:18 +00:00
Konstantin Shcheglov 9cbd76d2bd Issue 35090. Concrete nominal superclasses of mixin applications provide at least noSuchMethod forwarders for super-invoked members. 
Bug: https://github.com/dart-lang/sdk/issues/35090
Change-Id: Id54856cb44cfb30eccaac68a2ee21f4bc9439bd2
Reviewed-on: https://dart-review.googlesource.com/c/83881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-08 22:44:46 +00:00
Aart Bik abe8794605 Revert "[Gardening] Mark language_2/vm/mult_int_test as failing on windows-dartkp-simarm64" 
This reverts commit 3f585d1b78.

Reason for revert: underlying issue (spilling) has been fixed

Original change's description:
> [Gardening] Mark language_2/vm/mult_int_test as failing on windows-dartkp-simarm64
> 
> Issue https://github.com/dart-lang/sdk/issues/35091
> 
> Change-Id: I129c05994223fc5067ec720290fff9cc317f8bb4
> Reviewed-on: https://dart-review.googlesource.com/c/83386
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Commit-Queue: Martin Kustermann <kustermann@google.com>
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
> Auto-Submit: Martin Kustermann <kustermann@google.com>

TBR=vegorov@google.com,kustermann@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Idc8fbe3397e393813fffcab1336f74f324bc70bd
Reviewed-on: https://dart-review.googlesource.com/c/83880
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-11-08 21:32:56 +00:00
Aart Bik a40fd6a976 [vm/compiler] Fix bug in unboxed constant spilling 
Rationale:
Subtle but disastrous, spilling unboxed integers
in arm64 and x64 would store the value as smi,
detected as a nasty off by one error in flutter code.

https://github.com/flutter/flutter/issues/23879
https://github.com/dart-lang/sdk/issues/35091

Change-Id: I07d71727de8574ebd7d3ec3610d517d7903972f0
Reviewed-on: https://dart-review.googlesource.com/c/83565
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-11-08 19:03:22 +00:00
Paul Berry d076571cd9 Merge commit '35c6c79ebc052ab28efcaf045b38ff71c6ed5f3e' into analyzer 2018-11-08 09:32:18 -08:00
Johnni Winther a9e2af657f Refactor static type computation 
This decouples the computation of static types from the kernel impact
visitor and prepares for flow sensitive static types (i.e. guarded type
promotion).

Change-Id: Ic8b6283bd64d535ff49b1d6fee2e5ae38d48a2d9
Reviewed-on: https://dart-review.googlesource.com/c/83381
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-11-08 13:16:42 +00:00
Jenny Messerly 106d6b0ca5 [dartdevc] fix #29847 async* dropping errors in some cases 
This happened using APIs like `Stream.first` that set cancelOnError when
they called `Stream.listen()`. If an error is signaled, Stream internals
will call `cancel()` and wait for that future to complete before sending
the error to the resulting Future. However the `async*` implementation
class did not properly account for that possiblity, and never completed
the cancellation future in that case.

Change-Id: Ieaa35e56ee80208d7946904ea40bfd5f785ef9d6
Reviewed-on: https://dart-review.googlesource.com/c/83467
Commit-Queue: Alan Knight <alanknight@google.com>
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Alan Knight <alanknight@google.com>
 2018-11-08 05:04:23 +00:00
Ben Konyi 4e2c5bcece [ VM / Gardening ] Added better failure conditions to http_loopback_test 
Change-Id: I10b62723e67fd86b6e010de05e9232f7a10c187b
Reviewed-on: https://dart-review.googlesource.com/c/82714
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-11-08 01:58:20 +00:00
Dan Field 50418e07a1 Fix multicast_ttl patch for windows - previous patch made incorrect 
call for setsockopt on Windows machines.


collapse if block


move raw_datagram_socket_test to standalone_2


update test, check for success


fix windows


Fix bug in TTL logic for IPv6

Change-Id: I7940e2e1a3c355ebef752f951464e5ade96d2153
Reviewed-on: https://dart-review.googlesource.com/c/83360
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-11-07 18:26:04 +00:00
Paul Berry be7983e148 Merge commit 'c24073f442e7c7b789894ad8210aff8accc36702' into analyzer 2018-11-07 07:37:12 -08:00
Martin Kustermann e17960cee3 [Gardening] Mark co19 test as flaky and filed issue 
Issue https://github.com/dart-lang/co19/issues/186

Change-Id: Id15b08a4d1483431a8f8b2ad0224e0d672d61878
Reviewed-on: https://dart-review.googlesource.com/c/83387
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2018-11-07 12:46:59 +00:00
Martin Kustermann 3f585d1b78 [Gardening] Mark language_2/vm/mult_int_test as failing on windows-dartkp-simarm64 
Issue https://github.com/dart-lang/sdk/issues/35091

Change-Id: I129c05994223fc5067ec720290fff9cc317f8bb4
Reviewed-on: https://dart-review.googlesource.com/c/83386
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2018-11-07 12:13:48 +00:00
Martin Kustermann 660f64ed6b [Gardening] Mark test as flaky, reference existing co19 issue 
Issue https://github.com/dart-lang/co19/issues/184

Change-Id: I20f08b6e494ca50b17d78d25ff422fd34153ef89
Reviewed-on: https://dart-review.googlesource.com/c/83384
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2018-11-07 11:47:55 +00:00
Sergey G. Grekhov 7df494cecc [co19] DEPS updated to the latest co19_2 commit 
Change-Id: I8e37c6dc29dc5ee00525364bfdb6eaee02a37416
Reviewed-on: https://dart-review.googlesource.com/c/82202
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-11-07 08:30:38 +00:00
Jenny Messerly fceae8524d [dartdevc] fix #34531, optimize covariance checks in the kernel backend 
This is similar to the analyzer backend's optimization for fields, but
it also supports private methods and accessors.

Also fixes #34769, checks were missing for explicit covariant fields
and those are now generated (this is for fields of the form
`covariant SomeType fieldName`--implicitly covariant fields in generic
classes were already checked correctly).

Change-Id: I5ce3ed7944bdc5a9799c731c5f95e199b461b079
Reviewed-on: https://dart-review.googlesource.com/c/79432
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Commit-Queue: Alan Knight <alanknight@google.com>
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Alan Knight <alanknight@google.com>
 2018-11-07 01:56:35 +00:00
Ben Konyi fbe3b1ebc0 Reland "[ VM / Mirrors ] Added type checking to enforce strong mode semantics when using dart:mirrors" 
Was reverted to temporarily fix issue #35009 for 2.1.

This reverts commit 65ffd0f7190f04dd0a8f94b7941e1ab706b0b084.

Change-Id: I71fe094b24f882cd942634557c9c43af06058842
Reviewed-on: https://dart-review.googlesource.com/c/83226
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-11-06 23:59:29 +00:00
Ben Konyi 9c95624a63 Temporary revert to fix issue #35009 for 2.1. package:rpc relies on mirrors behaviour that is not valid for Dart 2, so these type checks cause the package to crash. 
Revert "[ VM / Mirrors ] Added type checking to enforce strong mode semantics when using dart:mirrors"

This reverts commit 9f00eec55b.

Change-Id: I82ce07d388ba9402f20caf700815b39c9bc418f6
Reviewed-on: https://dart-review.googlesource.com/c/83225
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-11-06 23:59:11 +00:00
Paul Berry 8b87e73428 Merge commit 'f7dab643ff254ead592d7bd038d858ebc9f2570c' into analyzer 2018-11-06 15:16:04 -08:00
Paul Berry 4b1870307d Merge commit '8d12600b16bcc9ae113c47fb6a3d5b68b1388c5c' into analyzer 2018-11-06 14:59:15 -08:00
Konstantin Shcheglov c39df1b6db Issue 34495. Change the way unexpected elements are handled in pushInstanceCreation() of expression builder. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/34495
Change-Id: I4b56b274d33e2a274de564d3dd78f592e482e660
Reviewed-on: https://dart-review.googlesource.com/c/83200
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-11-06 22:45:42 +00:00
Konstantin Shcheglov ed03883d76 Issue 35043. Fix type instantiation for implicit new. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/35043
Change-Id: Iaff74f25cb8bb3bfea5412892932dac46157c146
Reviewed-on: https://dart-review.googlesource.com/c/83061
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-06 22:38:28 +00:00
Paul Berry 5dc2156ba4 Cherry-pick be815e1a86 to analyzer branch 
Original commit message:

    [dartdevc] fix #35013, move DDC off Analyzer task model

    The new file pkg/dev_compiler/lib/src/analyzer/driver.dart handles
    building the linked summary for a build unit, and then is capable of
    doing analysis using LibraryAnalyzer.

    The algorithm is very similar to analyzer_cli's build mode. The
    biggest difference is that `dartdevc` has existing support for
    discovering source files from the explicit source list (rather than
    requiring every source to be listed on the command line). We don't want
    to break that support, so there's a bit of logic to follow imports,
    exports, and parts.

    After the linked summary is produced, DDC gets the analysis results
    (errors and resolved AST) for each library, and compiles it into a JS
    module.

Change-Id: I8d1855c27f9976cad6fd9ccb567b75a613e6048c
Reviewed-on: https://dart-review.googlesource.com/c/83060
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-11-06 21:43:42 +00:00
Ryan Macnak f8c89e0d20 [vm] Allow disabling concurrent mark separately from parallel mark. 
Bug: https://github.com/dart-lang/sdk/issues/34002
Bug: https://github.com/dart-lang/sdk/issues/35029
Change-Id: I3babfd1b8892da5b137f4e093901479797eccfc9
Reviewed-on: https://dart-review.googlesource.com/c/82945
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-11-06 21:00:28 +00:00
Paul Berry 57a119efed Merge commit 'd15026832117ca77a282f72cd6d7b3ab4c5fdf05' into analyzer 
Conflicts:
	pkg/analyzer/lib/src/lint/linter.dart
 2018-11-06 10:28:35 -08:00
Konstantin Shcheglov 6906ce3964 Issue 33553. Don't report ABSTRACT_SUPER_MEMBER_REFERENCE if the nominal superclass has noSuchMethod(). 
Bug: https://github.com/dart-lang/sdk/issues/33553
Change-Id: I37ef61ed57d5a479771c7e76a78f7f6fcb99e28b
Reviewed-on: https://dart-review.googlesource.com/c/82947
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-06 16:41:37 +00:00
Samir Jindel e190719e04 [vm] Fix typo in status file update. 
Change-Id: I59acedc511194a2f7c8b49ccb25024aa9795cf6e
Reviewed-on: https://dart-review.googlesource.com/c/83000
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2018-11-06 15:03:29 +00:00