dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

50 Commits

Author SHA1 Message Date
Nicholas Shahan 86c7165969 [tests] Avoid use of $strong because it is always true now 
* Remove all `&&  $strong` clauses.
* Delete all sections that include a `&& !$strong` clause.

Change-Id: Idd32cf5623793e3f98e3e998025bac079d88e2f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102223
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2019-05-16 17:41:27 +00:00
Daniel Hillerström de984e58cb Type checking for redirecting factories. 
Implements static semantics for redirecting factories (c.f. §10.6.2 of
the specification). This CL does not include inference of actual type
arguments on redirectees, that is it does not handle the case where
type arguments have been omitted on the redirectee as in this
following example program:

  class A<T> {
    factory A() = B;
  }
  class B<T> implements A<T> {
    B();
  }

Closes https://github.com/dart-lang/sdk/issues/32988.

Also resolves the second part of
https://github.com/dart-lang/sdk/issues/30579.

Can possibly also close https://github.com/dart-lang/sdk/issues/11578.

Change-Id: I5f1fb60510ba6cdc917321239819c1f817b5b85d
Reviewed-on: https://dart-review.googlesource.com/74580
Commit-Queue: Daniel Hillerström <hillerstrom@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-09-19 06:20:20 +00:00
Lasse Reichstein Holst Nielsen 72e6353c32 Make Stream.fromIterable handle errors in current and send a done. 
The code didn't handle `iterator.current` throwing, and it didn't send a done
event after `iterator.moveNext()` throws.

Fixes #33431.

Bug: http://dartbug.com/33431
Change-Id: Ic8f7b5d52793ea3db30480e7aa69d01a86e93772
Reviewed-on: https://dart-review.googlesource.com/63841
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-08-27 08:06:54 +00:00
Zach Anderson d0510501d2 [build] Add -a kbc for interpreter 
This CL adds support to build.py and test.py for building/testing
a VM with the interpreter on x64, e.g.:

$ ./tools/gn.py -m release -a x64 --bytecode
$ ./tools/build.py -m release -a x64 --bytecode runtime
$ ./tools/test.py -m release -a x64 -r vm -c dartkb language_2

Change-Id: I956d23790636609d4a2e71129481fcbd7afef9a0
Reviewed-on: https://dart-review.googlesource.com/65206
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-07-17 21:51:41 +00:00
Jenny Messerly c8f8190444 fix #33330, sync async functions should complete their future async 
This was difficult to observe in practice, as it required a combination
of two unlikely things:

- an `async` function with no awaits
- a custom Zone with side-effecting scheduleMicrotask callback

The new implementation matches dart2js and the Dart VM's behavior.

Change-Id: I4ff275f37aa93d23643481f00c33aeacb7138b01
Reviewed-on: https://dart-review.googlesource.com/58980
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-06-29 02:06:51 +00:00
Florian Loitsch 398ba13e4a Reapply "Make --sync-async the default for the VM." 
Change-Id: I6e4da0da6c3f635d84380b384ae17fbb55587895
Reviewed-on: https://dart-review.googlesource.com/58721
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
 2018-06-06 14:32:13 +00:00
Ryan Macnak 53f7bb175e Revert "Make --sync-async the default for the VM." 
This reverts commit 1ddf553eb6.

Reason for revert: Failing service tests

Original change's description:
> Make --sync-async the default for the VM.
> 
> Change-Id: Ic6d7bbc27835ea7b197cccf05724adb99e95dd51
> Reviewed-on: https://dart-review.googlesource.com/57580
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=vegorov@google.com,kustermann@google.com,floitsch@google.com

Change-Id: I062cb40badf0d1cf1808bee152fdd4074b00179d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/58380
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-06-04 21:04:20 +00:00
Florian Loitsch 1ddf553eb6 Make --sync-async the default for the VM. 
Change-Id: Ic6d7bbc27835ea7b197cccf05724adb99e95dd51
Reviewed-on: https://dart-review.googlesource.com/57580
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-06-04 18:05:20 +00:00
Alexander Thomas 2a3d1dc9ed [vm] Prepare status for app_jitk builders (#33126) 
Change-Id: Iec5347b5f091b9fd6ff3c24047b011527f8b08ee
Reviewed-on: https://dart-review.googlesource.com/56802
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-05-29 11:43:25 +00:00
Martin Kustermann 24224ced5b [VM] Update status file, test became much slower after strong-mode changes to mirrors implementation 
Issue https://github.com/dart-lang/sdk/issues/33057

Change-Id: I02785f43fd16f4396de770972a4e64d64500ea80
Reviewed-on: https://dart-review.googlesource.com/54404
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-05-09 13:33:03 +00:00
Alexander Thomas 3851591642 [infra] Keep comments intact when updating status files. 
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.

Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-04-10 19:03:21 +00:00
Peter von der Ahé f07534c36e Update status files for implicit new and const 
Change-Id: Ie71464c1c83ec9516d178640fdd745705588f410
Reviewed-on: https://dart-review.googlesource.com/35940
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-19 15:26:25 +00:00
Bob Nystrom a53e4dd504 Finish migrating stuff out of lib_strong. 
Some of these are data files that weren't picked up by the migration
script. Some are files that slipped between blocks of tests.

Change-Id: I184dc4701758b280444d54ec55c225ade30f3276
Reviewed-on: https://dart-review.googlesource.com/26423
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2017-12-11 23:45:23 +00:00
Morten Krogh-Jespersen 3db4b1070b Normalize all status files and enable presubmit hook. 
This CL normalizes all status files by the status file normalizer found at
pkg/status_file/bin/normalize.dart.

To make sure all status files are kept in pristine condition, a linter is placed
on the presubmit hook. The linter can be found at pkg/status_file/bin/lint.dart.

Bug:
Change-Id: I20bdb74824be65f079b8c9ab08b7ae38394d637f
Reviewed-on: https://dart-review.googlesource.com/24112
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-12-07 08:38:30 +00:00
Vijay Menon 416b55437a Limit renaming on external members 
Fixes #31489

Change-Id: Iece82eaf0bcd83dfc6f2335214b084b0d9e06de0
Reviewed-on: https://dart-review.googlesource.com/25180
Reviewed-by: Jacob Richman <jacobr@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2017-12-05 16:17:12 +00:00
Morten Krogh-Jespersen a9a5081e10 Remove duplicate entries in same section from status files. 
If two sections are syntactically equal, they are considered same section.

The discovery of duplicate entries was perfomed by the test in the CL:
https://dart-review.googlesource.com/#/c/sdk/+/21341

All removals has been done by hand to make sure the best comment was chosen.

Bug:
Change-Id: I105f6375adc1b5f555eb7c2af7d7d1e4e1922a32
Reviewed-on: https://dart-review.googlesource.com/21340
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-11-27 11:07:18 +00:00
Sigmund Cherem af814e27db Normalize lib_2 status files. 
All entries affecting dartk* are in lib_2_kernel.status

Change-Id: I10fda8747a514aabffcf6ecffd62db3b32df59a8
Reviewed-on: https://dart-review.googlesource.com/21561
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-11-17 01:14:38 +00:00
Bob Nystrom 307742d07e Move tests from package "test" (back) to "unittest". 
Since unittest is known to work with test.dart as a test runner and is
strong mode clean, it's a safer bet than test.

Change-Id: Id120d4f871827b1f131dff2a5ef2f7efb15a8382
Reviewed-on: https://dart-review.googlesource.com/12125
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-10 19:46:12 +00:00
Ben Konyi b4d5cbda31 Migrated test block 191 to Dart 2.0. 
WIP.

Fixed status file migration issues for html and isolate directories.

Bug:
Change-Id: Id84c7ee89a7eb283d3202f3018d008cede0fda56
Reviewed-on: https://dart-review.googlesource.com/4920
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-10-03 21:54:44 +00:00
Terry Lucas e61c567d7b Re-Migrate Block 192 and 193 to original unittest usage and re-run migration tool to move over *.html files too. 
R=bkonyi@google.com

Change-Id: I7cb8019c7b6881b09b52333a0457744f877f7aa0
Reviewed-on: https://dart-review.googlesource.com/7780
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-09-26 18:44:04 +00:00
Ben Konyi 2f0e925f56 Migrated test block 230 to Dart 2.0. 
Bug:
Change-Id: I254b96ad69961c4ecf7fd567edabd6d584a0d757
Reviewed-on: https://dart-review.googlesource.com/7583
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2017-09-21 23:39:49 +00:00
Ben Konyi fe01ec1d12 Migrated test block 179 to Dart 2.0. 
Some changes were required to stream_transformer_test to make it strong
mode clean. Other minor changes involved migrating from unittest->test.

Bug:
Change-Id: Ia21144090710137e4803c651cf9e3fd62e17f5f7
Reviewed-on: https://dart-review.googlesource.com/3707
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-20 19:29:01 +00:00
Terry Lucas c759ea8e69 More generally prevent HTML test from running in the VM. 
TBR=bkonyi@google.com

Change-Id: I132829a9597ad218b6503aeda16eb0cd236e3cf3
Reviewed-on: https://dart-review.googlesource.com/6261
Reviewed-by: Terry Lucas <terry@google.com>
 2017-09-15 19:40:43 +00:00
Terry Lucas 64fb95ffa2 Skip HTML test for all VM tests 
TBR=bkonyi@google.com

Change-Id: Ib912a4965691eee380ffc6ad0cd3e88042f2bdd4
Reviewed-on: https://dart-review.googlesource.com/6162
Reviewed-by: Terry Lucas <terry@google.com>
 2017-09-15 16:01:11 +00:00
Terry Lucas 303e06be4c Migrated test block 189 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I178251eea656777f8414cf2573f2bd146cdbab24
Reviewed-on: https://dart-review.googlesource.com/5920
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-15 14:19:50 +00:00
Ben Konyi 66a18d7e69 Migrated test block 174 to Dart 2.0. 
Minor changes to a couple of tests to fix strong mode issues.

Bug:
Change-Id: I0d8298c750b0f8c3c332019fee826548e5700843
Reviewed-on: https://dart-review.googlesource.com/3688
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-14 23:33:28 +00:00
Ben Konyi a061a49e07 Migrated test block 175 to Dart 2.0. 
Migrated stream_periodic* tests from unittest->test. Otherwise, simple
block.

Bug:
Change-Id: I99d59949ef5031513efd126303988da43d6f07cb
Reviewed-on: https://dart-review.googlesource.com/3702
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-14 22:07:28 +00:00
Ben Konyi 3cd31ff7c5 Migrated test block 221 to Dart 2.0. 
No changes made to tests.

Bug:
Change-Id: Ibb385452ad7b892d4993325359d5bdd3f92d875f
Reviewed-on: https://dart-review.googlesource.com/3743
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2017-09-13 22:46:48 +00:00
Ben Konyi b481cff9a5 Migrated test block 228 to Dart 2.0. 
No major changes.

Bug:
Change-Id: I8d9f90e442fb71e635f8319634e94a52098a56d1
Reviewed-on: https://dart-review.googlesource.com/3790
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2017-09-13 21:29:28 +00:00
Jaime Wren e160f89499 Migrated test block 215 to Dart 2.0 
Change-Id: Idea1235650b94fc77455cd46297803d3a169a791
Reviewed-on: https://dart-review.googlesource.com/3708
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2017-09-13 19:13:19 +00:00
Ben Konyi 5b60e5841d Migrated test block 222 to Dart 2.0. 
Minor changes to a few tests, no major refactors.

Bug:
Change-Id: I66c00b6465597a3534071f8d70c4718f209d5e6e
Reviewed-on: https://dart-review.googlesource.com/3787
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-13 02:05:02 +00:00
Ben Konyi ddf2987ed7 Migrated test block 180 to Dart 2.0. 
Small changes were required for zone_debug_test to become strong mode
clean.

Bug:
Change-Id: I5ef52d7d116dd25793117511d8ee1904a172c014
Reviewed-on: https://dart-review.googlesource.com/3740
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-11 13:52:19 +00:00
Ben Konyi 7530b4b7ba Migrated test block 176 to Dart 2.0. 
No major changes other than moving tests from unittest->test.

Bug:
Change-Id: Icc9935da0072fc11c54e42a369792fe2748323de
Reviewed-on: https://dart-review.googlesource.com/3703
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-11 13:20:14 +00:00
Ben Konyi 72df7029fb Migrated test block 177 to Dart 2.0. 
Minor changes, all related to moving from unittest->test.

Bug:
Change-Id: Ie85eccf43c775211cf9d1eb58417ec3b3cc7f9a5
Reviewed-on: https://dart-review.googlesource.com/3704
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-09 01:44:40 +00:00
William Hesse 93f255db7d Migrated test block 172 
Author: bkonyi@google.com

Migrated test block 172 to Dart 2.0 and rolled forward package:test to 0.12.24+2 to fix issues with testing streams.

Migrated stream_controller_async from unittest->test.

This is a duplicate copy of CL https://dart-review.googlesource.com/c/sdk/+/3685/ rebased, with merge conflict resolved.
Bug:
Change-Id: I56e8ef24c74dfccbda10800541d6916053d8c931
Reviewed-on: https://dart-review.googlesource.com/4621
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-09 00:18:53 +00:00
Ben Konyi 8f63a56c59 Migrated test block 178 to Dart 2.0. 
Migrated tests from unittest->test, updated status files for tests that
are now passing.

Bug:
Change-Id: Ie116d2e39ba472c6c0ae8dec9d6ba100364a6bcc
Reviewed-on: https://dart-review.googlesource.com/3706
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-08 23:35:54 +00:00
Ben Konyi 86bfc03a09 Migrated test block 225 to Dart 2.0. 
No major changes.

Bug:
Change-Id: Ib51de4db72d8e63d5824d772e3c9971f085c75dd
Reviewed-on: https://dart-review.googlesource.com/3785
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2017-09-08 21:58:43 +00:00
Ben Konyi 81ef1a9818 Migrated test block 223 to Dart 2.0. 
Updated invoke_call_through* tests to make them strong mode clean, which
mostly involved changing var -> dynamic in some places.

Bug:
Change-Id: I3ac946bdfadd09d6459c7f104068be4cb0c49c1d
Reviewed-on: https://dart-review.googlesource.com/3781
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2017-09-08 18:23:41 +00:00
Florian Loitsch 4443c34512 Migrate dart:convert tests from test block 188. 
Change-Id: I99e796a6793ab76c0f9d0c7c37377a97bb5102fd
Reviewed-on: https://dart-review.googlesource.com/3061
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-08 14:39:47 +00:00
Florian Loitsch 7c83d5ced6 Migrate test block 186. 
Change-Id: I5ff48ecdcba4b12280ecf76c53a6cc7f12dabfbf
Reviewed-on: https://dart-review.googlesource.com/3005
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-08 10:18:50 +00:00
Jakob Roland Andersen 05f0ce4aa9 Migrate test batch 227 to Dart 2.0 
Bug:
Change-Id: I34c57e58c08c1137c1bf517953dd204fa351aa09
Reviewed-on: https://dart-review.googlesource.com/3882
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-08 09:57:16 +00:00
Florian Loitsch 6d09d02a64 Migrate test block 184. 
Change-Id: Id6b51f0367e886b0c81d9899423a9525f2cd6a60
Reviewed-on: https://dart-review.googlesource.com/3040
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-06 08:48:51 +00:00
Ben Konyi adfc7a6b72 Migrated test lock 217 to Dart 2.0. 
Fairly simple block, with only minor changes made to lib_2/mirrors tests
needed for strong mode compliance.

BUG=

Review-Url: https://codereview.chromium.org/2997283003 .
 2017-08-31 07:47:36 -07:00
Ben Konyi 002ebba6f4 Migrated test block 216 to Dart 2.0. 
No changes made to this block.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2995343002 .
 2017-08-31 07:02:53 -07:00
Ben Konyi 64105ee014 Migrated test block 219 to Dart 2.0. 
No major changes. Some tests that rely on noSuchMethod needed to have
some 'var's changed to 'dynamic's.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/3003123002 .
 2017-08-30 07:51:59 -07:00
Ben Konyi d08e59e09c Migrated test block 171 to Dart 2.0. 
R=rnystrom@google.com

Moved schedule_microtask[2,3,5]_test off of package:test to
package:async_helper and package:expect.
Review-Url: https://codereview.chromium.org/3001793002 .
 2017-08-30 06:46:35 -07:00
Ben Konyi 0ea752b5bf Relanding test block 170 migration. 
"Migrated test block 170 to Dart 2.0.""

This reverts commit 201df65b50201f023a1db5bb26bea7b8976c3b32.

Review-Url: https://codereview.chromium.org/3005813002 .
 2017-08-29 16:22:07 -07:00
Ben Konyi e8b337f08f Revert "Migrated test block 170 to Dart 2.0." 
This reverts commit 6e6b0cadea9adbb48556384fac52b17c2ac15443.
 2017-08-29 15:37:15 -07:00
Ben Konyi a7b19c1b47 Migrated test block 170 to Dart 2.0. 
Updated status file to account for strange failure in package:test when
running multiple_timer_test on dartdevc.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2995013002 .
 2017-08-29 15:25:42 -07:00
Ben Konyi 42d354c91d Migrated test block 168 to Dart 2.0. 
This block felt trickier than others, mostly due to random errors that I
wasn't able to find a cause for. Tests that I'm uncertain about are:
-first_regression_test
-future_timeout_test
-future_or_bad_type_test/implements

These all have status entries to prevent failures, but I think these
tests need another set of eyes.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2999943002 .
 2017-08-21 00:59:34 -07:00