dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

32 Commits

Author SHA1 Message Date
Nicholas Shahan 939597863b [dartdevc] Move html/debugger_test.dart to compiler/dartdevc_native 
Allows the dart:_debugger import to work as it is white-listed in this
directory.

Reveals that DDK is not passing this test. The status changes from a
compile-time to a run-time error.

Change-Id: I3703496a4ede7d155a4d82286040f1a73be677ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106360
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-06-19 17:48:56 +00:00
Daniel Hillerström de984e58cb Type checking for redirecting factories. 
Implements static semantics for redirecting factories (c.f. §10.6.2 of
the specification). This CL does not include inference of actual type
arguments on redirectees, that is it does not handle the case where
type arguments have been omitted on the redirectee as in this
following example program:

  class A<T> {
    factory A() = B;
  }
  class B<T> implements A<T> {
    B();
  }

Closes https://github.com/dart-lang/sdk/issues/32988.

Also resolves the second part of
https://github.com/dart-lang/sdk/issues/30579.

Can possibly also close https://github.com/dart-lang/sdk/issues/11578.

Change-Id: I5f1fb60510ba6cdc917321239819c1f817b5b85d
Reviewed-on: https://dart-review.googlesource.com/74580
Commit-Queue: Daniel Hillerström <hillerstrom@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-09-19 06:20:20 +00:00
Devon Carew 87bbceb3f1 More cleanup of analyzer status file predicates. 
Change-Id: I047be4db04227d406ade3f206478d382e810cdd4
Reviewed-on: https://dart-review.googlesource.com/72063
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-08-29 22:48:29 +00:00
Aske Simon Christensen f8a96b88e9 It is an error if a final field is not initialized. 
Bug: https://github.com/dart-lang/sdk/issues/33022

This commit adds an error when a final field is not initialized at all
(and there is at least one generative constructor). A later commit
will add an error for the case where a field is initialized by some,
but not all, generative constructors.

A number of classes in the Dart2js and DDC support libraries use
uninitialized final fields to indicate getters in the corresponding
native classes. This commit adds a temporary whitelist for the
affected files, which can be removed when the fields have been
replaced by external getters.

This is tracked by https://github.com/dart-lang/sdk/issues/33762

Change-Id: I6b5cee230c7cd5554da2b61da7ebddb6b0b9396e
Reviewed-on: https://dart-review.googlesource.com/63781
Reviewed-by: Daniel Hillerström <hillerstrom@google.com>
 2018-08-17 12:37:52 +00:00
Devon Carew 6a4f1b76ac Remove the --preview-dart-2 option from dartanalyzer and the analysis server. 
Change-Id: I268b9d5f79b30d0e4a0f8e6bb81a7738c98e5eea
Reviewed-on: https://dart-review.googlesource.com/69802
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-08-14 04:24:47 +00:00
Devon Carew 6dfc4ef663 Remove old dart2analyzer not strong status file entries. 
Change-Id: I8e7775ce9a3d6fd14ee9d1b9d79be2f6df23cd01
Reviewed-on: https://dart-review.googlesource.com/63801
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-07-07 04:14:20 +00:00
Ryan Macnak 1e28b8987d [vm] Reify even more generics in the mirrors implementation to appease Dart 2. 
Bug: https://github.com/dart-lang/sdk/issues/33091
Bug: https://github.com/dart-lang/sdk/issues/33098
Change-Id: Ibecce1274b9bda47e387d109a29a5af4d53adb7f
Reviewed-on: https://dart-review.googlesource.com/54704
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2018-05-11 19:18:49 +00:00
Janice Collins 1afe71c08a Enable preview-dart-2 as default for analyzer. 
Based on https://dart-review.googlesource.com/c/sdk/+/52340, but adds
the necessary plumbing through the test system to pass through
negations to strong and preview-dart-2.  Also adds support for those
negations to the analyzer.

Change-Id: I9793ff28bb593d25bbb0a2ed8736b5b53e0a62d8
Reviewed-on: https://dart-review.googlesource.com/52461
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-26 17:01:12 +00:00
Brian Wilkerson 9e9b50d19d Improve error messages for annotations involving undefined names (issue 27788) 
Change-Id: Iccfcb73b7671f50353b57a81817dec013b997a53
Reviewed-on: https://dart-review.googlesource.com/52640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-25 17:48:49 +00:00
Alexander Thomas 3851591642 [infra] Keep comments intact when updating status files. 
* Preserve empty lines in the file header.
* Add empty entry to the tool's newly created sections.
* Remove extra empty line at the end of the file.

Change-Id: I271583774d5f5497025a9d85bcadf8b0b9e39e81
Reviewed-on: https://dart-review.googlesource.com/37600
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2018-04-10 19:03:21 +00:00
Terry Lucas ef6273cba0 Dart Web Libraries re-generated based on Chrome 63 WebIDLs. 
This is a migration of 13 Chrome release about 1.5 years of Chrome releases.
Update PYTHON scripts for cleaner and easier rolling.

Here's a doc on the changes that might affect Dart users:
https://docs.google.com/document/d/1Kj0nk3SueO3JKub8im7z3znu9j5oiI7vf49ejZrMxuE/edit#

Change-Id: I768fbd09b04fe6884af36ac102d5813f67bae426
Reviewed-on: https://dart-review.googlesource.com/24501
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-03-18 09:41:04 +00:00
Paul Berry 440b58d644 Start running analyzer tests with --preview-dart-2. 
The changes to the CQ bot should take effect immediately.  The changes
to the other bots will take effect once those bots are switched over
to use the test matrix.

Change-Id: Ibfe59817a11f730fd1847cdc60b3244b4a71a480
Reviewed-on: https://dart-review.googlesource.com/45300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-03-07 15:04:33 +00:00
Peter von der Ahé f07534c36e Update status files for implicit new and const 
Change-Id: Ie71464c1c83ec9516d178640fdd745705588f410
Reviewed-on: https://dart-review.googlesource.com/35940
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-19 15:26:25 +00:00
Bob Nystrom a53e4dd504 Finish migrating stuff out of lib_strong. 
Some of these are data files that weren't picked up by the migration
script. Some are files that slipped between blocks of tests.

Change-Id: I184dc4701758b280444d54ec55c225ade30f3276
Reviewed-on: https://dart-review.googlesource.com/26423
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2017-12-11 23:45:23 +00:00
Morten Krogh-Jespersen 3db4b1070b Normalize all status files and enable presubmit hook. 
This CL normalizes all status files by the status file normalizer found at
pkg/status_file/bin/normalize.dart.

To make sure all status files are kept in pristine condition, a linter is placed
on the presubmit hook. The linter can be found at pkg/status_file/bin/lint.dart.

Bug:
Change-Id: I20bdb74824be65f079b8c9ab08b7ae38394d637f
Reviewed-on: https://dart-review.googlesource.com/24112
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-12-07 08:38:30 +00:00
Terry Lucas 83ff87e4a3 Migrated Block 204 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I032f25969e75fb9966222da969e73a665bf35f44
Reviewed-on: https://dart-review.googlesource.com/12321
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-10-10 13:00:01 +00:00
Terry Lucas 0beb87c853 Migrated Block 197 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ic5ab3a1a5f300cc6df757ea03119595eac9dafc2
Reviewed-on: https://dart-review.googlesource.com/11340
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 10:46:21 +00:00
Terry Lucas 7f09d591fd Fix failure in analyzer w/o strong mode. 
TBR=bkonyi@google.com

Change-Id: I6b6faf3117a605793c056c02e1db7dd407f841fe
Reviewed-on: https://dart-review.googlesource.com/11346
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-10-05 04:55:05 +00:00
Terry Lucas 7f137ca921 Migrated Block 194 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I4e77f837a26d37e2d8f650c941f72454e6536b8d
Reviewed-on: https://dart-review.googlesource.com/8737
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 04:19:10 +00:00
Jakob Roland Andersen 0955c0ca9e Migrated test batch 211 to Dart 2.0. 
Bug:
Change-Id: Iee8198332fd94ef708eab1aa34867c5d68054c6a
Reviewed-on: https://dart-review.googlesource.com/10420
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-04 21:27:40 +00:00
Jakob Roland Andersen 07dfe1f802 Migrated test batch 205 to Dart 2.0. 
Bug:
Change-Id: I2bbcab02d7757f97f4ffdb2f74b7123def16af47
Reviewed-on: https://dart-review.googlesource.com/8861
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-28 08:27:49 +00:00
Terry Lucas 4d6e20bb8d Move failure and fix failure type. 
R=pquitslund@google.com

Change-Id: Id7b90c55a8b6912d04e85f3ddd3b2b6895f13b86
Reviewed-on: https://dart-review.googlesource.com/8725
Reviewed-by: Terry Lucas <terry@google.com>
 2017-09-26 20:58:43 +00:00
Terry Lucas 34b656894a Disabled HTML tests on VM and flag analyzer error too. 
TBR=bkonyi@google.com

Change-Id: Ic452b345e7265db1a2c2a263e73802901302b2b0
Reviewed-on: https://dart-review.googlesource.com/8723
Reviewed-by: Terry Lucas <terry@google.com>
 2017-09-26 20:22:24 +00:00
Terry Lucas e61c567d7b Re-Migrate Block 192 and 193 to original unittest usage and re-run migration tool to move over *.html files too. 
R=bkonyi@google.com

Change-Id: I7cb8019c7b6881b09b52333a0457744f877f7aa0
Reviewed-on: https://dart-review.googlesource.com/7780
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-09-26 18:44:04 +00:00
Ben Konyi 2f0e925f56 Migrated test block 230 to Dart 2.0. 
Bug:
Change-Id: I254b96ad69961c4ecf7fd567edabd6d584a0d757
Reviewed-on: https://dart-review.googlesource.com/7583
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2017-09-21 23:39:49 +00:00
Erik Ernst cf01c459f3 Updated tests for new treatment of init.formal type annotations 
Adjusted lib_2/mirrors/initializing_formals_test.dart to match new rule
for static checking on type annotations of initializing formals.

Added language_2/initializing_formals_type_annotation_test.dart to
check the 4 main situations directly.

Change-Id: Icf763c79c99274645f7967b8c3e3a3c3f6536763
Reviewed-on: https://dart-review.googlesource.com/7268
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2017-09-21 07:34:58 +00:00
Terry Lucas 358b62cd77 Migrated block 192 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I742f39564a8faf2ddf76817b4e493909d141f49c
Reviewed-on: https://dart-review.googlesource.com/6083
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-17 20:24:40 +00:00
Ben Konyi 3cd31ff7c5 Migrated test block 221 to Dart 2.0. 
No changes made to tests.

Bug:
Change-Id: Ibb385452ad7b892d4993325359d5bdd3f92d875f
Reviewed-on: https://dart-review.googlesource.com/3743
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2017-09-13 22:46:48 +00:00
Ben Konyi 5b60e5841d Migrated test block 222 to Dart 2.0. 
Minor changes to a few tests, no major refactors.

Bug:
Change-Id: I66c00b6465597a3534071f8d70c4718f209d5e6e
Reviewed-on: https://dart-review.googlesource.com/3787
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-13 02:05:02 +00:00
Jakob Roland Andersen 31d5dc1986 Migrate test batch 231 to Dart 2.0 
Bug:
Change-Id: I8a5659dfd76baa3b16e3570e410c262c14e3ded1
Reviewed-on: https://dart-review.googlesource.com/4021
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-08 12:59:34 +00:00
Jakob Roland Andersen 05f0ce4aa9 Migrate test batch 227 to Dart 2.0 
Bug:
Change-Id: I34c57e58c08c1137c1bf517953dd204fa351aa09
Reviewed-on: https://dart-review.googlesource.com/3882
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-08 09:57:16 +00:00
Ben Konyi 64105ee014 Migrated test block 219 to Dart 2.0. 
No major changes. Some tests that rely on noSuchMethod needed to have
some 'var's changed to 'dynamic's.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/3003123002 .
 2017-08-30 07:51:59 -07:00