dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

28 Commits

Author SHA1 Message Date
Lasse R.H. Nielsen 671865cd1a Fix JSON parser. 
JSON parser was not rewritten when integers became fixed-size, so
some large integers could overflow silently and give the wrong
result, as could some doubles where the pre-decimal point digits
overflowed an `int`. Also added overflow protection for exponent.

Change-Id: I02941272c36fba4b9226e324936aebd4a5c5aa3b
Reviewed-on: https://dart-review.googlesource.com/c/91521
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-02-13 11:06:35 +00:00
Kevin Moore 7a3762d4a9 Fixes for convert tests 
- remove unused variables
- use expanded test cases that were skipped with a mistyped variable
- Fix unintended string concat

Change-Id: I9bdfad6d31655261b378f878f36f4d07b2f64fe4
Reviewed-on: https://dart-review.googlesource.com/c/75789
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-10-19 15:00:28 +00:00
G?nter Z?chbauer 2da0b9f4f1 fix some typos 
Closes #34738
https://github.com/dart-lang/sdk/pull/34738

GitOrigin-RevId: d211bbacfe65355cf7304c990ffb6c79d7a229cf
Change-Id: If690e6d378e543b300e1f6a353ceae73e39c29db
Reviewed-on: https://dart-review.googlesource.com/c/78900
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-10-10 19:15:30 +00:00
Lasse R.H. Nielsen 6bc7288e70 Fix fused UTF-8/JSON decoding. 
The VM version's parser did not allow a leading BOM, and it failed to parse a top-level integer.

Added test to check this.

Fixes #33251

Bug: http://dartbug.com/33251
Change-Id: I51e429082f0e9baac81e20f73b0885922b40b0b8
Reviewed-on: https://dart-review.googlesource.com/56860
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2018-05-29 12:34:25 +00:00
Lasse R.H. Nielsen 2eeea7bc30 Remove more usages of upper-case constants in SDK 
Change-Id: I4e54ed7eba5f2af7852faba2cffae12f28e618cf
Reviewed-on: https://dart-review.googlesource.com/51844
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-04-19 13:31:57 +00:00
Lasse R.H. Nielsen 973a1a0219 Remove uses of upper-case constants in remaining SDK code. 
This includes Fasta, tools and observatory, so the checked-in SDK must
have the lower-case constants.

Change-Id: I8380ad041ad058f7d02ae19caccfecd434d13d75
Reviewed-on: https://dart-review.googlesource.com/50201
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-04-16 16:11:57 +00:00
Lasse Reichstein Holst Nielsen 414a3318ea Add jsonDecode, jsonEncode, base64Decode, base64Encode, base64UrlEncode functions. 
Change-Id: Ic65ada3b107cc8e6c3459459c4bea389feef2168
Reviewed-on: https://dart-review.googlesource.com/23664
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-03-12 09:16:27 +00:00
Leaf Petersen 6b3576f673 Fix fuzzy arrow issues in tests. 
Also fixes a variety of miscellaneous accidental strong mode compile time or runtime check violations.

Change-Id: Ia8a41ac291aff3689efae0b11a9c51a2db30ef33
Reviewed-on: https://dart-review.googlesource.com/34924
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2018-01-16 23:08:01 +00:00
Leaf Petersen 85ca7df7e2 Avoid fuzzy arrows when parsing json. 
Change the types on the json decoding reviver to avoid fuzzy arrow
checks.

Bug:
Change-Id: I3ca52d7676b6305c398f128d370bc9859fd65820
Reviewed-on: https://dart-review.googlesource.com/21564
Reviewed-by: Vijay Menon <vsm@google.com>
 2017-11-17 20:37:07 +00:00
Alexander Markov a211134136 [Tests] Update _2 tests for Dart 2.0 fixed-size integers 
Also, --limit-ints-to-64-bits is enabled when running tests in _2 test
suites.

This is the re-landing of 92ebd8aefa with
fixes:

* Revert changes in pkg/dev_compiler/test/browser/language_tests.js
  and tests/language/language_dart2js.status as they describe
  'language' test suite, not 'language_2'

* Correct tests/standalone_2/io/fuzz_support.dart as file_fuzz test was
  timing out on Windows and failing on android/arm.

Closes https://github.com/dart-lang/sdk/issues/31396

Change-Id: If9ca77fca300ddc605f17a7be39d1707e9724e25
Reviewed-on: https://dart-review.googlesource.com/21700
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2017-11-17 20:28:06 +00:00
Alexander Markov 22218e9b9e Revert "[Tests] Update _2 tests for Dart 2.0 fixed-size integers" 
This reverts commit 92ebd8aefa.

Reason: various failures on buildbots.
Change-Id: I03e877e240fdb010d1288baebc124a3e364d1025
Reviewed-on: https://dart-review.googlesource.com/21565
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2017-11-17 00:52:17 +00:00
Alexander Markov 92ebd8aefa [Tests] Update _2 tests for Dart 2.0 fixed-size integers 
Also, --limit-ints-to-64-bits is enabled when running tests in _2 test
suites.

Change-Id: I0b75e5e6e7af78adb29401d77ff55e735781ab73
Reviewed-on: https://dart-review.googlesource.com/20960
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2017-11-16 22:40:11 +00:00
Stephen Adams 3836c70a81 Redo "js_runtime: Use browser's TextDecoder for UTF8 decoding" 
Bug:
Change-Id: I40903bcdc1502e15cbf84298b43ba04ae8a8ecaf
Reviewed-on: https://dart-review.googlesource.com/21383
Reviewed-by: Stephen Adams <sra@google.com>
 2017-11-16 04:59:26 +00:00
Stephen Adams 5e06165d6b Revert "js_runtime: Use browser's TextDecoder for UTF8 decoding" 
This reverts commit 5f15867a47.

The recent renaming of constants had caused a lot of pain with this CL.

TBR=lrn@google.com

Bug:
Change-Id: I67a78fa09e15e95ea44fe18d9847fcfd9c61e043
Reviewed-on: https://dart-review.googlesource.com/21382
Reviewed-by: Stephen Adams <sra@google.com>
 2017-11-16 04:52:40 +00:00
Stephen Adams 5f15867a47 js_runtime: Use browser's TextDecoder for UTF8 decoding 
Change-Id: I85a8e774595784883281b1cc40ee75ae8de7d1d9
Reviewed-on: https://dart-review.googlesource.com/3303
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-16 04:22:22 +00:00
Lasse R.H. Nielsen 0b58c4bd10 Change some constant declarations to lowerCase. 
Retain the old values.

Reapply of https://dart-review.googlesource.com/c/sdk/+/20680 with fixes
for VM method fingerprints.

Change-Id: Ie14e7ccc3194d5561983348e6b6752728913ff4d
Reviewed-on: https://dart-review.googlesource.com/20664
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 12:59:14 +00:00
Lasse R.H. Nielsen e61fc07b58 Revert "Change some constant declarations to lowerCase." 
This reverts commit c048cfb178.

Reason for revert: VM code fingerprints needs update.

Original change's description:
> Change some constant declarations to lowerCase.
> 
> Retain the old values.
> 
> Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
> Reviewed-on: https://dart-review.googlesource.com/11520
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=lrn@google.com,floitsch@google.com

Change-Id: I095e8198304ca4e59b39d30b0fdf0af4945e5231
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/20680
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 11:23:08 +00:00
Lasse R.H. Nielsen c048cfb178 Change some constant declarations to lowerCase. 
Retain the old values.

Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
Reviewed-on: https://dart-review.googlesource.com/11520
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-11-14 11:13:04 +00:00
Bob Nystrom 07b9df22ac Use the Expect.throws___() helper methods throughout tests. 
No behavioral changes, just getting rid of a lot of redundant closures
and helper functions.

Change-Id: I55c52c2cc9e5505bb64203c31aad8d76847f8eeb
Reviewed-on: https://dart-review.googlesource.com/14320
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2017-10-17 23:37:15 +00:00
Florian Loitsch 4443c34512 Migrate dart:convert tests from test block 188. 
Change-Id: I99e796a6793ab76c0f9d0c7c37377a97bb5102fd
Reviewed-on: https://dart-review.googlesource.com/3061
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-08 14:39:47 +00:00
Florian Loitsch 6f748c50c4 Migrate test block 187. 
Change-Id: Ie396e72abc33885128f786609f8927624d68aa1b
Reviewed-on: https://dart-review.googlesource.com/3060
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-08 13:43:31 +00:00
Florian Loitsch 7c83d5ced6 Migrate test block 186. 
Change-Id: I5ff48ecdcba4b12280ecf76c53a6cc7f12dabfbf
Reviewed-on: https://dart-review.googlesource.com/3005
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-08 10:18:50 +00:00
Florian Loitsch bf8d86f4fd Migrate test block 182. 
Change-Id: I4834e2661f3cf78d95919db2cfcec1293c780925
Reviewed-on: https://dart-review.googlesource.com/3062
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-07 12:53:45 +00:00
Florian Loitsch 051f0f1267 Added new entries to the .gitattributes file. 
Also updated the tests so that we don't forget in the future.

Change-Id: I0a998af306a0b6fa54b3c86cf164fdfe1f76340d
Reviewed-on: https://dart-review.googlesource.com/3624
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-06 18:05:57 +00:00
Florian Loitsch bdbcad0458 Migrate test block 185. 
Change-Id: I9ab6bddaeed00dd9364066fae3df9bb4f681203d
Reviewed-on: https://dart-review.googlesource.com/3004
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-06 14:06:20 +00:00
Florian Loitsch 176b277f5d Fix encoding_test. 
Change-Id: I5d47366d62a44dd8ba6c56a65bb6c744e56407ea
Reviewed-on: https://dart-review.googlesource.com/3480
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
 2017-09-06 12:19:50 +00:00
Florian Loitsch 6d09d02a64 Migrate test block 184. 
Change-Id: Id6b51f0367e886b0c81d9899423a9525f2cd6a60
Reviewed-on: https://dart-review.googlesource.com/3040
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-06 08:48:51 +00:00
Florian Loitsch 57adc7b9ad Migrate test block 183. 
Change-Id: I86ccd460e1041b74e3960e95dbf67de35d33a782
Reviewed-on: https://dart-review.googlesource.com/3002
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-05 17:00:56 +00:00