Commit Graph

3 Commits

Author SHA1 Message Date
Lasse R.H. Nielsen 91ce347309 Reapply "Create _nullFuture and _falseFuture in the root zone."
Originally landed by https://dart-review.googlesource.com/c/sdk/+/49509
Reverted because an internal test is fragile and changes behavior when the bug is fixed.

Change-Id: I8516082e5741547c46aa521a91826846dc101303
Reviewed-on: https://dart-review.googlesource.com/63743
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
2018-07-16 16:19:15 +00:00
Keerti Parthasarathy 9eb09d825b Revert "Create _nullFuture and _falseFuture in the root zone."
This reverts commit 9bb085a1c6 due to
test failure in google3.

Change-Id: I63940e62bd97c83bc432db99b44c991e6c1e025e
Reviewed-on: https://dart-review.googlesource.com/52422
Reviewed-by: Dan Grove <dgrove@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
2018-04-24 20:45:38 +00:00
Lasse R.H. Nielsen 9bb085a1c6 Create _nullFuture and _falseFuture in the root zone.
Avoids issues where they are lazily created in a different current zone and that zone messes with, for example, schedule microtask, which the future uses to schedule invocations of its callbacks.

Change-Id: I6697ca469426472523089fcf7ca44312b9c6ff5f
Reviewed-on: https://dart-review.googlesource.com/49509
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
2018-04-06 16:10:52 +00:00