Commit Graph

6 Commits

Author SHA1 Message Date
Ben Konyi eb8b398163 Changed void -> dynamic return type to fix issue caused by poor merge decision.
TBR=rnystrom@google.com
BUG=

Review-Url: https://codereview.chromium.org/3012563002 .
2017-08-29 16:45:25 -07:00
Ben Konyi 0ea752b5bf Relanding test block 170 migration.
"Migrated test block 170 to Dart 2.0.""

This reverts commit 201df65b50201f023a1db5bb26bea7b8976c3b32.

Review-Url: https://codereview.chromium.org/3005813002 .
2017-08-29 16:22:07 -07:00
Ben Konyi e8b337f08f Revert "Migrated test block 170 to Dart 2.0."
This reverts commit 6e6b0cadea9adbb48556384fac52b17c2ac15443.
2017-08-29 15:37:15 -07:00
Ben Konyi a7b19c1b47 Migrated test block 170 to Dart 2.0.
Updated status file to account for strange failure in package:test when
running multiple_timer_test on dartdevc.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2995013002 .
2017-08-29 15:25:42 -07:00
Ben Konyi 42d354c91d Migrated test block 168 to Dart 2.0.
This block felt trickier than others, mostly due to random errors that I
wasn't able to find a cause for. Tests that I'm uncertain about are:
-first_regression_test
-future_timeout_test
-future_or_bad_type_test/implements

These all have status entries to prevent failures, but I think these
tests need another set of eyes.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2999943002 .
2017-08-21 00:59:34 -07:00
Ben Konyi 55612ef10c Migrated test block 167 to Dart 2.0.
No manual work required for this block.

BUG=
R=jcollins@google.com

Review-Url: https://codereview.chromium.org/2993213003 .
2017-08-17 12:42:36 -07:00