This CL modifies the Dart source used from test.py such that it takes
`syntax error` into account as an expected outcome in test files (so
that we can have `//# 01: syntax error` with a similar meaning as
`//# 01: compile-time error`).
For all tools except the spec_parser, `syntax error` is the same
outcome as `compile-time error`; that is, nobody else will see the
difference.
For the spec_parser, `syntax error` is the outcome where parsing has
failed; `compile-time error` is taken to mean some other compile-time
error, i.e., the spec_parser is expected to _succeed_ when the
expected outcome is `compile-time error`.
Test files in language and language_2 have been adjusted to use the
outcome `syntax error` where appropriate.
The status files in language and language_2 for the spec_parser have
been adjusted such that they fit all the new `syntax error` outcomes
in test files.
Other status files have been adjusted in a few cases where tests were
corrected (because a compile-time error which was clearly not intended
to be a syntax error turned out to be caused by a typo, which means
that the actual compile-time error has never been tested).
The spec grammar Dart.g was adjusted in a few cases, when some bugs
were discovered. In particular, the treatment of Function has been
changed: It is now known by the parser that Function does not take
any type arguments. This makes no difference for developers, because
they cannot declare a type named Function anyway, but it means that
a number of tricky parsing issues were resolved.
Dart.g was also adjusted to allow `qualified` to contain three
identifiers, which is an old bug (preventing things like metadata on
the form `@p.C.myConst`).
Change-Id: Ie420887d45c882ef97c84143365219f8aa0d2933
Reviewed-on: https://dart-review.googlesource.com/18262
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Successfully migrated 7 tests. Need manual work on 6 tests:
- language_2/try_catch_test.dart:
(TODO) Merge from language/try_catch_test.dart into this file.
- language_2/type_argument_in_super_type_test.dart:
(TODO) Ensure code that checks for a TypeError uses 2.0 semantics.
- language_2/type_check_const_function_typedef2_test.dart:
(TODO) Fix code that mentions "checked" mode.
- language_2/type_checks_in_factory_method_test.dart:
(TODO) Ensure code that checks for a TypeError uses 2.0 semantics.
- language_2/type_conversion_ssa_test.dart:
(TODO) Fix code that mentions "checked" mode.
- language_2/type_error_test.dart:
(TODO) Merge from language/type_error_test.dart into this file.
(TODO) Ensure code that checks for a TypeError uses 2.0 semantics.
Bug:
Change-Id: I43901890540efcf55da13d013571ce91979cbb64
Reviewed-on: https://dart-review.googlesource.com/11142
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Erik Ernst