 Ryan Macnak
|
30896b87f1
|
[vm] Fix crash when enum initialization hits a stack overflow.
Give the compiler more headroom.
Have the simulators and interpreters distinguish between the true stack limit and the limit for trigger an overflow exception.
Bug: https://github.com/dart-lang/sdk/issues/35224
Bug: https://github.com/flutter/flutter/issues/25041
Change-Id: I048d73b649b4ce1f3d9b5a33d898ee9cfe54f6ca
Reviewed-on: https://dart-review.googlesource.com/c/86821
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
|
2018-12-10 23:40:21 +00:00 |
|
|
Ryan Macnak
|
4463aa0038
|
Revert "[vm] Fix crash when enum initialization hits a stack overflow."
This reverts commit e59312dafa.
Reason for revert: Broken arm and arm64 simulators
Original change's description:
> [vm] Fix crash when enum initialization hits a stack overflow.
>
> Give the compiler more headroom.
>
> Have the KBC and DBC interpreters distinguish between the true stack limit and the limit for trigger an overflow exception.
>
> Bug: https://github.com/dart-lang/sdk/issues/35224
> Bug: https://github.com/flutter/flutter/issues/25041
> Change-Id: I85e72e1d3cceb70858c53567a4c8d3635e42165b
> Reviewed-on: https://dart-review.googlesource.com/c/86684
> Reviewed-by: Régis Crelier <regis@google.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
TBR=rmacnak@google.com,regis@google.com,ajcbik@google.com
Change-Id: I923cca32d34de37b761196f536873aaf81dcbc92
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/35224, https://github.com/flutter/flutter/issues/25041
Reviewed-on: https://dart-review.googlesource.com/c/86782
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
|
2018-12-10 18:52:10 +00:00 |
|
|
Ryan Macnak
|
e59312dafa
|
[vm] Fix crash when enum initialization hits a stack overflow.
Give the compiler more headroom.
Have the KBC and DBC interpreters distinguish between the true stack limit and the limit for trigger an overflow exception.
Bug: https://github.com/dart-lang/sdk/issues/35224
Bug: https://github.com/flutter/flutter/issues/25041
Change-Id: I85e72e1d3cceb70858c53567a4c8d3635e42165b
Reviewed-on: https://dart-review.googlesource.com/c/86684
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
|
2018-12-10 18:29:43 +00:00 |
|
|
Ryan Macnak
|
4191437ccc
|
Revert "[vm] Fix crash when enum initialization hits a stack overflow."
This reverts commit 67b5c878b3.
Reason for revert: Failures on KBC and ASAN.
Original change's description:
> [vm] Fix crash when enum initialization hits a stack overflow.
>
> Also, give the compiler more headroom.
>
> Bug: https://github.com/dart-lang/sdk/issues/35224
> Bug: https://github.com/flutter/flutter/issues/25041
> Change-Id: I51b24cdd79ac790c0ee951e14738a6e7b6f65647
> Reviewed-on: https://dart-review.googlesource.com/c/86584
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Aart Bik <ajcbik@google.com>
TBR=rmacnak@google.com,ajcbik@google.com
Change-Id: I1d4c2297154f93f16d2e33756713b30ebe024901
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/35224, https://github.com/flutter/flutter/issues/25041
Reviewed-on: https://dart-review.googlesource.com/c/86683
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
|
2018-12-07 21:08:33 +00:00 |
|
|
Ryan Macnak
|
67b5c878b3
|
[vm] Fix crash when enum initialization hits a stack overflow.
Also, give the compiler more headroom.
Bug: https://github.com/dart-lang/sdk/issues/35224
Bug: https://github.com/flutter/flutter/issues/25041
Change-Id: I51b24cdd79ac790c0ee951e14738a6e7b6f65647
Reviewed-on: https://dart-review.googlesource.com/c/86584
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
|
2018-12-07 19:54:41 +00:00 |
|