 Alexander Markov
|
477ad3c0ea
|
[vm/bytecode] Eliminate asserts from bytecode unless --enable-asserts
Total size of a large app:
Before: 23681504
After: 23207344 (-463K/-2%)
Size of bytecode instructions:
Before: 6282376
After: 5981716 (-4.8%)
Change-Id: I57703616ecc91301c928672c83571482500dc365
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101883
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
|
2019-05-09 20:41:21 +00:00 |
|
|
Stephen Adams
|
a521870e1a
|
Clean up dart2js assertion_test status
Change-Id: I665cfdd5a17da10dbab3fb187eb2ce1b3e922a4e
Reviewed-on: https://dart-review.googlesource.com/68580
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
|
2018-08-07 01:09:31 +00:00 |
|
|
Brian Wilkerson
|
c151dffb9f
|
Update tests to have an expression rather than a function as the argument in an assert
Change-Id: Ie95b39400adc0acd0b5f2c58dd26d21bb1b8c081
Reviewed-on: https://dart-review.googlesource.com/32502
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
|
2018-01-05 22:09:09 +00:00 |
|
|
Vijay Menon
|
6ce85d5f99
|
Revert "Remove support for functions in asserts in DDC."
This reverts commit 8140e1db64.
Change-Id: If505903ba475324392d6c6bcdae3392f523aadc8
Reviewed-on: https://dart-review.googlesource.com/7107
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
|
2017-09-19 21:46:13 +00:00 |
|
|
Bob Nystrom
|
8140e1db64
|
Remove support for functions in asserts in DDC.
These are not supported in Dart 2.0:
https://github.com/dart-lang/sdk/issues/30326
Change-Id: I2e177a647c43af2bf7f37ff382234b12b8c2286c
Reviewed-on: https://dart-review.googlesource.com/4182
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
|
2017-09-15 23:37:06 +00:00 |
|
|
Bob Nystrom
|
12433bd5f4
|
Update assertion_test to no longer allow functions in asserts.
Dart used to allow the first argument to assert() to be a function,
which it would implicitly call, but this is being removed for Dart 2.0.
https://github.com/dart-lang/sdk/issues/30326
This gets the test testing the 2.0 behavior. Since the test is now
leading the implementation, updated the status files to mark it failing.
Bug: https://github.com/dart-lang/sdk/issues/30326
Change-Id: Ia61f540f1991ecdf42ccdb47b932890e636c1bd3
Reviewed-on: https://dart-review.googlesource.com/4181
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
|
2017-09-14 18:10:26 +00:00 |
|
|
Bob Nystrom
|
f32d1b2bcd
|
Migrate block 37, language/arithmetic2 ... /async_await_syntax_test.
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2992003002 .
|
2017-07-28 11:16:23 -07:00 |
|
|
Erik Corry
|
e431e93e87
|
Revert two Kernel changes that were causing test failures.
Example failure:
python tools/test.py -m release -c dartk --builder-tag no_ipv6 \
language/function_type/function_type63_test
Revert "Serialize typedef parameters (including function typed ones) to Kernel and use it to resynthesize typedefs from Kernel."
This reverts commit afc392b66d.
Reverts https://codereview.chromium.org/2990783002
Revert "Add Member.documentationComment and use it to resynthesize documentation from Kernel."
This reverts commit 47ecf72272.
Reverts https://codereview.chromium.org/2990873002
Also reverts some attempts to fix test files:
302b410364
https://codereview.chromium.org/2984343002
05ccf27015
https://codereview.chromium.org/2992683002
f71dcd7834
https://codereview.chromium.org/2984363003
Also had to revert some test changes that were committed on top of a red buildbot, in order to try to get back to a place where bots were green:
23952fdf56
https://codereview.chromium.org/2990773002
557cab2a3e
https://codereview.chromium.org/2985173002
R=johnniwinther@google.com, karlklose@google.com
BUG=
Review-Url: https://codereview.chromium.org/2986093002 .
|
2017-07-28 14:08:23 +02:00 |
|
|
Bob Nystrom
|
23952fdf56
|
Migrate language/arithmetic2_test ... language/async_await_syntax_test.
R=sra@google.com
Review-Url: https://codereview.chromium.org/2990773002 .
|
2017-07-27 16:13:47 -07:00 |
|