477ad3c0ea
[vm/bytecode] Eliminate asserts from bytecode unless --enable-asserts
...
Total size of a large app:
Before: 23681504
After: 23207344 (-463K/-2%)
Size of bytecode instructions:
Before: 6282376
After: 5981716 (-4.8%)
Change-Id: I57703616ecc91301c928672c83571482500dc365
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101883
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2019-05-09 20:41:21 +00:00
0284fdab6b
dart2js: allow as expressions in constants
...
The CFE doesn't allow them explicitly yet, but implicit casts do show up by the
time we see them in dart2js.
Closes https://github.com/dart-lang/sdk/issues/32773
Change-Id: Idb566625ce7c8edc74a4eea0109491bd72357051
Reviewed-on: https://dart-review.googlesource.com/49801
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2018-04-06 00:46:30 +00:00
06439147c4
Update some tests to work better.
...
Add test for strong-mode only allowing super-chaining at the end of the initializer list.
Change-Id: Ic1c99f4f24738094eec14cb9c59354716f776b1e
Reviewed-on: https://dart-review.googlesource.com/40301
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-02-15 08:43:34 +00:00
85faacc23c
Fix the const assertion test.
...
Dart 2 has no notion of "checked mode", so a failed assertion in a
const constructor should always be a compile error.
Change-Id: I02227c03613346918de1e3a7f7c70d209a940b90
Reviewed-on: https://dart-review.googlesource.com/37647
Reviewed-by: Leaf Petersen <leafp@google.com >
2018-01-30 23:26:01 +00:00
94d4543245
Moved a comma in a test over some white space.
...
The multi-test language_2/assertion_initializer_const_error2_test used
to have outcomes caused by a syntax error (arising for all other cases
than `cc02` in this multi-test). This CL moves that comma such that all
subtests have the intended shape, and the test actually tests the
intended property. This causes a rather large number of status file
entries to be adjusted.
Change-Id: I2e176611813e5706e553fb51cda7553f17dfa300
Reviewed-on: https://dart-review.googlesource.com/19191
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Florian Loitsch <floitsch@google.com >
2017-11-09 14:04:08 +00:00
7a540d2f85
Remove VMOptions in tests for options that are now on by default.
...
Change-Id: Ic12edd3e76ba1f8b9fb096c96e310e7253cc6ac6
Reviewed-on: https://dart-review.googlesource.com/14722
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
2017-10-19 16:19:16 +00:00
f32d1b2bcd
Migrate block 37, language/arithmetic2 ... /async_await_syntax_test.
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2992003002 .
2017-07-28 11:16:23 -07:00
e431e93e87
Revert two Kernel changes that were causing test failures.
...
Example failure:
python tools/test.py -m release -c dartk --builder-tag no_ipv6 \
language/function_type/function_type63_test
Revert "Serialize typedef parameters (including function typed ones) to Kernel and use it to resynthesize typedefs from Kernel."
This reverts commit afc392b66dhttps://codereview.chromium.org/2990783002
Revert "Add Member.documentationComment and use it to resynthesize documentation from Kernel."
This reverts commit 47ecf72272https://codereview.chromium.org/2990873002
Also reverts some attempts to fix test files:
302b410364https://codereview.chromium.org/2984343002
05ccf27015https://codereview.chromium.org/2992683002
f71dcd7834https://codereview.chromium.org/2984363003
Also had to revert some test changes that were committed on top of a red buildbot, in order to try to get back to a place where bots were green:
23952fdf56https://codereview.chromium.org/2990773002
557cab2a3ehttps://codereview.chromium.org/2985173002
R=johnniwinther@google.com , karlklose@google.com
BUG=
Review-Url: https://codereview.chromium.org/2986093002 .
2017-07-28 14:08:23 +02:00
23952fdf56
Migrate language/arithmetic2_test ... language/async_await_syntax_test.
...
R=sra@google.com
Review-Url: https://codereview.chromium.org/2990773002 .
2017-07-27 16:13:47 -07:00
Alexander Markov