Commit Graph

3 Commits

Author SHA1 Message Date
Alexander Markov 4334c97dcb [Tests] Fix corelib_2/iterable_fold_test and iterable_reduce_test
* Change 'var iterable' to dynamic as type inference can only
  infer Object type.

* Explicitly set result type of closures passed to reduce() to
  make closure type compatible with parameter type expected by reduce().

* To modify List of Lists of int, add '[4]' instead of '4' to trigger
  expected ConcurrentModificationError instead of type error.

* Remove splitting to multi-test.

* Format with dartfmt.

Change-Id: Ie1a35eececbf1133cb2384afad10e9d355016abe
Reviewed-on: https://dart-review.googlesource.com/36300
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-01-26 17:43:33 +00:00
Paul Berry 76ea9d3dfd Strong mode fix for iterable_fold_test.dart
List.expand() requires a callback that returns an Iterable.

Change-Id: I969ee15bed5b219a688779317d89f50190b42e06
Reviewed-on: https://dart-review.googlesource.com/19402
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2017-11-09 16:49:28 +00:00
Janice Collins e6b3fb5b05 Migrate test block 10 to Dart 2.0.
Special bits in this block:

int_parse_radix_test: Converted to a check only on TypeError (since this is raised at runtime based on user data)
iterable_element_at_test.dart: Split into multitest with compile errors.
iterable_fold_test.dart: add4 and a couple of other cases here cause problems for some compilers, split out into multitests and annotated in
status file.

BUG=
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2997533002 .
2017-08-09 08:47:48 -07:00