Commit Graph

8 Commits

Author SHA1 Message Date
Stephen Adams 7cf2607344 Make minified names explicit in printed representation of types.
Supports mixed minified and unminified names (like `List` and `num` below).

Example:
TypeError: Closure 'minified:b3': type '() => minified:o<minified:k<num>>' is not a subtype of type 'List<minified:o<minified:k<num>>>'


Change-Id: I1fc67f189170eb9b9c8614b1e3d33128adc49787
Reviewed-on: https://dart-review.googlesource.com/67303
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-08-06 22:28:11 +00:00
Stephen Adams 0c46242023 dart2js_native tests: Migrate 'native STRING' to JS-calls - part 2/2
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2990083002 .
2017-07-31 15:14:47 -07:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
Stephen Adams f734606d0e Add native_testing library to mock @Native classes
Convert 114 tests to use native_testing.dart library.

Includes reviewed code from
https://codereview.chromium.org/2332953002/

Committed: https://github.com/dart-lang/sdk/commit/ddfc70f1640e5918216d1bd2b125d8d84d24c469

Review URL: https://codereview.chromium.org/2379173002 .

Reverted:  https://github.com/dart-lang/sdk/commit/74deaad759bfbacbdf55bd47e4f175a4c15ac571
2016-11-10 14:16:08 -08:00
Stephen Adams 74deaad759 Revert "Add native_testing library to mock @Native classes"
Investigating failures.

BUG=

Review URL: https://codereview.chromium.org/2383273002 .
2016-09-30 13:27:09 -07:00
Stephen Adams ddfc70f164 Add native_testing library to mock @Native classes
Convert 114 tests to use native_testing.dart library.

Review URL: https://codereview.chromium.org/2379173002 .
2016-09-30 12:13:52 -07:00
Harry Terkelsen 3d31aa2ff7 dart2js: run dartfmt on tests
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2345083003 .
2016-09-16 15:49:23 -07:00
Stephen Adams 5612c202a0 dart2js runtime: Harden objectTypeName.
1. Avoid crashing on short minified names.
2. Try to find a better name for external JavaScript classes.
3. Try to find a better name for undistingushed native classes.

BUG= http://dartbug.com/24393

This is related to http://dartbug.com/19137

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1362553002 .
2015-09-22 14:46:14 -07:00