Commit Graph

27 Commits

Author SHA1 Message Date
Johnni Winther 394f88d5cf Create source information from ConstantExpression
(now that it has a fileOffset)

Change-Id: I057ca3cf04a941ccdb03a6d8ca58947650b1cbec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99161
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-04-12 07:37:17 +00:00
Johnni Winther 60e4f194b0 Recognize and inline effectively constant fields
Change-Id: I243ee80ebc45d9cdab2f7c944cf5eceb26185b2c
Reviewed-on: https://dart-review.googlesource.com/c/93436
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2019-02-22 14:06:05 +00:00
Sigmund Cherem b484aada21 Remove library-root option - replace it with a libraries-spec option instead
Change-Id: Ie1df52cdaa7ab4381a4c1b94c61a1210f0f31b5f
Reviewed-on: https://dart-review.googlesource.com/c/83641
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-11-09 22:40:28 +00:00
Sigmund Cherem cb7341fceb Initial support for inlining-data in source-maps.
This starts tracking inlining data and records it as an extension
to source-map files so we are able to expand inlined calls when
deobfuscating production stack traces.


Change-Id: I46daf21c2f42305b2bd6ca17fbafb65226355096
Reviewed-on: https://dart-review.googlesource.com/67083
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-07-31 21:41:50 +00:00
Stephen Adams 5ccc497678 Inline constructor bodies that are called once
Change-Id: I74b2518fed543a78f1531b54510f4dcbe3a57192
Reviewed-on: https://dart-review.googlesource.com/60324
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-06-20 22:12:02 +00:00
Sigmund Cherem c25a9fd46b Remove support for dart:isolate in dart2js.
Change-Id: I1216a0ac91d8a1d13b441809596e1a8b5e51bb34
Reviewed-on: https://dart-review.googlesource.com/54526
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-05-10 01:20:17 +00:00
Johnni Winther 17e22dfcd3 Remove unneeded kernel tests and sourcemap old-frontend tests
Change-Id: Iaf9533a812df5c872f223bce17ec7127f0b46318
Reviewed-on: https://dart-review.googlesource.com/54200
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-05-09 07:55:08 +00:00
Johnni Winther 794fe1e14f Add stacktrace tests for synchronous async
Change-Id: Iafd66528f9ea3d7a301dc4845118ca16517e235f
Reviewed-on: https://dart-review.googlesource.com/53206
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-05-03 08:09:33 +00:00
Sigmund Cherem c438f8b3f4 Dart2js defaults to the new common front-end
Change-Id: Id0f69d258b010a746b56e259335185bcca7dafec
Reviewed-on: https://dart-review.googlesource.com/45143
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-03-13 19:25:59 +00:00
Johnni Winther d539c78af1 Add source information to parameter stubs.
Change-Id: If942cc13203752361c3104c89190d75979073498
Reviewed-on: https://dart-review.googlesource.com/34440
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-12 21:23:40 +00:00
Sigmund Cherem 414bad86df Directly create dart2js platform files using its patch files
Change-Id: I1c7d59968bfafeeb5a8b5252fa2d47e3c05b893e
Reviewed-on: https://dart-review.googlesource.com/27404
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
2017-12-19 20:31:57 +00:00
Jens Johansen 1e4625ea38 Small changes to stacktrace_helper to prepare for ddc usage
Bug:
Change-Id: Iab4fb0536456cded152646bf2725e8c918e4a8e8
Reviewed-on: https://dart-review.googlesource.com/23020
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2017-11-22 14:30:37 +00:00
Johnni Winther b9a222615b Add sourcemap_testing package
Change-Id: I9655ebf5bb93c61f9d1f0eae1fbc615761f23b47
Reviewed-on: https://dart-review.googlesource.com/22520
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2017-11-21 15:09:38 +00:00
Johnni Winther 4dbc717b33 Extract stacktrace_helper from stacktrace_test
- to prepare for reuse by ddc sourcemap testing.

Change-Id: I0d112d164009f263a03dd000d6e1bce1df5ed5f9
Reviewed-on: https://dart-review.googlesource.com/22480
Reviewed-by: Jens Johansen <jensj@google.com>
2017-11-21 13:07:00 +00:00
Johnni Winther 0a6782bab2 Reorganize source map tests, tools and helpers.
Change-Id: Ie3e5ebb41377c709c6685046b46d6eeb711ddddf
Reviewed-on: https://dart-review.googlesource.com/22040
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-11-21 09:12:27 +00:00
Johnni Winther d578cdb6a0 Test stacktrace sourcemaps for kernel.
Change-Id: Ic2bf02ec8aaff9a1c2495768a9bf1b8362acccca
Reviewed-on: https://dart-review.googlesource.com/21802
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-11-20 09:17:20 +00:00
Johnni Winther cb0978d691 Read stacktrace_test data from files.
Change-Id: I5dc3a2ef8ec8e77498ec09590f871e07d0beb5c5
Reviewed-on: https://dart-review.googlesource.com/21801
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-11-20 09:08:35 +00:00
Johnni Winther e8e3fb5224 Reenable source map tests
- and fixes regressions + add more coverage for the regressed parts

Change-Id: Ied0aa54389164650b4fcd8f0363ddabb60c00a77
Reviewed-on: https://dart-review.googlesource.com/20204
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-11-14 08:18:44 +00:00
Peter von der Ahé 2e6e44a69b Strong mode cleaning of many dart2js tests.
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2939063002 .
2017-06-16 09:31:29 +02:00
Stephen Adams 1472eba52d js_runtime: Split _asyncHelper into separate functions
The separate functions have smaller call-sites and less overhead.

_asyncStart uses Future._nullFuture to avoid 1 allocation.

BUG=
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2858463002 .
2017-05-03 12:38:35 -07:00
Johnni Winther 4358efc0ca Add test for expected source mappings
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2667983002 .
2017-02-01 10:00:17 +01:00
Johnni Winther ec71517bc8 Improve precision of stacktrace_test
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2654273002 .
2017-01-27 09:15:30 +01:00
Johnni Winther 6c919f02b4 Add no-info mappings at start of out.js and after mapped functions
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2654023003 .
2017-01-26 11:46:06 +01:00
Johnni Winther c885d809b6 Add inference test functionality based on code point id.
The code point id is meant to be basis for AST/Kernel-IR equivalence and the test framework should thereby be portable to a Kernel based inference.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2656583003 .
2017-01-25 14:44:28 +01:00
Johnni Winther a710603553 Update stacktrace_test with negative tests
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2519883002 .
2016-11-22 15:47:06 +01:00
Johnni Winther d0e057903e Provide source map info for simple async methods.
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2510073002 .
2016-11-18 09:28:40 +01:00
Johnni Winther d153808ca6 Add stacktrace_test
- also add helper program for working with sourcemaps.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2431223006 .
2016-11-03 11:00:46 +01:00