dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

20 Commits

Author SHA1 Message Date
Johnni Winther 3af2f793ac Remove --no-preview-dart-2 from dart2js 
Change-Id: I17a18ebe905fa60ba2a1b41af2f444cfe58a38a2
Reviewed-on: https://dart-review.googlesource.com/70512
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-08-20 09:18:02 +00:00
Mike Fairhurst 21258299d7 Reland "Fix #32227 export dynamic from dart:core in analyzer." 
This reverts commit d3b4ba3a0b.

Reason for revert: Previous breakage was related to overly strict tests.

Original change's description:
> Revert "Fix #32227 export dynamic from dart:core in analyzer."
> 
> This CL caused a breakage in angular code generation.
> 
> This reverts commit 6f965a94e2.
> 
> Change-Id: Id066661930b9531cdd32a0d38e71f70fe73ece75
> Reviewed-on: https://dart-review.googlesource.com/63680
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com,mfairhurst@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: If0a03148db5e88724f3498a1fa2d46a9c42d7f1f
Reviewed-on: https://dart-review.googlesource.com/64120
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-07-09 22:30:49 +00:00
Paul Berry d3b4ba3a0b Revert "Fix #32227 export dynamic from dart:core in analyzer." 
This CL caused a breakage in angular code generation.

This reverts commit 6f965a94e2.

Change-Id: Id066661930b9531cdd32a0d38e71f70fe73ece75
Reviewed-on: https://dart-review.googlesource.com/63680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-07-03 19:50:26 +00:00
Mike Fairhurst 6f965a94e2 Fix #32227 export dynamic from dart:core in analyzer. 
Assign dynamic to dart:core in NamespaceBuilder & LibraryScope

This seems to be the best two places to hit up all cases. We need two to
handle the case of where code imports dart:core, vs code that is itself
the definition of dart:core.

Includes a member sort of compile_time_error_code_kernel_test, so that
pollutes the diff a bit, but not importantly so and its good to get that
sorted.

Bug: 32227
Change-Id: Ibe620f4b66a35d088355f36da042a5d82380772c
Reviewed-on: https://dart-review.googlesource.com/62730
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-06-29 19:24:41 +00:00
Janice Collins 1afe71c08a Enable preview-dart-2 as default for analyzer. 
Based on https://dart-review.googlesource.com/c/sdk/+/52340, but adds
the necessary plumbing through the test system to pass through
negations to strong and preview-dart-2.  Also adds support for those
negations to the analyzer.

Change-Id: I9793ff28bb593d25bbb0a2ed8736b5b53e0a62d8
Reviewed-on: https://dart-review.googlesource.com/52461
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-26 17:01:12 +00:00
Johnni Winther dbadf204aa Add source information to break, continue, == and constructor body calls 
Change-Id: I3ca3dc1e1ed55b636808685bff5d017d422678e7
Reviewed-on: https://dart-review.googlesource.com/24923
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-12-05 11:40:41 +00:00
Johnni Winther 5a238b215a More source information 
+ on super calls
+ null tests
+ logical and

Change-Id: I136500544d14afa5cbaf431ec12dfb1516c38d29
Reviewed-on: https://dart-review.googlesource.com/24480
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-30 08:45:39 +00:00
Johnni Winther 93d03da1db Add source information to yield* and async* 
Change-Id: I4e3f09f60527c0ea501b266abca6b70dc01d1a64
Reviewed-on: https://dart-review.googlesource.com/23668
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 10:16:54 +00:00
Johnni Winther 9bfef29e21 Add source information to throw/try/await in async and yield in sync* 
Change-Id: I8559aaf40c3cb12892113b7373608dc0eed3cb45
Reviewed-on: https://dart-review.googlesource.com/23680
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 09:56:09 +00:00
Johnni Winther 03aab05eea Add source information on try, is and as 
Change-Id: I83eaad5913eead816d28286d31e370cafeb7f52b
Reviewed-on: https://dart-review.googlesource.com/23520
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 09:43:20 +00:00
Johnni Winther bc32fb7e42 Add sourcemapping to (simple) async methods. 
Change-Id: Ia1dbf85d75b2dd2c3c0308aa8ff4c65605c62481
Reviewed-on: https://dart-review.googlesource.com/23380
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 09:22:10 +00:00
Johnni Winther 758306af54 Provide source info on switch, boxing and capture 
Change-Id: I6d8deaa5d523a1f9346c773295f3d1152636f01a
Reviewed-on: https://dart-review.googlesource.com/23665
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 09:06:41 +00:00
Johnni Winther 3ee0a42842 Update source_mapping_test* to take arbitrary file input 
+ add the missing source information to HStringify found by through testing swarm with it.

Change-Id: Iaba9d8cc5c1ff2bee6a94988eb1916ac4abc66a2
Reviewed-on: https://dart-review.googlesource.com/22140
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-21 10:38:03 +00:00
Johnni Winther 9578eac4e2 Add source information to loops. 
Change-Id: I0d0ce8f39cba888741d8adffd7d07826dc82f93e
Reviewed-on: https://dart-review.googlesource.com/22120
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-21 10:23:17 +00:00
Johnni Winther 5e6a6bd035 Test all files in sourcemaps/data 
Change-Id: I4cab4910818435c7d96bf494770e9b064b30cfc9
Reviewed-on: https://dart-review.googlesource.com/22000
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-21 08:49:28 +00:00
Johnni Winther d578cdb6a0 Test stacktrace sourcemaps for kernel. 
Change-Id: Ic2bf02ec8aaff9a1c2495768a9bf1b8362acccca
Reviewed-on: https://dart-review.googlesource.com/21802
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-20 09:17:20 +00:00
Johnni Winther e8e3fb5224 Reenable source map tests 
- and fixes regressions + add more coverage for the regressed parts

Change-Id: Ied0aa54389164650b4fcd8f0363ddabb60c00a77
Reviewed-on: https://dart-review.googlesource.com/20204
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-14 08:18:44 +00:00
Peter von der Ahé 69d6e8e55a All strong mode cleaning of dart2js. 
Fixes https://github.com/dart-lang/sdk/issues/29886

Supersedes CLs 2939193003, 2950433002, and 2947583002.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2944843002 .
 2017-06-19 14:06:38 +02:00
Harry Terkelsen 3d31aa2ff7 dart2js: run dartfmt on tests 
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2345083003 .
 2016-09-16 15:49:23 -07:00
Johnni Winther 0e537d8086 Refactor unittests 
Move serialization tests into subfolder
Move data files into data subfolders
Move tests with errors/warnings into quarantined subfolder
Skip packages/ folder in test

The latter three improves workflow in IntelliJ; providing error/warning free analysis of unittests (by exclusion of folders).

R=sigmund@google.com

Review URL: https://codereview.chromium.org/1934883002 .
 2016-05-03 10:44:13 +02:00