dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

24 Commits

Author SHA1 Message Date
Johnni Winther 013cf68624 Replace js_helper annotations with @pragma 
@ForceInline is still used by dart:html, will be removed in a later CL.

Change-Id: I480325fe91cc6baefb17ead49f839442e023d441
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95160
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-05 08:56:18 +00:00
Johnni Winther 477de6b84b Cleanup unittests 
- remove use of '_strong', '_trust', and '_checked' suffices
- test omit-implicit-checks by default

Change-Id: I2a83f6fb23a22c894cc7867c51ab460abb4cc524
Reviewed-on: https://dart-review.googlesource.com/c/88454
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-01-07 15:01:10 +00:00
Johnni Winther 760a9690c2 Remove tests irrelevant for Dart 2 
Change-Id: Iedbab2ce11d7446ce28546f06ad97fd909f389c6
Reviewed-on: https://dart-review.googlesource.com/71404
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-08-29 07:29:38 +00:00
Johnni Winther 216e8dfe85 Stop using !kernel annotations 
Change-Id: I097253c0eb9ceb27322494194fbc6d899434807e
Reviewed-on: https://dart-review.googlesource.com/61263
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2018-06-21 07:36:42 +00:00
Johnni Winther 52d7a3043a Track RTI dependency through instantiations 
Closes #33093

Change-Id: Ia7d9cd1235cd4fe60858f37533689f5eeb600540
Reviewed-on: https://dart-review.googlesource.com/59400
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-06-12 08:00:09 +00:00
Johnni Winther d0112f4431 Remove old frontend equivalence tests 
Change-Id: I18b4b9979aea44b4dec64a5f1a32e67118b54a97
Reviewed-on: https://dart-review.googlesource.com/54222
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-05-09 07:55:08 +00:00
Johnni Winther 20c7725954 Handle deferred constant instantiations 
Closes #32997

Change-Id: I31661bb223ca9d9bdee2e7cabe4e62bf18e87509
Reviewed-on: https://dart-review.googlesource.com/53007
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-05-01 08:31:01 +00:00
Johnni Winther 6a8cad4877 Optimize RTI capture 
Change-Id: I1b1b363de442e118ccb1e2018748a2ba7c5fe9e6
Reviewed-on: https://dart-review.googlesource.com/51642
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-04-19 16:00:28 +00:00
Johnni Winther 1f2f8be33a Add tests for closure/rti optimization 
Change-Id: Iedf1d63cb7d87ecd87a059988b1fd95431aeab6a
Reviewed-on: https://dart-review.googlesource.com/51641
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-04-19 12:51:50 +00:00
Johnni Winther 73e35eb035 Update RTI optimization to handle type literal uses 
... for generic methods and local function. Also update capture
conversion to recognize the new kinds of type variables.

Change-Id: I9b8771b0ebe6c9e926712fa31b0bdea966cc6a25
Reviewed-on: https://dart-review.googlesource.com/34600
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2018-01-17 15:12:55 +00:00
Emily Fortuna 0eca8a1748 Add RTI while walking closure info. 
Bug:
Change-Id: If1b33706d3b7a784f292a9f133779109109d8d25
Reviewed-on: https://dart-review.googlesource.com/8321
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-10-04 19:24:31 +00:00
Emily Fortuna 088989920a Fix boxing of variables in for-in and while loops. 
Bug:
Change-Id: I8355f1b46a9dda03440fb8cadf1dbaf48572b41a
Reviewed-on: https://dart-review.googlesource.com/9430
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-29 19:11:53 +00:00
Emily Fortuna 5402179bd4 Properly pass on this as a free variable when inside closures. 
Bug:
Change-Id: Iba32dbc40e9361030a885b50a9e816c0ac123884
Reviewed-on: https://dart-review.googlesource.com/7102
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-19 20:16:45 +00:00
Johnni Winther 563304f174 Include constructors in equivalence tests 
Change-Id: I3725d6801b19b1737c60ee0d8c07f21a71d8f470
Reviewed-on: https://dart-review.googlesource.com/6582
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-19 10:08:53 +00:00
Emily Fortuna 553e4a0967 Don't make field entities for variables in boxes. 
Bug:
Change-Id: Ie31e88438da93a1d54c8c688a5ccd212bb81bb28
Reviewed-on: https://dart-review.googlesource.com/4241
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-09-11 23:32:51 +00:00
Johnni Winther f97a961cbe Support annotations on assignment and postfix operations 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3007903002 .
 2017-09-01 16:31:41 +02:00
Emily Fortuna ea038bd8e0 Pass in this as a free variable to the closure class 
BUG=
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3009903002 .
 2017-08-31 10:41:19 -07:00
Emily Fortuna 63754bba71 Add more tests for closures and change closure indexing to be by FunctionExpression or FunctionDeclaration rather than FunctionNode. 
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3003963002 .
 2017-08-28 14:24:58 -07:00
Emily Fortuna fba36729ec Revert "Revert "Reduce use of getClosureInfoForMember and cleanup closure_test"" 
This reverts commit e94ff86b2b.

Reapply Johnni's change with the status file updates.

BUG=

Review-Url: https://codereview.chromium.org/3008603002 .
 2017-08-25 18:14:34 -07:00
Emily Fortuna e94ff86b2b Revert "Reduce use of getClosureInfoForMember and cleanup closure_test" 
I tried to land  https://codereview.chromium.org/2998113002/ on behalf
of Johnni, but it wouldn't let me update the status files, and this
change modifies status files. Reverting.

This reverts commit 6b3f8665c0.

BUG=

Review-Url: https://codereview.chromium.org/3011433002 .
 2017-08-25 17:57:51 -07:00
Emily Fortuna 6b3f8665c0 Reduce use of getClosureInfoForMember and cleanup closure_test 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2998113002 .
 2017-08-25 17:48:14 -07:00
Johnni Winther 7ad43da779 Test closure data on anonymous local functions 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2996053002 .
 2017-08-17 09:39:53 +02:00
Johnni Winther 9ab9598918 Add more tested features to closure_test 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2999003002 .
 2017-08-16 09:30:29 +02:00
Johnni Winther 4a31a0be47 Add closure_test 
- currently only for AST-based elements; IR-based to come

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2950493002 .
 2017-06-20 12:27:19 +02:00