dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

7 Commits

Author SHA1 Message Date
Samir Jindel a5d396cd25 [vm/extensions] Fix native extensions in hot-reload and running from snapshot. 
This is a re-land of "[vm/extensions] Fix Loader::ReloadNativeExtensions(...)."

The native extension test was failing in hot-reload: this has been fixed.

Change-Id: Ic18da8cfbc6a3dba8aac09d654dce616487a67d7
Reviewed-on: https://dart-review.googlesource.com/c/92800
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
 2019-02-14 17:47:28 +00:00
Samir Jindel 754e5f404c Revert "[vm/extensions] Fix Loader::ReloadNativeExtensions(...)." 
This reverts commit 4118d3c793.

Crashes on hot reload/rollback bots.

Original change's description:
> [vm/extensions] Fix Loader::ReloadNativeExtensions(...).
> 
> This method was not doing anything since the switch to Dart 2
> because extensions no longer were added as imports to the libraries
> which loaded them.
> 
> This is a commandeer of https://dart-review.googlesource.com/c/sdk/+/90240 with a bug fix.
> 
> Change-Id: Idfe2ec16ae714b5a31ed53332da6704248949915
> Reviewed-on: https://dart-review.googlesource.com/c/92180
> Commit-Queue: Samir Jindel <sjindel@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>

TBR=rmacnak@google.com,sjindel@google.com

Change-Id: If8c8d6cf8ee2cb0a354601f94c609d3d7b5ddf03
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/92640
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-11 18:16:21 +00:00
Samir Jindel 4118d3c793 [vm/extensions] Fix Loader::ReloadNativeExtensions(...). 
This method was not doing anything since the switch to Dart 2
because extensions no longer were added as imports to the libraries
which loaded them.

This is a commandeer of https://dart-review.googlesource.com/c/sdk/+/90240 with a bug fix.

Change-Id: Idfe2ec16ae714b5a31ed53332da6704248949915
Reviewed-on: https://dart-review.googlesource.com/c/92180
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-02-11 16:52:20 +00:00
Ryan Macnak 49142b49e7 Revert "[gardening] mark sample_extension_test as error" 
This reverts commit 679108ea7b.

Revert "Update 'samples/sample_extension' to Dart 2"

This reverts commit fba5a58b47.

Reason for revert: Broken app-kernel and app-reload bots

TBR=asiva@google.com,kathyw@google.com

Change-Id: I690694ec974fa316b25934a1f0f62b5e665a28ba
Reviewed-on: https://dart-review.googlesource.com/c/86800
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-12-10 19:37:33 +00:00
Patrice Chalin fba5a58b47 Update 'samples/sample_extension' to Dart 2 
- Ran `dartfmt --fix`
- Fixed Dart 2 type errors
- Other misc cleanup (to conform to Effective Dart)

Contributes to https://github.com/dart-lang/site-www/issues/980

cc @a-siva @kwalrath @kevmoo

Closes #33711
https://github.com/dart-lang/sdk/pull/33711

GitOrigin-RevId: a832220272fe50a8bd96c6bc71692d54dcbf9465
Change-Id: Ia542ce073d2f9a4c78934a74ee17b60156a49d25
Reviewed-on: https://dart-review.googlesource.com/c/63260
Commit-Queue: Kathy Walrath <kathyw@google.com>
Reviewed-by: Kathy Walrath <kathyw@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-12-09 03:34:04 +00:00
Jacob Richman b33097b9b4 Format samples and samples-dev directories. 
BUG=
R=sra@google.com

Review-Url: https://codereview.chromium.org/2828603002 .
 2017-04-19 07:30:17 -07:00
Rico Wind f34fae854a Initial github commit for getting stuff working 
Readd samples, samples-dev, tools/testing/bin, third_party removed by cleanup (no history, sorry)

Add DEPS file which will replace the old all.deps and standalone.deps

Add tools/deps/dartium.deps replacing the old dartium.deps (but now editable from a normal checkout)

Fixup tools/utils.py to use the new archiving schema (git count for be, version number for dev/stable

Fix codereview.settings
 2015-05-16 15:41:58 +02:00