dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

15405 Commits

Author SHA1 Message Date
Ryan Macnak 89d753588c [test] Speed up get_vm_timeline_rpc_test.dart. 
Timing out on IA32 optcounter bot.

Change-Id: I1c9324b4712c963c2b22aaf10965c31c92f75406
Reviewed-on: https://dart-review.googlesource.com/c/78704
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-09 01:18:15 +00:00
asiva de18295924 Adjust some status files for the new build configurations added to the buildbots. 
Change-Id: I5b80e45780078e5613a7934751173b091e93628f
Reviewed-on: https://dart-review.googlesource.com/c/78707
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-10-09 00:49:41 +00:00
asiva 26cab0a4db [VM/IO] The exit code handler thread should not try to get the exit codes for detached child processes. Currently we end up in a tight loop in the exit code handler when detached processes are created. 
Change-Id: I0eb207c4421d9e22e62ffd5a53478cf1553a3188
Reviewed-on: https://dart-review.googlesource.com/c/78701
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2018-10-08 23:22:19 +00:00
Ryan Macnak 6edc759798 [vm] Do not print if kernel isolate initialization is interrupted by VM shutdown. 
Compare service_isolate.cc

Change-Id: I759252539170ffb346a6cde18a8cf250528a0638
Reviewed-on: https://dart-review.googlesource.com/c/78700
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-08 22:56:52 +00:00
Ryan Macnak c8bda47d88 [standalone] Fix memory leaks when kernel isolate fails to launch from an app snapshot. 
For example, due to VM shutdown.

Bug: https://github.com/dart-lang/sdk/issues/32187
Bug: https://github.com/dart-lang/sdk/issues/32616
Change-Id: I6e7e7ab6ee4986a0e8aabf2b0100e19369c9cea2
Reviewed-on: https://dart-review.googlesource.com/c/78622
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-08 22:43:09 +00:00
Ryan Macnak 33485f8ef2 [standalone] Fix leak when the kernel service produces a compile-time error. 
Bug: https://github.com/dart-lang/sdk/issues/32187
Change-Id: If845eec40fe013120455ac851395ee215a3ce0d2
Reviewed-on: https://dart-review.googlesource.com/c/78623
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-10-08 22:41:36 +00:00
Alexander Markov 4486bf5f6b [vm/bytecode] Fix return value for several BigInt intrinsics 
If these intrinsics are called from interpreter and return garbage,
the interpreter might crash in Interpreter::InvokeCompiled while
inspecting the result.

Also, this CL contains a fix for the slow path of Int64 box
allocation in the interpreter.

Change-Id: I27143d38ed39fdc234520c57e85bff066cc8cde3
Reviewed-on: https://dart-review.googlesource.com/c/78187
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
 2018-10-08 21:38:48 +00:00
Zach Anderson b4b02a6bde [vm] Include bytecode in core-jit and app-jit snapshots 
when the --enable_interpreter flag is passed to gen_snapshot/dart.

Change-Id: I6e9481e1793e4c97fd6b14b56e55aafcb044fc23
Reviewed-on: https://dart-review.googlesource.com/c/78150
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-10-08 19:51:10 +00:00
Aart Bik 5b1444503e [dart/fuzzer] Minor output tweaks 
Rationale:
(1) does not print output difference on clusters
    to avoid cluttering logs (difference can be
    reproduced locally anyway after the fact)
(2) prints total # divergences at end in summary
Change-Id: I6fb736178569bfc0fa41afc525dee8f76ea7b465
Reviewed-on: https://dart-review.googlesource.com/c/78581
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-10-08 17:59:09 +00:00
Ryan Macnak 41a9c38433 [vm, compiler] Shrink deopt stub and runtime call sequences. 
dart2js release
AOT X64 Instructions(CodeSize): 10171456 -> 10090272 (-0.798%)
AOT ARM Instructions(CodeSize): 10814976 -> 10708512 (-0.984%)
AOT ARM64 Instructions(CodeSize): 11751328 -> 11646464 (-0.892%)
JIT X64 Instructions(CodeSize): 14296224 -> 13593536 (-4.92%)
JIT ARM Instructions(CodeSize): 16034352 -> 15685664 (-2.17%)
JIT ARM64 Instructions(CodeSize): 17207968 -> 16901504 (-1.78%)

Bug: https://github.com/dart-lang/sdk/issues/26033
Change-Id: Ic41a80fe8a90973811e74471e13f3edb6e4bffb6
Reviewed-on: https://dart-review.googlesource.com/c/77987
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-10-08 17:44:43 +00:00
Ryan Macnak b2d22be0f3 [vm, arm64] Take advantage of Fuchsia's lack of signal handlers. 
Change-Id: I5cac30574a697a91116658cab5289d80f316f4b1
Reviewed-on: https://dart-review.googlesource.com/c/77901
Reviewed-by: Zach Anderson <zra@google.com>
 2018-10-08 16:59:20 +00:00
asiva af57d2a0eb [VM] Remove dead code associated with flag '--error-on-bad-override' 
- Remove all dead code associated with flag '--error-on-bad-override' which is currently running only under !FLAG_strong which is not valid anymore
- Not removing the flag from flag_list for now as it is used in a number of tests and removing it from all these places would be a big change, it would be a NOP flag
- removed some dead code in 'loader.dart' which was invoked from the tag handler

Change-Id: I5474b51b4dee7471e80b4081e55b996f1d75612f
Reviewed-on: https://dart-review.googlesource.com/c/78382
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-10-08 04:44:24 +00:00
Alexander Aprelev 0bd4cc880d [gardening] Mark more tests slow 
Change-Id: I25c9e14b8831de910ba15999f9823604bf5a6885
Reviewed-on: https://dart-review.googlesource.com/c/78402
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-06 05:52:18 +00:00
Alexander Aprelev 20e57c1bcc [gardening] Differentiate windows bot test failures on ia32 vs x64 
Change-Id: I9e7751acb3d68d4916a17eb79f86014a428ba1bf
Reviewed-on: https://dart-review.googlesource.com/c/78401
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-06 05:20:49 +00:00
Alexander Aprelev d54b262888 [gardening] Windows test status adjustments 
Change-Id: If721a2994cd4992d861453f0293625dee9aa076c
Reviewed-on: https://dart-review.googlesource.com/c/78400
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2018-10-06 04:36:48 +00:00
Aart Bik 4d69ecf4be [dart/fuzzer] Avoid OOM situations that may yield false divergence 
Bug:
https://github.com/dart-lang/sdk/issues/34688
https://github.com/dart-lang/sdk/issues/34681

Change-Id: Ia6426e2f6415294352d2a3bd3c10ed575ad8c261
Reviewed-on: https://dart-review.googlesource.com/c/78384
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-10-06 00:13:20 +00:00
Aart Bik f048ef3da8 [dart/fuzzer] Periodic output to keep cluster logs happy 
Rationale:
Even though I tried to keep fuzz testing log output to a
bare minimum, not showing something at least every 20 minutes
may cause a cluster run timeouts. Therefore, show some progress
indicators during run to keep cluster logs happy.
Change-Id: I59ea0e50d2ccbe78cf09fc2ee397eeb404ec72a2
Reviewed-on: https://dart-review.googlesource.com/c/78321
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-10-05 23:53:27 +00:00
Alexander Aprelev eddfdd00a4 [gardening] Further windows test status tweaks. 
Change-Id: I0a438fc8aaa84a648debe0c1832b228b5ec83f5b
Reviewed-on: https://dart-review.googlesource.com/c/78381
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-05 22:55:56 +00:00
Alexander Aprelev 08f6b34f78 Revert "[vm] Assert that we are not trying to construct old(reloaded) class constructor." 
This reverts commit ff3a841e2d as it
breaks quite a few reload buildbots tests.

Change-Id: I6e1d0bc6b69d4349e2ee47cb3419ec90ea129384
Reviewed-on: https://dart-review.googlesource.com/c/78380
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-05 22:06:18 +00:00
Alexander Aprelev 35a825ab5f [gardening] Mark service/pause_on_unhandled_async_exceptions2_test with dartk slow. 
Change-Id: I423649e2232dfbb52c7da2a72fee749484af3f14
Reviewed-on: https://dart-review.googlesource.com/c/78325
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-05 21:54:23 +00:00
Alexander Aprelev ea45756a7b [gardening] Windows dartk test status update. 
Change-Id: I30694678354943edeb2effc108bb922ee6fcb093
Reviewed-on: https://dart-review.googlesource.com/c/78342
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-05 21:46:58 +00:00
Zach Anderson 330deaa4e1 [vm] Disable library name and exported name caches 
Improves kernel loading time >5%

Change-Id: I1c5ed4cbb2de267b6f47c75612c09da620e9fb89
Reviewed-on: https://dart-review.googlesource.com/c/78183
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-10-05 17:31:20 +00:00
Alexander Aprelev ff3a841e2d [vm] Assert that we are not trying to construct old(reloaded) class constructor. 
Construction of old class constructor is not possible since we didn't keep its fields, its structure.

Change-Id: I1e2239c0aa1012737e94c8ba42b0fc07a732b61d
Reviewed-on: https://dart-review.googlesource.com/c/77986
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-05 15:52:31 +00:00
Aart Bik d31db6581c [dart/fuzzer] Add kbc execution mode 
Rationale:
This enables testing of bytecode interpretation,
compilation, or mixed mode.


Change-Id: Ie4322c62f1f6a1abe4896ec98c4edf40d25b7135
Reviewed-on: https://dart-review.googlesource.com/c/78186
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-10-05 05:39:09 +00:00
Alexander Markov 54a1738f87 [vm/compiler] Allocate result of BIT_NOT constant evaluation in Heap::kOld 
Fixes https://github.com/dart-lang/sdk/issues/34683

Change-Id: I6f7b797e495f2af61fa27eecca3a3e6aadfdc3b5
Reviewed-on: https://dart-review.googlesource.com/c/78188
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-10-05 01:30:12 +00:00
Ryan Macnak cc28d2caaa [standalone] Remove code for --snapshot-kind=app-aot from main.cc. 
This code was only used for dart_bootstrap, which has been removed.

Change-Id: I62f26a97058569724fdb2eb7344132a9e23b4207
Reviewed-on: https://dart-review.googlesource.com/c/78147
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-05 00:36:53 +00:00
Aart Bik a6f4b8d879 [vm/compiler] Fix crashes in AOT X64 DEBUG compiler. 
Rationale:
The method ConstructReplacementFor() in range analysis would unconditionally
replace an UnaryInt64Op with an UnaryUint32Op, regardless of whether it contains
an NEGATE or NOT. None of the backends supports a NEGATE UnaryUint32Op,
however (I added a missing assert to X64 for the future, even though we currently
found the issue in the constructor already). Note that alternatively we could implement
NEGATE UnaryUint32Op for all platforms.

Note:
A similar issue was found for TRUNCDIV with a second fuzz test, which is fixed
in same CL with a more general approach.

Bug:
https://github.com/dart-lang/sdk/issues/34678
https://github.com/dart-lang/sdk/issues/34679


Change-Id: I370268620008e5d4cb605c0bd11e423d8fcd5327
Reviewed-on: https://dart-review.googlesource.com/c/78148
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-10-04 23:10:45 +00:00
Aart Bik e1421f3d08 [dart/fuzzer] avoid timeouts 
Rationale:
Based on monitoring several runs, AOT on SIMARM(64)
simply takes too much time, resulting in sessions
that only have timeouts. Until we fix the runtime,
this CL disables these runs just to avoid wasting
cluster cycles.
Change-Id: I626ab07c64bd097dc8d654dbfc6a8030bc7803d1
Reviewed-on: https://dart-review.googlesource.com/c/78181
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-10-04 21:42:50 +00:00
Aart Bik 8d0281e03b [dart/fuzzer] Shard fuzzer support 
Change-Id: I727498e5fbc321bbcd9546f43b25cf3c47209dd1
Reviewed-on: https://dart-review.googlesource.com/c/78180
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-10-04 20:47:20 +00:00
asiva c6254163dc Fix source filter in built rule. 
Change-Id: I91167e012b48ae2c25e4f4d6edf14e86767affed
Reviewed-on: https://dart-review.googlesource.com/c/78146
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2018-10-04 20:32:26 +00:00
Alexander Markov a97ddf8ce1 [vm/bytecode] Fix sporadic crashes when running with bytecode. 
Several tests crashed sporadically as bytecode Code object was not
properly scanned by GC.

Change-Id: I4810c46552a9f1990f1304f7c502b3408df8ed88
Reviewed-on: https://dart-review.googlesource.com/c/78141
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-10-04 20:01:25 +00:00
Aart Bik 74f2348941 [dart/fuzzer] DartFuzz Improvements 
Included:
(1) Added more expression variants in generator.
(2) Added --isolates option in driver (enables parallel execution).


Change-Id: I4e04490acc3046fd4771dd07502ba0fcdceb7df5
Reviewed-on: https://dart-review.googlesource.com/c/77720
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-10-04 16:47:58 +00:00
Martin Kustermann 1cd2fc5883 [Gardening] Mark pause_on_unhandled_async_exceptions_test also flaky on kernel 
Issue https://github.com/dart-lang/sdk/issues/34673

Change-Id: I668e0ca670ef380860109653a66e5603fc8ebbbb
Reviewed-on: https://dart-review.googlesource.com/c/78124
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-10-04 16:39:47 +00:00
Martin Kustermann 22da7488ac [Gardening] Mark two service tests as passing on dartk-windows 
Change-Id: I9a905214d5ffa5275e4541740bc61c22d5b0d041
Reviewed-on: https://dart-review.googlesource.com/c/78120
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-10-04 14:51:54 +00:00
Alexander Markov 46983c2de9 [vm/aot/tfa] Detect if a method/setter is called from this 
This information could useful in AOT to omit unchecked entry points.

Change-Id: I1c54720e46d578dc64f67306abdf4619a34ae122
Reviewed-on: https://dart-review.googlesource.com/c/77921
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2018-10-04 11:26:44 +00:00
Devon Carew 45a5bc063a Mark the Script.source field as nullable. 
Change-Id: I1f176c7aa75eb9a15d3e237d894395632830291e
Reviewed-on: https://dart-review.googlesource.com/c/77981
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-10-03 22:59:17 +00:00
Ryan Macnak 69358a8755 [vm] Remove Dart_IsSnapshot and Dart_IsDart2Snapshot. 
Script snapshots no longer exist, so there is no need to distinguish them from kernel files via Dart_IsSnapshot. All snapshots are Dart 2 snapshots, so there is no need to distinguish them via Dart_IsDart2Snapshot.

Change-Id: I996ec4b4e63da6dbebbe05515392f067aa13f578
Reviewed-on: https://dart-review.googlesource.com/c/77942
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-03 21:19:37 +00:00
Todd Eisenberger cbf97be4e7 [fuchsia] Switch to new fdio API names 
Change-Id: Ib11fad17ddc04dad641a457f0a6db1e39d1f1c06
Reviewed-on: https://dart-review.googlesource.com/77700
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-10-03 18:28:27 +00:00
Zachary Anderson aedf5127bd [vm] Enable bump allocation scope for kernel loader 
This shifts the bump allocation scope up to the Dart_ API
implementation so that an IsolateReloadContext won't try
to enter one. It also disables reload during the scope.

Change-Id: I3ca52f35c3a43f58e447e88b4fa91a84d3eacdd9
Reviewed-on: https://dart-review.googlesource.com/77522
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-10-03 17:54:43 +00:00
Alexander Aprelev a33c1a1c17 [vm] Use proper lookup to find constructor during rebinding. 
Change-Id: Ia3113e10702b21293bb91a7169a6106ebaabc1c7
Reviewed-on: https://dart-review.googlesource.com/77675
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-03 17:38:57 +00:00
Alexander Markov 6d0601a72b [vm/bytecode] Add bytecodes for int operations and '== null' 
DeltaBlue performance in pure interpreted mode
(--enable-interpreter --compilation-counter-threshold=-1):
Before: DeltaBlue(RunTime): 269198.732 us.
After:  DeltaBlue(RunTime): 158216.34376923076 us. (-41.23%)

Change-Id: I9dea8d7949421986ee6fbdeae046fe4ef6d3227f
Reviewed-on: https://dart-review.googlesource.com/c/77231
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-10-03 15:45:36 +00:00
Samir Jindel 6c5326ae80 [vm] Fix issue with debugging generated code within RR. 
Change-Id: Ifa13d6695624158367b0aa1baadd6ca41e13197f
Reviewed-on: https://dart-review.googlesource.com/c/77880
Auto-Submit: Samir Jindel <sjindel@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-10-03 14:09:17 +00:00
Ryan Macnak d2e08e4952 [vm] Disable concurrent sweeping when --deterministic is set. 
Concurrent sweeping introduces non-determinism in heap iteration order, which can affect the result of (e.g.) Symbols::Compact.

Bug: https://github.com/dart-lang/sdk/issues/34638
Change-Id: If5afa41d23b0eabdcd67d0f30d0f8ab1acb3bbd6
Reviewed-on: https://dart-review.googlesource.com/c/77677
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-02 23:36:45 +00:00
asiva 30aa464f77 [VM] Remove 'corelib' and 'dart-io' sources generation into C++ arrays 
- Remove all code that generates the corelib and dart:io library sources into C++ arrays and link them into dart_bootstrap
- Remove the executable dart_bootstrap and all uses of it
- Remove bootstrap_nolib.cc and builtin_nocore.cc
- Remove the Dart 1 code in core lib bootstrap path

Change-Id: Ifd33496204285a08b42fe09e39428e7a92b416b6
Reviewed-on: https://dart-review.googlesource.com/c/77241
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-10-02 23:27:05 +00:00
Ryan Macnak abe93563c4 [vm, service] Enable _collectAllGarbage in release mode. 
Bug: https://github.com/dart-lang/sdk/issues/34618
Change-Id: I6f70797a221a2f9406f675ce9d97cd0bdab3a1f1
Reviewed-on: https://dart-review.googlesource.com/c/77642
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-02 23:21:53 +00:00
Ryan Macnak 4053ff96ec [vm] Fix --print-instructions-sizes-to in debug mode. 
Bug: https://github.com/dart-lang/sdk/issues/34650
Change-Id: I707ce48db7360061a71a50cc0dcd741775c3c272
Reviewed-on: https://dart-review.googlesource.com/c/77668
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-02 20:52:46 +00:00
Aart Bik 0016f80467 [dart/fuzzer] Pick execution modes at random by default 
Rationale:
Provides randomness for our bots without having to
explicitly code all execution modes.
Change-Id: Ida680ece59dd05e6fc11aa60ab9d4deacdbf3d05
Reviewed-on: https://dart-review.googlesource.com/c/77664
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-10-02 20:10:07 +00:00
Ryan Macnak 0804245caa [vm] Make filtering in Heap::RecordAfterGC consistent with ServiceEvent::ServiceEvent. 
Bug: https://github.com/dart-lang/sdk/issues/34640
Change-Id: Ie9771efe7af221c00d89f7f476d7faef76fc108f
Reviewed-on: https://dart-review.googlesource.com/77640
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-02 19:08:30 +00:00
Vyacheslav Egorov 0b48c4a6ad [gardening] Mark appjit_determinism_test flaky on IA32 
https://github.com/dart-lang/sdk/issues/34638

TBR=rmacnak@google.com

Change-Id: I28bd11ec2509385bbed781d53002c737d848adcc
Reviewed-on: https://dart-review.googlesource.com/77580
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-10-02 16:02:55 +00:00
Ben Konyi 07a8496919 [VM] Allow for Dart_SetVMFlags to be called again after Dart_Cleanup 
Change-Id: Icf07258cfb05a987e0a439277a59825c06f993b2
Reviewed-on: https://dart-review.googlesource.com/77486
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-10-02 00:33:37 +00:00