dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

15405 Commits

Author SHA1 Message Date
Zach Anderson 825d03c585 [vm] Remove malloc_hooks support for jemalloc 
Fuchsia is switching/has switched to scudo.

Change-Id: I0c829518652053243bf3f8db675e562ccfb448f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95663
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2019-03-06 19:16:27 +00:00
Daco Harkes 7a98559781 [vm/ffi] make Pointer.toString() uniform on all operating systems 
Change-Id: I805c8b3c56a18a253c5005945cab47d5a6aa26cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95648
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
 2019-03-06 16:48:09 +00:00
Alexander Markov dc1f2bd087 [vm] Avoid assertion for non-finalized type parameter of expression evaluation function 
This is the follow-up for https://dart-review.googlesource.com/c/sdk/+/95061.

Fixes https://github.com/dart-lang/sdk/issues/36117

Change-Id: I70d7a753fcb4d4063510548e74d635a35447b3dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95540
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-06 00:35:34 +00:00
Ben Konyi cbc404b6de [VM] Cleanup status files some more 
Change-Id: Ib7560d864b5506b2629413ccb1d70b8281e16315
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95040
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
 2019-03-05 23:47:14 +00:00
Ryan Macnak 2922878ce9 [vm, compiler] Fix GuardFieldTypeInstr to update the original field. 
Change-Id: I698b6f3315e76f6d491f514333cf38e035ad6e79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95423
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-03-05 23:06:22 +00:00
Ryan Macnak 60de5b4983 [vm] Avoid quadratic growth in (Malloc)TextBuffer and ZoneTextBuffer. 
In particular, avoid quadratic memory use in ZoneTextBuffer.

Change-Id: I8d2ea77d35cd3c2c353ae557a2ee676ee8413653
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95483
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-03-05 22:32:22 +00:00
Alexander Markov 51a334caa7 [vm] Remove kernel reading from BuildArgumentTypeChecks 
This change is a preparation for decoupling flow graph building of
special functions from kernel reading.

Change-Id: Ied90bc6894cdfa48f49c71e980079967c8c4fbb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95061
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-03-05 18:48:51 +00:00
Daco Harkes 2071d1284d [vm/ffi] Fix crash on toString for dart:ffi trampoline functions 
Change-Id: I8af3373619dca690a2f5e60f737714e1ac413408
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95500
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-03-05 17:43:56 +00:00
Liam Appelbe cc455ecc1d Add use_abi_version flag, and plumb ABI version to version.h 
Bug: https://github.com/dart-lang/sdk/issues/36047
Change-Id: Ie810cbd5079e1939bf190e06f6c2494bb4ab0805
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95282
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-05 17:16:11 +00:00
Samir Jindel ed8357cf83 Re-land "[vm/ffi] Stress tests for FFI functions."" 
We will only run the tests on supported configurations. Issues are open
to expand coverage.

This reverts commit 1d3a0d5129.

Change-Id: I28d90f36a97914dc0cb04c39046cb4bdafe1740b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95023
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-03-05 14:17:08 +00:00
Aart Bik 571ea80e11 [vm/compiler] added assert to kernel flowgraph builder 
Rationale:
Yields a more gentle crash in debug mode for
bug under investigation (found by DartFuzz)

https://github.com/dart-lang/sdk/issues/36076

Change-Id: I497fbef1ec2100b9701848c3454bef5ad7518d2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95280
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-03-04 19:30:53 +00:00
Aske Simon Christensen 2b2e71770c [kernel] Add SetConstant node to Kernel. 
Change-Id: I83da1afc9f15009c650a871a51ca8171b482d4df
Reviewed-on: https://dart-review.googlesource.com/c/94863
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-04 10:20:56 +00:00
Martin Kustermann 084e98e3a3 [VM] Ensure that a newly allocated object is either new or added to remembered set if we want to eliminate write barriers to it 
For all non-generic classes the AllocateObject runtime call would not
guarantee that the returned object is new or marked as remembered. If
such an object is subject to a store with an eliminated write-barrier,
we have incorrect remembered set, which causes flaky crashes.

This CL fixes the AllocateObject runtime call to always ensure the
object is new or added to the remembered set if write-barrier
elimination is enabled for those.

Furthermore the conditions for when the write barrier can be eliminated
is centralized in one place instead of duplicated (in runtime_entry.cc
and il.h) to avoid future divergence of the two.

Similarly the condition to when an array uses card marking is put into
one place.

Fixes https://github.com/dart-lang/sdk/issues/36011

Change-Id: I270f3618a267a35fa6ea63dcf4092488c0319328
Reviewed-on: https://dart-review.googlesource.com/c/95022
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-03-04 09:09:56 +00:00
Régis Crelier 0491d5cde7 Revert "[VM runtime] Dual mapping of executable pages." 
This reverts commit 44186dfdcd.

Reason for revert: not working on vm-kernel-precomp-android-release-arm

Original change's description:
> [VM runtime] Dual mapping of executable pages.
> 
> Change-Id: Iaad78d324e25462ce951f4df26974a6a368c50b7
> Reviewed-on: https://dart-review.googlesource.com/c/93377
> Commit-Queue: Régis Crelier <regis@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>

TBR=rmacnak@google.com,regis@google.com

Change-Id: I793ceee6252111eafbcbfe6e28268f4f6f2d7215
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/94989
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-01 22:55:14 +00:00
Liam Appelbe df59b09756 Fail early if a thread has no stack headroom 
Bug: https://github.com/dart-lang/sdk/issues/35745
Change-Id: I6a9dff8608385d4dde74a16b6d4dea42fe91460f
Reviewed-on: https://dart-review.googlesource.com/c/95041
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-03-01 22:34:21 +00:00
Régis Crelier 44186dfdcd [VM runtime] Dual mapping of executable pages. 
Change-Id: Iaad78d324e25462ce951f4df26974a6a368c50b7
Reviewed-on: https://dart-review.googlesource.com/c/93377
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-03-01 22:19:31 +00:00
Ben Konyi 1a9f40b1c5 [VM] Remove unnecessary assert to fix cc/PrintJSON test 
Change-Id: If6f44a3136002cd4c682f6b88bbd772db8f467b3
Reviewed-on: https://dart-review.googlesource.com/c/94984
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-03-01 19:07:30 +00:00
Régis Crelier c2a48ee065 [VM] Fix bigint left shift that could cause heap corruption when intrinsified. 
The size of the result digit array was not computed correctly.
When 64-bit intrinsics are used, one extra digit pair must be allocated.

Change-Id: Id3ca3a16ef24b598e44bf25221d400b9be71248a
Reviewed-on: https://dart-review.googlesource.com/c/94683
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-01 18:59:10 +00:00
Ryan Macnak dc555eb9a7 [vm] On Fuchsia, enable timeline streams based on the state of system trace categories. 
Allows categories to be selected through arguments to `trace` instead of changing VM flags and rebuilding.

Change-Id: Ia1ec6b58ca0b765c3d675b7d4938acc5f624b768
Reviewed-on: https://dart-review.googlesource.com/c/91860
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-03-01 18:05:40 +00:00
Alexander Markov c35304ef18 [vm/simdbc,interpreter] Preserve arguments descriptor around call to inline cache miss handler 
InlineCacheMissHandler* runtime entries may cause class finalization and
potentially run more Dart code (for example, to evaluate pragma annotations).
That could clobber arguments descriptor in simulator/interpreter.

Usually classes are finalized before their instances are allocated.
However, VM creates instances of certain built-in classes "magically",
without finalizing classes. For such classes finalization can occur
on the first method invocation.

Change-Id: I247197baf36858bfa43812aaaed02b10584762e0
Reviewed-on: https://dart-review.googlesource.com/c/94960
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-03-01 17:24:40 +00:00
Ian McKellar 16fc751e49 [fuchsia] Clean-up after the FIDL string/vector types transition 
This cleans up what was introduced in:
https://dart-review.googlesource.com/c/88122

Change-Id: If7596a3dd57af25d91fe880104e5aafd301c57f4
Reviewed-on: https://dart-review.googlesource.com/c/94922
Auto-Submit: Ian McKellar <ianloic@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-03-01 02:01:19 +00:00
Alexander Markov 1d3a0d5129 Revert "[vm/ffi] Stress tests for FFI functions." 
This reverts commit b186a270e4.

Revert "[vm] Fix windows build after "[vm/ffi] Stress tests for FFI functions.""

This reverts commit 3dcc0c69a1.

Revert "[vm] Update status file for standalone_2/ffi/function_stress_test"

This reverts commit 9d609426b2.

Revert "[gardening] Skip ffi/negative_function_test on asan bot"

This reverts commit 223f407af5.

Reasons for revert:
1) timeouts on app-kernel-linux-debug-x64 bot when it
tries to deflake new tests.
2) crash dump archiving fails on vm-kernel-asan-linux-release-x64
when trying to archive crash dumps from these tests.

Issue: https://github.com/dart-lang/sdk/issues/36033
Issue: https://github.com/dart-lang/sdk/issues/36034
Change-Id: Ifa338fb96b490e8137a8aa6a4a62f4a6f9e6ea83
Reviewed-on: https://dart-review.googlesource.com/c/94963
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
 2019-03-01 01:37:09 +00:00
Ryan Macnak 24df9cc588 [vm] Implement interpreter stubs for ARM, SIMARM and SIMARM64. 
Change-Id: If49e656bb3c016d42bc5588c6026116f2aff5076
Reviewed-on: https://dart-review.googlesource.com/c/94682
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2019-03-01 01:25:19 +00:00
Ben Konyi e8d6e2f704 [ VM ] Updated SourceReport tests with correct token positions 
Change-Id: I6aa49e715043a1ba463425e53018c5078a272129
Reviewed-on: https://dart-review.googlesource.com/c/94962
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-03-01 00:48:59 +00:00
Ryan Macnak 2259695037 [vm, gc] Document object representation. 
Change-Id: I18fea69cc86161c2f960854e636bfe07a44789cb
Reviewed-on: https://dart-review.googlesource.com/c/94841
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-03-01 00:32:25 +00:00
Aart Bik a10b0d8763 [vm/compiler] LICM and CSE improvements 
Several improvements
(1) makes implicit control dependence of a null check
    explicit by means of data dependence (already
    done for bounds checks); also see the doc in
    runtime/docs/compiler/data_dep_for_control_dep.md
(2) improves CSE properties of various IL nodes
(3) allows LICM on invariant code that may-throw
    as long as the visible behavior is preserved

https://github.com/dart-lang/sdk/issues/35323
https://github.com/dart-lang/sdk/issues/34684

Change-Id: Icb4520a649da38eddc3d7c85af21427d3c64d22e
Reviewed-on: https://dart-review.googlesource.com/c/93822
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-02-28 19:29:06 +00:00
Ben Konyi ff6f61c872 [VM / Observatory ] Remove needless stacktrace print when adding to closed socket 
Change-Id: Idc31b45fd880ff0233c7cbeb31a22d43fbcea01e
Reviewed-on: https://dart-review.googlesource.com/c/94840
Commit-Queue: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-02-28 18:35:03 +00:00
Alexander Markov bab9d2ad05 [vm] Remember GenericCovariantImpl in TypeParameter 
Previously, in order to get GenericCovariantImpl property of a type
parameter we had to (re-)read kernel.

This change is a preparation for decoupling flow graph building of
special functions from kernel reading.

Change-Id: I48b45d2cece683ac3a3bd0ed506ddfcc3c526826
Reviewed-on: https://dart-review.googlesource.com/c/94641
Commit-Queue: Régis Crelier <regis@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2019-02-28 17:38:19 +00:00
Samir Jindel 3dcc0c69a1 [vm] Fix windows build after "[vm/ffi] Stress tests for FFI functions." 
Change-Id: Iac44ba54452c8ae831202fa0c41b896b83a4a2fa
Reviewed-on: https://dart-review.googlesource.com/c/94754
Commit-Queue: Samir Jindel <sjindel@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-02-28 17:34:47 +00:00
Samir Jindel b186a270e4 [vm/ffi] Stress tests for FFI functions. 
Change-Id: I75251b92688b70b4d14eda7b1fddef0fe94c60fe
Reviewed-on: https://dart-review.googlesource.com/c/94384
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
 2019-02-28 16:40:36 +00:00
Ryan Macnak a3ab6b6514 [vm, gc] Reduce cost of maintaining allocation stats during scavenges. 
Change-Id: If44fe99c87b96f4f370efb3716009e230b5c4f25
Reviewed-on: https://dart-review.googlesource.com/c/94583
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-02-27 22:01:00 +00:00
Alexander Markov ab10fb12dc [vm/interpreter] Reduce stack usage of interpreter 
Bug: FLK-46
Change-Id: Ia596f46629ad32492b460a2ae54501f55b7e6ed4
Reviewed-on: https://dart-review.googlesource.com/c/94600
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-02-27 19:18:27 +00:00
Lasse R.H. Nielsen 40bab34fbd Fix Stopwatch timers to not overflow on intermediate computations. 
With a nanosecond tick counter, the elapsedMicroseconds getter
could overflow if a stopwatch runs for only ~2.5 hours.

Change-Id: I10cb54bba928713a3127a6bfbd19346b01d775b0
Reviewed-on: https://dart-review.googlesource.com/c/94381
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-02-27 09:56:12 +00:00
Ryan Macnak 603678e46c [vm, gc] Streamline the promotion allocation fast path. 
dart2js-compile geomean -0.8362% (Time)

Change-Id: I98dbbed2e7b96c8ff4950cc59421aef6bceef23b
Reviewed-on: https://dart-review.googlesource.com/c/94345
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-02-27 01:53:45 +00:00
Ryan Macnak 8fd09304b6 [vm, gc] Force inline MarkObject into its sole caller. 
Cf. e38e5aae46

Change-Id: Ibf9dad7358368eba2c20ba552fe6f83e2ce6ddc5
Reviewed-on: https://dart-review.googlesource.com/c/94466
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-02-27 01:46:16 +00:00
Alexander Aprelev fb88c983e7 [vm/compiler] Switch kernel helper for background compiler to use new space. 
Now that TLAB is enabled, background compiler can use new space for short-lived data created during kernel loading.

Change-Id: I0a05510bcc73be268895f093cd1422d80d6e39bf
Reviewed-on: https://dart-review.googlesource.com/c/94361
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2019-02-27 00:50:07 +00:00
Aart Bik 6d575152c9 [vm/compiler] Changes in Cid range computation 
Rationale:
An incorrect edit slipped into the JIT version, which
had some performance regression. Also we now make
the null optional when not excluded explicitly, since
this results in no ranges for a few cases.

https://github.com/flutter/flutter/issues/28260

Change-Id: I799683d938287661321033d6839fcf2f471b2bc4
Reviewed-on: https://dart-review.googlesource.com/c/94349
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-02-26 23:05:15 +00:00
Ryan Macnak fba89f9f64 [vm] Don't change the content of the VM isolate's snapshot based on what was loading into a core or app snapshot. 
Ensures, by default, multiple core or app snapshots are capable of being loaded into the same process. Flags that affect stub generation can still create incompatibilities. A later CL will internalize VM isolate snapshot generation to the VM build and ensure compatibility.

Change-Id: I247063d5a3a611b04963b8e8ab2ac8a1f20ea57a
Reviewed-on: https://dart-review.googlesource.com/c/93962
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-02-26 19:04:50 +00:00
Samir Jindel f0042a3225 [vm/ffi] Factor out FFI code shared between compiler and runtime. 
Change-Id: I0b4af9cb36fd5ebc163621951486333a68baa890
Reviewed-on: https://dart-review.googlesource.com/c/93503
Commit-Queue: Samir Jindel <sjindel@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
 2019-02-26 12:48:32 +00:00
Ben Konyi f7e435ac26 [ VM / Windows ] Removed call to SetThreadDescription which is only supported in new Win 10 builds 
This (hopefully) unblocks the Dart SDK roll into Flutter.

Change-Id: I5616fb2ace879f3a0c4532706d472f2cb488267d
Reviewed-on: https://dart-review.googlesource.com/c/94347
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-02-26 01:00:26 +00:00
Ryan Macnak bf7ecc40f9 [vm] Fix some compilation events to respect SUPPORT_TIMELINE instead of PRODUCT. 
Cf. d6caaeeebb

Change-Id: I1b1db807113f38a3a3205b33d523c5db0961bd41
Reviewed-on: https://dart-review.googlesource.com/c/94360
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2019-02-26 00:02:06 +00:00
Aart Bik fa0ba2220e [vm/compiler] Fix bug in Cid range computation 
Rationale:
Make sure open range is closed when skipping
special cids. This bug was probably undetected
for a while, since only kByteBufferCid is adjacent
to kNullCid.

https://github.com/flutter/flutter/issues/28260

Change-Id: Ic22c83aeb26c3130132dc901004a0ad818246dbc
Reviewed-on: https://dart-review.googlesource.com/c/93926
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-02-25 22:31:24 +00:00
Ryan Macnak afb8747fc2 [vm/tools] Add option in Graph Explorer to rewrite the graph to be more hierarchical. 
Helps to reveal more struction in the dominator tree that is normally lost from cross links added by call sites, allocation sites, inlining, etc.

Change-Id: Ib59350f9926324e6c53333388709ce4964c3f88b
Reviewed-on: https://dart-review.googlesource.com/c/94300
Reviewed-by: Aart Bik <ajcbik@google.com>
 2019-02-25 21:21:02 +00:00
Alexander Markov 55c07c6d7a [vm] Fix null checks when CodeSourceMap is missing 
This change fixes null checks in case of missing CodeSourceMap,
which happens when --dwarf_stack_traces is used.

Issue: https://github.com/dart-lang/sdk/issues/35851
Change-Id: I7d79533cc42c988618e2efe988f530d169d9aec1
Reviewed-on: https://dart-review.googlesource.com/c/93989
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-02-25 05:50:14 +00:00
Kevin Millikin c9b8bae4e6 [Kernel] Add BlockExpression to the Kernel language 
This is not yet used or tested.

Change-Id: Id050802926ad6452df3c39ace12ea5dd56d4faaa
Reviewed-on: https://dart-review.googlesource.com/c/87970
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2019-02-22 12:38:26 +00:00
Martin Kustermann 128acb264b [VM] Decouple compile_type.h from runtime by making it only use runtime_api.h 
Issue https://github.com/dart-lang/sdk/issues/31709

Change-Id: I36ae58a4d4f4540433cdb6de2aa370d025142863
Reviewed-on: https://dart-review.googlesource.com/c/93942
Auto-Submit: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-02-22 11:02:16 +00:00
Ryan Macnak d253642f25 [standalone] Fix isolate messages for processes that a creating an AppJIT snapshot. 
The standalone embedder was sorting classes in the main isolate, but not child isolates, causing the CIDs to diverge.

Also fix a few isolate tests.

Bug: https://github.com/dart-lang/sdk/issues/33128
Bug: https://github.com/dart-lang/sdk/issues/36000
Change-Id: Ic21acb02eb623ae177ed242aa21b0e243775e369
Reviewed-on: https://dart-review.googlesource.com/c/93923
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-02-21 22:39:39 +00:00
Liam Appelbe ee32f8c87e [VM] Rehash sets after they are read from a snapshot. 
Fixes: https://github.com/dart-lang/sdk/issues/35626
Bug: https://github.com/dart-lang/sdk/issues/35626
Change-Id: I4d5b3799072faf8abb16e9eac15b834dbecce07b
Reviewed-on: https://dart-review.googlesource.com/c/93843
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2019-02-21 19:39:09 +00:00
Ben Konyi 4cff5a4fd6 [ VM / Service ] Dynamically load source from linked-in platform kernel 
- Added `Dart_SetDartLibrarySourcesKernel` to the Dart embedding API.
- vm_platform_strong.dill now contains the Dart SDK sources
- If vm_platform_strong.dill is linked into the Dart binary, the first
  request for a Dart SDK Script object from the VM service will load the
  sources for the script from the linked in kernel buffer.

Change-Id: I664abe31f9378d25ec79c21edce0b237a278495d
Reviewed-on: https://dart-review.googlesource.com/c/93375
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-02-21 18:22:39 +00:00
Ryan Macnak dc2422ef84 [vm, gc] Fix accounting of external sizes in the class table. 
- Reset both new and old external sizes for both new and old space GC. Every GC visits weak handles for both generations.
 - Don't double count external old size during promotion.

Change-Id: Ic6ad1b4cad58ad18637cee974b170a2eab8afe29
Reviewed-on: https://dart-review.googlesource.com/c/93881
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2019-02-21 01:27:29 +00:00