e7175ac2ed
[vm, fuchsia] Consume specialized symbols for the Dart VM's profiler.
...
Bug: FL-238
Change-Id: Ie5e2786aeb47063ea1c534b2169b2547d6693a96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100200
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2019-04-24 19:53:35 +00:00
07852532e3
[ VM ] Additional cleanup in Dart_Initialize and Dart_Cleanup
...
Change-Id: I6dc02b3d9de16cc176eb97613bc0c7f0bb9b16eb
Reviewed-on: https://dart-review.googlesource.com/77013
Commit-Queue: Ben Konyi <bkonyi@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Auto-Submit: Ben Konyi <bkonyi@google.com >
2018-09-28 23:18:59 +00:00
6cd8a79078
VM: Re-format to use at most one newline between functions
...
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2974233002 .
2017-07-13 08:08:37 -07:00
030473f0ff
Fix the fix for the native symbol resolver on Windows.
...
The 'start' output parameter is optional, so check for NULL is required.
BUG=
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2772563002 .
2017-03-22 14:50:18 -07:00
9111df606e
Fix Windows native code profiling.
...
The start address for native symbols is now correctly computed.
Before it was left 0 - the symbol lookup code was just enabled in my previous CL.
BUG=
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2770863002 .
2017-03-22 14:17:48 -07:00
c32bfb4e34
Enable native symbol resolving on Windows again
...
This is needed when dumping stack traces.
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2768913002 .
2017-03-22 12:51:40 -07:00
b09552cd62
Reapply "DWARF and unwind support for AOT assembly output."
...
This reverts commit 8fcdbb4a7fR=vegorov@google.com
Review-Url: https://codereview.chromium.org/2761593002 .
2017-03-20 13:02:41 -07:00
8fcdbb4a7f
Revert "DWARF and unwind support for AOT assembly output."
...
Gardening.
This reverts commit ca20aab384https://codereview.chromium.org/2754233002 .
2017-03-17 12:57:45 +01:00
ca20aab384
DWARF and unwind support for AOT assembly output.
...
Emit CFI information to teach gdb how to unwind Dart frames. Fixes unwinding for Mac x64 and Linux x64/ARM/ARM64. Unwinding already worked for iOS ARM64. Fixes unwinding on Android 6+ ARM.
Emit DWARF information about function inlining and line number mappings. Works with gdb, addr2line and llvm-symbolizer.
With --dwarf-stack-traces, also remove CodeSourceMaps from snapshots and change stack traces to a non-compliant form resembling Android's debuggerd output, which can be passed to ndk-stack.
Issue #28785
R=fschneider@google.com , johnmccutchan@google.com , vegorov@google.com
Review-Url: https://codereview.chromium.org/2723213002 .
2017-03-16 13:08:54 -07:00
877284947b
Rename TARGET_OS_* to HOST_OS_*.
...
Like HOST_ARCH_*, HOST_OS_* describes the OS the VM is running on, which may be different from the OS the VM is generating code for during AOT compilation.
Currently we conflate the two when emitting AOT as assembly, and we get away with it because Flutter only uses assembly for targeting iOS and one can only target iOS from a Mac, but we expect to use assembly for Android as well so native tools can unwind Dart frames.
R=zra@google.com
Review-Url: https://codereview.chromium.org/2750843003 .
2017-03-15 13:11:05 -07:00
c7e9e048ed
Rename Thread -> OSThread.
...
It's a collection of static utility methods for primitive operations on OS threads.
Make room in the namespace for upcoming class that will represent all the complex state of a VM thread.
Review URL: https://codereview.chromium.org//796063006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42895 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 02:30:07 +00:00
14ecdbd66a
- Separate the thread implementation used in bin/ and vm/
...
to allow us to make VM specific changes.
R=asiva@google.com
Review URL: https://codereview.chromium.org//463993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39172 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 23:19:53 +00:00
7da1f4f3ba
Build map of code regions and address ticks for profile report.
...
Profile pauses should be less than 500 ms even when handling 120,000 samples (2 minutes @ 1000 hz).
Code objects are referenced by hex address: "code/cafebabe".
Test for retrieving code objects over the service.
Remove old profile tool scripts. Replaced by dprof (https://github.com/dart-lang/dprof ) and Observatory UI for profiler.
Support for stable service refs to implicit closures and dispatcher functions.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//100103011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31447 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-03 19:55:50 +00:00
919dc2d6eb
* Introduce ThreadInterrupter which calls a TLS set callback when thread is interrupted.
...
* Threads can only register and unregister themselves with ThreadInterrupter.
* Profiler is no longer involved in interrupting threads. It's just a callback and the buffer.
* Profiler operates lock free using an atomic operation to reserve sample in sample buffer.
* Linux, Mac, and Windows done.
R=asiva@google.com
Review URL: https://codereview.chromium.org//109803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31170 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-16 18:52:15 +00:00
b04d313c80
Disable native symbol resolver on WindowsDisable native symbol resolver on Windows
...
TBR
Review URL: https://codereview.chromium.org//81513004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30545 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-21 21:30:19 +00:00
97ac18aee9
Sampling profiler
...
BUG=4350
R=asiva@google.com
Review URL: https://codereview.chromium.org//25909002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30419 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-19 18:26:10 +00:00
Ryan Macnak