dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

126 Commits

Author SHA1 Message Date
Alexander Markov 3b22a7ae46 [vm/profiler] Fix native stack walker to properly skip PC = 0xFF..FF 
Fixes flaky service/get_cpu_profile_timeline_rpc_test test failure on debug/simdbc64
(Error "../../runtime/vm/profiler_service.cc: 290: error: expected: start_ < end_".)

Fixes https://github.com/dart-lang/sdk/issues/31794
Possible fix for https://github.com/dart-lang/sdk/issues/28736

Change-Id: I0119830d966aa24713c8572e28e4fc67e6d0de49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100920
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-04-30 22:27:12 +00:00
Alexander Markov 07482eeb5e [bots] Run all tests on vm-dartkb-* bots 
Bytecode configurations should have the same test coverage as default mode.

The following tests are excluded in dartkb mode as there are too many crashes:
 - service/* (debugging capabilities are not supported);
 - lib_2/mirrors/* (mirrors are not supported);
 - vm/cc/* (bytecode modes are not wired up in run_vm_tests).

Change-Id: I11eead94b96f43ab454acd6e6f6861af943c0488
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97847
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2019-04-05 18:25:34 +00:00
Ben Konyi ca2f03c5f8 [ VM / Service ] Allow for breakpoints to be set using either file: or package: URIs for packages. 
Additional minor changes:
- Sorted list of Symbols in symbols.h by name
- Added Symbol::PackageScheme() to symbol list

Change-Id: I2f739bfb5c8cbbe1e318614124695ae45dee4f23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98043
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2019-03-27 20:38:20 +00:00
Jens Johansen 14b2255584 Status update after c3c5250 
app_jitk also fails.

Change-Id: I7252d2a7b6e05151337dfff1cc7470ea34f8484a
Reviewed-on: https://dart-review.googlesource.com/c/91740
Auto-Submit: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-01-31 12:36:34 +00:00
Jens Johansen c3c525079b Demonstrate bug for the VMs way of doing initializers in face of mixins 
See http://dartbug.com/34841#issuecomment-458917175
and test in this CL for explanation.

Change-Id: Ie1d15078a9c5f71aa6edacd792b440520a3eb877
Reviewed-on: https://dart-review.googlesource.com/c/91660
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-31 10:08:15 +00:00
Ben Konyi b0900cf494 [ VM / Service ] Fixed issue where VMOptions were not being passed to app_jitk tests. 
Fixes #35512.

Change-Id: I34abbf0f73215b6695a0aa4ec6af6cb1c219d5e9
Reviewed-on: https://dart-review.googlesource.com/c/88429
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-01-08 00:44:38 +00:00
Daco Harkes e8c60f7ba6 [gardening] Mark service/simple_reload_test as Timeout for issue 35506 
Issue: https://github.com/dart-lang/sdk/issues/35506
Change-Id: I1d82426bf7f2af2253f6197abb47468f8c2b9fd4
Reviewed-on: https://dart-review.googlesource.com/c/88443
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2019-01-04 10:39:58 +00:00
Ben Konyi b61efcd3c4 [ VM / Service ] Started cleaning up tests for the service protocol. 
Mostly focused on app_jitk tests in this CL, but updated issue numbers
and statuses where appropriate.

Change-Id: I6b57d0a3091ad10ddd143c5b420f6b2121e9cc73
Reviewed-on: https://dart-review.googlesource.com/c/88128
Commit-Queue: Ben Konyi <bkonyi@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-12-28 20:53:39 +00:00
Ryan Macnak 566ae2490d [test] Update async stepping tests to reflect the status quo. 
Note that stepping behavior has degraded since support for Dart was removed, and now includes spurious steps through the async implementation.

Bug: https://github.com/dart-lang/sdk/issues/34746
Change-Id: I573e1a945d96a9ddda839f22e66e1f68202005c5
Reviewed-on: https://dart-review.googlesource.com/c/86828
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-12-12 02:31:02 +00:00
Martin Kustermann 25e38ebd60 [Gardening] Change tests to use default --sync-async behavior (this is what we care about), remove Crash status file marker 
To avoid Crashes for non-supported configurations (which --no-sync-async
is), this CL changes the tests to run in the default mode.

The tests are still failing because the new behavior does not match what
the test expects. -> The tests need to be changed.

Issue https://github.com/dart-lang/sdk/issues/34746

Change-Id: I920ca4e0070f9cfb43ecf2ee3ee754ec1fe80e4a
Reviewed-on: https://dart-review.googlesource.com/c/86352
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2018-12-06 12:10:33 +00:00
Martin Kustermann ad7fbb6dd7 [VM] Fix flow graph builder to not generate different code in unoptimized/optimized mode 
Change-Id: I752be6bd97dcd892ea6ba5d7fdd30575d4cee489
Reviewed-on: https://dart-review.googlesource.com/c/84720
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-22 14:05:47 +00:00
Ryan Macnak be670f0362 [test] Update status files for tests with code objects newly-passing on 64-bit Windows. 
Change-Id: I155a7e2ad338cb9a9aadf4a7699cf163c490112c
Reviewed-on: https://dart-review.googlesource.com/c/84836
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-11-20 01:25:08 +00:00
Ben Konyi 5afc1ec336 [ VM / Observatory ] Fixed tests that were failing due to lack of sources in app_jitk mode 
Change-Id: I74504cc5dea30a0b6841e0bf77d99c1cf3889269
Reviewed-on: https://dart-review.googlesource.com/c/84049
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2018-11-14 18:00:53 +00:00
Ryan Macnak bf26f2c022 [test] Update status for get_vm_timeline_rpc_test: Slow doesn't imply Pass. 
Change-Id: If6f4db659e8bdc31ec47367f8468b18947392918
Reviewed-on: https://dart-review.googlesource.com/c/83900
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-11-09 00:25:47 +00:00
Samir Jindel 56ea31b3d6 [vm/gardening] Mark get_vm_timeline_rpc_test as slow. 
Threads appear to still be doing real work when the timeout occurs. Local testing confirms
that the test is actually slow.

Change-Id: I3b0dfa467c5b2eeda481e31716cfc1e79583100d
Reviewed-on: https://dart-review.googlesource.com/c/83762
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
 2018-11-08 23:09:15 +00:00
Ben Konyi c086064565 [ VM / Gardening ] Mark flaky test get_vm_timeline_test as Pass, Timeout 
Change-Id: Id13e201e368ceded4adabc466e6c56938d1ff566
Reviewed-on: https://dart-review.googlesource.com/c/82523
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-11-02 05:35:28 +00:00
Ben Konyi 06c1ee0441 Reland "[ VM ] Delete code for _RegExp._ExecuteMatch and _RegExp._ExecuteMatchSticky before creating an app-jit snapshot." 
This reverts commit 022d181a4d.

Change-Id: Idcc9d681fea79ded731a49debb5faf88b88ca63c
Reviewed-on: https://dart-review.googlesource.com/c/82527
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
 2018-11-02 05:28:43 +00:00
Ben Konyi 022d181a4d Revert "[ VM ] Delete code for _RegExp._ExecuteMatch and _RegExp._ExecuteMatchSticky before creating an app-jit snapshot." 
This reverts commit 428a832a4b.

Change-Id: I7fb7dde39fd7575fb8885850007ca155b24b308e
Reviewed-on: https://dart-review.googlesource.com/c/82541
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-11-01 23:01:43 +00:00
Ben Konyi 428a832a4b [ VM ] Delete code for _RegExp._ExecuteMatch and _RegExp._ExecuteMatchSticky before creating an app-jit snapshot. 
Fixes issue #34422, where evaluating a RegExp on Windows during the
kernel isolate startup would crash when the '--interpret_irregexp' flag
was passed.

Change-Id: I4e8cd6a17973203b56ba0684a36a61b060f99670
Reviewed-on: https://dart-review.googlesource.com/c/82300
Commit-Queue: Ben Konyi <bkonyi@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-11-01 20:07:04 +00:00
Alexander Markov 5deb1c6e81 [vm] Remove strong mode and sync-async flags from pkg/vm 
Change-Id: Icd2920274ca4c402b38e5774bb408d6b5e529169
Reviewed-on: https://dart-review.googlesource.com/c/79082
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-10-10 20:11:35 +00:00
Alexander Markov 2695f36016 [Gardening] Status update (co19_2, optcounter/ia32) 
Change-Id: Ica90e83995ad2e89548c07824dc525f1cd84fd71
Reviewed-on: https://dart-review.googlesource.com/c/78921
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-10-09 23:56:31 +00:00
Alexander Markov 34651d204e [gardening] Update status 
Change-Id: I50470052bd646684d36c793424485a88f1b84ee6
Reviewed-on: https://dart-review.googlesource.com/c/78869
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-10-09 21:24:36 +00:00
Alexander Markov 70317473f0 [gardening] Update status 
Change-Id: Idb7feb6749df6824b0e3029ddc86112b18a7d7b2
Reviewed-on: https://dart-review.googlesource.com/c/78864
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-10-09 18:46:41 +00:00
asiva de18295924 Adjust some status files for the new build configurations added to the buildbots. 
Change-Id: I5b80e45780078e5613a7934751173b091e93628f
Reviewed-on: https://dart-review.googlesource.com/c/78707
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-10-09 00:49:41 +00:00
Alexander Aprelev 0bd4cc880d [gardening] Mark more tests slow 
Change-Id: I25c9e14b8831de910ba15999f9823604bf5a6885
Reviewed-on: https://dart-review.googlesource.com/c/78402
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-06 05:52:18 +00:00
Alexander Aprelev 20e57c1bcc [gardening] Differentiate windows bot test failures on ia32 vs x64 
Change-Id: I9e7751acb3d68d4916a17eb79f86014a428ba1bf
Reviewed-on: https://dart-review.googlesource.com/c/78401
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-06 05:20:49 +00:00
Alexander Aprelev d54b262888 [gardening] Windows test status adjustments 
Change-Id: If721a2994cd4992d861453f0293625dee9aa076c
Reviewed-on: https://dart-review.googlesource.com/c/78400
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2018-10-06 04:36:48 +00:00
Alexander Aprelev 35a825ab5f [gardening] Mark service/pause_on_unhandled_async_exceptions2_test with dartk slow. 
Change-Id: I423649e2232dfbb52c7da2a72fee749484af3f14
Reviewed-on: https://dart-review.googlesource.com/c/78325
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-05 21:54:23 +00:00
Alexander Aprelev ea45756a7b [gardening] Windows dartk test status update. 
Change-Id: I30694678354943edeb2effc108bb922ee6fcb093
Reviewed-on: https://dart-review.googlesource.com/c/78342
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-10-05 21:46:58 +00:00
Martin Kustermann 22da7488ac [Gardening] Mark two service tests as passing on dartk-windows 
Change-Id: I9a905214d5ffa5275e4541740bc61c22d5b0d041
Reviewed-on: https://dart-review.googlesource.com/c/78120
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-10-04 14:51:54 +00:00
Peter von der Ahé 56c2ed5e9e Avoid deprecation in source_loader 
Change-Id: Idf3250bd8fcc56f7d52e3f245671d2c1b91d0956
Reviewed-on: https://dart-review.googlesource.com/63144
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-09-13 08:10:15 +00:00
Ryan Macnak 02613eee3a [vm] Mark various service tests as now passing on -capp_jitk. 
Change-Id: I628ca476e7365a3af27834496c543a3926af10c3
Reviewed-on: https://dart-review.googlesource.com/74674
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-09-12 22:55:09 +00:00
Martin Kustermann e0f0f4b6a9 [gardening] Mark service/regexp_function_test as flaky 
Change-Id: Ib39bb6353b92ce89821256170c099828f72ebd05
Reviewed-on: https://dart-review.googlesource.com/74160
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-09-10 13:33:29 +00:00
Martin Kustermann a6c76475a9 [gardening] Mark service/regexp_test as Crashing on windows 
Issue https://github.com/dart-lang/sdk/issues/34422

Change-Id: I723512bfb68f58cf14d47a79dd443107db355507
Reviewed-on: https://dart-review.googlesource.com/74080
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-09-10 12:09:05 +00:00
Kevin Millikin 6e63df3bfb Revert "Avoid the deprecated input error in source_loader" 
Reverted because of failures on the VM reload tests.

Change-Id: I880523a5f3e14cc6d318d4493f037b79515b1dce
Reviewed-on: https://dart-review.googlesource.com/71401
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-08-24 11:03:28 +00:00
Kevin Millikin 0eb0f700b8 Avoid the deprecated input error in source_loader 
Avoid using deprecated errors by hadling them on a case-by-case basis.
This is a version of https://dart-review.googlesource.com/c/sdk/+/63144
with merge conflicts resolved.

Fixes #33686

Change-Id: I726740af2db5d32f15c8103c903376bc8ea948e6
Reviewed-on: https://dart-review.googlesource.com/71161
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-08-24 09:14:15 +00:00
Alexander Aprelev b878c21046 [gardening] Mark coverage_optimized_function_test slow on arm64. 
Change-Id: Iae9d3bb1721d84ff246a147cf2f44c7bb27c4d60
Reviewed-on: https://dart-review.googlesource.com/71181
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-08-22 16:14:07 +00:00
Alexander Aprelev e8e1ed6419 [vm] Fix hot reload when root script changes. 
This addresses https://github.com/dart-lang/sdk/issues/34025#issuecomment-408867998.

Change-Id: Ic3bfaaf9a43f42ffff15c5d8a8317dab83569b98
Reviewed-on: https://dart-review.googlesource.com/67400
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-08-16 14:24:19 +00:00
Alexander Markov 9f9682e8f3 [gardening] Filter out failing tests 
Issue: https://github.com/dart-lang/sdk/issues/34143
Change-Id: Idc8c1dd51a9763b30a0b4206aacdaa0732cf4f28
Reviewed-on: https://dart-review.googlesource.com/69982
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-08-14 19:01:32 +00:00
Martin Kustermann 2915e98de9 [gardening] Skip app-jitk tests which evaluate source and therefore need IKG 
Change-Id: I80c834174ea95ff9272a1904d747f2b265b2b2c1
Reviewed-on: https://dart-review.googlesource.com/69304
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-08-10 13:30:09 +00:00
Martin Kustermann d0f28884ff [VM] Fix expression evaluation implementation: Never register temporary/unused classes with the system. 
Until now the expression evaluation implementation was using normal kernel loader
functionality, which registered a new class with the isolate. Then the cid of that
class was set to kIllegalCid.

This caused the direct_subclasses/direct_implementors CHA information to contain a
class with kIllegalCid.

This CL fixes this by ensuring we never register the libraries/classes
created for expression evaluation (which are not even used, they are an artifact
of how the expressions are encoded in kernel).

Issue https://github.com/flutter/flutter/issues/20255
Issue https://github.com/flutter/flutter/issues/20307

Change-Id: Ie6dd76c7ff696cd8adf4f27e9a072274afd90136
Reviewed-on: https://dart-review.googlesource.com/68681
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-08-09 15:31:15 +00:00
Jens Johansen 6814dace8d Add bug number to kernel service status line 
Change-Id: I2f503ce783c8b32ac01a7c94df62559e6d1e40f4
Reviewed-on: https://dart-review.googlesource.com/68640
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-08-07 09:55:16 +00:00
Jens Johansen ad1d9e4f85 Update status for app_jitk after 164c7e3 
Change-Id: I5bba0e4a3db3c6c40356b1f1db1c2f54f6f55476
Reviewed-on: https://dart-review.googlesource.com/68661
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-08-07 09:43:05 +00:00
Jens Johansen 164c7e3195 Debugging sync* and yield 
Set position on yield in sync* functions; use yield position in VM.

Change-Id: I1c92fd47e3c8d4f747242e076007c122ea0d2186
Reviewed-on: https://dart-review.googlesource.com/68366
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-08-07 08:39:32 +00:00
Jens Johansen 1c2043e3a6 Update service test more to not be different in sync async mode 
Before this CL the test fails because the stacktrace was not as expected
when running in sync async mode.
This CL changes the test so async methods are not executed synchronously
by adding an "await null;" as the first thing in those methods.

An alternative fix would have been to pass --no-sync-async.

Bug: #29158

Change-Id: Idd9bd159610405bbdd479d50d823953a9ad1abde
Reviewed-on: https://dart-review.googlesource.com/63742
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-08-02 07:24:02 +00:00
Jens Johansen ac8fdb5a58 Add :controller_stream and call _asyncStarListenHelper 
This changes how we step out of async* functions slightly to match how
Dart1 behaves.

Bug: #29158

Change-Id: I8ee2df5eee8167fd1907a6e9f30c9dc7ab6939b1
Reviewed-on: https://dart-review.googlesource.com/63625
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-08-02 06:49:47 +00:00
Jens Johansen 2e98da68f9 Call _asyncStarMoveNextHelper in kernel 
This changes how we step into async* functions slightly to match how
Dart1 behaves.

Bug: #29158
Change-Id: I4969ca48f798bd51f9d2d5bc26dd224fa7eff627
Reviewed-on: https://dart-review.googlesource.com/63624
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-08-02 06:16:15 +00:00
Alexander Aprelev 70e58189d5 Update awaiter_async_stack_contents_2_test test status as failing in app_jitk config. 
This is follow-up to https://dart.googlesource.com/sdk/+/5d98fe159a622361f27804faab0b35fa02112797
which added the test.

Change-Id: Ib59a33244e520d93bd7b945e0a62594e02bb5f60
Reviewed-on: https://dart-review.googlesource.com/66841
Commit-Queue: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-07-25 23:37:25 +00:00
Ben Konyi 57e11e3d55 [ VM / Testing ] Added status file entry for debugger regression test which is expected to fail for app-jit in Dart 2 
Change-Id: I1b21234fd0d659bff80e51aa12ff41d7dc9ec31c
Reviewed-on: https://dart-review.googlesource.com/66220
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
 2018-07-23 17:52:52 +00:00
Jens Johansen 9873f04efc Update service test to not be different in sync async mode 
Before this CL the test fails because we land on the "await" when
stepping out of "helper" as "helper" is executed synchronously (i.e.
the call to await (which is translated into a call to an await-helper)
hasn't executed yet so landing on it is "correct").
This CL changes the test so "helper" is not executed synchronously by
adding an "await null;" as the first thing in the test. Once we step out
we thus have already executed the "await" and doesn't land on it.

An alternative fix would have been to pass --no-sync-async.

Change-Id: Iab6e5387960c2ebba10602f5e90630c30172c66e
Reviewed-on: https://dart-review.googlesource.com/63581
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-07-04 06:41:07 +00:00