Commit Graph

23 Commits

Author SHA1 Message Date
Kevin Moore eba45291fb [observatory] Cleanup unused imports, fix warning about SDK version
Change-Id: I80f1861b8dd1d1fa5eea93cc305fa0ee2475580d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101884
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
2019-05-13 16:27:41 +00:00
Kevin Moore 037792876a Fix analysis hints/warnings in runtime/observatory
Change-Id: I1afee0f09476185b2690e0c2bc98a4b7ae7bffa6
Reviewed-on: https://dart-review.googlesource.com/c/83480
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2018-11-09 00:52:44 +00:00
Devon Carew 188ef5e3d5 Analyze all the pkg/ code on the bots.
Bug: https://github.com/dart-lang/sdk/issues/29318
Change-Id: Iccb16ddbccbb43fa7a12eb818c2dde3a75700b97
Reviewed-on: https://dart-review.googlesource.com/64663
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-07-12 16:35:03 +00:00
Nate Bosch 6d5e8e8f87 Build Observatory directly with dart2js
- Drop the `copy_observatory` and pub get steps. Use a checked in
  `dart2js.packages` file and build from the source tree.
- Invoke dart2js directly for the build command.
- Use the dart2js executable checked in to the SDK when it is available,
  otherwise fall back on the dart VM and dart2js source.
- Manually synthesize a filered `packages` directory out of the source
  directories for observatory and it's dependencies
- Remove transformer section of the pubspec since it's unused.


Bug: #32900
Change-Id: I35a19ffc8c3e732c68b65adf4595a6a51e28b94f
Reviewed-on: https://dart-review.googlesource.com/51740
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2018-04-24 21:56:09 +00:00
asiva c1432bf7a3 [observatory] Remove references to pkg:browser from web/index.html
Updated version of dart-lang/observatory_pub_packages in DEPS

Updated generated pubspec.yaml file after removing web_components from
third_party/observatory_pub_packages

This should fix part of issue https://github.com/dart-lang/sdk/issues/32539

Bug: 32539
Change-Id: I3d48fd59f1fedc9d64a652cde7d0229c0a7ace28
Reviewed-on: https://dart-review.googlesource.com/48804
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-03-30 21:13:52 +00:00
Carlo Bernaschina a67d798841 Update observatory_pub_packages dependency
Updated all observatory dependencies.
In particular charted to 0.4.8

R=rmacnak@google.com
TBR=asiva@google.com

Review-Url: https://codereview.chromium.org/2990913002 .
2017-07-31 13:03:35 -07:00
John McCutchan cbbb82cfbe Ship Observatory with non-minified sources
This will help our users report more actionable bug reports.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2348673003 .
2016-09-16 13:00:38 -07:00
Carlo Bernaschina 5177c2bca9 Removed polymer & mirror from Observatory
web_components are still necessary, but avoiding to use shadow dom
allows us to use the lite version

Closes=https://github.com/dart-lang/sdk/issues/27239
Closes=https://github.com/dart-lang/sdk/issues/27148
Closes=https://github.com/dart-lang/sdk/issues/26952

R=johnmccutchan@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2310003004 .
2016-09-07 14:15:27 -07:00
Carlo Bernaschina 67063e3147 Added js and js_util to observatory deps
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2109293006 .
2016-06-30 14:09:07 -07:00
Carlo Bernaschina ce9f9621cb Revert "Added js and js_util to observatory deps"
This reverts commit bafbe3083d.

BUG=

Review URL: https://codereview.chromium.org/2114683002 .
2016-06-30 08:50:01 -07:00
Carlo Bernaschina bafbe3083d Added js and js_util to observatory deps
SEE= https://codereview.chromium.org/2104113003/
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2105883003 .
2016-06-30 08:39:34 -07:00
Todd Turnidge 08ce763e26 Update observatory_pub_packages_rev.
I want to pick up the new version of charted to drop some build warnings.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1519183003 .
2015-12-14 10:36:40 -08:00
John McCutchan 43b0ae00e7 Timeline service protocol support with Observatory UI
Service Protocol:
- _clearVMTimeline (clear timeline)
- _getVMTimeline (fetch timeline)
- _setVMTimelineFlag (control recording)
- _getVMTimelineFlag (...)
- _getVMTimeline service unit test

Observatory:
- timeline page with record on/off, clear timeline, and refresh buttons.
- trace-viewer based timeline view that runs in an iframe driven by a small javascript program

Misc:
- Fix default enable logic bugs
- Add 'Debugger Pause' timeline event
- Threads can have a name and that name will be displayed in Observatory
- Tighten up locking when printing JSON

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1406413006 .
2015-11-10 08:02:22 -08:00
John McCutchan d4d8098029 Roll observatory_pub_packages to 5c199c5954146747f75ed127871207718dc87786
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/1400023002 .
2015-10-13 10:17:41 -07:00
John McCutchan 95513b0a1d Switch from Google charts to Charted
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1310153002 .
2015-09-29 12:59:05 -07:00
John McCutchan 85d1e2c908 Bump observatory_pub_packages in DEPS
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1377583002 .
2015-09-28 12:57:19 -07:00
johnmccutchan@google.com 1c16abecf7 Fix breakage due to package upgrades
Paired with https://codereview.chromium.org/1129463003/

Review URL: https://codereview.chromium.org//1125203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45567 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-06 14:53:12 +00:00
nweiz@google.com 67f65fef97 Make observatory keep using html5lib.
Observatory has its own separate set of third_party packages.

TBR

Review URL: https://codereview.chromium.org//1060463006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45413 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 20:50:24 +00:00
nweiz@google.com 70a846ad6c Update pubspecs and dependencies to get pkgbuild tests working.
This also removes the vendored copy of Angular, which was an outdated version of
an unstaffed branch.

R=pquitslund@google.com

Review URL: https://codereview.chromium.org//1058283006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45410 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 20:08:53 +00:00
johnmccutchan@google.com 45b86c6b22 Rev observatory dependencies
To be committed after DEPS file updates.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//937603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43846 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-18 16:00:15 +00:00
johnmccutchan@google.com 261200c587 Build Observatory as part of runtime
Relanding https://codereview.chromium.org/810623005/

Review URL: https://codereview.chromium.org//837723004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42645 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 21:59:42 +00:00
whesse@google.com aa5a986d5d Revert "Build Observatory with runtime"
This reverts commit 76df7b3c1bf83c08d3994d61df4c9c530fadb4e5.
This commit breaks dartium compilation.

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//839543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42619 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 10:07:58 +00:00
johnmccutchan@google.com 9d6ac72b46 1) Remove prebuilt Observatory sources
2) Move observatory from runtime/bin/vmservice/observatory to runtime/observatory

3) Add two tools scripts:
- tools/run_pub.py (runs pub before SDK is built)
- tools/obs_tool.py (helper for get, build, and deploy stages)

4) Build Observatory with runtime:
- pub get --offline
- pub build
- deploy

5) Build artifacts are now in standard output directory, for example, out/DebugIA32/observatory.

6) Add a new 'dart_boostrap' host target (no snapshot, no observatory) that can be used as the Dart executable to run pub when building Observatory. This is behind a build.py flag --use-bootstrap-for-observatory because:

- It is only necessary on older Linux distributions that are incompatible with the prebuilt Dart testing executable.
- running pub build with the boostrap Debug build is significantly slower.

7) Detect if the prebuilt executable doesn't work and automatically switch to the 'dart_bootstrap' executable. Also, warn the user and provide a Wiki link with more information.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//810623005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42614 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 21:26:52 +00:00