Commit Graph

2159 Commits

Author SHA1 Message Date
ajohnsen@google.com e8ad108bec Revert "Fix fromEnvironment when called from isolates."
This reverts commit f5886c3a1fe96580c13d83d6422a6bb6931ae95a.

BUG=

Review URL: https://codereview.chromium.org//186573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33266 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 11:06:39 +00:00
ajohnsen@google.com 7e55a59ce4 Fix fromEnvironment when called from isolates.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//186393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33264 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 10:26:17 +00:00
rmacnak@google.com 7c4a84d130 Remove LibraryMirror.topLevelMembers.
R=gbracha@google.com

Review URL: https://codereview.chromium.org//164823006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33256 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 01:35:07 +00:00
hausner@google.com ad3fb79210 Better error message for assignment to final local variables
“No top-level getter found” becomes “cannot assign to final variable xxx”.

Fixes issue 16782.

R=iposva@google.com

Review URL: https://codereview.chromium.org//177633008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33028 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 18:01:35 +00:00
fschneider@google.com 16857e0b13 Revert r32930 (Add more timing information in the VM to track time...)
It caused severe performance regressions that should be addressed.

TBR=asiva@google.com

Review URL: https://codereview.chromium.org//177733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32959 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-24 12:15:55 +00:00
asiva@google.com 6d313d3797 Add more timing information in the VM to track time spent is dart code Vs native code.
R=johnmccutchan@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org//137483010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32930 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 21:30:29 +00:00
lrn@google.com 0dbb989cb8 Add internal operation that converts a growable list to a fixed list.
The conversion breaks the original list, but doesn't copy data.
Currently only used in List.from(Iterable).

BUG= http://dartbug.com/9458
R=floitsch@google.com, iposva@google.com

Review URL: https://codereview.chromium.org//134893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32896 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 13:15:16 +00:00
lrn@google.com 69145994de Allow multi-codeunit padding in String.padLeft/padRight.
Also allow negative repeats.

Based on suggestions from Stephen.

R=sra@google.com

Review URL: https://codereview.chromium.org//171773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32843 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-20 07:17:11 +00:00
iposva@google.com f2a6f1b4b6 Another round of cleanups for http://www.dartbug.com/15922
- Address warnings about 64-bit to 32-bit conversions.

R=ajohnsen@google.com, asiva@google.com

Review URL: https://codereview.chromium.org//169893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32831 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 23:35:55 +00:00
lrn@google.com a3ad46de0d Add String.repeat, String.padLeft, String.padRight.
We keep seeing reimplementations everywhere, and reimplementing it ourselves.

BUG= http://dartbug.com/16919
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//172153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32784 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 12:32:56 +00:00
iposva@google.com f3906bde8b Fix http://dartbug.com/16308
- Replace "non-extendable array" with "fixed-length list" when throwing
  UnsupportedError.
- Reword the error messages where needed.

Review URL: https://codereview.chromium.org//169963004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32733 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-17 23:54:58 +00:00
lrn@google.com b23f5d0327 Add 'startPaused' option to Isolate.spawn*.
Initial implementation of startPaused in dart2js.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//163523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32722 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-17 13:06:06 +00:00
rmacnak@google.com 0c821b2457 Fix getField/setField optimization for private members.
BUG=http://dartbug.com/16773
R=hausner@google.com

Review URL: https://codereview.chromium.org//160843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32634 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 23:44:34 +00:00
rmacnak@google.com 1c7fecac7e Add TypeMirror.isSubtypeOf, TypeMirror.isAssignableTo, ClassMirror.isSubclassOf to the API, the VM runtime mirrors and the source mirrors.
BUG=http://dartbug.com/12439
BUG=http://dartbug.com/13856
R=gbracha@google.com, johnniwinther@google.com, regis@google.com

Review URL: https://codereview.chromium.org//126823004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32577 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-11 20:41:32 +00:00
rmacnak@google.com d354d73609 Avoid printing the full token stream and doing line/column position calculations when extracting the source of a function where we don't have the original source.
Brings mirrors_reader_test from 2 minutes to 11 seconds on the standalone VM.

R=iposva@google.com

Review URL: https://codereview.chromium.org//133813008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32461 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-08 01:18:18 +00:00
rmacnak@google.com 41b3ac826d Adjust assertions in MethodMirror.source not to expect source for implicit constructors or signature functions.
BUG=http://dartbug.com/16588
R=hausner@google.com

Review URL: https://codereview.chromium.org//138383007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32454 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 21:46:01 +00:00
regis@google.com 7830430adf Implement eager instantiation and canonicalization of type arguments at run
time using a cache in uninstantiated type arguments.
Remove InstantiatedTypeArguments class.
Fix a bug in optimized code: do not update unused type test cache for Smi.
Fix a bug in optimized code on ARM and MIPS in type test cache lookup.

R=iposva@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//154393003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32447 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 19:54:33 +00:00
lrn@google.com d63af4cdc8 Add more complex mixing of random seed.
This changes the sequences generated by Random for a given seed,
since the internal state will not be the same as for the unmixed
seed.
It is consistent between VM and dart2js.

The provided integer seed is hashed as follows:
   uint64 hash = 0;
   while (seed > 0) {
      hash = hash * 1037 + mix64((int64)seed);
      seed >>= 64;
   }
where mix64 mixes the bits of a 64-bit value.
The hash is used to initialize the random generator's internal state.

R=floitsch@google.com, iposva@google.com

Review URL: https://codereview.chromium.org//156533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32412 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 08:42:43 +00:00
rmacnak@google.com 00c96bfbbf Optimize getField by caching a closure generated from eval.
R=iposva@google.com

Review URL: https://codereview.chromium.org//144383007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32343 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-05 23:03:46 +00:00
lrn@google.com 29dd07f51a Add Capability class.
Currently throws UnimplementedError in constructor patches. All implementation is still missing.

R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//148883009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32274 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 09:23:38 +00:00
rmacnak@google.com 2da8c830a3 Fix non-specific type parameter in member maps.
BUG=http://dartbug.com/14972
R=regis@google.com

Review URL: https://codereview.chromium.org//140313005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32225 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 23:52:15 +00:00
johnmccutchan@google.com 59f671c9d9 Add LL suffix to 64-bit integer constants
BUG=

Review URL: https://codereview.chromium.org//137893029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32205 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 18:09:12 +00:00
johnmccutchan@google.com 9d80608b9c Add Float64x2, Float64x2List, etc... with runtime and dart2js implementations
R=sra@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//148043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32196 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 15:28:05 +00:00
lrn@google.com d0651286c6 Make _Utf8Encoder create its buffer through an external function.
This allows the VM to use a Uint8List, where dart2js still has to use a plain List (due to versions of IE not supporting typed data).

R=floitsch@google.com

Review URL: https://codereview.chromium.org//144473004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32193 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 13:11:25 +00:00
turnidge@google.com b891e78325 Post-meetup feature extravaganza.
Remodel the top-level isolate summary page.

Add variables to stack frames in the stack trace.

Stop putting small integers and bools in the object id ring.

Rework how we pass down null references (and null-like references like
uninitialized values).

Collect all isolate timers by default.

Change the lifetime of IsolateSpawnState so that we can refer to it
later to know how an isolate started up.  Stop pretending that
IsolateSpawnState is a void*.  Clean up vestigial IsolateStartData.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//145323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32128 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 18:40:12 +00:00
srdjan@google.com 9c16a399ca Cleanups.
R=regis@google.com

Review URL: https://codereview.chromium.org//146843008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32000 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-24 22:00:04 +00:00
ajohnsen@google.com cb47100b7c Speed up typed *List:fromList constructor, by calling setRange.
BUG=
R=lrn@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//136473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31909 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 08:15:38 +00:00
lrn@google.com 3b3e87cabc Revert "Rename internal library dart:_collection-dev to dart:_internal."
Dartium needs updating too.

Committed: https://code.google.com/p/dart/source/detail?r=31827

R=floitsch@google.com

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31877 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 12:06:38 +00:00
lrn@google.com 9357caa547 Revert "Make VM TypedList not implement ByteBuffer."
Html transferable test fails to send buffer as buffer.

Review URL: https://codereview.chromium.org//137783019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31875 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 11:48:07 +00:00
lrn@google.com c2f6609181 Make VM TypedList not implement ByteBuffer.
BUG= http://dartbug.com/10136
R=asiva@google.com, sra@google.com

Review URL: https://codereview.chromium.org//138033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31873 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 10:18:41 +00:00
iposva@google.com 781f737c6a First round of http://dartbug.com/15922:
- Address warnings about 64-bit to 32-bit conversions.
- Remove heap profiler.

R=asiva@google.com

Review URL: https://codereview.chromium.org//139043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31867 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 05:05:35 +00:00
iposva@google.com aeb751f670 - Large constants need to be marked as such.
Review URL: https://codereview.chromium.org//140213003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31861 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 00:09:15 +00:00
iposva@google.com 8db30180b4 Fix http://dartbug.com/16111
- Use all bits from the seed value even if passed a Bigint.
- Fix out of bounds access in BigintOperations.
- Remove obsolete implementation note.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//136453012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31859 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 00:01:55 +00:00
srdjan@google.com e16402e56e Fix 16099: Invocation's positionalArguments contains an immutable array.
R=asiva@google.com

Review URL: https://codereview.chromium.org//139663003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31845 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 19:14:45 +00:00
lrn@google.com ead87f47e9 Revert "Rename internal library dart:_collection-dev to dart:_internal."
Dartium needs updating too.

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31827 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 12:27:44 +00:00
lrn@google.com 0098710559 Rename internal library dart:_collection-dev to dart:_internal.
BUG= http://dartbug.com/14140
R=floitsch@google.com

Review URL: https://codereview.chromium.org//133893007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31823 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 09:24:46 +00:00
rmacnak@google.com 2b77f8b1d4 dart2js: Implement instanceMembers and staticMembers.
BUG=http://dartbug.com/14633

Review URL: https://codereview.chromium.org//137123005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31808 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-14 22:31:20 +00:00
rmacnak@google.com 39f69b6045 Revert "dart2js: Implement instanceMembers and staticMembers."
Review URL: https://codereview.chromium.org//137533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31763 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 22:40:36 +00:00
rmacnak@google.com 3886174aa1 dart2js: Implement instanceMembers and staticMembers.
BUG=http://dartbug.com/14633
R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//94093011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31757 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 21:09:49 +00:00
rmacnak@google.com 615715ccaa Extend the immutable collections test to the new API. Make *Members return immutable collections. Add missing metadata property for SyntheticSetterParameter.
R=asiva@google.com

Review URL: https://codereview.chromium.org//132133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31675 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 20:38:32 +00:00
rmacnak@google.com 7dfcd0f4a1 Add ClassMirror.isAbstract to the API and VM implementation.
BUG=http://dartbug.com/12826
R=gbracha@google.com

Review URL: https://codereview.chromium.org//129883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31643 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 01:27:51 +00:00
rmacnak@google.com 8313c51650 Ensure a class is finalized before attempting any reflective invocation on it.
Avoids mysterious error that results when finalization that is triggered by the reflective invocation fails to propogate a compile-time error.

BUG=http://dartbug.com/15886
R=regis@google.com, zra@google.com

Review URL: https://codereview.chromium.org//129513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31638 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 00:18:09 +00:00
rmacnak@google.com d8c4c637bf Revert "Add ClassMirror.isAbstract to the API and VM implementation."
BUG=

Review URL: https://codereview.chromium.org//128673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31633 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 22:51:45 +00:00
rmacnak@google.com a5e3c91936 Add ClassMirror.isAbstract to the API and VM implementation.
BUG=http://dartbug.com/12826
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//128933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31630 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 22:21:43 +00:00
srdjan@google.com 2b2b08d058 Fix issue 15134: use fast setRange for setAll in TypedDataBase.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//126933004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31595 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 00:39:54 +00:00
srdjan@google.com e3ab171b21 Another fix for setRange on typed data and their views: use byte offsets in native code.
Adapted checks to do the same as dart2js

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//126393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31592 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 00:08:51 +00:00
regis@google.com 06830dbbd2 Use a trail instead of a mark bit when processing recursive types in the VM
(issue 15595).

R=asiva@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org//109593003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31584 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 21:55:07 +00:00
srdjan@google.com 5a093d9f9c Fix 15413: setRange for views with overlapping buffers.
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//124383007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31528 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 00:48:46 +00:00
ngeoffray@google.com 2015e5f204 Fix an old TODO.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//107333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31253 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-19 10:40:53 +00:00
iposva@google.com 1e8061f060 - Remove the reply_port from the VM internal message object.
- Adjust all the uses of this API.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//93873015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31205 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-17 21:11:18 +00:00