dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

2159 Commits

Author SHA1 Message Date
Lasse R.H. Nielsen 232a9d687e Add "environment" parameter to spawnUri for String.fromEnvironment support. 
This completes the parameters corresponding to official command line parameters
for the VM/dart2js.

R=floitsch@google.com, iposva@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//1350053002 .
 2015-09-22 12:29:40 +02:00
Ryan Macnak 5ee2da4475 Spec says empty namedArguments is const {}, not const <Symbol, dynamic>{}. 
BUG=http://dartbug.com/24331
R=gbracha@google.com

Review URL: https://codereview.chromium.org//1359503002 .
 2015-09-18 17:05:35 -07:00
regis e8139d4d92 Fix right shifting of a Mint value by an amount larger than 63. 
Add regression test.
Enhance existing bit shift test.

Fixes #24283

R=ager@google.com

Review URL: https://codereview.chromium.org//1338233002 .
 2015-09-14 18:20:48 +08:00
regis 9ca5ca6316 Fix a typo in Bigint dart implementation of modInverse. 
Fixes #24324

Review URL: https://codereview.chromium.org//1344483003 .
 2015-09-14 12:03:50 +08:00
Todd Turnidge b0ca0789be Fix a variety of service protocol bugs. 
Add documentation for breakpoint.

Fix Instance.pattern documentation.

Fix Instance.bytes documentation.

Add class field for null instances.

Fix documentation of Context and closureContext.

Make getObject return Collected for deleted breakpoints.

Closes #24247
Closes #24249
Closes #24309
Closes #24325
Closes #24326
Closes #24327

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1341473002 .
 2015-09-11 12:29:21 -07:00
Lasse R.H. Nielsen ff65079c47 Add packages parameter to Isolate.spawnUri. 
No implementation supplied, marked as "not implemented everywhere".

BUG= http://dartbug.com/23951
R=iposva@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//1323373002 .
 2015-09-11 13:07:54 +02:00
Lasse R.H. Nielsen 7464947ca0 Make Map constructor external to allow dart2js to specialize it. 
Review URL: https://codereview.chromium.org//1330303002 .
 2015-09-11 13:06:09 +02:00
Lasse R.H. Nielsen d755dd65b9 Update range errors to agree on the numbers. 
Also ensure that typed-data errors are consistent with other lists.

Fixes issue #24295
BUG= http://dartbug.com/24295
R=floitsch@google.com, iposva@google.com, sra@google.com

Review URL: https://codereview.chromium.org//1318943005 .
 2015-09-11 13:05:36 +02:00
Siva Annamalai 79ef28317f Changes to prepare for allowing script snapshots to be taken after running the main application: 
- Rename accessors of class Field to make it more apparent as to what is being accessed (static field values or instance field offsets
- Use precompiled initializer state (Used only during precompilation) to also store saved initial value of static fields (Used only during application snapshot   generation)

BUG=
R=hausner@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org//1289643005 .
 2015-09-04 11:03:46 -07:00
Florian Schneider 7e40108ff5 VM: Simplify irregexp entry stub. 
Pass on the incoming arguments descriptor when invoking an irregexp function.

Avoiding loading an arguments descriptor in the intrinsic code also allows
generated regexp code in precompiled code.

Loading a new descriptor is not necessary since the arguments are already on
the stack in the right order.

Use named constants for parameter indices in the regexp assembler.

BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1305993005 .
 2015-09-04 10:06:02 +02:00
Srdjan Mitrovic d4365bc6f4 Lookup getter/setter symbols before alllocating them, thus eliminating extra String allocations in new space. 
Various old space allocations, cleanups.
Add a test for Symbols concatenation.

BUG=
R=hausner@google.com

Review URL: https://codereview.chromium.org//1320673012 .
 2015-09-03 14:09:34 -07:00
Ivan Posva 4bd7cdc75c - Ensure that HandleScope is initialized with a thread. (Remove 
deprecated isolate based API.)
- Update all code impacted by this change. E.g. DARTSCOPE
- TEST_CASE now passes the current thread as a parameter to the   unit test.

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//1310463005 .
 2015-09-01 17:18:55 -07:00
John McCutchan 7052bd6bed Rework service extensions to be safe 
- When scheduling a service extension to be invoked, store the closure in an array held in the isolate.
- At the tail of IsolateMessageHandler::HandleMessage, invoke all pending service extension closures.

R=iposva@google.com, turnidge@google.com

Review URL: https://codereview.chromium.org//1299493007 .
 2015-08-27 11:23:39 -07:00
Seth Ladd 26eaf632cf removes a return from a void function 
BUG=

Review URL: https://codereview.chromium.org//1305583003 .
 2015-08-20 13:40:29 -07:00
Ryan Macnak 360b40a599 Update return type of dart2js patch of dart:developer.log. 
Review URL: https://codereview.chromium.org//1302823002 .
 2015-08-19 13:42:53 -07:00
Florian Loitsch debf1d6f7c Don't zone-register async callbacks for every await call in the VM. 
This has the nice side-effect that the stack_trace package provides nicer chains.
Fixes issue 23394.

R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/4dae43d63727268f2e0cc45d6020246eb49177b8
Reverted: https://github.com/dart-lang/sdk/commit/cb4f9fc925c5a92c6cf756751e38296383f66507

Review URL: https://codereview.chromium.org//1274133002 .
 2015-08-17 19:26:50 +02:00
Florian Loitsch cb4f9fc925 Revert "Don't zone-register async callbacks for every await call in the VM." 
This reverts commit 4dae43d637.

Review URL: https://codereview.chromium.org//1296973002 .
 2015-08-17 16:43:35 +02:00
Florian Loitsch 4dae43d637 Don't zone-register async callbacks for every await call in the VM. 
This has the nice side-effect that the stack_trace package provides nicer chains.
Fixes issue 23394.

R=hausner@google.com

Review URL: https://codereview.chromium.org//1274133002 .
 2015-08-17 15:58:19 +02:00
Lasse R.H. Nielsen edff0face7 Make String.allMatches lazy. 
R=floitsch@google.com, iposva@google.com

Review URL: https://codereview.chromium.org//1273713003 .
 2015-08-12 11:01:21 +02:00
Florian Schneider b19d518ede VM: Use const instead of final for constants in runtime libraries. 
It does not make a difference for optimized code (final does not help in
optimized code either btw), but allows using those constants directly in
unoptimized code.

BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1284873002 .
 2015-08-12 09:40:22 +02:00
Srdjan Mitrovic 56c91201c3 Fix issue 24043: do not trust the pattern. Enable a 'hidden' test. 
If there is a performance issues, I can add specialized code for String patterns.

BUG=24043
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1286823003 .
 2015-08-11 14:46:17 -07:00
Ryan Macnak b34267d0d7 Replace is_synthetic bit on Fields with is_reflectable. Mark private fields of dart:* as non-reflectable. 
This fixes an inconsistency in mirrors where some classes in dart:* would claim to have a field but throw NSM if one attempts to access it, and prevents accessing private static fields of dart:* that don't have implicit getters or setters.

R=asiva@google.com

Review URL: https://codereview.chromium.org//1280713002 .
 2015-08-06 16:48:01 -07:00
Ryan Macnak b6c979f20b Hoist InstanceMirror.delegate to ObjectMirror. 
BUG=http://dartbug.com/14827
R=gbracha@google.com

Review URL: https://codereview.chromium.org//1273983002 .
 2015-08-05 17:09:59 -07:00
Ivan Posva e974b952a7 - Prevent getting an unmodifiable list being returned from List.from. 
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1275703002 .
 2015-08-05 13:25:32 -07:00
Srdjan Mitrovic caa3cce77e Fix some TODOs 
BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org//1263963003 .
 2015-08-04 17:13:22 -07:00
Ivan Posva f63db4960c - Implement resource loading via the Resource class. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//1264413002 .
 2015-08-04 15:39:14 -07:00
John McCutchan 4505a79e58 Increment next sequence number 
BUG=

Review URL: https://codereview.chromium.org//1260343004 .
 2015-08-04 07:59:13 -07:00
John McCutchan a2757141b0 Make dart:developer log more user friendly 
- Make required arguments required.
- Validate required arguments in Dart before calling native.
- timestamp is now a DateTime.
- level has a default (ALL).
- sequence number is last + 1 if not provided.

R=lrn@google.com

Review URL: https://codereview.chromium.org//1266053003 .
 2015-08-04 07:12:39 -07:00
John McCutchan 7640cf4b85 Fix test failure 
patch from issue 1271693003 at patchset 20001 (http://crrev.com/1271693003#ps20001)

Review URL: https://codereview.chromium.org//1270953003 .
 2015-08-04 07:05:34 -07:00
William Hesse bdda0eff52 Revert "Change msg to message in debugger function." 
This reverts commit 2ae214316c.

BUG=

Review URL: https://codereview.chromium.org//1261203005 .
 2015-08-04 15:22:47 +02:00
Lasse R.H. Nielsen 2ae214316c Change msg to message in debugger function. 
BUG=23949
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1271693003 .
 2015-08-04 14:58:13 +02:00
Ryan Macnak db8ed04981 Hack around dart:io being loaded into non-service isolates in Dartium. 
BUG=http://dartbug.com/23940
R=asiva@google.com

Review URL: https://codereview.chromium.org//1259893006 .
 2015-08-03 16:59:32 -07:00
Ivan Posva b07a9ddbca - Implement .packages specification. 
Limitation: Currently only works for file: based .package files. If a script is loaded from http: then the VM currently assumes a co-located packages/ directory.

R=asiva@google.com

Review URL: https://codereview.chromium.org//1232593003 .
 2015-07-29 11:30:33 -07:00
Ryan Macnak bc90a5e1f0 Fix getField optimization when the selector is an operator. 
BUG=http://dartbug.com/23880
R=asiva@google.com

Review URL: https://codereview.chromium.org//1247733005 .
 2015-07-22 13:39:07 -07:00
Matthias Hausner f1da09741d Implement tear-off closure operator # 
BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org//1234883005 .
 2015-07-22 12:50:36 -07:00
John McCutchan bfd2d4ed2a Refactor dart:developer log to use named parameters 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1247803002 .
 2015-07-21 10:01:37 -07:00
John McCutchan f818f9dc0f Support piping log data over the service protocol 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1241683005 .
 2015-07-21 07:54:46 -07:00
Ivan Posva fe03640e85 - Implement VM parts of https://codereview.chromium.org/1240743003/ 
- Pass additional state in the IsolateSpawnState to set
  error and exit handlers, as well as fatal errors on isolate start.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1244733002 .
 2015-07-20 16:46:54 +02:00
Regis Crelier 7f10c1420d Make invocation namedArguments unmodifiable. 
Fixes #13714

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1241583008 .
 2015-07-17 14:04:54 -07:00
Lasse R.H. Nielsen e4881c55d0 Add errorsAreFatal, onExit and onError parameters to the spawn functions. 
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1240743003.
 2015-07-16 16:52:43 +02:00
Srdjan Mitrovic d503d2f0ed Added full deferred loading semantic to precompiled/--noopt/eager-loading code (some corner cases, e.g., compile-time errors for constants, still missing) 
BUG=
R=hausner@google.com

Review URL: https://codereview.chromium.org//1211273011 .
 2015-07-09 10:56:55 -07:00
Ryan Macnak d1475c0356 Port irregexp bytecode compiler and interpreter from V8 r24065. 
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1201383002 .
 2015-07-07 14:43:32 -07:00
Srdjan Mitrovic 5711c13f69 Make frequent type checks (instanceof) faster by adding dedicated instanceof methods; improves dart2js startup 
There is a possibility of adding intrinsics for all new instanceOf methods; my measurements did not show any benefits, therefore they were removed from this CL.

BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org//1222863003 .
 2015-07-07 10:20:41 -07:00
Lasse R.H. Nielsen 3c976019cc Make int.gcd accept zero as an operand, including both operands being zero. 
R=floitsch@google.com, regis@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//1211473002.
 2015-07-07 09:51:13 +02:00
Ryan Macnak 40fcf4a72d Handle field-invocation and method-extraction in the runtime when --lazy_dispatchers=false. 
R=fschneider@google.com

Review URL: https://codereview.chromium.org//1195573006.
 2015-06-30 15:14:35 -07:00
Lasse R.H. Nielsen ede6cb71a5 Make modInv throw Exception on incompatible operands. 
Also update errors to be more descriptive accross the integer methods.

I'm still considering whether a more precise "NotCoPrimeException" would be better.

R=regis@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//1209523002.
 2015-06-30 14:46:14 +02:00
Regis Crelier 6a69915cf5 Remove workaround in gcd for even operands and provide permanent fix. 
Relax minimum length calculation in _lShift and _lShiftDigits.

See details in https://codereview.chromium.org/1205363003/

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1207403003.
 2015-06-26 15:31:32 -07:00
Lasse R.H. Nielsen f8ce36df55 Add Resource class. Currently unimplemented. 
R=herhut@google.com, iposva@google.com

Committed: https://github.com/dart-lang/sdk/commit/2890a7a2a94ff54c7c0050e69c40ca6a60a28474

Review URL: https://codereview.chromium.org//1181663002.
 2015-06-26 11:42:02 +02:00
Lasse R.H. Nielsen 3a0edfba72 Add tests for gcd, modInverse and modPow that also run on dart2js. 
R=regis@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//1205363003.
 2015-06-26 11:05:11 +02:00
Lasse R.H. Nielsen 78a3db3128 Revert "Add Resource class. Currently unimplemented." 
This reverts commit 2890a7a2a9.

Causes a dart2js test error and a significant amount of analyzer
warnings.

Review URL: https://codereview.chromium.org//1193273003.
 2015-06-22 16:43:44 +02:00