* Updated directory_linux.cc to conform with the deprecation of readdir_r
* Fixes to directory_linux.cc
* Modified error checking to more accurately represent the original code
* Removed redundant check and changed variable names for readability
* Changed variable name in DeleteRecursively for readability
* Modified loop for better error checking
* Simplified loop in DirectoryListingEntry::Next
* Fixed text on a comment
* Added summary of pull request and fixed code style
* Fixed commenting style
* Fixed a comment referencing readdir_r
The build was broken by the addition of OS::MaxRSS, which I've added
unimplemented. I need the packages/ output to get the Dart language
tests going. I've added Directory::Exists() so that we can give
the right error message on a missing package: import instead of
crashing.
R=asiva@google.com
Review URL: https://codereview.chromium.org/2259613002 .
This change makes a few improvements to Fuchsia's wrapper around
run_vm_tests:
- Loads the binary into memory only once, speeding things up a bit.
- Captures the output of 'run_vm_tests --list' to extract the list
of tests to run instead of reading it from a file.
- Captures the output of the tests, and prints a test's stdout
and stderr to the console only if the test failed.
R=asiva@google.com
Review URL: https://codereview.chromium.org/2238983003 .
Fix some misspelled flags.
Remove some non-existent flags.
Fix --short_socket_read and --short_socket_write flags used in IO tests.
Running with --ignore-unrecognized-flags is still on because some flags are only visible
in DEBUG mode.
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org/2247733005 .
Allow members of patch classes to be annotated with @patch. The VM
ignores the annotation. I simply replaces the original method
if the name matches, or reports an error if field names match.
Adding a bit is_patched to members to do more checking remains a
TODO. There are currently no unused bits available, and I don’t want
to increase the size of Function objects for this.
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org/2230383003 .
Annotate patch classes and top-level patch functions with @patch
instead of the pseudo-keyword patch. This allows the analyzer
to read patch files, and matches the syntax that dart2js uses.
The deprecated syntax is still supported, but a warning is printed when detected.
BUG=
Review URL: https://codereview.chromium.org/2220883004 .
After running our tests with ASAN and inspecting the
BoringSSL code, it appears that the calls indicated
in the CL increment the reference count of the
objects passed in being added to the security context.
Therefore, to avoid a leak, we have to free() the
objects to decrement the reference count so that the
memory is freed when the context is destroyed.
R=asiva@google.com
Review URL: https://codereview.chromium.org/2206233003 .
Flutter now defines is_fuchsia to false, which breaks this check in this code.
The Fuchsia build seems fine without this check, so I've removed it.
TBR=zra@google.com
We now check all of the scripts which make up a library. If any
script is modified, then we consider that library to be modified. We
also consider any library which imports a modified library to be
modified. To propagate this info efficiently, we build and discard
the imported-by graph when beginning a reload.
The embedder must provide a FileModifiedCallback in order to support
the detection of modified scripts.
In order to detect changes to package: libraries, we have modified the
embedder interface to provide the resolved url when possible, so that
we don't need to re-resolve package uris when checking for reload.
This change is incompatible and all embedders will need to be updated.
We now support a "force" flag when reloading sources. This causes all
libraries to be reloaded regardless of whether the underlying scripts
have been updated.
Closes#26919R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org/2186423002 .
This CL adds rules to the GN build for building run_vm_tests for
Fuchsia. It also adds a wrapper program in
//runtime/bin/run_vm_tests_fuchsia.cc and a file containing the
output of 'run_vm_tests --list', //runtime/bin/fuchsia_vm_tests.txt.
The wrapper program and text file make it easier to run the tests
on Fuchsia, and should be able to go away once we are out of the
bootstrapping phase.
R=asiva@google.com
Review URL: https://codereview.chromium.org/2187153003 .
Steven Sheffey