dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
64,479 Commits 2 Branches 0 Tags
bc8b6fb94de1796bdcb7b02f0c5ce14ba369400a
Commit Graph

51 Commits

Author SHA1 Message Date
asiva af57d2a0eb [VM] Remove dead code associated with flag '--error-on-bad-override' 
- Remove all dead code associated with flag '--error-on-bad-override' which is currently running only under !FLAG_strong which is not valid anymore
- Not removing the flag from flag_list for now as it is used in a number of tests and removing it from all these places would be a big change, it would be a NOP flag
- removed some dead code in 'loader.dart' which was invoked from the tag handler

Change-Id: I5474b51b4dee7471e80b4081e55b996f1d75612f
Reviewed-on: https://dart-review.googlesource.com/c/78382
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-10-08 04:44:24 +00:00
Samir Jindel 5572df1458 [vm/precomp] Fix name of vm:entry-point. 
Change-Id: I907e59a9df9407f924c0518a185d5b28ab46e381
Cq-Include-Trybots: luci.dart.try:vm-kernel-win-release-x64-try,vm-kernel-optcounter-threshold-linux-release-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-release-simarm64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-win-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/69971
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-08-16 15:07:51 +00:00
Samir Jindel 9767af2550 [vm/precomp] Support @pragma for fields and remove associated entry-point entries. 
Cq-Include-Trybots: luci.dart.try: vm-kernel-optcounter-threshold-linux-release-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-linux-release-simarm64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-win-release-x64-try
Change-Id: I584aae2360771cf0599d9fb1b5ae2735b20d3413
Reviewed-on: https://dart-review.googlesource.com/65820
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-08-07 16:47:50 +00:00
Mike Fairhurst 7911fb2683 First pass at disabling packages/ dir, packageRoot 
Change-Id: Ib2d7738c84cd1258dcad46e8e2c8da8105efea60
Reviewed-on: https://dart-review.googlesource.com/59100
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2018-06-12 19:38:40 +00:00
Ryan Macnak 3b7199fe63 [standalone] Only allow one outstanding load when running with --deterministic. 
Bug: https://github.com/dart-lang/sdk/issues/31427
Change-Id: I3349d6cc1779ef4470262e65dff7410397cb12de
Reviewed-on: https://dart-review.googlesource.com/51161
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-04-16 18:31:28 +00:00
Paul Berry 8f57cf8e45 Strong mode fix for runtime/bin/vmservice/loader.dart 
The values in isolateEmbedderData have IsolateLoaderState in practice,
but the static type system only guarantees they have type
IsolateEmbedderData (a supertype).  So we need an implicit downcast.

Change-Id: I9da0c9a34deae233e3bb25d264e4307fd186c3c7
Reviewed-on: https://dart-review.googlesource.com/20160
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-11 15:38:51 +00:00
Erik Corry 029b1cb948 Spelling fixes e to i. 
R=kevmoo@google.com
BUG=

Review-Url: https://codereview.chromium.org/2957593002 .
 2017-06-24 13:41:39 +02:00
Ryan Macnak 9ab39ae099 Reapply "[fuchsia] Prepare for setting the Dart target architecture appropriately in the host binaries." 
Add missing config to run_vm_tests.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2937503003 .
 2017-06-13 08:49:00 -07:00
Ryan Macnak 3383c4ac25 Revert "[fuchsia] Prepare for setting the Dart target architecture appropriately in the host binaries." 
This reverts commit 54e80a8c32.

Review-Url: https://codereview.chromium.org/2940513002 .
 2017-06-12 15:19:23 -07:00
Ryan Macnak 54e80a8c32 [fuchsia] Prepare for setting the Dart target architecture appropriately in the host binaries. 
Build another varient of dart_bootstrap targeting the host architecture to ensure reasonable Observatory build times.

Remove assert assuming a root script, which does not exist when gen_snapshot builds core snapshots.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2924173005 .
 2017-06-12 14:33:10 -07:00
Vyacheslav Egorov 13f5616ef6 VM: Fix snapshoting slow-down caused by 99c6a18a1b. 
Only reload packages map when we are actually doing the isolate reload.

Snapshotting creates and destroys and loader object every time it loads a dart
file - which means kInitLoader is on the hot path and we should avoid rereading
packages map.

R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2901093002 .
 2017-05-23 22:01:45 +02:00
Jacob Richman b67e83eea3 Format all remaining unformatted runtime files other than multitests. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2829463003 .
 2017-04-18 15:34:03 -07:00
Ryan Macnak b810cb2fe5 Ensure resolved packages before _Dart_kResolveAsFilePath. 
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2820853002 .
 2017-04-14 15:55:03 -07:00
John McCutchan 9af072399e Fix reload bots 
BUG=

Review-Url: https://codereview.chromium.org/2812373003 .
 2017-04-12 14:36:38 -07:00
John McCutchan 99c6a18a1b Attempt 2 -- Fix updating packages map on reload and add a regression test 
- [x] Update the isolate's .packages path when requested.
- [x] Always refresh package map when loader is initialized.
- [x] Add regression test.

Review-Url: https://codereview.chromium.org/2810223003 .
 2017-04-12 14:02:19 -07:00
John McCutchan 94df115e4b Revert "Fix updating packages map on reload and add a regression test" 
This reverts commit 7a2d67f3ba.

BUG=

Review-Url: https://codereview.chromium.org/2808953003 .
 2017-04-10 12:30:38 -07:00
John McCutchan 80c27841a3 Fix logic bug in loader code 
BUG=

Review-Url: https://codereview.chromium.org/2815433002 .
 2017-04-10 11:13:46 -07:00
John McCutchan d75edfb408 Attempt to fix loader hangs 
I cannot reproduce locally so I'm going off scraps from the buildbot logs

BUG=

Review-Url: https://codereview.chromium.org/2814543002 .
 2017-04-10 10:12:04 -07:00
John McCutchan 7a2d67f3ba Fix updating packages map on reload and add a regression test 
- [x] Update the isolate's .packages path when requested.
- [x] Always refresh package map when loader is initialized.
- [x] Add regression test.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2797923008 .
 2017-04-10 08:59:10 -07:00
Ryan Macnak 2aecd5e588 Make --trace-loading great again. 
R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2775463002 .
 2017-03-22 17:06:42 -07:00
Jacob Richman a129931cda The formatter struggles a bit with these files. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2765523003 .
 2017-03-21 18:00:52 -07:00
Ryan Macnak c4f6728027 gen_snapshot: 
- Consistently accept hypens or underscores in option names.
 - Replace --snapshot_kind=none with --dependencies-only, since the former is ambiguous as to whether an existing core snapshot needs to be read. Important when using an embedder-specific dart: library.
 - Don't try to canonicalize file paths for the snapshot pieces since this fails if there isn't already a file on disk.

R=asiva@google.com, goderbauer@google.com

Review-Url: https://codereview.chromium.org/2707383007 .
 2017-02-27 15:18:27 -08:00
Ryan Macnak 781fd36086 Add an option to gen_snapshot for creating a Makefile describing a snapshot's dependencies. This option may be used when generating any snapshot kind, or without generating a snapshot. 
- Factor out MallocGrowableArray from vm to platform.
 - Add File::Print.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2715463003 .
 2017-02-23 12:40:48 -08:00
Zachary Anderson 9509bd4443 Limit the number of outstanding file reads in the VM loader 
related https://github.com/dart-lang/test/issues/373

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2626093003 .
 2017-01-11 15:33:07 -08:00
John McCutchan 1033075c36 Fix shutdown loaders 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2202593002 .
 2016-08-01 09:23:45 -07:00
Todd Turnidge 71c240470d Fix build. Fix tests. 
BUG=

Review URL: https://codereview.chromium.org/2194973004 .
 2016-07-29 12:32:53 -07:00
Todd Turnidge 1166f83bf6 Only reload libraries when they may have been modified. 
We now check all of the scripts which make up a library.  If any
script is modified, then we consider that library to be modified.  We
also consider any library which imports a modified library to be
modified.  To propagate this info efficiently, we build and discard
the imported-by graph when beginning a reload.

The embedder must provide a FileModifiedCallback in order to support
the detection of modified scripts.

In order to detect changes to package: libraries, we have modified the
embedder interface to provide the resolved url when possible, so that
we don't need to re-resolve package uris when checking for reload.
This change is incompatible and all embedders will need to be updated.

We now support a "force" flag when reloading sources.  This causes all
libraries to be reloaded regardless of whether the underlying scripts
have been updated.

Closes #26919

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2186423002 .
 2016-07-29 11:23:18 -07:00
John McCutchan 05c1eac65d Support loading dart-ext from within a package when using a package map 
Fixes https://github.com/dart-lang/sdk/issues/26879

When a dart-ext is imported from within a package: library we need to fully resolve the package: to a file: (or whatever scheme:) so that we can locate the shared object for the extension file.

This CL sends this request through the service isolate so that the package: can be resolved even when a package config is being used.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2146093002 .
 2016-07-13 15:20:13 -07:00
Siva Annamalai 11682cd4c7 Use the new loader mechanism to resolve URIs and load script files in gen_snapshot. This should allow the package config resolution to work in gen_snapshot for flutter and dartium snapshot generation cases. 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2073173002 .
 2016-06-20 13:56:06 -07:00
Lasse R.H. Nielsen 191ab42d64 Make VM resolvePackageUri fail on package:foo and package:/foo. 
R=asiva@google.com, floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/eb49613cbfaca2167b124ab01064a2412ff844a5

Review URL: https://codereview.chromium.org/1998603002 .
 2016-06-14 12:22:15 +02:00
Lasse R.H. Nielsen a5aebce4b7 Revert "Make VM resolvePackageUri fail on package:foo and package:/foo." 
There were some tests of the changed behavior.

R=whesse@google.com

Review URL: https://codereview.chromium.org/2068633002 .
 2016-06-14 10:53:08 +02:00
Lasse R.H. Nielsen eb49613cbf Make VM resolvePackageUri fail on package:foo and package:/foo. 
R=asiva@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org/1998603002.
 2016-06-14 09:38:51 +02:00
John McCutchan 8b4ac265c7 Fix Windows bots 
BUG=

Review URL: https://codereview.chromium.org/2045243003 .
 2016-06-08 07:20:42 -07:00
John McCutchan 6fd8fd7987 Rework standalone to use a synchronous loader that does not invoke Dart code 
- [x] The first caller of the tag handler blocks, recursive callers queue work and exit.
- [x] Use a NativeMessageHandler to receive I/O results from the service isolate.
- [x] Preserve load error message format.
- [x] Move packages map into service isolate.
- [x] Wire up Todd's native URI code.

R=turnidge@google.com

Review URL: https://codereview.chromium.org/1998963003 .
 2016-06-06 14:15:01 -07:00
Todd Turnidge 250773cb65 Improve the error message when an import fails. 
BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org/1641383003 .
 2016-01-29 16:30:08 -08:00
Ivan Posva 4f54e6aee5 - Add support for passing data: based URIs as packageConfig to 
Isolate.spawnUri.
- Loosen the expected mimeType and encoding for data: URI based
  file loading.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1585103006 .
 2016-01-15 17:01:58 -08:00
Ivan Posva 6d066c7e53 Add package config support to dart:isolate 
- Add "static Future<Uri> get packageRoot;",
  "static Future<Uri> get packageConfig;" and
  "static Future<Uri> resolvePackageUri(Uri packageUri)" to Isolate class.
- Added "Uri packageRoot, Uri packageConfig, bool automaticPackageResolution: false" parameters to spawnUri.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1553233002 .
 2016-01-12 18:19:04 -08:00
Ryan Macnak 6fc5018282 Standalone: Use new support in dart:core for decoding data uris. 
R=iposva@google.com

Review URL: https://codereview.chromium.org/1489603002 .
 2015-12-01 13:46:20 -08:00
Ivan Posva ee9c0cbb2c - Make sure to close the port if a packages file was passed on the 
command line without actually loading packages.

BUG=23991
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1278623002 .
 2015-08-05 16:34:50 -07:00
Ivan Posva 337931709a - Implement loading of .packages files from http. 
- Fix bad type annotation in builtin.dart when getting an async
  load error.

Review URL: https://codereview.chromium.org//1268313002 .
 2015-08-05 00:13:39 -07:00
Ivan Posva a78db046a6 - Fix logic bug when skipping comments. 
Review URL: https://codereview.chromium.org//1269643002 .
 2015-07-29 15:39:51 -07:00
Ivan Posva b07a9ddbca - Implement .packages specification. 
Limitation: Currently only works for file: based .package files. If a script is loaded from http: then the VM currently assumes a co-located packages/ directory.

R=asiva@google.com

Review URL: https://codereview.chromium.org//1232593003 .
 2015-07-29 11:30:33 -07:00
Srdjan Mitrovic 940cc2dab8 Fix package load error reporting. 
BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//1224403002 .
 2015-07-09 14:49:54 -07:00
Ivan Posva 2abc21a1bf - Avoid using a streamed receive port for single messages. 
- Only open a single receive port for a set of load requests.
- Store information about load requests in a map, which will be able to hold
  other relevant information about the request.

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//1154173006
 2015-05-27 16:59:43 -07:00
iposva@google.com f469f59b60 Reland r45669: 
- Refactor builtin.dart before any further work in this file.

Change to original submission is to not doubly sanitize the
Windows path when setting the working directory.

R=asiva@google.com

Review URL: https://codereview.chromium.org//1127343004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45703 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-11 18:23:20 +00:00
iposva@google.com 16a29667dd - Revert r45669 to address Windows issues. 
R=vegorov@google.com

Review URL: https://codereview.chromium.org//1130003004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45672 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-09 00:59:00 +00:00
iposva@google.com 7f5cdff385 - Refactor builtin.dart before any further work in this file. 
R=asiva@google.com

Review URL: https://codereview.chromium.org//1137853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45669 260f80e4-7a28-3924-810f-c04153c831b5
 2015-05-08 23:58:01 +00:00
rmacnak@google.com fbc6b005a4 Support percent encoded data URIs in the standalone embedder. 
BUG=
R=iposva@google.com

Review URL: https://codereview.chromium.org//1028453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44609 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-20 20:11:53 +00:00
johnmccutchan@google.com 172baa03ff Service isolate rework take 2 
Review URL: https://codereview.chromium.org//889443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43306 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-29 18:31:27 +00:00
johnmccutchan@google.com db271b0477 Revert r43217, r43215, r43208, r43207, and r43202. 
Reverting because of some isolate spawn issues (on Windows, and pub bots).

Review URL: https://codereview.chromium.org//867113003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43219 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-27 22:56:18 +00:00