57ac8b1ad9
Remove redundant instrumentation from tests and expectations.
...
Remove instrumentation for diagnostic messages, forwarding stubs and
covariance, since all this information is present in the expectation
files already.
Change-Id: Idf6622f7eddba801761e13666b470ae6dcc9d59b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97106
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2019-03-20 06:52:13 +00:00
dab228e55f
Save problems in ast - fasta changes
...
Change-Id: Id38f5e7495c245e5a7b161b55c58b8826c146a80
Reviewed-on: https://dart-review.googlesource.com/c/90000
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2019-01-17 10:46:13 +00:00
abdd6ca0d1
Verify that we don't emit SyntheticExpressionJudgment
...
Change-Id: I4973d6731a8095cb3bc58f13f8db522fe3984af8
Reviewed-on: https://dart-review.googlesource.com/c/86020
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Auto-Submit: Peter von der Ahé <ahe@google.com >
2018-12-11 14:55:57 +00:00
5aa705776b
Remove desugaredError
...
Change-Id: Ide688cb577457a642d989deb8d4c7c638274a1bc
Reviewed-on: https://dart-review.googlesource.com/c/80448
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-10-19 07:16:47 +00:00
097e8d86b8
Use context severity when calling onProblem
...
Change-Id: Id1aef8c9185e4d1e660cc342d54a12923a890a43
Reviewed-on: https://dart-review.googlesource.com/77060
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Auto-Submit: Peter von der Ahé <ahe@google.com >
2018-10-02 17:02:10 +00:00
98a9adf696
Make constructor function types conform with the specification.
...
Prior to this CL the return type of any constructor function was
always void. According to the specification §9.3 the return type of a
constructor function ought to be its enclosing class.
Change-Id: I70d76cc354b7f118ce96bf4954daf7fe535eb7be
Reviewed-on: https://dart-review.googlesource.com/76160
Commit-Queue: Daniel Hillerström <hillerstrom@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-09-26 09:39:11 +00:00
309d38f300
Consistency in messages about duplication
...
Change-Id: I2d29c4f08d55d97453cc44344036c54e70e8a155
Reviewed-on: https://dart-review.googlesource.com/75900
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-09-24 13:47:17 +00:00
3831da8743
Include all problems in expectations
...
Change-Id: Ib9426243ae851bdf529f11d0d9b47c75679972fa
Reviewed-on: https://dart-review.googlesource.com/74760
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2018-09-19 08:34:43 +00:00
149c5a0e0e
Improve formatting of errors in golden files
...
Change-Id: I72930f0785b4b451c23e9cd2ebed2fa8290df760
Reviewed-on: https://dart-review.googlesource.com/63840
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-07-05 13:42:42 +00:00
0271003c33
Extract parseFunctionLiteral from parseType
...
This is another step towards removing parseType and improving recovery.
Change-Id: Ie2cb1999406bc603355015e8a3b9aaa854f785db
Reviewed-on: https://dart-review.googlesource.com/56120
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-05-23 13:40:06 +00:00
0c2b349827
Blocks and variable declarations in Forest
...
This is a starting point for supporting blocks and variable
declarations in the forest API. I'm not sure exactly how the
analyzer handles variable declarations, so we'll probably have
to iterate on that part.
Change-Id: I93aec818baec24f8b038f02c66699117070d6b0c
Reviewed-on: https://dart-review.googlesource.com/55683
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2018-05-18 13:55:47 +00:00
4f586e265e
[fasta] Update expectation files after CL 50941
...
Change-Id: I85aba2501a7b8a911e122f0a802dfc21b7e87e1e
Reviewed-on: https://dart-review.googlesource.com/51620
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2018-05-08 10:53:47 +00:00
974a8ee21d
Fix crash in named function expression
...
Fixes https://github.com/dart-lang/sdk/issues/32694
Change-Id: Idfc2dbe11e44d6d927924a6fc54cf31cee66a6ae
Reviewed-on: https://dart-review.googlesource.com/51120
Reviewed-by: Aske Simon Christensen <askesc@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-04-13 12:02:47 +00:00
Peter von der Ahé