2 Commits

Author	SHA1	Message	Date
Kevin Millikin	9bdf2489b5	Signal errors and warnings for invalid returns ... Implement the feature spec for checking returns against inferred function return types: https://github.com/dart-lang/sdk/blob/master/docs/language/informal/invalid_returns.md with the change that an invalid return without a subexpression is a warning, not an error. This is because it is a warning in the analyzer and it would be a breaking change to turn it into an error. The check for valid returns is moved to exactly where we handle returns, rather than in ensureAssignable which is used as a helper in a lot of places. A bug in type inference was fixed: we would use `void` for the type of return without a subexpression instead of `null`. To accommodate that we would use a non-standard subtyping relation for returns. This could lead to us inferring a return type of `void` in cases where we should not. Change-Id: Iee9ece9c722f47efa305f49490d3022d0bbb9f44 Reviewed-on: https://dart-review.googlesource.com/72403 Commit-Queue: Kevin Millikin <kmillikin@google.com> Reviewed-by: Aske Simon Christensen <askesc@google.com>	2018-09-04 16:50:51 +00:00
Samir Jindel	4289a9967b	Check expected outputs of transforms. ... Change-Id: I56ff4d4391b7a22d709dc60b696646895928e34c Reviewed-on: https://dart-review.googlesource.com/46100 Reviewed-by: Peter von der Ahé <ahe@google.com> Commit-Queue: Samir Jindel <sjindel@google.com>	2018-03-15 12:11:13 +00:00