98a9adf696
Make constructor function types conform with the specification.
...
Prior to this CL the return type of any constructor function was
always void. According to the specification §9.3 the return type of a
constructor function ought to be its enclosing class.
Change-Id: I70d76cc354b7f118ce96bf4954daf7fe535eb7be
Reviewed-on: https://dart-review.googlesource.com/76160
Commit-Queue: Daniel Hillerström <hillerstrom@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-09-26 09:39:11 +00:00
4f586e265e
[fasta] Update expectation files after CL 50941
...
Change-Id: I85aba2501a7b8a911e122f0a802dfc21b7e87e1e
Reviewed-on: https://dart-review.googlesource.com/51620
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
2018-05-08 10:53:47 +00:00
bf797e6507
[kernel] Re-land assert initializers.
...
This change updates Dart2js and DDC.
Thanks to johnniwinther@ for the Dart2js updates.
The original revision is in patchset 2.
Change-Id: I26db33312f003f88ccccb67b27998ef21a1f667f
Reviewed-on: https://dart-review.googlesource.com/25820
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
Commit-Queue: Samir Jindel <sjindel@google.com >
2017-12-04 11:22:34 +00:00
48a927acb2
Revert "[kernel] Introduce assert initializers."
...
Reverting due to several test failures.
This reverts commit 67adfe741bhttps://dart-review.googlesource.com/25520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-01 17:46:05 +00:00
67adfe741b
[kernel] Introduce assert initializers.
...
Assert initializers in Dart may be compiled directly to this form of initializer,
rather than through local initializers as is done now.
Bug:
Change-Id: Ia149ea3d1df5d1dc18be5636801604ffaf7ca7d8
Reviewed-on: https://dart-review.googlesource.com/14760
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2017-12-01 14:04:06 +00:00
02511ceeb4
Fix the precedence of FunctionExpression
...
FunctionExpression should have a low precedence to ensure that it is
properly parenthesized.
Fixes https://github.com/dart-lang/sdk/issues/31380
Bug:
Change-Id: I2ca2bb728973c5b374411dc07fdadc4dda8c707b
Reviewed-on: https://dart-review.googlesource.com/21343
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Kevin Millikin <kmillikin@google.com >
2017-11-16 10:38:12 +00:00
ae4cbb50af
Use "bool" as the downward inference context for assert conditions.
...
This addresses the type inference part of #30326 .
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2997513002 .
2017-08-07 10:36:51 -07:00
1b9ba53fb6
Implement type inference for asserts in constructor initializers.
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2995553002 .
2017-08-04 17:55:11 -07:00
Daniel Hillerström