Commit Graph

2256 Commits

Author SHA1 Message Date
John Messerly c761b425df fix default warning level
See https://github.com/dart-atom/dartlang/issues/327

R=vsm@google.com

Review URL: https://codereview.chromium.org/1374563004 .
2015-09-29 10:18:04 -07:00
John Messerly 47bab055d7 [js] simplify qualified names
R=vsm@google.com

Review URL: https://codereview.chromium.org/1368153002 .
2015-09-25 13:03:59 -07:00
John Messerly 0cdc8c28fb Revert "Qualified exports and inheritance for Closure" 2015-09-25 11:31:25 -07:00
John Messerly 2d5525fc4a Merge pull request #319 from dart-lang/closure-qualify
Qualified exports and inheritance for Closure
2015-09-25 10:53:37 -07:00
Devon Carew 7d31247eff add a changelog 2015-09-23 10:43:50 -07:00
Leaf Petersen ff1669f8db Screen dynamic invokes to object properties in checker. In the old code, when we so o.f (or o.f(..)) and o had type dynamic, we would promote the type of o to Object so that our dynamic invocation code would not emit a dinvoke. This seems a little bit of a hack in the context of the analyzer integration, so this CL eliminates the promotion, and changes the checker to screen out these dynamic invokes. This should eliminate some of the additional dynamic invokes that Vijay is seeing.
BUG=
R=jmesserly@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/1361833002 .
2015-09-22 16:28:58 -07:00
Vijay Menon 2c2a80e587 Update to 0.1.8
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1355043003 .
2015-09-21 15:51:35 -07:00
Devon Carew 318584b4ba add a --version option 2015-09-18 21:39:31 -07:00
John Messerly 9383237f36 additional SDK fixes. This gets all of them, once we upgrade to new analyzer
there's still a lot of warnings, those are next up

R=leafp@google.com

Review URL: https://codereview.chromium.org/1347153005 .
2015-09-18 17:11:21 -07:00
John Messerly 28f1e80cd6 fix some errors in our SDK, mostly around numbers, see issue #103
also improved codegen of JSNumber's methods

R=leafp@google.com

Review URL: https://codereview.chromium.org/1348453004 .
2015-09-18 17:10:02 -07:00
Vijay Menon bf99bdc21c Remove redundant call
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1357713006 .
2015-09-18 15:40:35 -07:00
John Messerly e34e64370b Merge pull request #333 from dart-lang/self_references
normalize lib/ self-refs to path references
2015-09-17 13:27:19 -07:00
John Messerly 6038aa2955 Merge pull request #334 from dart-lang/finish_rename
finish rename of devc.dart to dartdevc.dart
2015-09-17 08:22:39 -07:00
vsmenon 423c8503d9 Merge pull request #328 from dart-lang/dartdoc
make dev_compiler slightly happier with dartdoc
2015-09-17 06:43:57 -07:00
vsmenon 265f76ef44 Merge pull request #318 from dart-lang/travis-runner2
Speed Travis CI up with some caching & faster fails
2015-09-17 06:40:22 -07:00
Devon Carew 01ffd2684d finish rename of devc.dart to dartdevc.dart 2015-09-16 21:22:57 -07:00
Devon Carew 2ae203eff8 normalize lib/ self-refs to path references 2015-09-16 19:23:14 -07:00
Devon Carew 5baea1b7e7 make dev_compiler slightly happier with dartdoc 2015-09-16 18:03:52 -07:00
John Messerly 4c43f3f8bb Merge pull request #323 from dart-lang/language_tests
add language tests & run them in karma
2015-09-16 16:43:33 -07:00
Devon Carew 6f3710e317 catch parse exceptions from args 2015-09-16 16:33:29 -07:00
Devon Carew d3e6d3af24 support running the dev_compiler package directly 2015-09-16 16:13:11 -07:00
John Messerly bea9ae786a add language tests & run them in karma 2015-09-16 16:00:46 -07:00
John Messerly bcec623909 fixes #315, order of libraries in the HTML file
the lesson here is never use .importedLibraries ... we might want to change it in analyzer to use LinkedHashSet ...

R=vsm@google.com

Review URL: https://codereview.chromium.org/1337993004 .
2015-09-15 09:13:18 -07:00
John Messerly ff1b78ca42 fix a few more codegen issues:
* don't generate script tag
* handle U+2028 and U+2029
* handle name conflict with constructor

R=vsm@google.com

Review URL: https://codereview.chromium.org/1347453002 .
2015-09-14 17:06:28 -07:00
Olivier Chafik 58f1ca9259 Qualified exports and inheritance for Closure (fixes core.Object issue) 2015-09-14 14:07:02 +01:00
Olivier Chafik 56a534ae65 Speed Travis CI up with some caching & faster fails 2015-09-12 17:55:46 +01:00
John Messerly 637c2c83de fixes #314, super method tear offs
R=leafp@google.com

Review URL: https://codereview.chromium.org/1310513013 .
2015-09-10 17:18:21 -07:00
Vijay Menon b90511b88c Omit Chrome stable in travis for now
The default Chrome in travis is Chrome *37*.  Disabling - will a send
a separate CL to fix properly.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/1331963002 .
2015-09-10 09:23:37 -07:00
Vijay Menon febc95eead Run tests on Chrome stable and canary
As of Chrome 45, we can run on stable and canary.  Karma appears to
run these in parallel - I see little difference in wall clock time on
my laptop.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1310753007 .
2015-09-10 09:14:45 -07:00
John Messerly dc560e572c fix readability regressions from previous block-scope CL
also reverts the simple incremental compile code, it wasn't aware of our own compiler's version.

also fixes a warning from analyzer

R=leafp@google.com

Review URL: https://codereview.chromium.org/1305413006 .
2015-09-09 15:52:17 -07:00
John Messerly 99bdee4f8d fix implicit_scope_test and builtin_identifier_test
these were generating invalid JS code

R=vsm@google.com

Review URL: https://codereview.chromium.org/1328303002 .
2015-09-08 16:56:50 -07:00
John Messerly 7263daed54 fix dynamic type literal
it doesn't have a library

R=leafp@google.com

Review URL: https://codereview.chromium.org/1310943005 .
2015-09-04 15:57:32 -07:00
John Messerly badedeaf16 fix cascade on ThisExpression
R=leafp@google.com

Review URL: https://codereview.chromium.org/1309383003 .
2015-09-04 15:28:38 -07:00
Vijay Menon 2ef54c946b Fixes for Angular
R=leafp@google.com

Review URL: https://codereview.chromium.org/1324693004 .
2015-09-02 13:39:53 -07:00
Vijay Menon 33ad4d9600 Reformat
Olivier: running presubmit locally (for me) reformats a few files.  May be a pub upgrade issue to get on the latest formatter.

TBR=ochafik@google.com

Review URL: https://codereview.chromium.org/1322673004 .
2015-09-02 12:53:05 -07:00
Olivier Chafik 8ebe4c8a09 Merge pull request #286 from dart-lang/closure-annotations
Output Closure annotations when --closure (very experimental feature)
2015-09-02 18:34:54 +01:00
John Messerly 798076dbc8 make build_sdk more incremental
saves about 3s off a typical rebuild where nothing changed

R=vsm@google.com

Review URL: https://codereview.chromium.org/1327573002 .
2015-09-02 08:43:00 -07:00
John Messerly 707b9cc09c triage remaining async tests
one fix, two rejected statically

R=leafp@google.com

Review URL: https://codereview.chromium.org/1319523007 .
2015-08-31 17:49:41 -07:00
Vijay Menon b0abb3b302 Some preliminary support for quasi-generics
This just expands John's earlier hack on min/max.  No downward
inference, etc, but it captures some simple cases.  Worthwhile?

Testing whether this makes much of a difference on our larger code bases.

R=jmesserly@google.com, leafp@google.com

Review URL: https://codereview.chromium.org/1317933005 .
2015-08-31 09:56:41 -07:00
vsmenon fbba7e95ff Update STRONG_MODE.md 2015-08-28 13:16:49 -07:00
John Messerly 9c832d6a6b makes tests faster, see #304
this doesn't completely address the issue, but it knocks off some of the time.
also attempt to stabilize error message order.

R=vsm@google.com

Review URL: https://codereview.chromium.org/1321103002 .
2015-08-28 10:14:16 -07:00
John Messerly c4b754b041 use the real matchers for running language tests
R=vsm@google.com

Review URL: https://codereview.chromium.org/1321683004 .
2015-08-28 09:27:36 -07:00
vsmenon 0a54ee5563 Update pubspec.yaml
0.1.7
2015-08-27 16:34:39 -07:00
Olivier Chafik 08174babac Update flags for iojs: --harmony_generators needed by async, --harmony_modules useless for now. 2015-08-27 16:34:26 +01:00
Olivier Chafik 59cf5dd893 Output some basic type annotations for the Closure Compiler when --closure is set. 2015-08-27 16:30:20 +01:00
Vijay Menon 604b199ed3 Make implicit casts hints
This appears to cut out about 1/3 of the strong mode errors reported
in angular2.  The actual cases removed that I looked at seem fine - e.g., we may inject an implicit cast, but it'll work fine at runtime.

Fixes #302

R=leafp@google.com

Review URL: https://codereview.chromium.org/1310053005 .
2015-08-26 15:01:59 -07:00
John Messerly 74c760066b implement null aware ops, fixes #249
this also implements multitest support, which fixes #280

Fixes some other preexisting bugs:
* MetaLets did not simplify themselves correctly in some nested cases
* Library prefixed identifiers did not work as lvalues in opassign
* dsetindex/dput/[]= methods did not return a value
* checker did not correctly handle invalid constructor field initializers
* cascades did not correctly work with method invocations(?)
* postfix ++/-- did not correctly generate lvalues in some cases

The good news: because this reuses on our existing lvalue/metalet helpers, it managed to flush out a lot of bugs in other features that use them.

R=vsm@google.com

Review URL: https://codereview.chromium.org/1316723003 .
2015-08-25 15:13:18 -07:00
Vijay Menon 50eb282f87 Infer parameter types on overrides
Fixes #105

This overlaps with brian's recent CL moving override inference logic.  If this looks good, we'll need to move it over as well.

R=brianwilkerson@google.com, leafp@google.com

Review URL: https://codereview.chromium.org/1311863005 .
2015-08-25 10:45:08 -07:00
vsmenon c38d2e8cf2 Update pubspec.yaml 2015-08-21 13:25:45 -07:00
Vijay Menon 242511dab7 Fixes #287 and other failures statically checking SDK tests
This adds some defensiveness to override checking and other checks.

It fixes all known crashers running dartanalyzer in strong mode on language, co19, etc.

R=leafp@google.com

Review URL: https://codereview.chromium.org/1303913003 .
2015-08-21 13:15:36 -07:00