Commit Graph

817 Commits

Author SHA1 Message Date
John Messerly 85d3071fba remove canonicalType
it is unused now since the extension type system replaced it.

there's a potentially interesting use case supported, e.g. ES6 subclasses of JS Array, but we can ignore that for now (IMO)

R=sra@google.com

Review URL: https://codereview.chromium.org/1967743005 .
2016-05-11 10:56:58 -07:00
Leaf Petersen 2031f66a95 Canonicalize function types. Brings sample app load time
down to the 6-7s range.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1969523002 .
2016-05-11 10:08:29 -07:00
Bob Nystrom 9cf428afdd Delete work-in-progress script.
Oops, didn't mean to check this in.

R=sra@google.com

Review URL: https://codereview.chromium.org/1969663002 .
2016-05-11 09:54:52 -07:00
Stephen Adams 098508c533 Update _charCodeApply, makeFixedStringUnmodifiable
TBR=vsm@google.com

Review URL: https://codereview.chromium.org/1969683002 .
2016-05-10 18:44:33 -07:00
Stephen Adams a2ebf2ada1 Speed up String.fromCharCodes a bit
About 4x speedup of convert/ascii_test.dart by removing dsend in inner loop.

R=leafp@google.com

Review URL: https://codereview.chromium.org/1968783002 .
2016-05-10 17:30:19 -07:00
Harry Terkelsen 32fd2f8215 update Map
R=sra@google.com

Review URL: https://codereview.chromium.org/1963723003 .
2016-05-10 16:19:19 -07:00
John Messerly a7f812b676 fix #552, Object members on native types
We initially hard coded a few of these. That worked until native_typed_data and html were added. Those two libraries have a lot of native types.

This also fixes TypeRep to extend dart:core Object, and fixes the dart:_runtime so we can write Dart classes. Cleans up a few of the JS builtins as well.

R=vsm@google.com

Review URL: https://codereview.chromium.org/1962823002 .
2016-05-10 11:35:38 -07:00
Bob Nystrom e535970604 Update dart:convert and dart:core Uri.
I started trying to get the convert tests all cleaned up and passing
but realized I was going down a rathole. So, for now, all of the slow
or failing ones are just skipped.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1965563003 .
2016-05-10 10:25:38 -07:00
Leaf Petersen 3cbf0e4a92 Delete logging code
TBR=vsm@google.com

BUG=

Review URL: https://codereview.chromium.org/1961393003 .
2016-05-10 10:09:30 -07:00
Leaf Petersen 97d91f620c Faster ignore.
Put a cache in front of the function which tests for failures to
ignore.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/1963733003 .
2016-05-10 09:43:20 -07:00
Stephen Adams 783a1f45c2 Update linked_list, queue, splay_tree
Now identical to (pending) CL from main branch.

TBR=vsm@google.com

Review URL: https://codereview.chromium.org/1966473002 .
2016-05-09 14:14:29 -07:00
Stephen Adams c2e170fb1f Update mirrors.dart
This is a comments-only update.
Several APIs need to be visited to be made to work for DDC.
These are much clearer now.

TBR=vsm@google.com

BUG=

Review URL: https://codereview.chromium.org/1955293003 .
2016-05-08 18:31:18 -07:00
Stephen Adams 8da8c3efbf Update dart:typed_data
This is all all-documentation change.

TBR=vsm@google.com

Review URL: https://codereview.chromium.org/1956263002 .
2016-05-08 18:12:50 -07:00
Leaf Petersen 86c4dc01a1 Only use white list on indefinite checks
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/1953823005 .
2016-05-06 19:14:47 -07:00
Stephen Adams a5d1626299 Update date_time.
TBR=vsm@google.com

Review URL: https://codereview.chromium.org/1952133007 .
2016-05-06 17:52:21 -07:00
Stephen Adams 090110fb65 Update native_typed_data
TBR=vsm@google.com

Review URL: https://codereview.chromium.org/1956993003 .
2016-05-06 17:26:25 -07:00
Stephen Adams 65e8266447 Update collection (list / map / iterable) printing.
Remove methods from IterableBase that are now on Iterable.

And random comments from other files.

Review URL: https://codereview.chromium.org/1956933002 .
2016-05-06 16:03:44 -07:00
Leaf Petersen 7c634031e5 Fix void subtype checks.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/1958683002 .
2016-05-06 14:04:03 -07:00
Stephen Adams 7bd37f015f Upgrade StringBuffer, identical
TBR=vsm@google.com

Review URL: https://codereview.chromium.org/1957633002 .
2016-05-05 21:11:09 -07:00
Stephen Adams bf4e10e356 Update String.fromCharCodes from sdk
TBR=vsm@google.com

Review URL: https://codereview.chromium.org/1952223006 .
2016-05-05 20:52:27 -07:00
Stephen Adams 5c41457500 Update CodeUnits.
TBR=vsm@google.com

Review URL: https://codereview.chromium.org/1956623002 .
2016-05-05 17:25:56 -07:00
Vijay Menon 7d32105a82 Pickup latest analyzer fixes
Note the new errors in sdk.  Did we change something wrt overrides?

R=leafp@google.com

Review URL: https://codereview.chromium.org/1951263004 .
2016-05-05 16:30:39 -07:00
Stephen Adams 155597eebc Update object.dart and some comments.
TBR=vsm@google.com

Review URL: https://codereview.chromium.org/1952903003 .
2016-05-05 16:29:06 -07:00
Stephen Adams daddc0d4fa Update number parsing.
Review URL: https://codereview.chromium.org/1950133008 .
2016-05-05 16:15:05 -07:00
Bob Nystrom a191ce0384 Update dart:async to match the Dart repo.
R=vsm@google.com

Review URL: https://codereview.chromium.org/1953153002 .
2016-05-05 15:03:10 -07:00
Stephen Adams 6ef3c8821d Updates for core/{pattern,regexp,stopwatch,duration}.dart
TBR=vsm@google.com

Review URL: https://codereview.chromium.org/1944413006 .
2016-05-05 11:43:32 -07:00
Stephen Adams aa2baf19d3 Updates for js_array.
Copy over most js_array methods.
Remove IterableMixinWorkaround.

R=vsm@google.com

Review URL: https://codereview.chromium.org/1943563002 .
2016-05-05 11:35:37 -07:00
Stephen Adams f6fc1e380f Upgrade Iterable and Iterator.
R=vsm@google.com

Review URL: https://codereview.chromium.org/1948113003 .
2016-05-04 20:22:42 -07:00
Stephen Adams b016f035bd Update String methods.
This will need a second pass after core.Iterable is updated
and JS type strings are better parsed.

R=vsm@google.com

Review URL: https://codereview.chromium.org/1950133003 .
2016-05-04 19:40:51 -07:00
Leaf Petersen a860134afc Fix subtyping for generic typedefs. Generic typedefs were being
treated as classes.

Fixes https://github.com/dart-lang/dev_compiler/issues/550 .

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/1948253002 .
2016-05-04 18:35:59 -07:00
Stephen Adams a703b28667 Merge in JSNumber changes.
R=vsm@google.com
TBR=vsm@google.com

Review URL: https://codereview.chromium.org/1952043002 .
2016-05-04 16:41:13 -07:00
Bob Nystrom a6d1fbfb9d Fix accessing private members on extension classes.
Since the member was already a symbol, canonicalMember() was incorrectly
double wrapping it.

Fixes #508.

R=vsm@google.com

Review URL: https://codereview.chromium.org/1944293003 .
2016-05-04 15:04:00 -07:00
Stephen Adams e227caef4d Update core/{bool,errors,exceptions}
BUG=

Review URL: https://codereview.chromium.org/1952013002 .
2016-05-04 13:42:19 -07:00
Leaf Petersen 2f00ebd41c Better is/as check handling. With this CL, the subtype function in
the DDC runtime returns null when a difference from the spec mode
result is possible.

Fixes https://github.com/dart-lang/dev_compiler/issues/524 .

BUG=
R=jmesserly@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/1945113003 .
2016-05-04 13:25:55 -07:00
Stephen Adams f6e0383b90 Update core/errors.dart
Also
- update some error helpers functions in the js runtime.
- add 'int' to stringFromCharCode to avoid dcalls.

R=vsm@google.com

Review URL: https://codereview.chromium.org/1947723002 .
2016-05-04 10:41:14 -07:00
Vijay Menon 642d08f400 Add global compile tool
This is for testing purposes and hence in tool.  Gives a dart2js-ish
API to invoke DDC, but stuffs everything in one module.

Closed https://codereview.chromium.org/1900813002/ in favor of this.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1951433002 .
2016-05-04 08:57:31 -07:00
John Messerly 2b20f3d1cc fix #543, export of properties should now work
top-level fields, getters, setters were all broken

R=vsm@google.com

Review URL: https://codereview.chromium.org/1949733002 .
2016-05-03 16:37:42 -07:00
Bob Nystrom 44db042cd8 Redo how Type objects are exposed from DDC.
- Instead of using the raw runtime type that DDC uses for its type
  checks, use a WrappedType that correctly implements Type's interface.
- Compile class literals to wrap the type in a WrappedType.
- Make Object.runtimeType() do the same thing.

Fixes #488. Fixes #511.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1944483002 .
2016-05-03 14:24:08 -07:00
Stephen Adams 6485751d8c Implement Map.unmodifiable
This is a temporary solution.
When we have an implementation of const maps, we should switch to that.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/1946663002 .
2016-05-03 12:02:20 -07:00
Vijay Menon dc8e00b2da Revert "Workaround #537"
Undoing this.  Paul fixed this in 1.17.  We'll need to run with 1.17 builds going forward, but we need that for other reasons.

Fixes #537

R=jacobr@google.com

Review URL: https://codereview.chromium.org/1936693002 .
2016-05-03 10:38:59 -07:00
Vijay Menon 6d8dc11397 Suppress extra cast
If I rebuild the SDK, I see a cast from List to List<E> on the next line without this.  With the change, we just infer List<E> in the first place.

R=sra@google.com

Review URL: https://codereview.chromium.org/1945793002 .
2016-05-03 10:30:17 -07:00
Stephen Adams 1aa00bc447 List.unmodifiable
Most operations don't check, that will happen as more code is updated
to a more recent sdk.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/1939093003 .
2016-05-03 09:34:44 -07:00
John Messerly 733773476d instantiate generic tear-offs, fixes #525
R=het@google.com

Review URL: https://codereview.chromium.org/1930323004 .
2016-04-29 16:41:24 -07:00
Vijay Menon b2c0a7446e Workaround #537
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1933383002 .
2016-04-29 12:47:16 -07:00
John Messerly 6598fa0f7d implement generic method runtime behavior, fixes #301
R=leafp@google.com, vsm@google.com

Review URL: https://codereview.chromium.org/1926283002 .
2016-04-29 10:41:48 -07:00
Jacob Richman 7db49e6a44 Fixed 3 final missing casts in dart:js
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1931373002 .
2016-04-29 08:50:14 -07:00
John Messerly 9f764bf5b4 Make parts hermetic, fixes #531
R=paulberry@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org/1930133002 .
2016-04-28 13:37:10 -07:00
Vijay Menon acc4d6867d Stop concatenating all tests
R=sra@google.com

Review URL: https://codereview.chromium.org/1928443006 .
2016-04-28 11:29:38 -07:00
Jacob Richman eef7f81d0a Land fix to StackTrace.current performance already landed in dart2js.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/1927813002 .
2016-04-28 09:28:25 -07:00
John Messerly aa0b75f893 simplify emitting dart.bind for native types
R=het@google.com

Review URL: https://codereview.chromium.org/1921503007 .
2016-04-27 09:59:32 -07:00