John Messerly
010ce41dea
skip map files in test.sh diff
...
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org/979503002
2015-03-03 14:08:43 -08:00
Vijay Menon
946676554b
Make int and double nullable by default
...
See patch set 1 for the initial step back and patch set 2 to try to get some of this back.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/977613002
2015-03-03 12:08:30 -08:00
Sigmund Cherem
f7b7f43d28
Fixing layout in js output (use full paths rather than just the library name)
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org/968273002
2015-03-03 09:05:09 -08:00
Sigmund Cherem
17c3dcfca6
Fix test related to sdk move
...
BUG=
Review URL: https://codereview.chromium.org/970223002
2015-03-03 09:03:44 -08:00
John Messerly
77e62cc7fb
implement private members, fixes #74
...
naturally, lots of things to iterate on, but this expresses the key idea (per-library ES6 symbols for privacy).
R=vsm@google.com
Review URL: https://codereview.chromium.org/963343002
2015-03-03 06:44:25 -08:00
John Messerly
a3aebf03ed
fix dummy setters -- grammar requires an identifier
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/974703003
2015-03-03 06:42:04 -08:00
John Messerly
5d52de79e1
implement rethrow
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org/969783002
2015-03-02 09:49:17 -08:00
John Messerly
a260ce7a62
fixes #69 , avoid module name inside module scope
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/967713002
2015-03-02 07:10:55 -08:00
Sigmund Cherem
a72f8d67b9
Fix report test
...
Review URL: https://codereview.chromium.org/965033003
2015-02-27 17:39:03 -08:00
John Messerly
4d7aa8e397
add source maps support, fixes #50
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org/965033002
2015-02-27 15:17:19 -08:00
John Messerly
bd06d9e7f4
support the JS builtin
...
* fix a few cases where we regressed js_ast parser interpolations
* infer correct static type for JS call expressions
R=vsm@google.com
Review URL: https://codereview.chromium.org/962083002
2015-02-27 11:28:41 -08:00
John Messerly
2a5adfe05a
fix analysis messages
...
seen on the latest dev channel editor w/ analysis server
R=sigmund@google.com
Review URL: https://codereview.chromium.org/962213003
2015-02-27 09:06:13 -08:00
John Messerly
a3bbe2a291
cleans up sdk patching so we no longer have unresolved names
...
js_codegen.dart and patch_sdk.dart are the only human-changed files.
This also pulls in dart:isolate, which is depended on from one of the implementation libraries
This also moves dart:_* files back to `lib/_internal/compiler/js_lib/` because there's where libraries.dart points to, and hence Analyzer looks for them there. Alternatively, we could put them somewhere like `tool/input_sdk_internal` and then copy that file into the right path.
R=vsm@google.com
Review URL: https://codereview.chromium.org/955513008
2015-02-26 17:58:13 -08:00
Leaf Petersen
40688929e5
Typecheck map and list literals
...
We were not checking the elements of list and map literals against the declared type of the literal.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/957013002
2015-02-26 16:45:15 -08:00
Vijay Menon
50753e3a47
Typecheck constructor initializers properly
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/959003003
2015-02-26 16:19:27 -08:00
Sigmund Cherem
9369b3e981
Fix new line breaks on }
...
R=leafp@google.com
Review URL: https://codereview.chromium.org/959073002
2015-02-26 14:32:48 -08:00
Sigmund Cherem
2ffd89471a
Disable formatting and add new-lines to make tests faster.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/963593002
2015-02-26 13:13:56 -08:00
John Messerly
ead4fe2e85
merge class extensions from patch files.
...
There are a few examples of classes like this:
```dart
@patch
class StringBuffer {
... various @patch members ...
// no @patch here
void _writeString(str) { ... }
}
```
we need to merge in those members too
R=vsm@google.com
Review URL: https://codereview.chromium.org/955513007
2015-02-26 08:08:21 -08:00
John Messerly
425c3d8359
don't run dart gen on JS patch code
...
R=vsm@google.com
Review URL: https://codereview.chromium.org/961493003
2015-02-26 08:07:22 -08:00
John Messerly
89651ccdef
cleanup patch generation to preseve comments and remove @patch
...
the only human authored changes here are tool/patch_sdk.dart
R=vsm@google.com
Review URL: https://codereview.chromium.org/959913003
2015-02-25 13:23:23 -08:00
John Messerly
b82e83f383
use js_ast instead of strings to generate JS
...
fixes https://github.com/dart-lang/dev_compiler/issues/61
R=sigmund@google.com , vsm@google.com
Review URL: https://codereview.chromium.org/949383003
2015-02-25 11:14:19 -08:00
Sigmund Cherem
e57c960817
rename package:ddc to package:dev_compiler
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org/954773003
2015-02-24 17:01:15 -08:00
John Messerly
0e46bb35ba
fix formatting to include test, exclude lib/src/js
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org/953093005
2015-02-24 16:56:13 -08:00
Vijay Menon
5c1c9c2381
Add LICENSE and corresponding headers
...
Fix expectations where line number has changed.
R=dgrove@google.com
Review URL: https://chromereviews.googleplex.com/158257013
2015-02-24 15:02:26 -08:00
Sigmund Cherem
6ca4479a85
Undo rename of analyzer now that we are unforked
...
BUG=
Review URL: https://chromereviews.googleplex.com/158907014
2015-02-24 10:06:47 -08:00
Sigmund Cherem
608906db87
Fixes needed so we work correctly with the latest analyzer
...
Review URL: https://chromereviews.googleplex.com/157367013
2015-02-20 15:39:28 -08:00
Sigmund Cherem
d2834b49a6
Reenable type promotion
...
R=jmesserly@google.com , vsm@google.com
Review URL: https://chromereviews.googleplex.com/159667013
2015-02-20 13:56:46 -08:00
John Messerly
6c7cd9b731
Begin to handle some of the *_patch.dart files
...
Moves: test/sdk --> tool/input_sdk_src
Also moves: test/sdk/lib/_internal/js_lib --> tool/input_sdk_patch
we'll eventually need to customize that code
Adds tool/patch_sdk.dart, an offline transformation step that produces: test/generated_sdk
Essentially this merges the "external" declarations and the @patch syntactically. There's a comment in tool/patch_sdk.dart explaining the rationale behind this approach.
There's still *lots* to do in the generated code. This does none of that. The only new code is tool/patch_sdk.dart and the minimum changes to test/codegen_test.dart and js_codegen.dart to get test.sh running and debuggable.
Tracking bug for SDK is https://github.com/dart-lang/dart-dev-compiler/issues/58
R=sigmund@google.com , vsm@google.com
Review URL: https://chromereviews.googleplex.com/157137013
2015-02-20 08:58:01 -08:00
Sigmund Cherem
d78ecd3241
Infer consts and final fields based on RHS
...
R=vsm@google.com
Review URL: https://chromereviews.googleplex.com/142457013
2015-02-19 08:34:01 -08:00
Sigmund Cherem
ce3dd48740
Accept compilng HTML files
...
R=jmesserly@google.com , vsm@google.com
Review URL: https://chromereviews.googleplex.com/153157013
2015-02-18 16:48:56 -08:00
John Messerly
7c1ab1f04d
work around issue #51 , super restrictions in V8
...
Adds an explicit "extends dart.Object", which we probably want for other reasons (e.g. toString, runtimeType, hashCode)
Attempts to recover some readability by tweaking the name of the initialize functions. This closes #51 , but we should open another tracking bug because there are concerning aspects to this workaround.
R=sigmund@google.com , vsm@google.com
Review URL: https://chromereviews.googleplex.com/150417015
2015-02-18 16:27:32 -08:00
Vijay Menon
260cfc05d2
Make nonnullability configurable
...
John: I added code in the JS codegen to query which primitives are non-nullable.
R=jmesserly@google.com , sigmund@google.com
Review URL: https://chromereviews.googleplex.com/155407013
2015-02-18 14:20:22 -08:00
Vijay Menon
eb3c51e6f3
Check default parameters properly
...
R=leafp@google.com
Review URL: https://chromereviews.googleplex.com/155367013
2015-02-18 12:13:30 -08:00
Sigmund Cherem
b23578984b
Unify naming of output libraries in both backends
...
R=jmesserly@google.com , leafp@google.com
Review URL: https://chromereviews.googleplex.com/157197015
2015-02-18 10:12:54 -08:00
John Messerly
694c93c61f
fix #41 , named arguments with conversions
...
R=leafp@google.com
Review URL: https://chromereviews.googleplex.com/150407013
2015-02-17 13:27:37 -08:00
Sigmund Cherem
ae910f2860
Infer return types and field types based on overrides
...
R=jmesserly@google.com , vsm@google.com
Review URL: https://chromereviews.googleplex.com/145247013
2015-02-13 16:53:58 -08:00
Sigmund Cherem
46dfefcae7
Fix check of functions agasint void.
...
R=vsm@google.com
Review URL: https://chromereviews.googleplex.com/156137013
2015-02-13 16:48:37 -08:00
Sigmund Cherem
0ab8340e79
Minor improvement on dart:mocks mocks, and fix related test.
...
R=jmesserly@google.com
Review URL: https://chromereviews.googleplex.com/155267013
2015-02-13 16:18:36 -08:00
Sigmund Cherem
c08003a36e
Add options and move the multi-package options to normal flags
...
R=jmesserly@google.com
Review URL: https://chromereviews.googleplex.com/149487013
2015-02-13 13:04:16 -08:00
Vijay Menon
394bb7fbe7
Fix typename for bottom
...
R=sigmund@google.com
Review URL: https://chromereviews.googleplex.com/151297013
2015-02-13 09:35:24 -08:00
John Messerly
f7a5ff4523
workaround for arrow function bind this
...
I filed https://github.com/dart-lang/dart-dev-compiler/issues/43 to track removal of this workaround
R=vsm@google.com
Review URL: https://chromereviews.googleplex.com/154077013
2015-02-12 15:18:22 -08:00
Sigmund Cherem
26061d84eb
Get rid of redundant error messages.
...
R=jmesserly@google.com
Review URL: https://chromereviews.googleplex.com/146637013
2015-02-12 13:23:14 -08:00
John Messerly
fe19170e93
better handling of string literals and interpolation
...
fixes https://github.com/dart-lang/dart-dev-compiler/issues/42
V8 has shipped template strings: https://code.google.com/p/v8/issues/detail?id=3230
R=vsm@google.com
Review URL: https://chromereviews.googleplex.com/152127013
2015-02-12 11:45:39 -08:00
John Messerly
267f6fb0a1
exclude test from dartfmt
...
formatter is currently failing on generated code files
Review URL: https://chromereviews.googleplex.com/150227013
2015-02-12 11:44:00 -08:00
Vijay Menon
266b6df92d
Error on uninitialized non-nullables
...
R=jmesserly@google.com , leafp@google.com
Review URL: https://chromereviews.googleplex.com/157727013
2015-02-12 09:44:41 -08:00
John Messerly
bf9a2b9015
add test tools, implement generic type constructor
...
test tools are from https://github.com/webcomponents/webcomponentsjs/tree/master/tests/tools
R=vsm@google.com
Review URL: https://chromereviews.googleplex.com/151127013
2015-02-11 16:53:05 -08:00
Vijay Menon
9265d63a32
Fix core libs for primitives
...
R=jacobr@google.com , jmesserly@google.com
Review URL: https://chromereviews.googleplex.com/155017013
2015-02-11 14:10:27 -08:00
Vijay Menon
e64630186d
Add non-nullability logic for primitives
...
Still need to:
- Fix our dart:core errors
- Change DownCastLiteral to error
- Handle "int x;", etc.
R=jmesserly@google.com , leafp@google.com
Review URL: https://chromereviews.googleplex.com/156787013
2015-02-11 12:08:34 -08:00
John Messerly
d1cffd61c4
fix indent for generic classes. the previous change intentionally skipped indent for easier diff viewing.
...
R=vsm@google.com
Review URL: https://chromereviews.googleplex.com/157687013
2015-02-11 10:10:57 -08:00
John Messerly
083e4c4889
reified generics baby steps
...
introduces a memoized function that produces the generic type instance
generic type parameters are closed over, making it easy to get them and ensure they flow correctly through base class/mixins.
also implements the unimplemented features in _typeName.
R=leafp@google.com , vsm@google.com
Review URL: https://chromereviews.googleplex.com/157627013
2015-02-11 09:03:03 -08:00