Commit Graph

17 Commits

Author SHA1 Message Date
danrubel f7d3e5bebf Add dartfix --server option
This adds a --server option for specifying the analyis server snapshot
to be used when calculating fixes.

Change-Id: I0adc3148c030d23a9a62883d842851709cb78168
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106220
Auto-Submit: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-06-18 03:07:58 +00:00
Nicholas Shahan f9dfa7cbfd [dartfix] Bump pkg:pedantic to version 1.7.0
New versions of pedantic now offer imports to versioned includes. This will
allow us to update packages in the SDK independently when new lints are added in
future versions.

Issue: #37218
Change-Id: I43a4a9ba6730ed107a87f4060d47bb50d837de49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106184
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
2019-06-17 16:47:52 +00:00
Devon Carew ce2bbd4108 [dartfix] refactor dartfix pubspec.yaml
Change-Id: Ib651df66b8ecef1abc9e9992e1461412d6e88df2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101760
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2019-05-08 18:46:51 +00:00
danrubel 6c680a0ebd Update dartfix readme and update version numbers
* Update the readme to discuss required vs suggested fixes
* Remove the out-of-date options section from the readme
* Update dartfix and analysis_server_client versions and changelog

Change-Id: Ida4b30f9f89eb84a2fe856f61562ff73bf6725da
Reviewed-on: https://dart-review.googlesource.com/c/92153
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2019-02-07 01:16:56 +00:00
danrubel da09945643 Update dartfix pubspec before publishing
Change-Id: I542aa5973aa22725980baf048fa07bc10d7b85bb
Reviewed-on: https://dart-review.googlesource.com/c/89902
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-01-17 02:05:53 +00:00
danrubel 62850bf967 update pubspec version
Change-Id: If8eb29cba552a3ab18660e731d3c4a909a9382b5
Reviewed-on: https://dart-review.googlesource.com/c/87624
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-12-18 21:04:42 +00:00
danrubel bfc8ba1459 Update dartfix SDK constraints
Change-Id: I272161b5fedfd59c084e84684344c45f2d962c6a
Reviewed-on: https://dart-review.googlesource.com/c/87621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-12-18 18:09:10 +00:00
danrubel 93306f5ec0 Add dartfix integration test
... and update changelog and tweak SDK constraints

Change-Id: Ifb3e733b84c3aecad0ff8fe805f77ef497248f3b
Reviewed-on: https://dart-review.googlesource.com/c/86600
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-12-17 04:37:07 +00:00
danrubel ebeae74390 Update version before publishing
Change-Id: Ia83e7226715ad1469d51e443a6a24505da71660a
Reviewed-on: https://dart-review.googlesource.com/c/84941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-11-20 18:54:43 +00:00
danrubel b607f65217 More dartfix tests
This adds a test that asserts the analysis_server_client version
matches the version specified in the dartfix pubspec.

In addition, this remove code that reads the version
from dartfix pubspec.yaml because the pubspec.yaml is not present
when dartfix is activated and run via pub global activate.

Change-Id: I6deed00428afb8844d03a9604699e0c089d7ce6f
Reviewed-on: https://dart-review.googlesource.com/c/84940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-11-20 17:47:27 +00:00
Dan Rubel 784ad29470 Update dartfix to check analysis server protocol version
This updates dartfix to more narrowly verify the analysis server
protocol version and print instructions for the user if the protocol
version expected by dartfix is incompatible with the current Dart SDK.
This is necessary because the edit.dartfix protocol is experimental
and will continue to evolve.

Change-Id: Ib31eb594a8a94416cb4fc676e7da9150f8c99b6a
Reviewed-on: https://dart-review.googlesource.com/c/84780
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-11-19 21:14:28 +00:00
Dan Rubel 8178cb602e Refactor dartfix to use new notification handlers
and narrow the SDK version supported by dartfix

Change-Id: I63317a3a89d68d74815f5c192970f71bfbc422d4
Reviewed-on: https://dart-review.googlesource.com/c/83720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-11-08 21:10:06 +00:00
Dan Rubel a074bcf93c Update dartfix package for publication
Updates to dartfix for publication including:
* add changelog, readme, and license
* update pubspec version and executables

along with a collection of smaller changes including:
* test cleanup
* remove duplicate time value from verbose output
* read dartfix pubspec version and pass that to analysis server

Change-Id: Ifa94df45e6cbcf9a98f7bf393c22e06eaab48c38
Reviewed-on: https://dart-review.googlesource.com/c/82240
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-10-31 17:36:51 +00:00
Devon Carew f4ce2c5749 Update deps for dartfix.
Change-Id: Ia26438cc05a8d102657a39adb9bb647aed04a578
Reviewed-on: https://dart-review.googlesource.com/c/81961
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-10-29 23:22:17 +00:00
danrubel e414b5823d Improve dartfix output
* include file path in suggestion output
* more verbose output for debugging in the field
* update pubspec.yaml
* display paths relative to the target directories

Change-Id: I64e519d72773c3e56e4502fab7591c43fda35bf3
Reviewed-on: https://dart-review.googlesource.com/c/81860
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-10-29 16:47:30 +00:00
Dan Rubel b8fd29e0bb Remove dartfix dependencies on analysis server
This replaces dartfix dependencies on ...
* analysis_server
* analyzer (except for testing)
* analyzer_plugins

... with a dependency on analysis_server_client.

Change-Id: If511de69333e925ae082fa06c5114188c3c405b1
Reviewed-on: https://dart-review.googlesource.com/c/81342
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-10-24 19:26:58 +00:00
danrubel a82e025739 Move dartfix to its own package
Fix https://github.com/dart-lang/sdk/issues/34765

Change-Id: I44b3ccc4861b383601fea1b006f1fd4726b11062
Reviewed-on: https://dart-review.googlesource.com/c/81080
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2018-10-22 17:50:25 +00:00